Build Bitcoin-ABC / Diffs / Diff Testing passed.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Oct 16 2019
Build Bitcoin-ABC / Diffs / Diff Testing started.
Removed changes from PR14444.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Added changes to validation.cpp. Removed them from D4026.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Oct 15 2019
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Changed default variable names and pattern from *_DEFAULT to DEFAULT_*.
No word from them yet, though they're expected to do a release soon. Pinging them again.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Changed constants to upper snake case and made static.
Updated test plan.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Added braces.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
fix the rebase
Build Bitcoin-ABC / Diffs / Diff Testing passed.
In D4234#102134, @deadalnix wrote:It looks like you have dependencies to backport first.
Build Bitcoin-ABC / Diffs / Diff Testing started.
fix rebase error
The diff doesn't match the description anymore. It's also unclear to me why the double outputs wasn't stacked first.
You shouldn't have made this dependent on the other
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
The test plan doesn't cover the change.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Fixed braces.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Build Bitcoin-ABC / Diffs / Diff Testing started.
I don't agree that this is easier to read, but I do agree with where this is heading and that it will integrate with ArgsManager better.
Oct 14 2019
testplan doesn't verify that all modified defaults are still set as expected
Updated summary to reflect discuss on why changes were reverted.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Rebased.
Build Bitcoin-ABC / Diffs / Diff Testing passed.
Build Bitcoin-ABC / Diffs / Diff Testing started.
Reverted the std::string constants to const char*. The const char*s will be changed to std::string in another diff.
Build Bitcoin-ABC / Diffs / Diff Testing started.