jasonbcox retitled D6265: Add land bot dependencies to base image setup script from Add base image setup script for the land bot to Add land bot dependencies to base image setup script.

May 30 2020, 00:41

teamcity added a comment to D6265: Add land bot dependencies to base image setup script.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

May 30 2020, 00:39

teamcity added a comment to D6265: Add land bot dependencies to base image setup script.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

May 30 2020, 00:39

teamcity added a comment to D6265: Add land bot dependencies to base image setup script.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

May 30 2020, 00:39

jasonbcox updated the diff for D6265: Add land bot dependencies to base image setup script.

Update same base image used for CI builds rather than introducing a new one.

May 30 2020, 00:39

majcosta updated the test plan for D6296: [backport#15932] rpc: Use IsValidNumArgs in getblock.

May 30 2020, 00:31

teamcity added a comment to D5956: Add -datadir option to allow specification of seeder's data directory.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

May 30 2020, 00:22

teamcity added a comment to D5956: Add -datadir option to allow specification of seeder's data directory.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

May 30 2020, 00:15

teamcity added a comment to D6303: Wrap nChainTx into GetChainTxCount.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

May 30 2020, 00:14

teamcity added a comment to D5956: Add -datadir option to allow specification of seeder's data directory.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

May 30 2020, 00:11

teamcity added a comment to D5956: Add -datadir option to allow specification of seeder's data directory.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

May 30 2020, 00:10

teamcity added a comment to D5956: Add -datadir option to allow specification of seeder's data directory.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

May 30 2020, 00:10

teamcity added a comment to D5956: Add -datadir option to allow specification of seeder's data directory.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

May 30 2020, 00:10

nakihito added inline comments to D5956: Add -datadir option to allow specification of seeder's data directory.

May 30 2020, 00:10

nakihito updated the diff for D5956: Add -datadir option to allow specification of seeder's data directory.

Added some output that specifies the default directory and the directory in use on start up.

May 30 2020, 00:10

teamcity added a comment to D6303: Wrap nChainTx into GetChainTxCount.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

May 30 2020, 00:07

teamcity added a comment to D6303: Wrap nChainTx into GetChainTxCount.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

May 30 2020, 00:05

teamcity added a comment to D6303: Wrap nChainTx into GetChainTxCount.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

May 30 2020, 00:03

teamcity added a comment to D6303: Wrap nChainTx into GetChainTxCount.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

May 30 2020, 00:03

teamcity added a comment to D6303: Wrap nChainTx into GetChainTxCount.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

May 30 2020, 00:03

deadalnix updated the diff for D6303: Wrap nChainTx into GetChainTxCount.

Also update getchaintxstats

May 30 2020, 00:02

May 29 2020

majcosta added inline comments to D6303: Wrap nChainTx into GetChainTxCount.

May 29 2020, 23:51

nakihito updated the summary of D6302: Merge #12330: Reduce scope of cs_wallet locks in listtransactions.

May 29 2020, 23:29

nakihito requested review of D6302: Merge #12330: Reduce scope of cs_wallet locks in listtransactions.

May 29 2020, 23:28

teamcity added a comment to D6303: Wrap nChainTx into GetChainTxCount.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

May 29 2020, 23:16

teamcity added a comment to D6289: Generate assumed blockchain and chainstate disk sizes when updating chainparams.

Build Bitcoin ABC Diffs / Diff Testing (build-ibd-no-assumevalid-checkpoint) passed.

May 29 2020, 23:13

teamcity added a comment to D6303: Wrap nChainTx into GetChainTxCount.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

May 29 2020, 23:06

teamcity added a comment to D6303: Wrap nChainTx into GetChainTxCount.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

May 29 2020, 23:04

teamcity added a comment to D6303: Wrap nChainTx into GetChainTxCount.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

May 29 2020, 23:04

teamcity added a comment to D6303: Wrap nChainTx into GetChainTxCount.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

May 29 2020, 23:02

teamcity added a comment to D6303: Wrap nChainTx into GetChainTxCount.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

May 29 2020, 23:01

deadalnix requested review of D6303: Wrap nChainTx into GetChainTxCount.

May 29 2020, 23:00

teamcity added a comment to D6302: Merge #12330: Reduce scope of cs_wallet locks in listtransactions.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

May 29 2020, 22:53

deadalnix accepted D6301: Merge #15345: net: Correct comparison of addr count.

May 29 2020, 22:51

deadalnix committed rABC89778bcdb086: Remove CBlockIndex::SetNull (authored by deadalnix).

Remove CBlockIndex::SetNull

May 29 2020, 22:48

deadalnix closed D6290: Remove CBlockIndex::SetNull.

May 29 2020, 22:48

teamcity added a comment to D6302: Merge #12330: Reduce scope of cs_wallet locks in listtransactions.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

May 29 2020, 22:43

teamcity added a comment to D6301: Merge #15345: net: Correct comparison of addr count.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

May 29 2020, 22:43

teamcity added a comment to D6302: Merge #12330: Reduce scope of cs_wallet locks in listtransactions.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

May 29 2020, 22:42

teamcity added a comment to D6302: Merge #12330: Reduce scope of cs_wallet locks in listtransactions.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

May 29 2020, 22:42

nakihito retitled D6302: Merge #12330: Reduce scope of cs_wallet locks in listtransactions from Merge #12330: Reduce scope of cs_main and cs_wallet locks in listtransactions to Merge #12330: Reduce scope of cs_wallet locks in listtransactions.

May 29 2020, 22:42

teamcity added a comment to D6302: Merge #12330: Reduce scope of cs_wallet locks in listtransactions.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

May 29 2020, 22:40

teamcity added a comment to D6302: Merge #12330: Reduce scope of cs_wallet locks in listtransactions.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

May 29 2020, 22:40

teamcity added a comment to D6301: Merge #15345: net: Correct comparison of addr count.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

May 29 2020, 22:40

nakihito planned changes to D6302: Merge #12330: Reduce scope of cs_wallet locks in listtransactions.

May 29 2020, 22:39

teamcity updated the summary of D6302: Merge #12330: Reduce scope of cs_wallet locks in listtransactions.

May 29 2020, 22:38

teamcity added a comment to D6302: Merge #12330: Reduce scope of cs_wallet locks in listtransactions.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

May 29 2020, 22:38

nakihito requested review of D6302: Merge #12330: Reduce scope of cs_wallet locks in listtransactions.

May 29 2020, 22:38

teamcity added a comment to D6301: Merge #15345: net: Correct comparison of addr count.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

May 29 2020, 22:34

teamcity added a comment to D6301: Merge #15345: net: Correct comparison of addr count.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

May 29 2020, 22:34

teamcity added a comment to D6301: Merge #15345: net: Correct comparison of addr count.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

May 29 2020, 22:33

teamcity added a comment to D6301: Merge #15345: net: Correct comparison of addr count.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

May 29 2020, 22:32

teamcity added a comment to D6301: Merge #15345: net: Correct comparison of addr count.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

May 29 2020, 22:31

teamcity updated the summary of D6301: Merge #15345: net: Correct comparison of addr count.

May 29 2020, 22:31

jasonbcox requested review of D6301: Merge #15345: net: Correct comparison of addr count.

May 29 2020, 22:31

majcosta accepted D6290: Remove CBlockIndex::SetNull.

May 29 2020, 22:29

deadalnix committed rABCec2417bd70d6: [wallet] abort when attempting to fund a transaction above maxtxfee (authored by Sjors Provoost <sjors@sprovoost.nl>).

[wallet] abort when attempting to fund a transaction above maxtxfee

May 29 2020, 22:18

deadalnix closed D6268: [wallet] abort when attempting to fund a transaction above maxtxfee.

May 29 2020, 22:18

teamcity added a comment to D6268: [wallet] abort when attempting to fund a transaction above maxtxfee.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

May 29 2020, 22:00

teamcity added a comment to D6268: [wallet] abort when attempting to fund a transaction above maxtxfee.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

May 29 2020, 21:54

jasonbcox added a comment to D6291: [SECP256K1] Fix -Wmaybe-uninitialized in tests.

In D6291#155387, @deadalnix wrote:

I would rather avoid taking ownership of this. The part of libsecp256k1 we have ownership over are very well delimited and separated from the rest of the codebase. IMO this is a feature.

I would suggest you go about this by either:

Disable this warning for libsecp256k1 and report the problem upstream.

Submit a patch upstream.

May 29 2020, 21:53

jasonbcox planned changes to D6265: Add land bot dependencies to base image setup script.

May 29 2020, 21:52

jasonbcox accepted D6268: [wallet] abort when attempting to fund a transaction above maxtxfee.

May 29 2020, 21:51

teamcity added a comment to D6268: [wallet] abort when attempting to fund a transaction above maxtxfee.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

May 29 2020, 21:51

jasonbcox added inline comments to D6290: Remove CBlockIndex::SetNull.

May 29 2020, 21:51

teamcity added a comment to D6268: [wallet] abort when attempting to fund a transaction above maxtxfee.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.