Page MenuHomePhabricator
Feed All Stories

Jun 12 2020

jasonbcox closed D6543: Add a lock on cs_main while modifying the config in setexcessiveblock.
Jun 12 2020, 14:48
teamcity added a comment to D6547: Fix single parameter constructors not marked "explicit".

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 12 2020, 14:39
teamcity updated the summary of D6547: Fix single parameter constructors not marked "explicit".
Jun 12 2020, 14:39
Fabien requested review of D6547: Fix single parameter constructors not marked "explicit".
Jun 12 2020, 14:39
Fabien requested review of D6546: Lint everything.
Jun 12 2020, 14:32
deadalnix accepted D6544: [CMAKE] Don't require jemalloc for systems where it's the default.
Jun 12 2020, 12:25
deadalnix accepted D6545: [CMAKE] Fail early if a lib header is missing, remove garbage in version.

The fact a very similar chage had to be done in so many places hints at the fact that some factoring is in order.

Jun 12 2020, 12:22
Fabien requested review of D6545: [CMAKE] Fail early if a lib header is missing, remove garbage in version.
Jun 12 2020, 09:43
Fabien updated the test plan for D6544: [CMAKE] Don't require jemalloc for systems where it's the default.
Jun 12 2020, 09:10
Fabien requested review of D6544: [CMAKE] Don't require jemalloc for systems where it's the default.
Jun 12 2020, 09:07
Fabien accepted D6543: Add a lock on cs_main while modifying the config in setexcessiveblock.
Jun 12 2020, 07:46
Fabien requested changes to D6539: [backport#14193] validation: Add missing mempool locks.
Jun 12 2020, 07:22
Fabien requested changes to D6526: Merge #14719: qa: Check specific reject reasons in feature_block.

The test plan is still wrong

Jun 12 2020, 06:37
deadalnix committed rABCf3afcb9a6003: txmempool: Remove unused default value MemPoolRemovalReason::UNKNOWN (authored by MarcoFalke <falke.marco@gmail.com>).
txmempool: Remove unused default value MemPoolRemovalReason::UNKNOWN
Jun 12 2020, 02:03
deadalnix closed D6504: txmempool: Remove unused default value MemPoolRemovalReason::UNKNOWN.
Jun 12 2020, 02:03
nakihito accepted D6543: Add a lock on cs_main while modifying the config in setexcessiveblock.

This is actually necessary to fix WSL too.

Jun 12 2020, 01:27
majcosta updated the diff for D6539: [backport#14193] validation: Add missing mempool locks.

rebase

Jun 12 2020, 01:27
teamcity added a comment to D6539: [backport#14193] validation: Add missing mempool locks.
Jun 12 2020, 01:14
teamcity added a comment to D6539: [backport#14193] validation: Add missing mempool locks.
Jun 12 2020, 01:14
teamcity added a comment to D6539: [backport#14193] validation: Add missing mempool locks.
Jun 12 2020, 01:14
majcosta updated the diff for D6539: [backport#14193] validation: Add missing mempool locks.

added a missing lock in DisconnectedBlockTransactions::addForBlock

Jun 12 2020, 01:11

Jun 11 2020

majcosta accepted D6504: txmempool: Remove unused default value MemPoolRemovalReason::UNKNOWN.
Jun 11 2020, 23:56
jasonbcox committed rABC62cc9f5b0bb2: Merge #16092: Don't use global (external) symbols for symbols that are used in… (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #16092: Don't use global (external) symbols for symbols that are used in…
Jun 11 2020, 22:28
deadalnix updated the diff for D6504: txmempool: Remove unused default value MemPoolRemovalReason::UNKNOWN.

rebase

Jun 11 2020, 22:28
jasonbcox closed D6514: Merge #16092: Don't use global (external) symbols for symbols that are used in only one translation unit.
Jun 11 2020, 22:28
jasonbcox committed rABCdfd3616955ca: Merge #15622: Remove global symbols: Avoid using the global namespace if… (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #15622: Remove global symbols: Avoid using the global namespace if…
Jun 11 2020, 22:21
jasonbcox closed D6516: Merge #15622: Remove global symbols: Avoid using the global namespace if possible.
Jun 11 2020, 22:21
jasonbcox committed rABC54554de6b6cb: Merge #12980: Allow quicker shutdowns during LoadBlockIndex() (authored by Jonas Schnelli <dev@jonasschnelli.ch>).
Merge #12980: Allow quicker shutdowns during LoadBlockIndex()
Jun 11 2020, 22:13
jasonbcox closed D6513: Merge #12980: Allow quicker shutdowns during LoadBlockIndex().
Jun 11 2020, 22:13
jasonbcox requested review of D6543: Add a lock on cs_main while modifying the config in setexcessiveblock.
Jun 11 2020, 22:10
jasonbcox abandoned D6540: Disable DEBUG_LOCKORDER on TSAN builds.
Jun 11 2020, 21:39
jasonbcox committed rABCc5c01c8243f5: Replace automatic bans with discouragement filter (authored by Pieter Wuille <pieter@wuille.net>).
Replace automatic bans with discouragement filter
Jun 11 2020, 21:38
jasonbcox closed D6506: Replace automatic bans with discouragement filter.
Jun 11 2020, 21:38
jasonbcox committed rABCa0c05b6739fe: [CI] Do not enable debug for TSAN builds (authored by jasonbcox).
[CI] Do not enable debug for TSAN builds
Jun 11 2020, 21:36
jasonbcox closed D6541: [CI] Do not enable debug for TSAN builds.
Jun 11 2020, 21:36
deadalnix accepted D6541: [CI] Do not enable debug for TSAN builds.
Jun 11 2020, 21:32
deadalnix accepted D6506: Replace automatic bans with discouragement filter.
Jun 11 2020, 21:30
majcosta abandoned D6542: [cleanup] stop using misc deprecated Qt things.
Jun 11 2020, 20:49
majcosta planned changes to D6542: [cleanup] stop using misc deprecated Qt things.
Jun 11 2020, 20:46
jasonbcox updated the test plan for D6541: [CI] Do not enable debug for TSAN builds.
Jun 11 2020, 20:42
teamcity added a comment to D6542: [cleanup] stop using misc deprecated Qt things.
Jun 11 2020, 20:39
teamcity added a comment to D6542: [cleanup] stop using misc deprecated Qt things.
Jun 11 2020, 20:38
teamcity added a comment to D6542: [cleanup] stop using misc deprecated Qt things.
Jun 11 2020, 20:38
majcosta requested review of D6542: [cleanup] stop using misc deprecated Qt things.
Jun 11 2020, 20:36
teamcity added a comment to D6541: [CI] Do not enable debug for TSAN builds.
Jun 11 2020, 20:30
jasonbcox requested review of D6541: [CI] Do not enable debug for TSAN builds.
Jun 11 2020, 20:08
jasonbcox planned changes to D6540: Disable DEBUG_LOCKORDER on TSAN builds.
Jun 11 2020, 19:41
jasonbcox requested review of D6540: Disable DEBUG_LOCKORDER on TSAN builds.
Jun 11 2020, 19:41
Fabien requested changes to D6539: [backport#14193] validation: Add missing mempool locks.

Clang build is unhappy

Jun 11 2020, 18:44
majcosta committed rABC01f6deea0f1a: [backport#13531] doc: Clarify that mempool txiter is const_iterator (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#13531] doc: Clarify that mempool txiter is const_iterator
Jun 11 2020, 18:20
majcosta closed D6538: [backport#13531] doc: Clarify that mempool txiter is const_iterator.
Jun 11 2020, 18:19
Fabien accepted D6538: [backport#13531] doc: Clarify that mempool txiter is const_iterator.
Jun 11 2020, 18:08
nakihito requested review of D6525: Merge #14700: qa: Avoid race in p2p_invalid_block by waiting for the block request.

Updated test plan.

Jun 11 2020, 18:03
nakihito planned changes to D6525: Merge #14700: qa: Avoid race in p2p_invalid_block by waiting for the block request.
Jun 11 2020, 17:46
deadalnix requested changes to D6506: Replace automatic bans with discouragement filter.

There are instances where we ban, such as the use of the wrong net magic, that also need to be modified.

Jun 11 2020, 17:34
nakihito updated the test plan for D6525: Merge #14700: qa: Avoid race in p2p_invalid_block by waiting for the block request.
Jun 11 2020, 17:28
nakihito updated the test plan for D6526: Merge #14719: qa: Check specific reject reasons in feature_block.
Jun 11 2020, 17:24
nakihito updated the diff for D6526: Merge #14719: qa: Check specific reject reasons in feature_block.

Fixed test and text plan.

Jun 11 2020, 17:23
teamcity updated the summary of D6539: [backport#14193] validation: Add missing mempool locks.
Jun 11 2020, 17:10
teamcity added a comment to D6539: [backport#14193] validation: Add missing mempool locks.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 11 2020, 17:10
majcosta requested review of D6539: [backport#14193] validation: Add missing mempool locks.
Jun 11 2020, 17:09
majcosta updated the diff for D6537: [backport#14193] txpool: Make nTransactionsUpdated atomic.

rebase

Jun 11 2020, 16:51
teamcity updated the summary of D6538: [backport#13531] doc: Clarify that mempool txiter is const_iterator.
Jun 11 2020, 16:50
teamcity added a comment to D6538: [backport#13531] doc: Clarify that mempool txiter is const_iterator.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 11 2020, 16:50
majcosta requested review of D6538: [backport#13531] doc: Clarify that mempool txiter is const_iterator.
Jun 11 2020, 16:50
deadalnix accepted D6537: [backport#14193] txpool: Make nTransactionsUpdated atomic.
Jun 11 2020, 16:03
majcosta updated the summary of D6537: [backport#14193] txpool: Make nTransactionsUpdated atomic.
Jun 11 2020, 15:14
teamcity updated the summary of D6537: [backport#14193] txpool: Make nTransactionsUpdated atomic.
Jun 11 2020, 15:14
teamcity added a comment to D6537: [backport#14193] txpool: Make nTransactionsUpdated atomic.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 11 2020, 15:14
majcosta requested review of D6537: [backport#14193] txpool: Make nTransactionsUpdated atomic.
Jun 11 2020, 15:14
majcosta closed D6527: [backport#16908] txmempool: Make entry time type-safe (std::chrono).
Jun 11 2020, 14:16
majcosta committed rABC02d552019c16: [backport#16908] txmempool: Make entry time type-safe (std::chrono) (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#16908] txmempool: Make entry time type-safe (std::chrono)
Jun 11 2020, 14:16
majcosta committed rABC583e959f15f3: [backport#16908] util: Add count_seconds time helper (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#16908] util: Add count_seconds time helper
Jun 11 2020, 14:15
majcosta closed D6524: [backport#16908] util: Add count_seconds time helper.
Jun 11 2020, 14:15
majcosta committed rABC9dfe4441b84d: [backport#16908] test: mempool entry time is persisted (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#16908] test: mempool entry time is persisted
Jun 11 2020, 14:15
majcosta closed D6523: [backport#16908] test: mempool entry time is persisted.
Jun 11 2020, 14:14
majcosta committed rABC4505e1cdfd10: [backport#14931] test: mempool_persist: Verify prioritization is dumped… (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#14931] test: mempool_persist: Verify prioritization is dumped…
Jun 11 2020, 14:13
majcosta closed D6522: [backport#14931] test: mempool_persist: Verify prioritization is dumped correctly.
Jun 11 2020, 14:13
majcosta committed rABC27ef44d03b66: [backport#14704]: doc: add detached release notes for #14060 (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
[backport#14704]: doc: add detached release notes for #14060
Jun 11 2020, 14:07
majcosta closed D6528: [backport#14704]: doc: add detached release notes for #14060.
Jun 11 2020, 14:07
teamcity triaged T932: Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC Master TSAN is broken. as Unbreak Now! priority.
Jun 11 2020, 13:42
teamcity closed T931: Build Bitcoin-ABC / Master / Bitcoin-ABC Master w/o Wallet is broken. as Resolved.
Jun 11 2020, 13:35
deadalnix committed rABC879fe2a3226a: Drop unused reverselock.h (authored by Anthony Towns <aj@erisian.com.au>).
Drop unused reverselock.h
Jun 11 2020, 13:19
deadalnix closed D6535: Drop unused reverselock.h.
Jun 11 2020, 13:19
teamcity triaged T931: Build Bitcoin-ABC / Master / Bitcoin-ABC Master w/o Wallet is broken. as Unbreak Now! priority.
Jun 11 2020, 13:15
deadalnix committed rABC1af5e7c22bca: scheduler: switch from boost to std (authored by Anthony Towns <aj@erisian.com.au>).
scheduler: switch from boost to std
Jun 11 2020, 13:13
deadalnix closed D6533: scheduler: switch from boost to std.
Jun 11 2020, 13:12
deadalnix committed rABCfba3cd616798: sync.h: add REVERSE_LOCK (authored by Anthony Towns <aj@erisian.com.au>).
sync.h: add REVERSE_LOCK
Jun 11 2020, 13:02
deadalnix closed D6532: sync.h: add REVERSE_LOCK.
Jun 11 2020, 13:02
deadalnix committed rABC014e5697a60a: scheduler: don't rely on boost interrupt on shutdown (authored by Anthony Towns <aj@erisian.com.au>).
scheduler: don't rely on boost interrupt on shutdown
Jun 11 2020, 12:57
deadalnix closed D6531: scheduler: don't rely on boost interrupt on shutdown.
Jun 11 2020, 12:57
Fabien accepted D6535: Drop unused reverselock.h.
Jun 11 2020, 12:55
Fabien accepted D6533: scheduler: switch from boost to std.
Jun 11 2020, 12:54
deadalnix committed rABC72ebb4217e4f: UninterruptibleSleep in avalanche test (authored by deadalnix).
UninterruptibleSleep in avalanche test
Jun 11 2020, 12:53
deadalnix closed D6530: UninterruptibleSleep in avalanche test.
Jun 11 2020, 12:53
Fabien accepted D6532: sync.h: add REVERSE_LOCK.
Jun 11 2020, 12:47
Fabien accepted D6531: scheduler: don't rely on boost interrupt on shutdown.
Jun 11 2020, 12:41
Fabien accepted D6530: UninterruptibleSleep in avalanche test.
Jun 11 2020, 12:39
teamcity added a comment to D6535: Drop unused reverselock.h.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 11 2020, 12:07
teamcity updated the summary of D6535: Drop unused reverselock.h.
Jun 11 2020, 12:07