Improve the API, it looks like it used to.

Ok so you you ave something that goes roughly as

Rebase

Rename the script to something more sensible

In D7476#177734, @deadalnix wrote:

I' not sure why you would revert back other changes, there were not bad per se.

I' not sure why you would revert back other changes, there were not bad per se.

In D7475#177718, @PiRK wrote:

update diff message with arc diff --edit

Remove all the refactoring and just call the land patch script

update diff message with arc diff --edit

Please fix the test plan, it doesn't display properly.

This is doing exactly the wrong things. Instead of consolidating the framework in which automated commit happen, this instead consolidate the fact that there some kind of big ball of mud type script that can do every signle automated commit, but only half the workflow.

You want something like:

In D7475#177686, @PiRK wrote:

fix formatting of commit message

fix formatting of commit message

This does not solve the problem mentioned, because there might be more changes in between the rebase and the push. This is fundamentally broken and cannot be fixed with this approach.

For reference the build instructions are good afaik and the software runs fine on FreeBSD (I had some nodes running on it no so long ago).

Improve the name, and fix the arguments ordering in the comment

I don't see what problem this solves. The description doesn't explains this.

run_silent is a pretty bad name, considering this is not running "silent". Running something silently is also not the only thing that this script is doing.

Clean the log files