Page MenuHomePhabricator
Feed All Stories

May 9 2021

majcosta accepted D9473: [website] remove exchanges that don't have withdrawals and deposits enabled.
May 9 2021, 22:39
Mengerian requested review of D9473: [website] remove exchanges that don't have withdrawals and deposits enabled.

We may as well land this now IMO.

May 9 2021, 22:11
deadalnix requested changes to D9489: [avalanche] Annouce our proofs to our peers.
May 9 2021, 21:15
Fabien updated the diff for D9489: [avalanche] Annouce our proofs to our peers.

Drop the conditions for creating the relay structure (not needed at this point), fix the circular dependencies.

May 9 2021, 18:52
Fabien planned changes to D9489: [avalanche] Annouce our proofs to our peers.
May 9 2021, 16:59
teamcity added a comment to D9489: [avalanche] Annouce our proofs to our peers.
May 9 2021, 16:58
Fabien requested review of D9489: [avalanche] Annouce our proofs to our peers.
May 9 2021, 16:57
Mengerian closed D9488: [website] Update Cain sponsor link.
May 9 2021, 15:53
Mengerian committed rABCWEB22a41916bf4d: [website] Update Cain sponsor link (authored by Mengerian).
[website] Update Cain sponsor link
May 9 2021, 15:53
bytesofman accepted D9488: [website] Update Cain sponsor link.
May 9 2021, 05:06

May 8 2021

Mengerian requested review of D9488: [website] Update Cain sponsor link.
May 8 2021, 22:59
deadalnix requested changes to D9487: [avalanche] let PeerManager::addNode deal with signature verification.

Just check the signature as soon as the messages arrives. There is no point making this dependent on the network layer.

May 8 2021, 22:32
PiRK updated the diff for D9487: [avalanche] let PeerManager::addNode deal with signature verification.

set a default parameter to avoid repeating std::nullopt in tests

May 8 2021, 21:35
PiRK updated the summary of D9487: [avalanche] let PeerManager::addNode deal with signature verification.
May 8 2021, 21:22
PiRK added a comment to D9487: [avalanche] let PeerManager::addNode deal with signature verification.

An alternative solution is to extract the delegated key from the delegation without checking it, use it to check the signature, then call PeerManager::addNode which will then verify the delegation . I like this solution a bit less, because it is more code : the pubkey is initialized twice it requires an additional Delegation::getPubKey method to return the last level of the delegation.

May 8 2021, 21:21
PiRK requested review of D9487: [avalanche] let PeerManager::addNode deal with signature verification.
May 8 2021, 21:16

May 7 2021

Mengerian closed D9486: [website] Add an image to the upgrade page.
May 7 2021, 22:24
Mengerian committed rABCWEBc15506bfa2e6: [website] Add an image to the upgrade page (authored by Mengerian).
[website] Add an image to the upgrade page
May 7 2021, 22:24
bytesofman accepted D9486: [website] Add an image to the upgrade page.
May 7 2021, 21:53
Mengerian requested review of D9486: [website] Add an image to the upgrade page.
May 7 2021, 19:29
teamcity closed T1610: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Windows 64-bit is broken. as Resolved.
May 7 2021, 19:23
Joey King <joseph.roy.king@gmail.com> closed D9484: [Cashtab] Patch z-index css issue in forms vs footer.
May 7 2021, 19:01
Joey King <joseph.roy.king@gmail.com> committed rABCe4faaf6c88a0: [Cashtab] Patch z-index css issue in forms vs footer (authored by Joey King <joseph.roy.king@gmail.com>).
[Cashtab] Patch z-index css issue in forms vs footer
May 7 2021, 19:01
majcosta accepted D9484: [Cashtab] Patch z-index css issue in forms vs footer.
May 7 2021, 18:50
Mengerian closed D9485: [website] Add dedicated upgrade page.
May 7 2021, 17:54
Mengerian committed rABCWEBfdb616538e89: [website] Add dedicated upgrade page (authored by Mengerian).
[website] Add dedicated upgrade page
May 7 2021, 17:54
bytesofman accepted D9485: [website] Add dedicated upgrade page.
May 7 2021, 17:31
Mengerian updated the diff for D9485: [website] Add dedicated upgrade page.

Fix typo

May 7 2021, 17:03
Mengerian updated the diff for D9485: [website] Add dedicated upgrade page.

Add more info about the activation time

May 7 2021, 17:00
Mengerian updated the diff for D9485: [website] Add dedicated upgrade page.

Fix typo

May 7 2021, 16:48
Mengerian updated the diff for D9485: [website] Add dedicated upgrade page.

Update description

May 7 2021, 16:45
Mengerian requested review of D9485: [website] Add dedicated upgrade page.
May 7 2021, 16:41
bytesofman requested review of D9484: [Cashtab] Patch z-index css issue in forms vs footer.
May 7 2021, 15:42
deadalnix requested changes to D9478: [avalanche] make avalanche peer discovery in a simple case.
May 7 2021, 13:29
deadalnix accepted D9482: remove misleading comment.
May 7 2021, 13:17
Fabien closed D9483: [WEBSITE] Display the upgrade banner on main and BCHA pages.
May 7 2021, 10:52
Fabien committed rABCWEB51e8cb87be77: [WEBSITE] Display the upgrade banner on main and BCHA pages (authored by Fabien).
[WEBSITE] Display the upgrade banner on main and BCHA pages
May 7 2021, 10:52
deadalnix accepted D9483: [WEBSITE] Display the upgrade banner on main and BCHA pages.
May 7 2021, 10:51
Fabien requested review of D9483: [WEBSITE] Display the upgrade banner on main and BCHA pages.
May 7 2021, 10:48
PiRK updated the summary of D9478: [avalanche] make avalanche peer discovery in a simple case.
May 7 2021, 10:06
PiRK requested review of D9482: remove misleading comment.
May 7 2021, 10:05
PiRK updated the diff for D9478: [avalanche] make avalanche peer discovery in a simple case.

Add an -exchangeavaproofs configuration option, with default false. If false, don't ask for avaproof, don't reply to avaproof getdata requests, don't process AVAPROOF messages.
Unless a node enables this option, it shouldn't be able to add avalanche nodes automatically, and other nodes shouldn't be able to add it, unless it is done via the addavalanchenode RPC.

May 7 2021, 10:00
majcosta updated the summary of D8692: [CashAddr] replace bitcoincash: prefix with ecash: in the node.
May 7 2021, 01:40

May 6 2021

teamcity triaged T1610: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Windows 64-bit is broken. as Unbreak Now! priority.
May 6 2021, 22:48
Joey King <joseph.roy.king@gmail.com> closed D9480: [Cashtab] standardize balance header components.
May 6 2021, 21:17
Joey King <joseph.roy.king@gmail.com> committed rABC271f5dc8c9f9: [Cashtab] standardize balance header components (authored by Joey King <joseph.roy.king@gmail.com>).
[Cashtab] standardize balance header components
May 6 2021, 21:17
majcosta accepted D9480: [Cashtab] standardize balance header components.
May 6 2021, 21:12
Joey King <joseph.roy.king@gmail.com> closed D9481: [Cashtab] Reduce bundle size by 70kb (10%).
May 6 2021, 21:06
Joey King <joseph.roy.king@gmail.com> committed rABCc6966a23eb5d: [Cashtab] Reduce bundle size by 70kb (10%) (authored by Joey King <joseph.roy.king@gmail.com>).
[Cashtab] Reduce bundle size by 70kb (10%)
May 6 2021, 21:06
majcosta accepted D9481: [Cashtab] Reduce bundle size by 70kb (10%).
May 6 2021, 21:04
bytesofman updated the summary of D9481: [Cashtab] Reduce bundle size by 70kb (10%).
May 6 2021, 20:24
bytesofman updated the diff for D9481: [Cashtab] Reduce bundle size by 70kb (10%).

Only include used lodash functions

May 6 2021, 20:22
bytesofman requested review of D9481: [Cashtab] Reduce bundle size by 70kb (10%).
May 6 2021, 20:05
PiRK added inline comments to D9478: [avalanche] make avalanche peer discovery in a simple case.
May 6 2021, 17:58
PiRK planned changes to D9478: [avalanche] make avalanche peer discovery in a simple case.
May 6 2021, 17:46
PiRK updated the diff for D9478: [avalanche] make avalanche peer discovery in a simple case.

make it work (the test was taking the local and remote entropy in the wrong order, so checking the avahello signature failed)

May 6 2021, 17:46
PiRK planned changes to D9476: [avalanche] use the OrphanProofPool.
May 6 2021, 14:39
PiRK updated the diff for D9476: [avalanche] use the OrphanProofPool.

Improve tests according to review. Enforce, document and test the sequential iteration over proof in forEachProof.
Fix the potential problem of updating the pool while iterating on it in updatedBlockTip.
Let fetchOrCreatePeer remove proofs from the orphan pool if they are found to be good.
Don't copy proofs in the temporary vectors created in updateBlockTip, use pointers instead.

May 6 2021, 14:39
bytesofman requested review of D9480: [Cashtab] standardize balance header components.
May 6 2021, 13:52
Joey King <joseph.roy.king@gmail.com> closed D9475: [Cashtab] MVP token creation.
May 6 2021, 13:34
Joey King <joseph.roy.king@gmail.com> committed rABC80146d4c6054: [Cashtab] MVP token creation (authored by Joey King <joseph.roy.king@gmail.com>).
[Cashtab] MVP token creation
May 6 2021, 13:33
majcosta accepted D9475: [Cashtab] MVP token creation.
May 6 2021, 12:26
• charlottemia updated • charlottemia.
May 6 2021, 08:49
• charlottemia updated • charlottemia.
May 6 2021, 08:49
abc-bot committed rABCafd4a34a7e4b: [Automated] Update timing.json (authored by abc-bot).
[Automated] Update timing.json
May 6 2021, 03:19
abc-bot committed rABCde1a9e51c336: [Automated] Update seeds (authored by abc-bot).
[Automated] Update seeds
May 6 2021, 02:18
abc-bot committed rABCca6ac5d8598b: [Automated] Update chainparams (authored by abc-bot).
[Automated] Update chainparams
May 6 2021, 02:08

May 5 2021

bytesofman updated the diff for D9475: [Cashtab] MVP token creation.

Mark snapshots @generated

May 5 2021, 23:30
Mengerian planned changes to D9473: [website] remove exchanges that don't have withdrawals and deposits enabled.
May 5 2021, 23:27
bytesofman updated the diff for D9475: [Cashtab] MVP token creation.

Improve speed of form by making it its own react component, parse Genesis transactions in txHistory, unit tests for each

May 5 2021, 23:26
Mengerian updated the diff for D9473: [website] remove exchanges that don't have withdrawals and deposits enabled.

Update Diff summary

May 5 2021, 23:25
Mengerian updated the diff for D9473: [website] remove exchanges that don't have withdrawals and deposits enabled.

Keep STEX, they have working withdrawal/deposit

May 5 2021, 23:21
teamcity closed T1609: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux ARM is broken. as Resolved.
May 5 2021, 18:53
Joey King <joseph.roy.king@gmail.com> closed D9479: [Cashtab] Patch validation bug on settings page.
May 5 2021, 18:36
Joey King <joseph.roy.king@gmail.com> committed rABCad083d3fedb7: [Cashtab] Patch validation bug on settings page (authored by Joey King <joseph.roy.king@gmail.com>).
[Cashtab] Patch validation bug on settings page
May 5 2021, 18:36
majcosta accepted D9479: [Cashtab] Patch validation bug on settings page.
May 5 2021, 18:32
bytesofman requested review of D9479: [Cashtab] Patch validation bug on settings page.
May 5 2021, 17:52
teamcity triaged T1609: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux ARM is broken. as Unbreak Now! priority.
May 5 2021, 17:32
PiRK abandoned D9395: [avalanche] remove orphan proofs after they become valid or invalid.
May 5 2021, 17:25
PiRK abandoned D9370: [avalanche] orphan pool for proofs, make AlreadyHave support proofs.
May 5 2021, 17:25
PiRK planned changes to D9478: [avalanche] make avalanche peer discovery in a simple case.
May 5 2021, 17:23
PiRK requested review of D9478: [avalanche] make avalanche peer discovery in a simple case.
May 5 2021, 17:23
teamcity closed T1608: Build Bitcoin-ABC / Master / Sanitizers / Thread Sanitizer (TSAN) is broken. as Resolved.
May 5 2021, 17:18
majcosta closed D9477: [backport#20016] uint256: 1 is a constant.
May 5 2021, 17:02
majcosta committed rABC1377a4f39fc1: [backport#20016] uint256: 1 is a constant (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#20016] uint256: 1 is a constant
May 5 2021, 17:01
deadalnix requested changes to D9476: [avalanche] use the OrphanProofPool.
May 5 2021, 15:39
deadalnix accepted D9477: [backport#20016] uint256: 1 is a constant.
May 5 2021, 14:58
teamcity updated the summary of D9477: [backport#20016] uint256: 1 is a constant.
May 5 2021, 14:50
majcosta requested review of D9477: [backport#20016] uint256: 1 is a constant.
May 5 2021, 14:49
PiRK updated subscribers of D9476: [avalanche] use the OrphanProofPool.
May 5 2021, 14:32
majcosta added inline comments to D9476: [avalanche] use the OrphanProofPool.
May 5 2021, 13:21
bytesofman updated the diff for D9475: [Cashtab] MVP token creation.

Unit tests for token genesis validation functions and css bug fix

May 5 2021, 11:39
teamcity added a comment to D9476: [avalanche] use the OrphanProofPool.
May 5 2021, 08:43
PiRK requested review of D9476: [avalanche] use the OrphanProofPool.
May 5 2021, 08:32

May 4 2021

bytesofman updated the diff for D9475: [Cashtab] MVP token creation.

Remove duplicate import

May 4 2021, 22:00
bytesofman updated the diff for D9475: [Cashtab] MVP token creation.

Handle invalid wallet case with thrown error + add unit test for this

May 4 2021, 21:59
bytesofman updated the diff for D9475: [Cashtab] MVP token creation.

Hide unit test mock for createToken function

May 4 2021, 21:49
bytesofman updated the diff for D9475: [Cashtab] MVP token creation.

Add unit test for new createToken function, correct css bug in new TokenCollapse component

May 4 2021, 21:48
bytesofman updated the diff for D9475: [Cashtab] MVP token creation.

Updating snapshots on unit tests

May 4 2021, 21:14
teamcity added a comment to D9475: [Cashtab] MVP token creation.
May 4 2021, 21:09