Feed All Stories
Jun 7 2023
Jun 7 2023
Fabien committed rABC2fcf9572de66: Revert to finding and linking boost headers (authored by Fabien).
Revert to finding and linking boost headers
Fix a warning with GCC 13.1
Optimization: Coin&& to UndoCoinSpend
bytesofman added a comment to D13683: [WIP] [Cashtab] [Jest refactor] alias.js unit tests.
Cashtab UI changes / fixes supporting alias registration have been on hold while the server is finalized
bytesofman requested review of D14003: [ecash-herald] Implement ecash-script for OP_RETURN parsing.
bytesofman updated the diff for D14002: [ecash-script] Add util function swapEndianness.
Better tests, remove commenting errors, validate for hex string
Fabien retitled D14006: Fix a warning with GCC 13.1 from Fix a couple warnings with GCC 13.1 to Fix a warning with GCC 13.1.
teamcity updated the summary of D14010: Optimization: Coin&& to UndoCoinSpend.
Fabien requested review of D14010: Optimization: Coin&& to UndoCoinSpend.
teamcity added a comment to D13999: [build] check for boost 1.64 except for native build.
Build Bitcoin ABC Diffs / Diff Testing (gitian-linux) failed.
Fabien committed rABC6b2f9a78f408: refactor: Do not discard try_lock() return value (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
refactor: Do not discard try_lock() return value
teamcity added a comment to D13999: [build] check for boost 1.64 except for native build.
Build Bitcoin ABC Diffs / Diff Testing (gitian-osx) failed.
teamcity awarded D14009: Revert to finding and linking boost headers a Haypence token.
Fabien added a comment to D14009: Revert to finding and linking boost headers.
@bot build-linux64 build-osx build-win64 gitian-linux gitian-osx gitian-win
Fabien requested review of D14009: Revert to finding and linking boost headers.
teamcity added a comment to D13999: [build] check for boost 1.64 except for native build.
Build Bitcoin ABC Diffs / Diff Testing (gitian-win) failed.
bytesofman added a comment to D14000: [ecash-herald] Simplify miner parsing for IceBerg.
The problem is that there isn't actually a "CK Pool" mining pool on eCash. As far as I can tell, the "CK pool" message in the coinbase is just a result of a solo miner using this software
bytesofman added inline comments to D14003: [ecash-herald] Implement ecash-script for OP_RETURN parsing.
teamcity awarded D13999: [build] check for boost 1.64 except for native build a Mountain of Wealth token.
PiRK planned changes to D13999: [build] check for boost 1.64 except for native build.
@bot gitian-osx gitian-linux gitian-win
PiRK updated the diff for D13999: [build] check for boost 1.64 except for native build.
try to find_package(Boost... unconditionnaly
PiRK added a comment to D14006: Fix a warning with GCC 13.1.
This is probably the missing commit : https://github.com/bitcoin/bitcoin/pull/10195/commits/bd83111a0fcfdb97204a0180bcf861d3b53bb6c2
PiRK added inline comments to D14006: Fix a warning with GCC 13.1.
teamcity awarded D14007: scripts: make security checks architecture independent a Haypence token.
PiRK added a comment to D14007: scripts: make security checks architecture independent.
@bot gitian-osx gitian-linux gitian-win
teamcity updated the summary of D14007: scripts: make security checks architecture independent.
PiRK requested review of D14007: scripts: make security checks architecture independent.
Fabien requested changes to D14003: [ecash-herald] Implement ecash-script for OP_RETURN parsing.
Fabien requested changes to D13999: [build] check for boost 1.64 except for native build.
Fabien requested review of D14006: Fix a warning with GCC 13.1.
teamcity updated the summary of D14005: refactor: Do not discard try_lock() return value.
Fabien requested review of D14005: refactor: Do not discard try_lock() return value.
teamcity added a comment to D14004: [e.cash] Add get ecash page.
Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.19.73:41831 for the next 60 minutes.
teamcity awarded D14004: [e.cash] Add get ecash page a Haypence token.
bytesofman added a comment to D14004: [e.cash] Add get ecash page.
@bot preview-e.cash
Fabien requested changes to D14002: [ecash-script] Add util function swapEndianness.
johnkuney requested review of D14004: [e.cash] Add get ecash page.
PiRK published D13999: [build] check for boost 1.64 except for native build for review.
teamcity awarded D13999: [build] check for boost 1.64 except for native build a Doubloon token.
Fabien added a comment to D14000: [ecash-herald] Simplify miner parsing for IceBerg.
teamcity triaged T3184: Build Bitcoin-ABC / Master / Native tests / Test Native OSX is broken. as Unbreak Now! priority.
PiRK committed rABC13643e75537e: Add time helpers for std::chrono::steady_clock, Remove unused GetTimeSeconds (authored by MarcoFalke <falke.marco@gmail.com>).
Add time helpers for std::chrono::steady_clock, Remove unused GetTimeSeconds
Mengerian added a comment to D14000: [ecash-herald] Simplify miner parsing for IceBerg.
bytesofman updated the diff for D14003: [ecash-herald] Implement ecash-script for OP_RETURN parsing.
typo fix
bytesofman requested review of D14003: [ecash-herald] Implement ecash-script for OP_RETURN parsing.
Jun 6 2023
Jun 6 2023
bytesofman retitled D14002: [ecash-script] Add util function swapEndianness from [ecash-script] Add util function toBigEndianHexString to [ecash-script] Add util function swapEndianness.
bytesofman requested review of D14002: [ecash-script] Add util function swapEndianness.
bytesofman planned changes to D14001: [ecash-script] Return pushdata if requested.
util add should be split out
bytesofman requested review of D14001: [ecash-script] Return pushdata if requested.
Fabien added a comment to D13683: [WIP] [Cashtab] [Jest refactor] alias.js unit tests.
What's the status of this diff ?
Fabien requested changes to D14000: [ecash-herald] Simplify miner parsing for IceBerg.
This is strictly worse than the current implementation.
bytesofman planned changes to D13994: [alias] spec overview before alias-server implementation.
Actually if we want to do minimum pushes, better to support eMPP spec https://github.com/Bitcoin-ABC/bitcoin-abc/blob/master/chronik/bitcoinsuite-slp/src/empp/mod.rs
Mengerian published D14000: [ecash-herald] Simplify miner parsing for IceBerg for review.
bytesofman updated the diff for D13994: [alias] spec overview before alias-server implementation.
Simplify indexing by requiring single OP_RETURN output at first position to be valid
bytesofman committed rABC20c41a4f309d: [ecash-opreturn] New npm library for parsing OP_RETURN in ecash app dev (authored by bytesofman).
[ecash-opreturn] New npm library for parsing OP_RETURN in ecash app dev
bytesofman added inline comments to D13994: [alias] spec overview before alias-server implementation.
Fabien added inline comments to D13994: [alias] spec overview before alias-server implementation.
bytesofman updated the diff for D13993: [ecash-opreturn] New npm library for parsing OP_RETURN in ecash app dev.
Responding to feedback
bytesofman updated the diff for D13994: [alias] spec overview before alias-server implementation.
Require minimal pushes, require valid addresses
bytesofman added inline comments to D13994: [alias] spec overview before alias-server implementation.
bytesofman committed rABC6ee1468e8cce: [arclint] prettier to more of the monorepo p4 of 4 - add more directories to… (authored by bytesofman).
[arclint] prettier to more of the monorepo p4 of 4 - add more directories to…
bytesofman committed rABC3c657da23ee7: [arclint] prettier to more of the monorepo p3 - lint modules/ (authored by bytesofman).
[arclint] prettier to more of the monorepo p3 - lint modules/
bytesofman committed rABC6e9cbbd32f00: [arclint] prettier to more of the monorepo p2 - lint apps/ (authored by bytesofman).
[arclint] prettier to more of the monorepo p2 - lint apps/
bytesofman committed rABC09b327bba5d2: [arclint] prettier to more of the monorepo p1 - lint doc/standards (authored by bytesofman).
[arclint] prettier to more of the monorepo p1 - lint doc/standards
teamcity awarded D13999: [build] check for boost 1.64 except for native build a Piece of Eight token.
teamcity awarded D13999: [build] check for boost 1.64 except for native build a Haypence token.
teamcity triaged T3181: Build Bitcoin-ABC / Master / Build Documentation is broken. as Unbreak Now! priority.
PiRK updated the diff for D13988: Add time helpers for std::chrono::steady_clock, Remove unused GetTimeSeconds.
move compat/stdin.h to internal includes
build: header-only Boost
Fabien requested changes to D13994: [alias] spec overview before alias-server implementation.
PiRK added a comment to D13998: [arclint] prettier to more of the monorepo p4 of 4 - add more directories to prettier for .arclint.
tested with
arc patch D13998 arc lint --everything
Fabien requested changes to D13993: [ecash-opreturn] New npm library for parsing OP_RETURN in ecash app dev.
Fabien accepted D13991: build: header-only Boost.
That's awesome! It will cut the depends build time quite a bit.