Page MenuHomePhabricator
Feed All Stories

Jun 9 2023

PiRK committed rABC55a6b186ddc8: build: use macOS 11 SDK (Xcode 12.2) (authored by fanquake <fanquake@gmail.com>).
build: use macOS 11 SDK (Xcode 12.2)
Jun 9 2023, 08:19
PiRK accepted D14024: Remove tx chained limit from the coin selection algorithm.
Jun 9 2023, 06:30
PiRK accepted D14023: Rewrite OutputGroups to be clearer and to use scriptPubKeys.
Jun 9 2023, 06:27
PiRK accepted D14021: Move OutputGroup positive only filtering into Insert.
Jun 9 2023, 06:22
PiRK accepted D14022: Explicitly filter out partial groups when we don't want them.
Jun 9 2023, 06:17
PiRK requested changes to D14022: Explicitly filter out partial groups when we don't want them.
Jun 9 2023, 06:16
Fabien updated the diff for D14024: Remove tx chained limit from the coin selection algorithm.

Rebase

Jun 9 2023, 06:03
Fabien updated the diff for D14023: Rewrite OutputGroups to be clearer and to use scriptPubKeys.

Rebase

Jun 9 2023, 06:01
Fabien updated the diff for D14022: Explicitly filter out partial groups when we don't want them.

Rease

Jun 9 2023, 06:00
Fabien updated the diff for D14021: Move OutputGroup positive only filtering into Insert.

Rebase

Jun 9 2023, 05:59
Fabien closed D14020: Move EligibleForSpending into GroupOutputs.
Jun 9 2023, 05:59
Fabien committed rABC1f415b29c79a: Move EligibleForSpending into GroupOutputs (authored by Andrew Chow <achow101-github@achow101.com>).
Move EligibleForSpending into GroupOutputs
Jun 9 2023, 05:59
Fabien closed D14019: Move fee setting of OutputGroup to Insert.
Jun 9 2023, 05:59
Fabien closed D14018: Move GroupOutputs into SelectCoinsMinConf.
Jun 9 2023, 05:59
Fabien committed rABCa9e91bbf1bc9: Move fee setting of OutputGroup to Insert (authored by Andrew Chow <achow101-github@achow101.com>).
Move fee setting of OutputGroup to Insert
Jun 9 2023, 05:59
Fabien committed rABC399d24266641: Move GroupOutputs into SelectCoinsMinConf (authored by Andrew Chow <achow101-github@achow101.com>).
Move GroupOutputs into SelectCoinsMinConf
Jun 9 2023, 05:59
Fabien committed rABCe0f238e52d0d: Remove OutputGroup non-default constructors (authored by Andrew Chow <achow101-github@achow101.com>).
Remove OutputGroup non-default constructors
Jun 9 2023, 05:59
Fabien closed D14017: Remove OutputGroup non-default constructors.
Jun 9 2023, 05:59
johnkuney requested review of D14025: [e.cash] Fetch exchanges and services and render on get ecash page.
Jun 9 2023, 05:58
Fabien accepted D14015: build: use macOS 11 SDK (Xcode 12.2).
Jun 9 2023, 05:57
Fabien planned changes to D14024: Remove tx chained limit from the coin selection algorithm.
Jun 9 2023, 05:51
Fabien planned changes to D14023: Rewrite OutputGroups to be clearer and to use scriptPubKeys.
Jun 9 2023, 05:51
Fabien planned changes to D14022: Explicitly filter out partial groups when we don't want them.

Needs a clang-tidy fix

Jun 9 2023, 05:51
teamcity awarded D14015: build: use macOS 11 SDK (Xcode 12.2) a Piece of Eight token.
Jun 9 2023, 05:50
PiRK published D14015: build: use macOS 11 SDK (Xcode 12.2) for review.

@bot gitian-osx

Jun 9 2023, 05:50
PiRK accepted D14020: Move EligibleForSpending into GroupOutputs.
Jun 9 2023, 05:49
PiRK accepted D14019: Move fee setting of OutputGroup to Insert.
Jun 9 2023, 05:47
PiRK accepted D14018: Move GroupOutputs into SelectCoinsMinConf.
Jun 9 2023, 05:41
PiRK accepted D14017: Remove OutputGroup non-default constructors.
Jun 9 2023, 05:36

Jun 8 2023

teamcity added a comment to D14024: Remove tx chained limit from the coin selection algorithm.
Jun 8 2023, 21:43
teamcity added a comment to D14023: Rewrite OutputGroups to be clearer and to use scriptPubKeys.
Jun 8 2023, 21:39
teamcity added a comment to D14022: Explicitly filter out partial groups when we don't want them.
Jun 8 2023, 21:32
Fabien requested review of D14024: Remove tx chained limit from the coin selection algorithm.
Jun 8 2023, 21:27
teamcity updated the summary of D14023: Rewrite OutputGroups to be clearer and to use scriptPubKeys.
Jun 8 2023, 21:04
Fabien requested review of D14023: Rewrite OutputGroups to be clearer and to use scriptPubKeys.
Jun 8 2023, 21:04
teamcity updated the summary of D14022: Explicitly filter out partial groups when we don't want them.
Jun 8 2023, 21:03
Fabien requested review of D14022: Explicitly filter out partial groups when we don't want them.
Jun 8 2023, 21:03
teamcity updated the summary of D14021: Move OutputGroup positive only filtering into Insert.
Jun 8 2023, 21:03
Fabien requested review of D14021: Move OutputGroup positive only filtering into Insert.
Jun 8 2023, 21:03
teamcity updated the summary of D14020: Move EligibleForSpending into GroupOutputs.
Jun 8 2023, 21:02
Fabien requested review of D14020: Move EligibleForSpending into GroupOutputs.
Jun 8 2023, 21:02
teamcity updated the summary of D14019: Move fee setting of OutputGroup to Insert.
Jun 8 2023, 21:02
Fabien requested review of D14019: Move fee setting of OutputGroup to Insert.
Jun 8 2023, 21:01
teamcity updated the summary of D14018: Move GroupOutputs into SelectCoinsMinConf.
Jun 8 2023, 21:01
Fabien requested review of D14018: Move GroupOutputs into SelectCoinsMinConf.
Jun 8 2023, 21:01
teamcity updated the summary of D14017: Remove OutputGroup non-default constructors.
Jun 8 2023, 21:00
Fabien requested review of D14017: Remove OutputGroup non-default constructors.
Jun 8 2023, 21:00
Fabien requested changes to D14011: [ecash-script] Add option to return pushdata to existing consumeNextPush function.
Jun 8 2023, 18:03
Fabien accepted D14013: build: add -fstack-clash-protection to hardening flags.
Jun 8 2023, 17:54
Mengerian abandoned D14000: [ecash-herald] Simplify miner parsing for IceBerg.

Sounds like it's best to just abandon this for now

Jun 8 2023, 17:28
bytesofman updated the diff for D14011: [ecash-script] Add option to return pushdata to existing consumeNextPush function.

Change consumeNextPush to always return an object instead of a string, change version number to reflect breaking change

Jun 8 2023, 16:26
PiRK updated the diff for D14013: build: add -fstack-clash-protection to hardening flags.

use tabs for identation

Jun 8 2023, 16:19
teamcity awarded D14015: build: use macOS 11 SDK (Xcode 12.2) a Haypence token.
Jun 8 2023, 16:14
PiRK closed D14008: build: add -fcf-protection=full to hardening options and test for control flow instrumentation.
Jun 8 2023, 15:58
PiRK committed rABC894376aa8c6e: build: add -fcf-protection=full to hardening options and test for control flow… (authored by PiRK).
build: add -fcf-protection=full to hardening options and test for control flow…
Jun 8 2023, 15:58
bytesofman closed D14012: [ecash-script] Add unit tests to CI.
Jun 8 2023, 15:21
bytesofman committed rABC428a0842939c: [ecash-script] Add unit tests to CI (authored by bytesofman).
[ecash-script] Add unit tests to CI
Jun 8 2023, 15:21
Fabien accepted D14008: build: add -fcf-protection=full to hardening options and test for control flow instrumentation.
Jun 8 2023, 15:19
PiRK added a comment to D14008: build: add -fcf-protection=full to hardening options and test for control flow instrumentation.

It is

Jun 8 2023, 15:16
teamcity awarded D14013: build: add -fstack-clash-protection to hardening flags a Piece of Eight token.
Jun 8 2023, 15:13
PiRK added a comment to D14013: build: add -fstack-clash-protection to hardening flags.

@bot gitian-linux gitian-win

Jun 8 2023, 15:13
PiRK planned changes to D14013: build: add -fstack-clash-protection to hardening flags.

the error seems to be caused by downtime for download.qt.io, so i'll try again to run these.
But I need to fix the tabs vs spaces situation

Jun 8 2023, 15:13
PiRK abandoned D13989: refactor: move Boost datetime usage to wallet.

Better to do these backports in the right order if/when we have bandwidth for fuzzing. It does not really improve the boost situation anyway.

Jun 8 2023, 15:09
Fabien accepted D14012: [ecash-script] Add unit tests to CI.
Jun 8 2023, 13:49
bytesofman updated the diff for D14012: [ecash-script] Add unit tests to CI.

newline

Jun 8 2023, 13:40
Fabien requested changes to D14012: [ecash-script] Add unit tests to CI.
Jun 8 2023, 13:24
Fabien requested changes to D14011: [ecash-script] Add option to return pushdata to existing consumeNextPush function.

That's a bad API. As a general rule, don't have a function do 2 different things depending on a flag but create 2 functions instead.
Here you have 2 solutions:

  • Create a new function that calls consumeNextPush, and returns the data in addition
  • Just return the pushed data unconditionally and the callsite can drop the push if unused.
Jun 8 2023, 13:22
Fabien requested changes to D14013: build: add -fstack-clash-protection to hardening flags.

Back to your queue

Jun 8 2023, 13:18
Fabien added inline comments to D14008: build: add -fcf-protection=full to hardening options and test for control flow instrumentation.
Jun 8 2023, 13:17
PiRK closed D14007: scripts: make security checks architecture independent.
Jun 8 2023, 07:59
PiRK committed rABC364c0a6d7ab0: scripts: make security checks architecture independent (authored by fanquake <fanquake@gmail.com>).
scripts: make security checks architecture independent
Jun 8 2023, 07:58
teamcity awarded D14014: build: add test-(security|symbol)-check targets a Haypence token.
Jun 8 2023, 07:34
teamcity added a comment to D14013: build: add -fstack-clash-protection to hardening flags.
Jun 8 2023, 07:03
teamcity added a comment to D14013: build: add -fstack-clash-protection to hardening flags.
Jun 8 2023, 06:59
PiRK published D14008: build: add -fcf-protection=full to hardening options and test for control flow instrumentation for review.
Jun 8 2023, 06:35
teamcity awarded D14013: build: add -fstack-clash-protection to hardening flags a Haypence token.
Jun 8 2023, 06:35
PiRK added a comment to D14013: build: add -fstack-clash-protection to hardening flags.

@bot gitian-osx gitian-linux gitian-win

Jun 8 2023, 06:35
teamcity updated the summary of D14013: build: add -fstack-clash-protection to hardening flags.
Jun 8 2023, 06:34
PiRK requested review of D14013: build: add -fstack-clash-protection to hardening flags.
Jun 8 2023, 06:34
teamcity awarded D14008: build: add -fcf-protection=full to hardening options and test for control flow instrumentation a Piece of Eight token.
Jun 8 2023, 06:08
PiRK abandoned D13999: [build] check for boost 1.64 except for native build.

fixed in D14009

Jun 8 2023, 05:39
teamcity closed T3186: Build Bitcoin-ABC / Master / Default Extended Tests is broken. as Resolved.
Jun 8 2023, 04:37
abc-bot committed rABC7a9ea103316c: [Automated] Update timing.json (authored by abc-bot).
[Automated] Update timing.json
Jun 8 2023, 03:38
teamcity triaged T3186: Build Bitcoin-ABC / Master / Default Extended Tests is broken. as Unbreak Now! priority.
Jun 8 2023, 03:16
abc-bot committed rABC09d7b8397b35: [Automated] Update seeds (authored by abc-bot).
[Automated] Update seeds
Jun 8 2023, 02:19
abc-bot committed rABC5b5f2f98b051: [Automated] Update chainparams (authored by abc-bot).
[Automated] Update chainparams
Jun 8 2023, 02:09

Jun 7 2023

emack planned changes to D13683: [WIP] [Cashtab] [Jest refactor] alias.js unit tests.
Jun 7 2023, 22:16
bytesofman requested review of D14012: [ecash-script] Add unit tests to CI.
Jun 7 2023, 21:22
bytesofman abandoned D14001: [ecash-script] Return pushdata if requested.

Superseded by D14011

Jun 7 2023, 19:59
teamcity closed T3185: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux ARM is broken. as Resolved.
Jun 7 2023, 19:51
teamcity triaged T3185: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux ARM is broken. as Unbreak Now! priority.
Jun 7 2023, 19:16
bytesofman requested review of D14011: [ecash-script] Add option to return pushdata to existing consumeNextPush function.
Jun 7 2023, 19:01
johnkuney closed D14004: [e.cash] Add get ecash page.
Jun 7 2023, 19:00
johnkuney committed rABC0830ba75c4ed: [e.cash] Add get ecash page (authored by johnkuney).
[e.cash] Add get ecash page
Jun 7 2023, 19:00
bytesofman closed D14003: [ecash-herald] Implement ecash-script for OP_RETURN parsing.
Jun 7 2023, 18:46
bytesofman committed rABC120e68c63d9c: [ecash-herald] Implement ecash-script for OP_RETURN parsing (authored by bytesofman).
[ecash-herald] Implement ecash-script for OP_RETURN parsing
Jun 7 2023, 18:46
bytesofman closed D14002: [ecash-script] Add util function swapEndianness.
Jun 7 2023, 18:46
bytesofman committed rABCdbf24d31c5bd: [ecash-script] Add util function swapEndianness (authored by bytesofman).
[ecash-script] Add util function swapEndianness
Jun 7 2023, 18:46
teamcity closed T3184: Build Bitcoin-ABC / Master / Native tests / Test Native OSX is broken. as Resolved.
Jun 7 2023, 18:35
Fabien accepted D14003: [ecash-herald] Implement ecash-script for OP_RETURN parsing.
Jun 7 2023, 18:13