What do you think about mirroring the placement of the "Lean more" tile ? The site is in english, reading from left to right and it would make sense imo to have the tile on the left, and the techno tiles on the right.
This should be done in another diff though.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Jun 12 2023
Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.104.128:41647 for the next 60 minutes.
@bot preview-e.cash
Jun 10 2023
improve comment
respond to feedback, add explanation of conditional return
One more comment and it should be good to go
Both default genesis block and user specified block words fine, just need to test the failed price API scenario on sendBlockSummary
you should create a new __mocks__ and new __test__ folder in utils/
Jun 9 2023
add untracked files
add some test and put scripts in same file
improve comments
In D14025#313322, @johnkuney wrote:Okay. So, something like
utils/pageUtils.js , with both functions in it
utils/__tests__/pageUtils.test.js, with unit testsI was about to say actually I forgot why I did it like that in the first place, those functions have to be called there afaik since the data is coming from getstaticprops if I try to break it down at the component level, I run into some lifecycle issues. And getstatic props can only run at the page level
add scoring notes, handle no id passed to h3
Okay. So, something like
utils/pageUtils.js , with both functions in it
utils/__tests__/pageUtils.test.js, with unit tests
links load with title under nav bar, would be nice if they loaded with the title just below nav bar. Maybe further down or something like "centered in screen" , so that the animation is not cut off
Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.19.73:41252 for the next 60 minutes.
@bot preview-e.cash
In D14025#313280, @johnkuney wrote:weird that getScores and makeDivisibleByThree have their own files? Match the pattern from your earlier diff.
- Put component-specific methods into a single file in the folder for that component
- Add unit tests for these functions
well they are not in a component as was the case earlier, they are at the page level. Can refactor so the TileSection is a component though
weird that getScores and makeDivisibleByThree have their own files? Match the pattern from your earlier diff.
- Put component-specific methods into a single file in the folder for that component
- Add unit tests for these functions
weird that getScores and makeDivisibleByThree have their own files? Match the pattern from your earlier diff.
simplifying, improved variable names
In D14025#313252, @johnkuney wrote:The links don't jump to the title of the section but to the table on my browser. It looks like the anchor is misplaced
good call, they werent on the headers. Added some padding too so theyre not under the navbar
Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.68.37.192:41393 for the next 60 minutes.
@bot preview-e.cash
The links don't jump to the title of the section but to the table on my browser. It looks like the anchor is misplaced
change api var name, fix anchor links, homogenize functoin syntax
The links don't jump to the title of the section but to the table on my browser. It looks like the anchor is misplaced
Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.68.37.192:41383 for the next 60 minutes.
@bot preview-e.cash
less ambiguous variables, cleaning up variable assignment in response to feedback
typo fix
lint
@bot gitian-osx gitian-linux gitian-win