Page MenuHomePhabricator
Feed All Stories

Jun 12 2023

Fabien added a comment to D14035: [e.cash] Add tile section to homepage.

What do you think about mirroring the placement of the "Lean more" tile ? The site is in english, reading from left to right and it would make sense imo to have the tile on the left, and the techno tiles on the right.
This should be done in another diff though.

Jun 12 2023, 06:53
teamcity added a comment to D14035: [e.cash] Add tile section to homepage.

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.104.128:41647 for the next 60 minutes.

Jun 12 2023, 06:42
teamcity awarded D14035: [e.cash] Add tile section to homepage a Piece of Eight token.
Jun 12 2023, 06:42
Fabien added a comment to D14035: [e.cash] Add tile section to homepage.

@bot preview-e.cash

Jun 12 2023, 06:41

Jun 10 2023

bytesofman closed D14011: [ecash-script] Add option to return pushdata to existing consumeNextPush function.
Jun 10 2023, 20:44
bytesofman committed rABC926f1357d20e: [ecash-script] Add option to return pushdata to existing consumeNextPush… (authored by bytesofman).
[ecash-script] Add option to return pushdata to existing consumeNextPush…
Jun 10 2023, 20:44
Fabien published D14032: Remove the miner fund consensus code for review.
Jun 10 2023, 19:22
Fabien abandoned D9694: Ensure `nExtraNonce` is initialized randomly.
Jun 10 2023, 19:22
Fabien commandeered D9694: Ensure `nExtraNonce` is initialized randomly.
Jun 10 2023, 19:22
Fabien accepted D14011: [ecash-script] Add option to return pushdata to existing consumeNextPush function.
Jun 10 2023, 19:21
bytesofman updated the diff for D14011: [ecash-script] Add option to return pushdata to existing consumeNextPush function.

improve comment

Jun 10 2023, 16:47
bytesofman updated the diff for D14011: [ecash-script] Add option to return pushdata to existing consumeNextPush function.

respond to feedback, add explanation of conditional return

Jun 10 2023, 16:47
emack planned changes to D12862: [Cashtab] [eToken multisends] Part 1/3 - Frontend scaffolding.
Jun 10 2023, 07:41
emack accepted D14033: [ecash-herald] Remove deprecated function.
Jun 10 2023, 07:39
Fabien requested changes to D14025: [e.cash] Fetch exchanges and services and render on get ecash page.
Jun 10 2023, 07:33
emack requested changes to D14034: [ecash-herald] Parse cash fusion txs.
Jun 10 2023, 07:30
Fabien requested changes to D14011: [ecash-script] Add option to return pushdata to existing consumeNextPush function.

One more comment and it should be good to go

Jun 10 2023, 07:26
emack requested changes to D14036: [ecash-herald] Add new script to support testing, sendMsgByBlock.

Both default genesis block and user specified block words fine, just need to test the failed price API scenario on sendBlockSummary

Jun 10 2023, 07:14
bytesofman requested changes to D14025: [e.cash] Fetch exchanges and services and render on get ecash page.

you should create a new __mocks__ and new __test__ folder in utils/

Jun 10 2023, 00:03

Jun 9 2023

johnkuney updated the diff for D14025: [e.cash] Fetch exchanges and services and render on get ecash page.

add untracked files

Jun 9 2023, 23:43
johnkuney updated the diff for D14025: [e.cash] Fetch exchanges and services and render on get ecash page.

add some test and put scripts in same file

Jun 9 2023, 23:42
bytesofman updated the diff for D14036: [ecash-herald] Add new script to support testing, sendMsgByBlock.

improve comments

Jun 9 2023, 23:39
bytesofman requested review of D14036: [ecash-herald] Add new script to support testing, sendMsgByBlock.
Jun 9 2023, 23:35
bytesofman requested changes to D14025: [e.cash] Fetch exchanges and services and render on get ecash page.
Jun 9 2023, 22:58
bytesofman added a comment to D14025: [e.cash] Fetch exchanges and services and render on get ecash page.

Okay. So, something like

utils/pageUtils.js , with both functions in it
utils/__tests__/pageUtils.test.js, with unit tests

I was about to say actually I forgot why I did it like that in the first place, those functions have to be called there afaik since the data is coming from getstaticprops if I try to break it down at the component level, I run into some lifecycle issues. And getstatic props can only run at the page level

Jun 9 2023, 22:57
johnkuney updated the diff for D14025: [e.cash] Fetch exchanges and services and render on get ecash page.

add scoring notes, handle no id passed to h3

Jun 9 2023, 22:48
johnkuney added a comment to D14025: [e.cash] Fetch exchanges and services and render on get ecash page.

Okay. So, something like

utils/pageUtils.js , with both functions in it
utils/__tests__/pageUtils.test.js, with unit tests

Jun 9 2023, 22:46
johnkuney added inline comments to D14025: [e.cash] Fetch exchanges and services and render on get ecash page.
Jun 9 2023, 22:41
bytesofman added a comment to D14035: [e.cash] Add tile section to homepage.

links load with title under nav bar, would be nice if they loaded with the title just below nav bar. Maybe further down or something like "centered in screen" , so that the animation is not cut off

Jun 9 2023, 22:29
bytesofman added inline comments to D14035: [e.cash] Add tile section to homepage.
Jun 9 2023, 22:27
teamcity added a comment to D14035: [e.cash] Add tile section to homepage.

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://54.39.19.73:41252 for the next 60 minutes.

Jun 9 2023, 22:27
teamcity awarded D14035: [e.cash] Add tile section to homepage a Haypence token.
Jun 9 2023, 22:26
bytesofman added a comment to D14035: [e.cash] Add tile section to homepage.

@bot preview-e.cash

Jun 9 2023, 22:26
bytesofman added a comment to D14025: [e.cash] Fetch exchanges and services and render on get ecash page.

weird that getScores and makeDivisibleByThree have their own files? Match the pattern from your earlier diff.

  • Put component-specific methods into a single file in the folder for that component
  • Add unit tests for these functions

well they are not in a component as was the case earlier, they are at the page level. Can refactor so the TileSection is a component though

Jun 9 2023, 22:22
johnkuney requested review of D14035: [e.cash] Add tile section to homepage.
Jun 9 2023, 21:36
bytesofman added a comment to D14034: [ecash-herald] Parse cash fusion txs.

image.png (198×533 px, 25 KB)

Jun 9 2023, 21:18
bytesofman requested review of D14034: [ecash-herald] Parse cash fusion txs.
Jun 9 2023, 21:18
bytesofman requested review of D14033: [ecash-herald] Remove deprecated function.
Jun 9 2023, 20:28
johnkuney added a comment to D14025: [e.cash] Fetch exchanges and services and render on get ecash page.

weird that getScores and makeDivisibleByThree have their own files? Match the pattern from your earlier diff.

  • Put component-specific methods into a single file in the folder for that component
  • Add unit tests for these functions
Jun 9 2023, 20:16
bytesofman closed D14030: [ecash-herald] Parse memo txs using ecash-script library.
Jun 9 2023, 19:31
bytesofman committed rABC4d294d2f4e4e: [ecash-herald] Parse memo txs using ecash-script library (authored by bytesofman).
[ecash-herald] Parse memo txs using ecash-script library
Jun 9 2023, 19:31
bytesofman closed D14031: [ecash-herald] Prep OP_RETURN strings for tg parsing depending on content.
Jun 9 2023, 19:28
bytesofman committed rABC041ae57f661f: [ecash-herald] Prep OP_RETURN strings for tg parsing depending on content (authored by bytesofman).
[ecash-herald] Prep OP_RETURN strings for tg parsing depending on content
Jun 9 2023, 19:28
bytesofman requested changes to D14025: [e.cash] Fetch exchanges and services and render on get ecash page.

weird that getScores and makeDivisibleByThree have their own files? Match the pattern from your earlier diff.

Jun 9 2023, 19:23
bytesofman added inline comments to D14011: [ecash-script] Add option to return pushdata to existing consumeNextPush function.
Jun 9 2023, 18:57
bytesofman updated the diff for D14011: [ecash-script] Add option to return pushdata to existing consumeNextPush function.

simplifying, improved variable names

Jun 9 2023, 18:57
Fabien accepted D14030: [ecash-herald] Parse memo txs using ecash-script library.
Jun 9 2023, 18:27
Fabien accepted D14031: [ecash-herald] Prep OP_RETURN strings for tg parsing depending on content.
Jun 9 2023, 18:26
Fabien added a comment to D14025: [e.cash] Fetch exchanges and services and render on get ecash page.

The links don't jump to the title of the section but to the table on my browser. It looks like the anchor is misplaced

good call, they werent on the headers. Added some padding too so theyre not under the navbar

Jun 9 2023, 18:24
teamcity added a comment to D14025: [e.cash] Fetch exchanges and services and render on get ecash page.

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.68.37.192:41393 for the next 60 minutes.

Jun 9 2023, 18:15
teamcity awarded D14025: [e.cash] Fetch exchanges and services and render on get ecash page a Piece of Eight token.
Jun 9 2023, 18:14
Fabien added a comment to D14025: [e.cash] Fetch exchanges and services and render on get ecash page.

@bot preview-e.cash

Jun 9 2023, 18:14
johnkuney added a comment to D14025: [e.cash] Fetch exchanges and services and render on get ecash page.

The links don't jump to the title of the section but to the table on my browser. It looks like the anchor is misplaced

Jun 9 2023, 18:06
johnkuney updated the diff for D14025: [e.cash] Fetch exchanges and services and render on get ecash page.

change api var name, fix anchor links, homogenize functoin syntax

Jun 9 2023, 18:03
Fabien requested changes to D14011: [ecash-script] Add option to return pushdata to existing consumeNextPush function.
Jun 9 2023, 17:55
Fabien added a comment to D14025: [e.cash] Fetch exchanges and services and render on get ecash page.

The links don't jump to the title of the section but to the table on my browser. It looks like the anchor is misplaced

Jun 9 2023, 17:48
johnkuney added inline comments to D14025: [e.cash] Fetch exchanges and services and render on get ecash page.
Jun 9 2023, 17:47
bytesofman requested changes to D14025: [e.cash] Fetch exchanges and services and render on get ecash page.
Jun 9 2023, 17:35
teamcity added a comment to D14025: [e.cash] Fetch exchanges and services and render on get ecash page.

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.68.37.192:41383 for the next 60 minutes.

Jun 9 2023, 17:29
teamcity awarded D14025: [e.cash] Fetch exchanges and services and render on get ecash page a Haypence token.
Jun 9 2023, 17:27
bytesofman added a comment to D14025: [e.cash] Fetch exchanges and services and render on get ecash page.

@bot preview-e.cash

Jun 9 2023, 17:27
bytesofman added inline comments to D14030: [ecash-herald] Parse memo txs using ecash-script library.
Jun 9 2023, 17:10
bytesofman updated the diff for D14011: [ecash-script] Add option to return pushdata to existing consumeNextPush function.

less ambiguous variables, cleaning up variable assignment in response to feedback

Jun 9 2023, 17:09
teamcity awarded D14032: Remove the miner fund consensus code a Haypence token.
Jun 9 2023, 16:46
Fabien closed D14028: Cleanup remaining chained-tx related code and comments.
Jun 9 2023, 16:46
Fabien committed rABC9e1671c99fa5: Cleanup remaining chained-tx related code and comments (authored by Fabien).
Cleanup remaining chained-tx related code and comments
Jun 9 2023, 16:46
bytesofman requested review of D14031: [ecash-herald] Prep OP_RETURN strings for tg parsing depending on content.
Jun 9 2023, 16:35
bytesofman updated the diff for D14030: [ecash-herald] Parse memo txs using ecash-script library.

typo fix

Jun 9 2023, 16:30
bytesofman added inline comments to D14030: [ecash-herald] Parse memo txs using ecash-script library.
Jun 9 2023, 16:29
bytesofman updated the diff for D14030: [ecash-herald] Parse memo txs using ecash-script library.

lint

Jun 9 2023, 16:26
bytesofman requested review of D14030: [ecash-herald] Parse memo txs using ecash-script library.
Jun 9 2023, 16:26
PiRK closed D14027: depends: update the native_*.mk files.
Jun 9 2023, 15:45
PiRK committed rABCcef329cd0fb1: depends: update the native_*.mk files (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>).
depends: update the native_*.mk files
Jun 9 2023, 15:45
PiRK accepted D14028: Cleanup remaining chained-tx related code and comments.
Jun 9 2023, 15:42
Fabien accepted D14027: depends: update the native_*.mk files.
Jun 9 2023, 15:41
Fabien updated the summary of D14027: depends: update the native_*.mk files.
Jun 9 2023, 15:41
Fabien requested review of D14029: Remove tx MIN_STANDARD_VERSION and MAX_STANDARD_VERSION.
Jun 9 2023, 14:49
Fabien requested review of D14028: Cleanup remaining chained-tx related code and comments.
Jun 9 2023, 13:57
teamcity awarded D14027: depends: update the native_*.mk files a Haypence token.
Jun 9 2023, 13:50
PiRK added a comment to D14027: depends: update the native_*.mk files.

@bot gitian-osx gitian-linux gitian-win

Jun 9 2023, 13:50
teamcity updated the summary of D14027: depends: update the native_*.mk files.
Jun 9 2023, 13:24
PiRK requested review of D14027: depends: update the native_*.mk files.
Jun 9 2023, 13:24
Fabien closed D14024: Remove tx chained limit from the coin selection algorithm.
Jun 9 2023, 13:24
Fabien committed rABCbcd6dafcd35e: Remove tx chained limit from the coin selection algorithm (authored by Fabien).
Remove tx chained limit from the coin selection algorithm
Jun 9 2023, 13:24
Fabien closed D14023: Rewrite OutputGroups to be clearer and to use scriptPubKeys.
Jun 9 2023, 13:24
Fabien committed rABC5726657eaaf7: Rewrite OutputGroups to be clearer and to use scriptPubKeys (authored by Andrew Chow <achow101-github@achow101.com>).
Rewrite OutputGroups to be clearer and to use scriptPubKeys
Jun 9 2023, 13:24
Fabien closed D14022: Explicitly filter out partial groups when we don't want them.
Jun 9 2023, 13:24
Fabien committed rABC8c9a764afae1: Explicitly filter out partial groups when we don't want them (authored by Andrew Chow <achow101-github@achow101.com>).
Explicitly filter out partial groups when we don't want them
Jun 9 2023, 13:24
Fabien closed D14021: Move OutputGroup positive only filtering into Insert.
Jun 9 2023, 13:24
Fabien committed rABC1afb4e8964c7: Move OutputGroup positive only filtering into Insert (authored by Andrew Chow <achow101-github@achow101.com>).
Move OutputGroup positive only filtering into Insert
Jun 9 2023, 13:24
PiRK closed D14026: depends: use latest config.(guess|sub).
Jun 9 2023, 13:23
PiRK committed rABC5ef77befd14f: depends: use latest config.(guess|sub) (authored by fanquake <fanquake@gmail.com>).
depends: use latest config.(guess|sub)
Jun 9 2023, 13:23
Fabien accepted D14026: depends: use latest config.(guess|sub).
Jun 9 2023, 12:17
PiRK updated the summary of D14026: depends: use latest config.(guess|sub).
Jun 9 2023, 11:08
PiRK published D14026: depends: use latest config.(guess|sub) for review.
Jun 9 2023, 10:44
teamcity awarded D14016: gitian: support arm64 darwin a Haypence token.
Jun 9 2023, 09:09
teamcity awarded D14026: depends: use latest config.(guess|sub) a Haypence token.
Jun 9 2023, 09:07
PiRK closed D14013: build: add -fstack-clash-protection to hardening flags.
Jun 9 2023, 08:22
PiRK committed rABCcde09d204c3f: build: add -fstack-clash-protection to hardening flags (authored by PiRK).
build: add -fstack-clash-protection to hardening flags
Jun 9 2023, 08:22
PiRK closed D14015: build: use macOS 11 SDK (Xcode 12.2).
Jun 9 2023, 08:20