Differential D7161

[backport#17304 14/18] Refactor: Move HavePrivateKeys code out of CWallet::CreateWalletFromFile
ClosedPublic
Actions

Authored by majcosta on Aug 7 2020, 17:20.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rABC0495ea423821: [backport#17304 14/18] Refactor: Move HavePrivateKeys code out of CWallet…

Summary

This commit does not change behavior.

https://github.com/bitcoin/bitcoin/pull/17304/commits/f45d12b36cee05aa3c2685b951d27bd8a58539ae

Depends on D7160

Partial backport of Core PR17304

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 12344
Build 24882: Build Diff	build-without-wallet · build-diff · build-clang-tidy · build-clang-10
Build 24881: arc lint + arc unit

Event Timeline

majcosta created this revision.Aug 7 2020, 17:20

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 7 2020, 17:20

majcosta requested review of this revision.Aug 7 2020, 17:20

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta added a child revision: D7162: [backport#17304 15/18] Refactor: Move SetupGeneration code out of CWallet.Aug 7 2020, 17:21

Harbormaster completed remote builds in B12344: Diff 22805.Aug 7 2020, 17:41

jasonbcox accepted this revision.Aug 8 2020, 00:03

This revision is now accepted and ready to land.Aug 8 2020, 00:03

Closed by commit rABC0495ea423821: [backport#17304 14/18] Refactor: Move HavePrivateKeys code out of CWallet… (authored by Andrew Chow <achow101-github@achow101.com>, committed by majcosta). · Explain WhyAug 8 2020, 19:57

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABC0495ea423821: [backport#17304 14/18] Refactor: Move HavePrivateKeys code out of CWallet….

Revision Contents
Changeset List

Path

Size

src/

wallet/

scriptpubkeyman.h

4 lines

scriptpubkeyman.cpp

5 lines

wallet.cpp

16 lines

Diff 22805

View Options

src/wallet/scriptpubkeyman.h

View Options

src/wallet/scriptpubkeyman.cpp

View Options

[backport#17304 14/18] Refactor: Move HavePrivateKeys code out of CWallet::CreateWalletFromFileClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 22805

src/wallet/scriptpubkeyman.h

src/wallet/scriptpubkeyman.cpp

src/wallet/wallet.cpp

[backport#17304 14/18] Refactor: Move HavePrivateKeys code out of CWallet::CreateWalletFromFile
ClosedPublic
Actions

Revision Contents
Changeset List