Page MenuHomePhabricator
Differential D7162

[backport#17304 15/18] Refactor: Move SetupGeneration code out of CWallet
ClosedPublic
Actions

Authored by majcosta on Aug 7 2020, 17:21.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABCc8f95523f65b: [backport#17304 15/18] Refactor: Move SetupGeneration code out of CWallet
Summary

This commit does not change behavior.

https://github.com/bitcoin/bitcoin/pull/17304/commits/0eac7088ab878372a72f85f9c5f7662a14199083

Depends on D7161

Partial backport of Core PR17304

Test Plan
ninja check

Diff Detail

Event Timeline

majcosta created this revision.Aug 7 2020, 17:21
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 7 2020, 17:22
majcosta requested review of this revision.Aug 7 2020, 17:22
teamcity edited the summary of this revision. (Show Details)Aug 7 2020, 17:22

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

majcosta added a child revision: D7163: [backport#17304 16/18] Refactor: Move RewriteDB code out of CWallet.Aug 7 2020, 17:23
Harbormaster completed remote builds in B12345: Diff 22806.Aug 7 2020, 17:46
jasonbcox accepted this revision.Aug 8 2020, 00:12
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/wallet/scriptpubkeyman.h
182

Nit: missing period between successful Set

This revision is now accepted and ready to land.Aug 8 2020, 00:12
Closed by commit rABCc8f95523f65b: [backport#17304 15/18] Refactor: Move SetupGeneration code out of CWallet (authored by Andrew Chow <achow101-github@achow101.com>, committed by majcosta). · Explain WhyAug 8 2020, 19:57
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABCc8f95523f65b: [backport#17304 15/18] Refactor: Move SetupGeneration code out of CWallet.

Revision Contents
Changeset List

PathSize
src/
wallet/
10 lines
12 lines
35 lines

Diff 22806

View Options

src/wallet/scriptpubkeyman.h

Loading...
View Options

src/wallet/scriptpubkeyman.cpp

Loading...
View Options

src/wallet/wallet.cpp

Loading...