Differential D1972

[Part 5 of 5] Add a CChainState class to clarify internal interfaces
ClosedPublic
Actions

Authored by jasonbcox on Oct 24 2018, 18:51.

Details

Reviewers

schancel
deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGING39f8c32faa2d: [Part 5 of 5] Add a CChainState class to clarify internal interfaces
rABC39f8c32faa2d: [Part 5 of 5] Add a CChainState class to clarify internal interfaces

Summary

Move some additional variables into CChainState private

Backport of Core PR 10279 commit 2862aca
https://github.com/bitcoin/bitcoin/pull/10279/commits/2862aca40f24acc48d3052d5ba3f639e3fc0a621

Depends on D1971 and D2645
T572

Test Plan

make check
test_runner.py --extended

Diff Detail

Repository

rABC Bitcoin ABC

Branch

arcpatch-D1972

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6865
Build 11777: Bitcoin ABC Buildbot (legacy)
Build 11776: arc lint + arc unit

Event Timeline

schancel created this revision.Oct 24 2018, 18:51

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 24 2018, 18:51

schancel edited the summary of this revision. (Show Details)Oct 24 2018, 18:52

schancel added a parent revision: D1971: [Part 4 of 5] Add a CChainState class to clarify internal interfaces.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3678: Diff 5527.Oct 24 2018, 19:12

schancel planned changes to this revision.Oct 26 2018, 22:48

jasonbcox edited the summary of this revision. (Show Details)Apr 2 2019, 20:34

schancel edited the summary of this revision. (Show Details)Apr 9 2019, 03:24

schancel added a parent revision: D2645: Reject headers building on invalid chains by tracking invalidity.

jasonbcox mentioned this in D2818: Remove direct bitcoin calls from qt/clientmodel.cpp.Apr 17 2019, 18:28

What about the UpdateTip changes?

markblundeberg mentioned this in D2788: Remove unknown version warning from UpdateTip.Jun 21 2019, 23:05

jasonbcox commandeered this revision.Jul 16 2019, 02:14

jasonbcox added a reviewer: schancel.

Rebase
Fix missing portions of the backport

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox edited the test plan for this revision. (Show Details)Jul 16 2019, 02:59

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6865: Diff 10310.Jul 16 2019, 03:06

jasonbcox added a child revision: D3693: scripted-diff: Rename CChainState::g_failed_blocks to m_failed_blocks.Jul 18 2019, 17:28

deadalnix accepted this revision.Jul 21 2019, 13:36

This revision is now accepted and ready to land.Jul 21 2019, 13:36

Closed by commit rABC39f8c32faa2d: [Part 5 of 5] Add a CChainState class to clarify internal interfaces (authored by jasonbcox). · Explain WhyJul 22 2019, 16:23

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rABC39f8c32faa2d: [Part 5 of 5] Add a CChainState class to clarify internal interfaces.

jasonbcox added a commit: rSTAGING39f8c32faa2d: [Part 5 of 5] Add a CChainState class to clarify internal interfaces.Sep 19 2019, 01:21

PiRK mentioned this in D11755: Fix outdated comments referring to ::ChainActive().Jul 15 2022, 11:50

PiRK mentioned this in rABC1b305875768a: Fix outdated comments referring to ::ChainActive().Jul 15 2022, 13:12

Fabien mentioned this in D12278: validation: change UpdateTip for multiple chainstates.Oct 17 2022, 15:58

PiRK mentioned this in rABCa1093fa5f579: validation: change UpdateTip for multiple chainstates.Oct 19 2022, 11:34

Revision Contents
Changeset List

Path

Size

src/

validation.cpp

99 lines

Diff 10310

View Options

[Part 5 of 5] Add a CChainState class to clarify internal interfacesClosedPublicActions