Page MenuHomePhabricator
Differential D4370

Deprecate wallet 'account' API
ClosedPublic
Actions

Authored by nakihito on Nov 4 2019, 19:33.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING5ef562707048: Deprecate wallet 'account' API
rABC5ef562707048: Deprecate wallet 'account' API
Summary

[wallet] [rpc] Deprecate wallet 'account' API
[wallet] [tests] Add tests for accounts/labels APIs

This commit finalizes the deprecation of the wallet 'accounts' API by
removing all account arguments and return values.

RPC behaviour is slightly different if the 'accounts' or 'labels' API is
being used. Those behaviour changes are fully documented in the RPC help
text.

Partial backport of Core PR12953
https://github.com/bitcoin/bitcoin/pull/12953/commits/109e05dcd163b8ddb7f4b3550db6b9ab833b2c04
https://github.com/bitcoin/bitcoin/pull/12953/commits/72c9575f7b793e3c77bd2d631ef7345a4c31cb0d

Depends on D4369

Test Plan
make check
test_runner.py
./bitcoind -deprecatedrpc=accounts
./bitcoin-cli help getbalance
./bitcoin-cli help sendmany
./bitcoin-cli help listtransactions
./bitcoin-cli help listsinceblock
./bitcoin-cli help getaddressinfo

Repeat the above help commands, but under ./bitcoind and verify the help messages are correct.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.Nov 4 2019, 19:33
Owners added a reviewer: Restricted Owners Package.Nov 4 2019, 19:33
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 4 2019, 19:33
nakihito mentioned this in D3950: Merge #12953: Deprecate accounts.Nov 4 2019, 19:33
teamcity added a comment.Nov 4 2019, 19:33

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 4 2019, 19:42

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7975: Diff 13901.Nov 4 2019, 19:42
Fabien requested changes to this revision.Nov 5 2019, 07:50
Fabien added inline comments.
src/wallet/rpcwallet.cpp
1131 ↗(On Diff #13901)

Restore single line

1515 ↗(On Diff #13901)

I count only 5

2062 ↗(On Diff #13901)

Braces

2094 ↗(On Diff #13901)

Dito

2132 ↗(On Diff #13901)

Dito

This revision now requires changes to proceed.Nov 5 2019, 07:50
nakihito updated this revision to Diff 13926.Nov 5 2019, 17:03

Restored single line if, added braces, and fixed argument count check.

teamcity added a comment.Nov 5 2019, 17:03

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 5 2019, 17:13

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7992: Diff 13926.Nov 5 2019, 17:13
Fabien accepted this revision.Nov 5 2019, 20:22
This revision is now accepted and ready to land.Nov 5 2019, 20:22
Closed by commit rABC5ef562707048: Deprecate wallet 'account' API (authored by John Newbery <john@johnnewbery.com>, committed by nakihito). · Explain WhyNov 5 2019, 21:37
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABC5ef562707048: Deprecate wallet 'account' API.
nakihito mentioned this in D5316: Merge #14023: Remove accounts rpcs.Mar 4 2020, 20:04
nakihito added a commit: rSTAGING5ef562707048: Deprecate wallet 'account' API.Apr 7 2020, 21:36

Revision Contents
Changeset List

PathSize
src/
wallet/
336 lines
test/
functional/
60 lines

Diff 13933

View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

test/functional/wallet_labels.py

Loading...