Page MenuHomePhabricator
Feed Advanced Search

Nov 6 2018

schancel accepted D2010: Migrate test framework from deprecated optparse to argparse.
Nov 6 2018, 17:28
schancel updated the diff for D1937: Change the maxtxfee to be per kb..

Rebas eon updated changes to maxtxfee

Nov 6 2018, 02:39
schancel committed rSTAGING8df8f0c5fadc: Update release notes to include several missing items (authored by schancel).
Update release notes to include several missing items
Nov 6 2018, 02:20
schancel committed rSTAGING0d78d3bac38d: [qa] Improve wallet-accounts test (authored by Russell Yanofsky <russ@yanofsky.org>).
[qa] Improve wallet-accounts test
Nov 6 2018, 02:20
schancel committed rSTAGINGa38cb6434eae: [tests] fix cross-platform sprintf issue in blockindex_tests (authored by schancel).
[tests] fix cross-platform sprintf issue in blockindex_tests
Nov 6 2018, 02:20
schancel committed rSTAGINGc8c4ff20a84f: scripted-diff: Use UniValue.pushKV instead of push_back(Pair()) (authored by Karel Bilek <kb@karelbilek.com>).
scripted-diff: Use UniValue.pushKV instead of push_back(Pair())
Nov 6 2018, 02:20
schancel committed rSTAGING6daa39b9af87: Update univalue to latest release (1.0.4) (authored by schancel).
Update univalue to latest release (1.0.4)
Nov 6 2018, 02:19
schancel added inline comments to D1986: Rename account to label where appropriate.
Nov 6 2018, 02:15
schancel updated the diff for D1986: Rename account to label where appropriate.

Fix pushKVs

Nov 6 2018, 02:12
Herald added a reviewer for D2006: Ensure config variables are initalized: Restricted Project.
Nov 6 2018, 00:45
schancel updated the diff for D1936: Move handling for `-maxtxfee` to the config object.

Address more feedback

Nov 6 2018, 00:18
schancel updated the diff for D1936: Move handling for `-maxtxfee` to the config object.

Update per feedback from @deadalnix

Nov 6 2018, 00:08

Nov 5 2018

schancel committed rABC8df8f0c5fadc: Update release notes to include several missing items (authored by schancel).
Update release notes to include several missing items
Nov 5 2018, 23:18
schancel closed D1994: Update release notes to include several missing items.
Nov 5 2018, 23:17
D1994: Update release notes to include several missing items is now accepted and ready to land.
Nov 5 2018, 23:17
schancel updated the diff for D1994: Update release notes to include several missing items.

Remove duplicate

Nov 5 2018, 23:15
schancel updated the diff for D1994: Update release notes to include several missing items.

Update per feedback

Nov 5 2018, 22:45
schancel updated the diff for D1986: Rename account to label where appropriate.

Remove clang-format

Nov 5 2018, 21:30
schancel updated the diff for D1986: Rename account to label where appropriate.

Rebase

Nov 5 2018, 21:13
schancel updated the diff for D1986: Rename account to label where appropriate.

Pull in previous fixes per Fabian.

Nov 5 2018, 21:12
schancel updated the diff for D1986: Rename account to label where appropriate.

Finish removing address_type from getnewaddress.

Nov 5 2018, 20:33
schancel added a comment to D2004: Reconsider parked chains when enough works piles up.

Help on getbestblockhash is no longer valid.

Nov 5 2018, 20:31
schancel added inline comments to D2005: Add RWCollection, a read-write locked collection with a mostly safe API.
Nov 5 2018, 20:21
schancel updated the summary of D2005: Add RWCollection, a read-write locked collection with a mostly safe API.
Nov 5 2018, 20:17
schancel committed rABC0d78d3bac38d: [qa] Improve wallet-accounts test (authored by Russell Yanofsky <russ@yanofsky.org>).
[qa] Improve wallet-accounts test
Nov 5 2018, 19:55
schancel closed D2001: [qa] Improve wallet-accounts test.
Nov 5 2018, 19:55
schancel updated the diff for D1937: Change the maxtxfee to be per kb..

Fix Qt Compilation error

Nov 5 2018, 19:49
schancel updated the summary of D1937: Change the maxtxfee to be per kb..
Nov 5 2018, 19:31
schancel updated the diff for D1986: Rename account to label where appropriate.

Update per feedback

Nov 5 2018, 19:13
schancel added inline comments to D1986: Rename account to label where appropriate.
Nov 5 2018, 19:06

Nov 4 2018

schancel added inline comments to D2004: Reconsider parked chains when enough works piles up.
Nov 4 2018, 00:50

Nov 3 2018

schancel added inline comments to D2004: Reconsider parked chains when enough works piles up.
Nov 3 2018, 21:59
schancel added inline comments to D2004: Reconsider parked chains when enough works piles up.
Nov 3 2018, 08:52

Nov 2 2018

Herald added a reviewer for D2002: Disallow using addresses in createmultisig: Restricted Project.
Nov 2 2018, 22:36
schancel updated the summary of D1986: Rename account to label where appropriate.
Nov 2 2018, 22:28
schancel updated the summary of D2001: [qa] Improve wallet-accounts test.
Nov 2 2018, 22:27
schancel updated the diff for D1986: Rename account to label where appropriate.

Rebase on D2001

Nov 2 2018, 22:25
Herald added a reviewer for D2001: [qa] Improve wallet-accounts test: Restricted Project.
Nov 2 2018, 22:19
schancel accepted D2000: Remove unused github-merge script.
Nov 2 2018, 21:58
schancel committed rABCa38cb6434eae: [tests] fix cross-platform sprintf issue in blockindex_tests (authored by schancel).
[tests] fix cross-platform sprintf issue in blockindex_tests
Nov 2 2018, 20:57
schancel closed D1997: [tests] fix cross-platform sprintf issue in blockindex_tests.
Nov 2 2018, 20:56
schancel updated the summary of D1997: [tests] fix cross-platform sprintf issue in blockindex_tests.
Nov 2 2018, 20:46
Herald added a reviewer for D1997: [tests] fix cross-platform sprintf issue in blockindex_tests: Restricted Project.
Nov 2 2018, 20:44
schancel updated the diff for D1992: Rename wallet functional test files to match bitcoin core.

Fix timings.json again

Nov 2 2018, 00:42
schancel added inline comments to D1992: Rename wallet functional test files to match bitcoin core.
Nov 2 2018, 00:41
schancel updated the diff for D1994: Update release notes to include several missing items.

Fixup

Nov 2 2018, 00:40

Nov 1 2018

Herald added a reviewer for D1994: Update release notes to include several missing items: Restricted Project.
Nov 1 2018, 02:39
schancel updated the diff for D1992: Rename wallet functional test files to match bitcoin core.

...

Nov 1 2018, 02:36
schancel updated the diff for D1992: Rename wallet functional test files to match bitcoin core.

Fix timings once more

Nov 1 2018, 02:34
schancel updated the diff for D1992: Rename wallet functional test files to match bitcoin core.

Fix timings

Nov 1 2018, 02:32

Oct 31 2018

schancel updated the summary of D1992: Rename wallet functional test files to match bitcoin core.
Oct 31 2018, 23:17
Herald added a reviewer for D1992: Rename wallet functional test files to match bitcoin core: Restricted Project.
Oct 31 2018, 23:16
schancel updated the diff for D1986: Rename account to label where appropriate.

Fix feedback

Oct 31 2018, 23:04
schancel added inline comments to D1986: Rename account to label where appropriate.
Oct 31 2018, 23:03
schancel added inline comments to D1986: Rename account to label where appropriate.
Oct 31 2018, 22:56
schancel accepted D1988: Fix make-base-vm distro according to current CI configuration.
Oct 31 2018, 22:40
schancel added a comment to D1979: [qt] Multiwallet support for GUI (Core PR12610).

I can't review this. QT is currently broken on MacOS X mojave. I need to look into it more.

Oct 31 2018, 20:57
schancel committed rABCc8c4ff20a84f: scripted-diff: Use UniValue.pushKV instead of push_back(Pair()) (authored by Karel Bilek <kb@karelbilek.com>).
scripted-diff: Use UniValue.pushKV instead of push_back(Pair())
Oct 31 2018, 20:57
schancel closed D1990: scripted-diff: Use UniValue.pushKV instead of push_back(Pair()).
Oct 31 2018, 20:56
schancel committed rABC6daa39b9af87: Update univalue to latest release (1.0.4) (authored by schancel).
Update univalue to latest release (1.0.4)
Oct 31 2018, 20:56
schancel closed D1989: Update univalue to latest release (1.0.4).
Oct 31 2018, 20:56
schancel accepted D1991: Update gitian instructions to reference a newer version of boxcutter (ubuntu 16.04.4 -> 16.04.5).
Oct 31 2018, 20:54
schancel updated the test plan for D1991: Update gitian instructions to reference a newer version of boxcutter (ubuntu 16.04.4 -> 16.04.5).
Oct 31 2018, 20:53
Herald added a reviewer for D1990: scripted-diff: Use UniValue.pushKV instead of push_back(Pair()): Restricted Project.
Oct 31 2018, 19:00
Herald added a reviewer for D1989: Update univalue to latest release (1.0.4): Restricted Project.
Oct 31 2018, 18:55
schancel added inline comments to D1967: Move transaction combining from signrawtransaction to new RPC.
Oct 31 2018, 15:46
schancel updated the diff for D1986: Rename account to label where appropriate.

Adjust release notes

Oct 31 2018, 00:26
schancel updated the diff for D1986: Rename account to label where appropriate.

Rebase

Oct 31 2018, 00:03
schancel updated the diff for D1986: Rename account to label where appropriate.

Rebase

Oct 31 2018, 00:00

Oct 30 2018

schancel updated the diff for D1927: Use a modified size for transaction minimum fee calculation..

Rebase fix conflicts

Oct 30 2018, 23:20
schancel added inline comments to D1967: Move transaction combining from signrawtransaction to new RPC.
Oct 30 2018, 23:17
schancel committed rSTAGING49a6e572ef41: Add address filtering to listreceivedbyaddress (authored by Jeremy Rubin <jeremy.l.rubin@gmail.com>).
Add address filtering to listreceivedbyaddress
Oct 30 2018, 21:04
schancel committed rSTAGINGbbdea980420a: [Part 2 of 2] [wallet] getreceivedbyaddress should return error if address is… (authored by John Newbery <john@johnnewbery.com>).
[Part 2 of 2] [wallet] getreceivedbyaddress should return error if address is…
Oct 30 2018, 21:04
schancel committed rSTAGING7e5ed0e6b988: [Part 1 of 2] [qa] receivedby.py cleanup and fixes (authored by John Newbery <john@johnnewbery.com>).
[Part 1 of 2] [qa] receivedby.py cleanup and fixes
Oct 30 2018, 21:04
schancel committed rSTAGING00c72639b0c7: Fix that CWallet::AbandonTransaction would only traverse one level (authored by Ben Woosley <ben.woosley@gmail.com>).
Fix that CWallet::AbandonTransaction would only traverse one level
Oct 30 2018, 21:04
schancel committed rSTAGING0e52717a569d: Add CMerkleTx::IsImmatureCoinBase method (authored by Ben Woosley <ben.woosley@gmail.com>).
Add CMerkleTx::IsImmatureCoinBase method
Oct 30 2018, 21:04
schancel committed rSTAGING58b7c73e214d: [qt] Move BitcoinGUI initializers to class, fix initializer order warning (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
[qt] Move BitcoinGUI initializers to class, fix initializer order warning
Oct 30 2018, 21:04
schancel committed rSTAGING3a13d305d291: Introduce and track a billable size in addition to real txn size (authored by schancel).
Introduce and track a billable size in addition to real txn size
Oct 30 2018, 21:03
schancel committed rSTAGING016915fd5727: Clean up feerate.h to support constexpr and not-equal operator (authored by schancel).
Clean up feerate.h to support constexpr and not-equal operator
Oct 30 2018, 21:03
schancel committed rSTAGING2df90fe06893: [qa] make extended cutoff configurable (authored by schancel).
[qa] make extended cutoff configurable
Oct 30 2018, 21:02
schancel committed rSTAGING9106f81e7af2: [qa] fix dbcrash and calculate_fee (authored by schancel).
[qa] fix dbcrash and calculate_fee
Oct 30 2018, 21:01
schancel updated the summary of D1981: Various small changes in p2p-fullblocktest.py.
Oct 30 2018, 17:08
schancel updated the summary of D1979: [qt] Multiwallet support for GUI (Core PR12610).
Oct 30 2018, 16:43
schancel accepted D1985: Nits in rpcconsole.
Oct 30 2018, 00:41
schancel committed rABC49a6e572ef41: Add address filtering to listreceivedbyaddress (authored by Jeremy Rubin <jeremy.l.rubin@gmail.com>).
Add address filtering to listreceivedbyaddress
Oct 30 2018, 00:30
schancel closed D1980: Add address filtering to listreceivedbyaddress.
Oct 30 2018, 00:30
schancel committed rABCbbdea980420a: [Part 2 of 2] [wallet] getreceivedbyaddress should return error if address is… (authored by John Newbery <john@johnnewbery.com>).
[Part 2 of 2] [wallet] getreceivedbyaddress should return error if address is…
Oct 30 2018, 00:26
schancel closed D1984: [Part 2 of 2] [wallet] getreceivedbyaddress should return error if address is not mine.
Oct 30 2018, 00:25
schancel committed rABC7e5ed0e6b988: [Part 1 of 2] [qa] receivedby.py cleanup and fixes (authored by John Newbery <john@johnnewbery.com>).
[Part 1 of 2] [qa] receivedby.py cleanup and fixes
Oct 30 2018, 00:17
schancel closed D1983: [Part 1 of 2] [qa] receivedby.py cleanup and fixes.
Oct 30 2018, 00:17
schancel updated the summary of D1983: [Part 1 of 2] [qa] receivedby.py cleanup and fixes.
Oct 30 2018, 00:06

Oct 29 2018

Herald added a reviewer for D1986: Rename account to label where appropriate: Restricted Project.
Oct 29 2018, 23:59
schancel created T463: Switch test_framework.py not to use deprecated OptionParser.
Oct 29 2018, 23:47 · Bootcamp, Restricted Project
schancel committed rABC00c72639b0c7: Fix that CWallet::AbandonTransaction would only traverse one level (authored by Ben Woosley <ben.woosley@gmail.com>).
Fix that CWallet::AbandonTransaction would only traverse one level
Oct 29 2018, 23:45
schancel closed D1978: Fix that CWallet::AbandonTransaction would only traverse one level.
Oct 29 2018, 23:45
schancel updated the summary of D1980: Add address filtering to listreceivedbyaddress.
Oct 29 2018, 23:44
Herald added a reviewer for D1984: [Part 2 of 2] [wallet] getreceivedbyaddress should return error if address is not mine: Restricted Project.
Oct 29 2018, 23:26
Herald added a reviewer for D1983: [Part 1 of 2] [qa] receivedby.py cleanup and fixes: Restricted Project.
Oct 29 2018, 23:25
Herald added a reviewer for D1980: Add address filtering to listreceivedbyaddress: Restricted Project.
Oct 29 2018, 22:35
schancel added a comment to D1927: Use a modified size for transaction minimum fee calculation..
Oct 29 2018, 21:32