Page MenuHomePhabricator
Feed Advanced Search

Oct 8 2020

jasonbcox closed D7826: Merge #19756: tests: add sync_all to fix race condition in wallet groups test.
Oct 8 2020, 18:16
jasonbcox committed rABCb427253b0a2f: Merge #19756: tests: add sync_all to fix race condition in wallet groups test (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #19756: tests: add sync_all to fix race condition in wallet groups test
Oct 8 2020, 18:15
jasonbcox requested review of D7827: [buildbot] Fix ref master to be full ref name.
Oct 8 2020, 18:14
jasonbcox closed D7824: [buildbot] Fix getIgnoreList dangling arg.
Oct 8 2020, 17:59
jasonbcox committed rABC1fca0f0b7b2e: [buildbot] Fix getIgnoreList dangling arg (authored by jasonbcox).
[buildbot] Fix getIgnoreList dangling arg
Oct 8 2020, 17:59
jasonbcox requested review of D7826: Merge #19756: tests: add sync_all to fix race condition in wallet groups test.
Oct 8 2020, 17:58
jasonbcox requested review of D7825: Some more release notes.
Oct 8 2020, 17:49
jasonbcox updated the diff for D7824: [buildbot] Fix getIgnoreList dangling arg.

Fix copy-paste error

Oct 8 2020, 17:37
jasonbcox requested review of D7824: [buildbot] Fix getIgnoreList dangling arg.
Oct 8 2020, 17:05
jasonbcox closed D7813: [buildbot] Remove bot message about linking PRs.
Oct 8 2020, 16:16
jasonbcox committed rABC95104fc18bf9: [buildbot] Remove bot message about linking PRs (authored by jasonbcox).
[buildbot] Remove bot message about linking PRs
Oct 8 2020, 16:16
jasonbcox updated the diff for D7810: Merge #18192: Bugfix: Wallet: Safely deal with change in the address book.

Rebase on D7823

Oct 8 2020, 16:09
jasonbcox added inline comments to D7810: Merge #18192: Bugfix: Wallet: Safely deal with change in the address book.
Oct 8 2020, 16:05
jasonbcox requested review of D7823: Cleanup unused old_label variable.
Oct 8 2020, 16:05

Oct 7 2020

jasonbcox requested review of D7813: [buildbot] Remove bot message about linking PRs.
Oct 7 2020, 22:53
jasonbcox requested review of D7811: Merge #18546: Bugfix: Wallet: Safely deal with change in the address book [part 2].
Oct 7 2020, 20:44
jasonbcox requested review of D7810: Merge #18192: Bugfix: Wallet: Safely deal with change in the address book.
Oct 7 2020, 20:36
jasonbcox reassigned T1093: Backport script and key management improvements (PR17261) from jasonbcox to majcosta.
Oct 7 2020, 20:23 · Restricted Project
jasonbcox closed D7787: [buildbot] Introduce an ignore list for known flaky errors.
Oct 7 2020, 20:05
jasonbcox committed rABC9e32b347175d: [buildbot] Introduce an ignore list for known flaky errors (authored by jasonbcox).
[buildbot] Introduce an ignore list for known flaky errors
Oct 7 2020, 20:05
jasonbcox closed D7793: Fix release notes that got automated out of existence.
Oct 7 2020, 16:59
jasonbcox committed rABCca05a7160d20: Fix release notes that got automated out of existence (authored by jasonbcox).
Fix release notes that got automated out of existence
Oct 7 2020, 16:59
jasonbcox updated the diff for D7793: Fix release notes that got automated out of existence.

* -> + per feedback

Oct 7 2020, 16:20
jasonbcox updated the diff for D7793: Fix release notes that got automated out of existence.

Came up with a better solution that is more robust, fails when there is no version number found, and
does not introduce a new dependency.

Oct 7 2020, 16:05
jasonbcox updated the test plan for D7793: Fix release notes that got automated out of existence.
Oct 7 2020, 02:21
jasonbcox requested review of D7793: Fix release notes that got automated out of existence.
Oct 7 2020, 02:20
jasonbcox closed D7792: Fix passing of coin control in SendMoney().
Oct 7 2020, 01:18
jasonbcox committed rABC2fef637bd376: Fix passing of coin control in SendMoney() (authored by jasonbcox).
Fix passing of coin control in SendMoney()
Oct 7 2020, 01:18
jasonbcox accepted D7789: [backport#10842] Fix incorrect Doxygen tag (@ince → @since). Doxygen parameter name matching..
Oct 7 2020, 01:14
jasonbcox accepted D7790: [backport#11138] Compat: Simplify bswap_16 implementation.
Oct 7 2020, 01:13
jasonbcox accepted D7791: [backport#10691] Trivial: Properly comment about shutdown process in init.cpp file..
Oct 7 2020, 01:12
jasonbcox requested review of D7792: Fix passing of coin control in SendMoney().
Oct 7 2020, 00:14

Oct 6 2020

jasonbcox added a comment to T1094: Backport transaction cache fixes (PR17843).

The change is currently being drafted here: https://reviews.bitcoinabc.org/D7685 but there are test failures that need fixing before we proceed.

Oct 6 2020, 21:40 · Restricted Project
jasonbcox triaged T1094: Backport transaction cache fixes (PR17843) as High priority.
Oct 6 2020, 21:40 · Restricted Project
jasonbcox triaged T1093: Backport script and key management improvements (PR17261) as High priority.
Oct 6 2020, 21:35 · Restricted Project
jasonbcox triaged T1092: Unrevert coin selection changes as High priority.
Oct 6 2020, 21:32 · Restricted Project
jasonbcox accepted D7786: [CI] Remove the Openjdk 8 dependency.
Oct 6 2020, 20:34
jasonbcox requested changes to D7786: [CI] Remove the Openjdk 8 dependency.
Oct 6 2020, 18:04
jasonbcox closed T664: Automate version bumping, a subtask of T646: Release Automation, as Invalid.
Oct 6 2020, 18:00 · Restricted Project, Restricted Project
jasonbcox closed T664: Automate version bumping as Invalid.

The approach has changed significantly. While the spirit of this task is right, it's not really valid anymore.

Oct 6 2020, 18:00 · Restricted Project, Restricted Project
jasonbcox closed T656: Automate release page, a subtask of T646: Release Automation, as Resolved.
Oct 6 2020, 17:59 · Restricted Project, Restricted Project
jasonbcox closed T656: Automate release page as Resolved.
Oct 6 2020, 17:59 · Restricted Project, Restricted Project
jasonbcox closed T269: Create a `contrib/teamcity/build-cmake.sh`, a subtask of T248: Add cmake build to teamcity, as Resolved.
Oct 6 2020, 17:57
jasonbcox closed T269: Create a `contrib/teamcity/build-cmake.sh` as Resolved.
Oct 6 2020, 17:57 · Bootcamp
jasonbcox closed T248: Add cmake build to teamcity, a subtask of T267: CMake builds, as Resolved.
Oct 6 2020, 17:57
jasonbcox closed T248: Add cmake build to teamcity as Resolved.
Oct 6 2020, 17:57
jasonbcox closed T267: CMake builds, a subtask of T258: Quality Assurance Improvements, as Resolved.
Oct 6 2020, 17:57
jasonbcox closed T267: CMake builds as Resolved.
Oct 6 2020, 17:57
jasonbcox closed T571: Backport Core PR 10973 as Resolved.
Oct 6 2020, 17:50 · Restricted Project
jasonbcox closed T1045: Top 5 Watch Dogs as a Pets as Invalid.
Oct 6 2020, 17:48
jasonbcox closed T1044: Cat Foods as Invalid.
Oct 6 2020, 17:48
jasonbcox closed T638: Backport Core PR 11738 (fix hang in sendrawtransaction) as Resolved.
Oct 6 2020, 17:47
jasonbcox closed T639: Backport Core PR 11877 (tests) as Resolved.
Oct 6 2020, 17:47
jasonbcox closed T682: Backport Core PR 14456 as Resolved.
Oct 6 2020, 17:46
jasonbcox closed T681: Backport Core PR 14119, a subtask of T682: Backport Core PR 14456, as Resolved.
Oct 6 2020, 17:46
jasonbcox closed T681: Backport Core PR 14119 as Resolved.
Oct 6 2020, 17:46
jasonbcox closed T657: New sigops counting as Resolved.
Oct 6 2020, 17:45
jasonbcox closed T336: Phabricator to Github repo sync bot, a subtask of T647: [Epic] Development Automation Base Infra, as Resolved.
Oct 6 2020, 17:45 · Restricted Project, Restricted Project
jasonbcox closed T336: Phabricator to Github repo sync bot as Resolved.
Oct 6 2020, 17:45
jasonbcox closed T383: Generate help page from RPC doc as Resolved.
Oct 6 2020, 17:45
jasonbcox closed T482: Make p2p-compbactblocks work with magnetic anomaly. as Resolved.
Oct 6 2020, 17:41
jasonbcox closed T483: Make invalidateblock work with magnetic anomalty as Resolved.
Oct 6 2020, 17:41
jasonbcox closed T434: Backport Core PR #12909 as Resolved.
Oct 6 2020, 17:40 · Restricted Project
jasonbcox closed T438: Backport core PR 10579 as Resolved.
Oct 6 2020, 17:40 · Restricted Project
jasonbcox closed T661: Backport PR12804 [tests] Fix intermittent rpc_net.py failure. as Resolved.
Oct 6 2020, 17:38
jasonbcox closed T662: Backport PR11389 "Support having SegWit always active in regtest" as Resolved.
Oct 6 2020, 17:38
jasonbcox closed T652: Backport PR13126 as Resolved.
Oct 6 2020, 17:38
jasonbcox closed T996: LOOKING FOR EXPERT’S SEO SERVICES? as Invalid.
Oct 6 2020, 17:36
jasonbcox closed T495: Fix bip65-cltv-p2p.py for post-fork conditions as Resolved.
Oct 6 2020, 17:33
jasonbcox closed T1050: Reasons Why Dogs are the Go-to Emotional Support Animals as Invalid.
Oct 6 2020, 17:32
jasonbcox closed T1051: Emotional Support Animals related Laws You Should Know About as Invalid.
Oct 6 2020, 17:31
jasonbcox closed T1055: Burr Grinder & Blade Grinder: Differences and Which to Choose as Invalid.
Oct 6 2020, 17:29
jasonbcox closed T1069: Đâu là liệu trình trẻ hóa da tốt nhất tại thẩm mỹ viện Xuân Hương? as Invalid.
Oct 6 2020, 17:28
jasonbcox closed T992: Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC Master TSAN is broken. as Resolved.
Oct 6 2020, 17:25
jasonbcox requested review of D7787: [buildbot] Introduce an ignore list for known flaky errors.
Oct 6 2020, 17:19
jasonbcox closed D7784: Ensure the source repo in the cache is in a clean state before building.
Oct 6 2020, 16:06
jasonbcox committed rABCWEBa756d858c84d: Ensure the source repo in the cache is in a clean state before building (authored by jasonbcox).
Ensure the source repo in the cache is in a clean state before building
Oct 6 2020, 16:05
jasonbcox closed D7785: Apply cherry-pick before cmake.
Oct 6 2020, 16:05
jasonbcox committed rABCWEBb94b4268192a: Apply cherry-pick before cmake (authored by jasonbcox).
Apply cherry-pick before cmake
Oct 6 2020, 16:05
jasonbcox requested review of D7785: Apply cherry-pick before cmake.
Oct 6 2020, 15:59
jasonbcox requested review of D7784: Ensure the source repo in the cache is in a clean state before building.
Oct 6 2020, 15:14
jasonbcox closed D7774: Cleanup copy-pasted comment.
Oct 6 2020, 05:41
jasonbcox committed rABC1175f57283d5: Cleanup copy-pasted comment (authored by jasonbcox).
Cleanup copy-pasted comment
Oct 6 2020, 05:41
jasonbcox closed D7773: [CI] Set default git user and email during setup.
Oct 6 2020, 05:40
jasonbcox committed rABC63d110c7b254: [CI] Set default git user and email during setup (authored by jasonbcox).
[CI] Set default git user and email during setup
Oct 6 2020, 05:40
jasonbcox requested review of D7774: Cleanup copy-pasted comment.
Oct 6 2020, 01:15

Oct 5 2020

jasonbcox requested review of D7773: [CI] Set default git user and email during setup.
Oct 5 2020, 23:45
jasonbcox closed D7770: Do not cache HTML of pages that are expected to change.
Oct 5 2020, 21:07
jasonbcox committed rABCWEBe26427bae4e4: Do not cache HTML of pages that are expected to change (authored by jasonbcox).
Do not cache HTML of pages that are expected to change
Oct 5 2020, 21:07
jasonbcox closed D7772: Fix 0.22.3 manpages not appearing in the doc index.
Oct 5 2020, 21:05
jasonbcox committed rABCWEBce1e353fd0bf: Fix 0.22.3 manpages not appearing in the doc index (authored by jasonbcox).
Fix 0.22.3 manpages not appearing in the doc index
Oct 5 2020, 21:05
jasonbcox requested review of D7772: Fix 0.22.3 manpages not appearing in the doc index.
Oct 5 2020, 19:08
jasonbcox accepted D7771: [CMAKE] Fix version in the man2html template.
Oct 5 2020, 18:54
jasonbcox updated the summary of D7770: Do not cache HTML of pages that are expected to change.
Oct 5 2020, 17:40
jasonbcox requested review of D7770: Do not cache HTML of pages that are expected to change.
Oct 5 2020, 17:39

Oct 2 2020

jasonbcox accepted D7747: [backport#16578] Do not pass in command line arguments to QApplication.
Oct 2 2020, 18:53
jasonbcox accepted D7746: [backport#16554] test: only include and use OpenSSL where it's actually needed (BIP70).
Oct 2 2020, 18:52
jasonbcox requested changes to D7748: [backport#10899] [test] Qt: Use _putenv_s instead of setenv on Windows builds.

Unless something changed, I think the feedback from D3225 is still valid.

Oct 2 2020, 18:22
jasonbcox requested changes to D7747: [backport#16578] Do not pass in command line arguments to QApplication.

The summary describes some steps that aren't included in the test plan.

Oct 2 2020, 18:20
jasonbcox requested changes to D7746: [backport#16554] test: only include and use OpenSSL where it's actually needed (BIP70).

You need to enable/disable BIP70 in the test plan.

Oct 2 2020, 18:16