additional changes needed to be carried over for this to work

hm, didn't hit that error locally. investigating.

• correct two erroneous amounts in wallet_txn_clone to use XEC
• changed the repr method for CTxOut from using 8 to 2 decimals

corrections to wallet_txn_clone.py

thank you for the corrections.

• updated mempool_limit.py, mempool_packages.py and mempool_unbroadcast.py
• I've also ditched zeroes after the decimal where they aren't needed in the new unit.

a few new tests were added since I worked on the diff. their Amounts have been multiplied by a million as well.

fixing failure

POD'ified Currency, renamed 'unit' to 'baseunit' for clarity

addressed feedback

missing newline at end of file

do not set the parameter in an inappropriate function, create a compilation unit for currency unit related code

ValueFromAmount function still had the decimal places magical number code

you're right, this is not good

couldn't reproduce this failure. rebasing on latest master.

bummer. alright, how about D9638, then?

rebase on master

rebase

that flakiness in script_tests.cpp is unrelated, restarting build

fixed feature_notifications.py without wallet

Depends on D9635

green, just as long as you rebase on top of D9609 after it lands :)

forgot to comment. I think you need to clear the proofs container since std::move leaves it in a 'valid, but unspecified state'. I assume that means it could contain garbage or something.

sounds good

looks like we're missing something in validation.cpp

abandoned in favor of D9606

remove spurious include in amount_tests.cpp

gonna put this behind the same runtime configuration option as decimal change

nvm

fix oversight on test cases

rebase

rebase

no reason to drop this, imho

already done D9547