Feed Advanced Search

Advanced Search
Use Results
Edit Query
Hide Query

Aug 8 2022

sdulfari added inline comments to D11829: [avalanche] Remove the network bypass flag, make it default for avalanche outbounds.

Aug 8 2022, 15:34

Aug 6 2022

sdulfari requested changes to D11829: [avalanche] Remove the network bypass flag, make it default for avalanche outbounds.

Aug 6 2022, 08:25

sdulfari accepted D11827: Add a method to make addrman deterministic.

Aug 6 2022, 08:11

sdulfari accepted D11828: Add unit test for the outbound connection logic.

Aug 6 2022, 08:10

Aug 5 2022

sdulfari added inline comments to D11828: Add unit test for the outbound connection logic.

Aug 5 2022, 06:32

Aug 4 2022

sdulfari requested changes to D11827: Add a method to make addrman deterministic.

Aug 4 2022, 22:58

sdulfari requested review of D11830: [avalanche] Increase proof dust threshold.

Aug 4 2022, 22:50

sdulfari updated the diff for D11750: [avalanche] Make proof dust threshold configurable.

Rebase on new unit test

Aug 4 2022, 19:51

Aug 3 2022

sdulfari closed D11821: [avalanche] Bump stake used in proof deserialization tests.

Aug 3 2022, 15:28

sdulfari committed rABCc59a1cd712e4: [avalanche] Bump stake used in proof deserialization tests (authored by sdulfari).

[avalanche] Bump stake used in proof deserialization tests

Aug 3 2022, 15:27

sdulfari closed D11822: [avalanche] Add coins directly instead of using coinbases in processor unit tests.

Aug 3 2022, 15:26

sdulfari committed rABC90b5164c2248: [avalanche] Add coins directly instead of using coinbases in processor unit… (authored by sdulfari).

[avalanche] Add coins directly instead of using coinbases in processor unit…

Aug 3 2022, 15:26

sdulfari closed D11820: [avalanche] Use MIN_VALID_PROOF_SCORE where appropriate.

Aug 3 2022, 15:22

sdulfari committed rABC61577540686e: [avalanche] Use MIN_VALID_PROOF_SCORE where appropriate (authored by sdulfari).

[avalanche] Use MIN_VALID_PROOF_SCORE where appropriate

Aug 3 2022, 15:22

sdulfari requested review of D11822: [avalanche] Add coins directly instead of using coinbases in processor unit tests.

Aug 3 2022, 07:57

sdulfari requested review of D11821: [avalanche] Bump stake used in proof deserialization tests.

Aug 3 2022, 07:43

sdulfari requested review of D11820: [avalanche] Use MIN_VALID_PROOF_SCORE where appropriate.

Aug 3 2022, 07:35

sdulfari accepted D11819: Bump version to 0.25.11.

Aug 3 2022, 07:30

Jul 31 2022

sdulfari accepted D11815: [avalanche] Don't ban a peer sending a proof with an unknown utxo.

Jul 31 2022, 05:53

sdulfari accepted D11816: [avalanche] Don't download proofs during IBD.

Jul 31 2022, 05:52

Jul 29 2022

sdulfari updated the diff for D11750: [avalanche] Make proof dust threshold configurable.

Rebase on fixes for flaky tests

Jul 29 2022, 20:38

sdulfari closed D11814: [avalanche] Fix flaky check for finalized proofs in abc_rpc_getavalancheinfo.

Jul 29 2022, 18:44

sdulfari committed rABCc948c127e1e9: [avalanche] Fix flaky check for finalized proofs in abc_rpc_getavalancheinfo (authored by sdulfari).

[avalanche] Fix flaky check for finalized proofs in abc_rpc_getavalancheinfo

Jul 29 2022, 18:44

sdulfari accepted D11770: [avalanche] Request more peers for their avalanche nodes.

Jul 29 2022, 18:42

sdulfari requested changes to D11816: [avalanche] Don't download proofs during IBD.

Jul 29 2022, 18:41

sdulfari requested changes to D11815: [avalanche] Don't ban a peer sending a proof with an unknown utxo.

Jul 29 2022, 18:27

sdulfari accepted D11817: [avalanche] Fix flaky loops in abc_p2p_compactproofs.

Jul 29 2022, 18:11

Jul 28 2022

sdulfari requested changes to D11770: [avalanche] Request more peers for their avalanche nodes.

Jul 28 2022, 17:07

sdulfari requested review of D11814: [avalanche] Fix flaky check for finalized proofs in abc_rpc_getavalancheinfo.

Jul 28 2022, 16:58

sdulfari accepted D11809: [avalanche] Simplify the wait_for_proof test facility.

Jul 28 2022, 15:59

sdulfari accepted D11812: [linter] Sanitize the headers include guard.

Jul 28 2022, 14:41

sdulfari updated the summary of D11750: [avalanche] Make proof dust threshold configurable.

Jul 28 2022, 05:05

sdulfari updated the diff for D11750: [avalanche] Make proof dust threshold configurable.

Add dust threshold to the new ava config so the arg is no longer parsed on every proof verification.

Jul 28 2022, 05:04

sdulfari requested changes to D11812: [linter] Sanitize the headers include guard.

Jul 28 2022, 02:46

Jul 27 2022

sdulfari requested changes to D11809: [avalanche] Simplify the wait_for_proof test facility.

Jul 27 2022, 17:53

sdulfari accepted D11802: [avalanche] Return all the status in getrawavalancheproof RPC.

Jul 27 2022, 17:51

sdulfari accepted D11808: [avalanche] Fix flakiness in the stale vote functional test.

Jul 27 2022, 17:47

sdulfari closed D11800: [avalanche] Verify that polling has started on an item before verifying that it has stopped.

Jul 27 2022, 17:45

sdulfari committed rABCc3de9a21195e: [avalanche] Verify that polling has started on an item before verifying that it… (authored by sdulfari).

[avalanche] Verify that polling has started on an item before verifying that it…

Jul 27 2022, 17:45

Jul 26 2022

sdulfari updated the diff for D11800: [avalanche] Verify that polling has started on an item before verifying that it has stopped.

Reuse code per feedback

Jul 26 2022, 19:14

sdulfari abandoned D11801: [avalanche] Fix multiple flakiness issues in abc_p2p_avalanche_proof_voting.

You are right. This is the better solution: D11802

Jul 26 2022, 19:08

sdulfari requested changes to D11802: [avalanche] Return all the status in getrawavalancheproof RPC.

Jul 26 2022, 19:08

sdulfari accepted D11803: [avalanche] Account for the avalanche outbound when checking for outbound eviction.

Jul 26 2022, 15:42

sdulfari requested review of D11800: [avalanche] Verify that polling has started on an item before verifying that it has stopped.

Jul 26 2022, 14:41

Jul 25 2022

sdulfari requested review of D11801: [avalanche] Fix multiple flakiness issues in abc_p2p_avalanche_proof_voting.

Jul 25 2022, 23:59

sdulfari requested review of D11800: [avalanche] Verify that polling has started on an item before verifying that it has stopped.

Jul 25 2022, 23:54

sdulfari closed D11761: [avalanche] Add a way to pass avalanche config values around.

Jul 25 2022, 21:38

sdulfari committed rABC72c060adeae9: [avalanche] Add a way to pass avalanche config values around (authored by sdulfari).

[avalanche] Add a way to pass avalanche config values around

Jul 25 2022, 21:38

Jul 23 2022

sdulfari requested changes to D11770: [avalanche] Request more peers for their avalanche nodes.

Jul 23 2022, 06:01

sdulfari updated the diff for D11761: [avalanche] Add a way to pass avalanche config values around.

I'm not entirely convinced renaming AvalancheConfig -> Config is the best path because of the way
Config and ::Config both appear in avalanche code. But it's not all bad since it is nearly
impossible to pick the wrong one and get past compilation. I'm still posting this change here
so it will get reviewed.

Jul 23 2022, 05:56

sdulfari accepted D11766: [avalanche] Don't consider our quorum valid if we don't have enough nodes connected.

Jul 23 2022, 05:24

sdulfari accepted D11792: [avalanche] Request more node addresses upon receipt of a dangling proof.

Jul 23 2022, 05:21

Jul 22 2022

sdulfari updated the diff for D11761: [avalanche] Add a way to pass avalanche config values around.

feedback

Jul 22 2022, 05:28

sdulfari closed D11786: [avalanche] Fix a race condition in a unit test where proof registration time could be off by one.

Jul 22 2022, 05:22

sdulfari committed rABC06a488e349d0: [avalanche] Fix a race condition in a unit test where proof registration time… (authored by sdulfari).

[avalanche] Fix a race condition in a unit test where proof registration time…

Jul 22 2022, 05:22

Jul 21 2022

sdulfari accepted D11778: [refactor] clean up logic in testmempoolaccept.

Jul 21 2022, 18:06

sdulfari accepted D11782: [avalanche] Add the dangling proofs count to the getavalancheinfo RPC.

I'm not sure the dangling proof count is helpful, but reducing mental math for the dangling stake could be.

Jul 21 2022, 18:02

sdulfari accepted D11785: Remove obsolete --runbarelyexpensive parameter.

Jul 21 2022, 17:55

sdulfari updated the summary of D11786: [avalanche] Fix a race condition in a unit test where proof registration time could be off by one.

Jul 21 2022, 17:51

sdulfari requested review of D11786: [avalanche] Fix a race condition in a unit test where proof registration time could be off by one.

Jul 21 2022, 17:49

Jul 20 2022

sdulfari accepted D11775: Fix tsan suppression with Clang 14.

Jul 20 2022, 21:14

sdulfari published D11761: [avalanche] Add a way to pass avalanche config values around for review.

Jul 20 2022, 18:52

sdulfari requested changes to D11766: [avalanche] Don't consider our quorum valid if we don't have enough nodes connected.

The code changes are fine, but the comments (or lack of) confuse the intent.

Jul 20 2022, 18:36

sdulfari accepted D11776: [cmake] Double the functional test timeout when a sanitizer is enabled.

Jul 20 2022, 18:19

Jul 19 2022

sdulfari requested changes to D11770: [avalanche] Request more peers for their avalanche nodes.

Jul 19 2022, 16:26

sdulfari accepted D11769: [avalanche] Request more avalanche peers if we have dangling proofs.

Jul 19 2022, 16:22

sdulfari added inline comments to D11766: [avalanche] Don't consider our quorum valid if we don't have enough nodes connected.

Jul 19 2022, 16:18

sdulfari accepted D11768: Bump version to 0.25.10.

Jul 19 2022, 15:49

Jul 18 2022

sdulfari closed D11760: Add linter to ensure chrono::duration is always initialized.

Jul 18 2022, 16:11

sdulfari committed rABC7da1378306f6: Add linter to ensure chrono::duration is always initialized (authored by sdulfari).

Add linter to ensure chrono::duration is always initialized

Jul 18 2022, 16:10

sdulfari added a reverting change for D11759: [avalanche] Fix conflict time initializer to zero: rABC7da1378306f6: Add linter to ensure chrono::duration is always initialized.

Jul 18 2022, 16:10

Jul 16 2022

sdulfari requested review of D11760: Add linter to ensure chrono::duration is always initialized.

Jul 16 2022, 03:33

sdulfari added a reverting change for D11759: [avalanche] Fix conflict time initializer to zero: D11760: Add linter to ensure chrono::duration is always initialized.

Jul 16 2022, 03:33

Jul 15 2022

sdulfari closed D11759: [avalanche] Fix conflict time initializer to zero.

Jul 15 2022, 21:12

sdulfari committed rABC0ba75da2ed39: [avalanche] Fix conflict time initializer to zero (authored by sdulfari).

[avalanche] Fix conflict time initializer to zero

Jul 15 2022, 21:12

sdulfari requested review of D11759: [avalanche] Fix conflict time initializer to zero.

Jul 15 2022, 19:06

sdulfari closed D11729: [avalanche] Add count of finalized proofs to getavalancheinfo.

Jul 15 2022, 16:52

sdulfari committed rABCf25aa39263fb: [avalanche] Add count of finalized proofs to getavalancheinfo (authored by sdulfari).

[avalanche] Add count of finalized proofs to getavalancheinfo

Jul 15 2022, 16:52

sdulfari accepted D11756: [avalanche] Fix an log error during proof rejection.

Jul 15 2022, 16:45

sdulfari closed D11749: [avalanche] Fix typo in dust threshold validation result type.

Jul 15 2022, 05:38

sdulfari committed rABCfe417440582e: [avalanche] Fix typo in dust threshold validation result type (authored by sdulfari).

[avalanche] Fix typo in dust threshold validation result type

Jul 15 2022, 05:38

Jul 14 2022

sdulfari requested review of D11750: [avalanche] Make proof dust threshold configurable.

Jul 14 2022, 22:36

sdulfari requested review of D11749: [avalanche] Fix typo in dust threshold validation result type.

Jul 14 2022, 21:13

sdulfari closed D11746: [avalanche] Use proof dust threshold in unit tests instead of low coin amounts.

Jul 14 2022, 16:47

sdulfari committed rABC80c5993fb9d6: [avalanche] Use proof dust threshold in unit tests instead of low coin amounts (authored by sdulfari).

[avalanche] Use proof dust threshold in unit tests instead of low coin amounts

Jul 14 2022, 16:47

Jul 13 2022

sdulfari requested review of D11746: [avalanche] Use proof dust threshold in unit tests instead of low coin amounts.

Jul 13 2022, 21:44

sdulfari accepted D11745: [avalanche] Don't consider our local proof as dangling.

Jul 13 2022, 20:47

sdulfari accepted D11743: [avalanche] Ban peers that send conflicting proofs repeatidly.

Jul 13 2022, 18:59

sdulfari published D11729: [avalanche] Add count of finalized proofs to getavalancheinfo for review.

Jul 13 2022, 18:47

Jul 12 2022

sdulfari accepted D11701: [avalanche] Don't rely on the service bit for sending the avalanche message.

Jul 12 2022, 18:13

sdulfari requested changes to D11701: [avalanche] Don't rely on the service bit for sending the avalanche message.

Jul 12 2022, 16:31

sdulfari accepted D11723: [avalanche] Send a avahello message when no proof is supplied.

Jul 12 2022, 16:13

sdulfari accepted D11738: [avalanche] Don't register known dangling proofs.

Jul 12 2022, 15:55

Jul 11 2022

sdulfari closed D11734: [avalanche] Fix flaky checks after orphaning a valid proof.

Jul 11 2022, 19:07

sdulfari committed rABC7d9f34c53fd1: [avalanche] Fix flaky checks after orphaning a valid proof (authored by sdulfari).

[avalanche] Fix flaky checks after orphaning a valid proof

Jul 11 2022, 19:07

sdulfari updated the diff for D11734: [avalanche] Fix flaky checks after orphaning a valid proof.

Feedback

Jul 11 2022, 18:22

sdulfari accepted D11735: [avalanche] Fix a lock order inversion.

Jul 11 2022, 17:57

sdulfari accepted D11736: [avalanche] Hold the peer manager lock during the peer cleanup.

Jul 11 2022, 17:55

Jul 8 2022

sdulfari requested review of D11734: [avalanche] Fix flaky checks after orphaning a valid proof.

Jul 8 2022, 18:30

sdulfari closed D11669: [avalanche] Make the orphan pool only accept proofs that have valid but immature utxos.

Jul 8 2022, 16:31