Page MenuHomePhabricator
Feed Advanced Search

Mar 22 2023

sdulfari accepted D13426: Bump version to 0.27.2.
Mar 22 2023, 19:52
sdulfari requested review of D13424: [avalanche] Make peer availability score accessible via getavalanchepeerinfo.
Mar 22 2023, 17:49

Mar 21 2023

sdulfari accepted D13401: More block template creation simplifications.
Mar 21 2023, 16:05

Mar 20 2023

sdulfari accepted D13394: Bump version to 0.27.1.
Mar 20 2023, 16:39
sdulfari requested changes to D13394: Bump version to 0.27.1.

Looks like wrong release notes file was copied.

Mar 20 2023, 16:09
sdulfari accepted D13393: Fix the makeseeds.py version filter.
Mar 20 2023, 16:07

Mar 19 2023

sdulfari abandoned D13095: Introduce miner fund policy whitelist.
Mar 19 2023, 21:28

Mar 17 2023

sdulfari accepted D13381: refactor: replace RecursiveMutex cs_SubVer with Mutex (and rename).
Mar 17 2023, 20:14
sdulfari accepted D13376: Refactor: Uses c++ init convention for time variables.
Mar 17 2023, 20:11
sdulfari accepted D13375: Refactor: Changes remaining time variable type from int to chrono.
Mar 17 2023, 20:04
sdulfari accepted D13374: Change time variable type to std::chrono::seconds in src/net_processing.cpp.
Mar 17 2023, 19:39
sdulfari accepted D13380: [net processing] Default initialize m_recent_confirmed_transactions.
Mar 17 2023, 19:26
sdulfari accepted D13379: scripted-diff: Rename recentRejects.
Mar 17 2023, 19:24
sdulfari accepted D13378: [net processing] Default initialize recentRejects.
Mar 17 2023, 19:24
sdulfari accepted D13377: [net processing] Add Orphanage empty consistency check.
Mar 17 2023, 19:21

Mar 16 2023

sdulfari closed D13219: [avalanche] Limit polling of finalized items of all types.
Mar 16 2023, 17:08
sdulfari committed rABC478b00b20c20: [avalanche] Limit polling of finalized items of all types (authored by sdulfari).
[avalanche] Limit polling of finalized items of all types
Mar 16 2023, 17:08

Mar 15 2023

sdulfari retitled D13219: [avalanche] Limit polling of finalized items of all types from [avalanche] Generalize the limiting of polling already polled items for all types to [avalanche] Limit polling of finalized items of all types.
Mar 15 2023, 20:06
sdulfari updated the summary of D13219: [avalanche] Limit polling of finalized items of all types.
Mar 15 2023, 20:05
sdulfari updated the diff for D13219: [avalanche] Limit polling of finalized items of all types.

Feedback + reworking some comments

Mar 15 2023, 20:04
sdulfari closed D13073: [avalanche] Add a peer availability score that aggregates node availability scores.
Mar 15 2023, 18:27
sdulfari committed rABCe2399c334b9f: [avalanche] Add a peer availability score that aggregates node availability… (authored by sdulfari).
[avalanche] Add a peer availability score that aggregates node availability…
Mar 15 2023, 18:27
teamcity awarded D13073: [avalanche] Add a peer availability score that aggregates node availability scores a Haypence token.
Mar 15 2023, 09:48

Mar 14 2023

sdulfari published D13073: [avalanche] Add a peer availability score that aggregates node availability scores for review.
Mar 14 2023, 23:59
sdulfari accepted D13336: [Chronik] Disallow combining -prune and -chronik.
Mar 14 2023, 23:21
sdulfari accepted D13332: net: remove unnecessary check of CNode::cs_vSend.
Mar 14 2023, 16:29
sdulfari requested changes to D13336: [Chronik] Disallow combining -prune and -chronik.
Mar 14 2023, 16:26
sdulfari accepted D13331: Replace spaces with tabs in test/CMakeLists.txt.
Mar 14 2023, 16:22
sdulfari accepted D13335: p2p: pass strings to NetPermissions::TryParse functions by const ref.
Mar 14 2023, 16:19
sdulfari updated the summary of D13219: [avalanche] Limit polling of finalized items of all types.
Mar 14 2023, 16:17
sdulfari added a comment to D13219: [avalanche] Limit polling of finalized items of all types.

Why not use the registerVotes and addToReconcile API like the other tests, rather than massaging the internals ?

Mar 14 2023, 16:14
sdulfari updated the diff for D13219: [avalanche] Limit polling of finalized items of all types.
  • Address feedback
  • Restrict filtering to finalized items of any type and invalidated blocks only. See comments for rationale.
Mar 14 2023, 16:12

Mar 9 2023

sdulfari updated the summary of D13219: [avalanche] Limit polling of finalized items of all types.
Mar 9 2023, 07:02
sdulfari published D13219: [avalanche] Limit polling of finalized items of all types for review.
Mar 9 2023, 00:57

Mar 3 2023

sdulfari closed D13118: [consensus + avalanche] Move miner fund from consensus to policy.
Mar 3 2023, 08:21
sdulfari committed rABC9a0a03e35160: [consensus + avalanche] Move miner fund from consensus to policy (authored by sdulfari).
[consensus + avalanche] Move miner fund from consensus to policy
Mar 3 2023, 08:21

Mar 2 2023

sdulfari accepted D13207: [avalanche] Do not poll avalanche invalidated blocks more than once.
Mar 2 2023, 22:07
sdulfari updated the diff for D13118: [consensus + avalanche] Move miner fund from consensus to policy.

fixup f-string

Mar 2 2023, 00:03

Mar 1 2023

sdulfari added a comment to D13207: [avalanche] Do not poll avalanche invalidated blocks more than once.

D13219 is a draft to give an idea what the followup can look like to generalize this. Still needs updates to tests and renaming pending acceptance of this diff.

Mar 1 2023, 23:59
sdulfari updated the diff for D13207: [avalanche] Do not poll avalanche invalidated blocks more than once.

Use a bloom filter instead

Mar 1 2023, 23:56
sdulfari accepted D13214: Improve the performance of removeForBlock.
Mar 1 2023, 23:50
sdulfari updated the summary of D13118: [consensus + avalanche] Move miner fund from consensus to policy.
Mar 1 2023, 00:51
sdulfari updated the diff for D13118: [consensus + avalanche] Move miner fund from consensus to policy.
  • Rebase and fixup release notes
  • Add miner fund rejection test case
Mar 1 2023, 00:51
sdulfari requested review of D13207: [avalanche] Do not poll avalanche invalidated blocks more than once.
Mar 1 2023, 00:21

Feb 28 2023

sdulfari accepted D13182: util: Handle HTTP_SERVICE_UNAVAILABLE in bitcoin-cli.
Feb 28 2023, 16:47

Feb 27 2023

sdulfari accepted D13171: Disable the chained-tx limit after wellington.
Feb 27 2023, 21:41
sdulfari requested changes to D13171: Disable the chained-tx limit after wellington.

Does not matter now that this patch has been reviewed a couple times but lots of little things could have been their own diffs like making some things const, moving nNoLimit, etc.

Feb 27 2023, 20:43
sdulfari closed D13172: Fix wait_for_debug_log acting as a noop.
Feb 27 2023, 20:34
sdulfari committed rABC3dce76cef88a: Fix wait_for_debug_log acting as a noop (authored by sdulfari).
Fix wait_for_debug_log acting as a noop
Feb 27 2023, 20:34
sdulfari accepted D13170: Latch the wellington activation in the mempool.
Feb 27 2023, 19:59
sdulfari requested changes to D13182: util: Handle HTTP_SERVICE_UNAVAILABLE in bitcoin-cli.
Feb 27 2023, 18:41
sdulfari updated the summary of D13172: Fix wait_for_debug_log acting as a noop.
Feb 27 2023, 18:34
sdulfari updated the diff for D13172: Fix wait_for_debug_log acting as a noop.

Fix the callsite instead of modifying the implementation

Feb 27 2023, 18:31
sdulfari accepted D13159: [Consensus] Allow only tx versions 1 and 2 by consensus.
Feb 27 2023, 16:30

Feb 24 2023

sdulfari requested review of D13172: Fix wait_for_debug_log acting as a noop.
Feb 24 2023, 23:00
sdulfari updated the diff for D13118: [consensus + avalanche] Move miner fund from consensus to policy.

More test cleanup

Feb 24 2023, 19:01
sdulfari updated the diff for D13118: [consensus + avalanche] Move miner fund from consensus to policy.

Rebase and add null check

Feb 24 2023, 18:00
sdulfari accepted D13168: Remove unused block height in mempool removeForBlock.
Feb 24 2023, 18:00

Feb 23 2023

sdulfari updated the diff for D13118: [consensus + avalanche] Move miner fund from consensus to policy.

add release note

Feb 23 2023, 19:08
sdulfari updated the diff for D13118: [consensus + avalanche] Move miner fund from consensus to policy.
  • Remove unnecessary fParked
  • Add new functional test to ensure miner fund address and amount can be changed by policy
Feb 23 2023, 19:01
sdulfari added inline comments to D13118: [consensus + avalanche] Move miner fund from consensus to policy.
Feb 23 2023, 19:00
sdulfari closed D13161: [avalanche] Disable test framework default proof expiry.
Feb 23 2023, 18:28
sdulfari committed rABC683173751045: [avalanche] Disable test framework default proof expiry (authored by sdulfari).
[avalanche] Disable test framework default proof expiry
Feb 23 2023, 18:28
sdulfari closed D13160: [avalanche] Log when a proof becomes invalid.
Feb 23 2023, 16:57
sdulfari committed rABCb472229476e8: [avalanche] Log when a proof becomes invalid (authored by sdulfari).
[avalanche] Log when a proof becomes invalid
Feb 23 2023, 16:57
sdulfari requested changes to D13159: [Consensus] Allow only tx versions 1 and 2 by consensus.
Feb 23 2023, 16:57
sdulfari updated the diff for D13161: [avalanche] Disable test framework default proof expiry.

feedback

Feb 23 2023, 16:41
sdulfari updated the test plan for D13160: [avalanche] Log when a proof becomes invalid.
Feb 23 2023, 16:36
sdulfari updated the diff for D13160: [avalanche] Log when a proof becomes invalid.

feedback

Feb 23 2023, 16:35
sdulfari requested review of D13161: [avalanche] Disable test framework default proof expiry.
Feb 23 2023, 01:02
sdulfari requested review of D13160: [avalanche] Log when a proof becomes invalid.
Feb 23 2023, 00:22

Feb 22 2023

sdulfari closed D13150: [avalanche] Add regression testing for flip flopping votes on blocks.
Feb 22 2023, 16:27
sdulfari committed rABCd883fe1178d4: [avalanche] Add regression testing for flip flopping votes on blocks (authored by sdulfari).
[avalanche] Add regression testing for flip flopping votes on blocks
Feb 22 2023, 16:27
sdulfari closed D13149: [avalanche] Reduce scope of block tips being checked in avalanche voting test.
Feb 22 2023, 16:26
sdulfari committed rABC5fd1489177ac: [avalanche] Reduce scope of block tips being checked in avalanche voting test (authored by sdulfari).
[avalanche] Reduce scope of block tips being checked in avalanche voting test
Feb 22 2023, 16:26

Feb 21 2023

sdulfari published D13118: [consensus + avalanche] Move miner fund from consensus to policy for review.
Feb 21 2023, 21:56
sdulfari updated the diff for D13150: [avalanche] Add regression testing for flip flopping votes on blocks.

Rebase & fixup according to feedback

Feb 21 2023, 21:41
sdulfari updated the diff for D13149: [avalanche] Reduce scope of block tips being checked in avalanche voting test.

feedback

Feb 21 2023, 21:38
sdulfari requested review of D13150: [avalanche] Add regression testing for flip flopping votes on blocks.
Feb 21 2023, 20:14
sdulfari updated the diff for D13149: [avalanche] Reduce scope of block tips being checked in avalanche voting test.

Cleanup unnecessary check against getbestblockhash

Feb 21 2023, 20:08
sdulfari requested review of D13149: [avalanche] Reduce scope of block tips being checked in avalanche voting test.
Feb 21 2023, 19:55
sdulfari closed D13129: Introduce facility to evaluate miner fund as a block parking policy.
Feb 21 2023, 16:30
sdulfari committed rABCa6a32a4fce4e: Introduce facility to evaluate miner fund as a block parking policy (authored by sdulfari).
Introduce facility to evaluate miner fund as a block parking policy
Feb 21 2023, 16:30

Feb 20 2023

sdulfari updated the diff for D13129: Introduce facility to evaluate miner fund as a block parking policy.

Incorporate nits except moving checkEarlyBlocks. This would work as the test is now but it is not clear to me that this actually adds value.

Feb 20 2023, 21:54
sdulfari accepted D13133: mempool: Add topological index, enforce consistency, updated reorg logic.
Feb 20 2023, 21:43

Feb 17 2023

sdulfari accepted D13141: mempool: Save & restore mempool entry acceptance height on reorg.
Feb 17 2023, 20:24
sdulfari updated the diff for D13129: Introduce facility to evaluate miner fund as a block parking policy.
  • Fix leftover assumptions from previous iteration. Genesis block is now robustly supported.
  • Rename pindex -> blockIndex
  • Improve test coverage for early blocks including genesis
  • Refactor tests to make better use of lambdas and fix other minor issues throughout.
Feb 17 2023, 20:16

Feb 16 2023

sdulfari updated the summary of D13129: Introduce facility to evaluate miner fund as a block parking policy.
Feb 16 2023, 22:33
sdulfari updated the diff for D13129: Introduce facility to evaluate miner fund as a block parking policy.

Improve file names. Remove now unneeded GetParkingPoliciesForBlock and other cleanup.

Feb 16 2023, 22:29
sdulfari updated the diff for D13129: Introduce facility to evaluate miner fund as a block parking policy.

Address all feedback. Add more test cases and cleanup test code.

Feb 16 2023, 18:53
sdulfari added inline comments to D13129: Introduce facility to evaluate miner fund as a block parking policy.
Feb 16 2023, 18:52

Feb 15 2023

sdulfari requested changes to D13133: mempool: Add topological index, enforce consistency, updated reorg logic.

first pass

Feb 15 2023, 19:32
sdulfari accepted D13121: mempool: Evict transactions by modified feerate.
Feb 15 2023, 17:08
sdulfari closed D13128: Improve miner fund whitelist test coverage.
Feb 15 2023, 17:05
sdulfari committed rABCee19a7f889ef: Improve miner fund whitelist test coverage (authored by sdulfari).
Improve miner fund whitelist test coverage
Feb 15 2023, 17:05

Feb 14 2023

sdulfari requested review of D13129: Introduce facility to evaluate miner fund as a block parking policy.
Feb 14 2023, 22:50
sdulfari accepted D13100: [tests] show the proofid when representing a proof.
Feb 14 2023, 22:17
sdulfari accepted D13126: scripted-diff: rename CChainState -> Chainstate.
Feb 14 2023, 22:16
sdulfari accepted D13127: Pass lifetimebound reference to SingleThreadedSchedulerClient.
Feb 14 2023, 22:06
sdulfari accepted D13123: mempool: Removed the ancestor_score index.
Feb 14 2023, 21:53