only remove 'relay_fee', keep 'banner'
Feed Advanced Search
Jul 2 2024
Jul 2 2024
PiRK updated the diff for D16406: [electrum] support trezor==0.13.9.
move the imports to compat.py
PiRK updated the diff for D16406: [electrum] support trezor==0.13.9.
revert an unwanted change. I initially tried to not define RECOVERY_TYPE_MATRIX in trezor.py, because it is not used in this module, but after testing the application interactively it turned out to be imported and used elsewhere.
PiRK requested review of D16406: [electrum] support trezor==0.13.9.
PiRK committed rABC928d1f039a5c: [electrum] fix handling of unsupported p2sh scripts in the TransactionDialog (authored by PiRK).
[electrum] fix handling of unsupported p2sh scripts in the TransactionDialog
Jul 1 2024
Jul 1 2024
PiRK requested review of D16393: [electrum] remove server.relay_fee API call.
PiRK added a comment to D16391: [electrum] fix handling of unsupported p2sh scripts in the TransactionDialog.
PiRK added a comment to D16391: [electrum] fix handling of unsupported p2sh scripts in the TransactionDialog.
PiRK updated the summary of D16391: [electrum] fix handling of unsupported p2sh scripts in the TransactionDialog.
PiRK requested review of D16391: [electrum] fix handling of unsupported p2sh scripts in the TransactionDialog.
Jun 29 2024
Jun 29 2024
PiRK requested changes to D16390: add RPC (-regtest only) for testing package policy.
mostly LGTM, just one debugging print to be removed
PiRK added a comment to D16388: [Chronik] Add `ParseChronikParams` and use it in chronik::Start.
This looks like a good first step to remove most gArgs access (eventually we want the ArgsManager to not be a global).
PiRK requested changes to D16388: [Chronik] Add `ParseChronikParams` and use it in chronik::Start.
Jun 26 2024
Jun 26 2024
Jun 25 2024
Jun 25 2024
Jun 24 2024
Jun 24 2024
Jun 21 2024
Jun 21 2024
[electrum] Bump version and add release notes
PiRK requested review of D16363: [electrum] Bump version and add release notes.
PiRK committed rABCad005c298d17: [electrum] fix support for Ledger app versions >= 2.4.0 (authored by PiRK).
[electrum] fix support for Ledger app versions >= 2.4.0
PiRK committed rABC2e3c49b5123a: [electrum] handle 0x5515 status when a Ledger device is locked in screensaver… (authored by PiRK).
[electrum] handle 0x5515 status when a Ledger device is locked in screensaver…
PiRK committed rABC5a4cbddd8c97: [electrum] print a less alarming error when the wrong app is open on a Ledger… (authored by PiRK).
[electrum] print a less alarming error when the wrong app is open on a Ledger…
PiRK requested review of D16362: [electrum] fix support for Ledger app versions >= 2.4.0.
PiRK updated the diff for D16359: [electrum] print a less alarming error when the wrong app is open on a Ledger device.
remove debugging related line
PiRK updated the diff for D16359: [electrum] print a less alarming error when the wrong app is open on a Ledger device.
handle the 0x6d00 status separately, show a full exception traceback in the dialog.
Jun 20 2024
Jun 20 2024
PiRK retitled D16360: [electrum] handle 0x5515 status when a Ledger device is locked in screensaver mode from [electrum] handle 0x5515 status when device is locked in screensaver mode to [electrum] handle 0x5515 status when a Ledger device is locked in screensaver mode.
PiRK committed rABC7abe30a0a8b1: [electrum] minor cleanup in Transaction.verify_signature (authored by PiRK).
[electrum] minor cleanup in Transaction.verify_signature
PiRK updated the diff for D16302: [electrum] minor cleanup in Transaction.verify_signature.
rebase
[electrum] fix imports in digitalbitbox
PiRK committed rABC2065f00accec: [electrum] move pubkey_from_signature -> ECPubkey.from_signature65 (authored by PiRK).
[electrum] move pubkey_from_signature -> ECPubkey.from_signature65
PiRK committed rABCd46492c45532: [electrum] remove broken PaymentRequestBitPay20 (authored by PiRK).
[electrum] remove broken PaymentRequestBitPay20
PiRK committed rABC2f9c5287d613: [electrum] move ECKey.verify_message to ECPubkey.verify_message_for_address (authored by PiRK).
[electrum] move ECKey.verify_message to ECPubkey.verify_message_for_address
[electrum] use ECPubkey in verify_message
PiRK committed rABC74b0434cd708: [electrum] cleanup point_to_ser and stop leaking ecdsa implementation details… (authored by PiRK).
[electrum] cleanup point_to_ser and stop leaking ecdsa implementation details…
[electrum] introduce a new ECPubkey class
[electrum] cleanup ser_to_point
[electrum] cleanup ECC_YfromX
PiRK updated the diff for D16355: [electrum] move pubkey_from_signature -> ECPubkey.from_signature65.
rebase
PiRK updated the diff for D16354: [electrum] remove broken PaymentRequestBitPay20.
rebase
PiRK updated the diff for D16352: [electrum] move ECKey.verify_message to ECPubkey.verify_message_for_address.
rebase
PiRK updated the diff for D16351: [electrum] use ECPubkey in verify_message.
rebase
PiRK updated the diff for D16350: [electrum] cleanup point_to_ser and stop leaking ecdsa implementation details for ECPubkey.
rebase
PiRK updated the diff for D16349: [electrum] introduce a new ECPubkey class.
fix f-string, rebase
PiRK added inline comments to D16351: [electrum] use ECPubkey in verify_message.
PiRK updated the diff for D16348: [electrum] cleanup ser_to_point.
rename ser_to_point -> ser_to_coordinates and ser_to_ecdsa_python_point -> ser_to_point
Use a NamedTuple for the output of ser_to_point (better type-safety than a generic 2-tuple)
Jun 19 2024
Jun 19 2024
PiRK added inline comments to D16348: [electrum] cleanup ser_to_point.
PiRK updated the test plan for D16348: [electrum] cleanup ser_to_point.
PiRK requested review of D16356: [electrum] fix imports in digitalbitbox.
PiRK requested review of D16355: [electrum] move pubkey_from_signature -> ECPubkey.from_signature65.
PiRK requested review of D16354: [electrum] remove broken PaymentRequestBitPay20.
PiRK added inline comments to D16352: [electrum] move ECKey.verify_message to ECPubkey.verify_message_for_address.
PiRK updated the summary of D16351: [electrum] use ECPubkey in verify_message.
PiRK requested review of D16352: [electrum] move ECKey.verify_message to ECPubkey.verify_message_for_address.
PiRK added inline comments to D16351: [electrum] use ECPubkey in verify_message.
PiRK requested review of D16351: [electrum] use ECPubkey in verify_message.
PiRK added a comment to D16349: [electrum] introduce a new ECPubkey class.
Also future backports of electrum will depend on these changes (PSBT for instance)
PiRK requested review of D16349: [electrum] introduce a new ECPubkey class.
PiRK requested review of D16348: [electrum] cleanup ser_to_point.
PiRK requested review of D16347: [electrum] cleanup ECC_YfromX.
Jun 18 2024
Jun 18 2024
PiRK added inline comments to D16345: Add test coverage for oversized block messages.
The code looks goods. For future maintenance and ease of review, some additional comments would help.
Jun 17 2024
Jun 17 2024
[electrum] start implementing the PSBT format
PiRK committed rABCe1f67687b71c: [electrum] make read_compact_size return None at EOF instead of raising an error (authored by PiRK).
[electrum] make read_compact_size return None at EOF instead of raising an error
PiRK updated the diff for D16333: [electrum] start implementing the PSBT format.
fix a comment in the tests