Page MenuHomePhabricator
Feed Advanced Search

Sep 7 2024

PiRK closed D16731: [electrum] push release notification for 5.3.0.
Sep 7 2024, 09:58
PiRK committed rABC875ff7c0a7fe: [electrum] push release notification for 5.3.0 (authored by PiRK).
[electrum] push release notification for 5.3.0
Sep 7 2024, 09:58

Sep 6 2024

PiRK accepted D16729: Reject blocks that violate the real time target policy.
Sep 6 2024, 15:39
PiRK accepted D16728: Compute the real-time hash target for the next block.
Sep 6 2024, 15:13
PiRK requested review of D16731: [electrum] push release notification for 5.3.0.
Sep 6 2024, 15:03
PiRK closed D16727: [electrum] remove misleading LIBSECP_COMMIT var.
Sep 6 2024, 08:19
PiRK closed D16726: [electrum] bump pyinstaller to v6.10.0.
Sep 6 2024, 08:19
PiRK committed rABC241cae514ecc: [electrum] remove misleading LIBSECP_COMMIT var (authored by PiRK).
[electrum] remove misleading LIBSECP_COMMIT var
Sep 6 2024, 08:19
PiRK committed rABCc8ea5bde090d: [electrum] bump pyinstaller to v6.10.0 (authored by PiRK).
[electrum] bump pyinstaller to v6.10.0
Sep 6 2024, 08:19
PiRK closed D16725: [electrum] pinpoint packaging lib and specify hashes for MacOS build.
Sep 6 2024, 08:19
PiRK committed rABC91433c549c89: [electrum] pinpoint packaging lib and specify hashes for MacOS build (authored by PiRK).
[electrum] pinpoint packaging lib and specify hashes for MacOS build
Sep 6 2024, 08:19
PiRK requested review of D16727: [electrum] remove misleading LIBSECP_COMMIT var.
Sep 6 2024, 07:50
PiRK requested review of D16726: [electrum] bump pyinstaller to v6.10.0.
Sep 6 2024, 07:47
PiRK requested review of D16725: [electrum] pinpoint packaging lib and specify hashes for MacOS build.
Sep 6 2024, 07:02

Sep 5 2024

PiRK closed D16721: [electrum] bump version to 5.3.0, add release notes.
Sep 5 2024, 18:14
PiRK closed D16719: [electrum] misc fixes for OSX build.
Sep 5 2024, 18:14
PiRK committed rABC98e4dec4c3b6: [electrum] misc fixes for OSX build (authored by PiRK).
[electrum] misc fixes for OSX build
Sep 5 2024, 18:14
PiRK committed rABC3e825e7454b2: [electrum] bump version to 5.3.0, add release notes (authored by PiRK).
[electrum] bump version to 5.3.0, add release notes
Sep 5 2024, 18:14
PiRK closed D16718: [electrum] consistently download the locale files from github.
Sep 5 2024, 18:14
PiRK committed rABC03313bee132b: [electrum] consistently download the locale files from github (authored by PiRK).
[electrum] consistently download the locale files from github
Sep 5 2024, 18:14
PiRK updated the diff for D16721: [electrum] bump version to 5.3.0, add release notes.

5.3.05.3.05.3.05.3.05.3.0

Sep 5 2024, 18:03
PiRK updated the diff for D16721: [electrum] bump version to 5.3.0, add release notes.

cacke -> cache

Sep 5 2024, 14:24
PiRK requested review of D16721: [electrum] bump version to 5.3.0, add release notes.
Sep 5 2024, 14:22
PiRK closed D16715: [electrum] consistently use the seclib alias in schnorr.py.
Sep 5 2024, 13:22
PiRK committed rABCecf072cabad2: [electrum] consistently use the seclib alias in schnorr.py (authored by PiRK).
[electrum] consistently use the seclib alias in schnorr.py
Sep 5 2024, 13:22
PiRK requested review of D16719: [electrum] misc fixes for OSX build.
Sep 5 2024, 13:12
PiRK requested review of D16718: [electrum] consistently download the locale files from github.
Sep 5 2024, 13:10
PiRK requested review of D16715: [electrum] consistently use the seclib alias in schnorr.py.
Sep 5 2024, 06:18
PiRK closed D16705: [electrum] use libsecp256k1 for pubkey recovery (from sig and msg).
Sep 5 2024, 06:09
PiRK closed D16707: [electrum] remove ecdsa as a direct dependency.
Sep 5 2024, 06:09
PiRK committed rABCbc020f8f7b51: [electrum] use libsecp256k1 for pubkey recovery (from sig and msg) (authored by PiRK).
[electrum] use libsecp256k1 for pubkey recovery (from sig and msg)
Sep 5 2024, 06:09
PiRK committed rABC752fbaadbcf4: [electrum] remove ecdsa as a direct dependency (authored by PiRK).
[electrum] remove ecdsa as a direct dependency
Sep 5 2024, 06:09
PiRK committed rABC6e34ee149f1c: [electrum] use libsecp256k1 for signature conversions (authored by PiRK).
[electrum] use libsecp256k1 for signature conversions
Sep 5 2024, 06:09
PiRK closed D16690: [electrum] use libsecp256k1 for signature conversions.
Sep 5 2024, 06:09
PiRK closed D16689: [electrum] ecc: use libsecp256k1 for sign/verify/mul/add.
Sep 5 2024, 06:09
PiRK committed rABC813785828d83: [electrum] ecc: use libsecp256k1 for sign/verify/mul/add (authored by PiRK).
[electrum] ecc: use libsecp256k1 for sign/verify/mul/add
Sep 5 2024, 06:09

Sep 4 2024

PiRK updated the diff for D16707: [electrum] remove ecdsa as a direct dependency.

rebase

Sep 4 2024, 13:52
PiRK updated the diff for D16689: [electrum] ecc: use libsecp256k1 for sign/verify/mul/add.

improve error message some more

Sep 4 2024, 13:52
PiRK updated the diff for D16707: [electrum] remove ecdsa as a direct dependency.

improve error message some more

Sep 4 2024, 13:49
PiRK added inline comments to D16689: [electrum] ecc: use libsecp256k1 for sign/verify/mul/add.
Sep 4 2024, 13:44
PiRK updated the diff for D16689: [electrum] ecc: use libsecp256k1 for sign/verify/mul/add.

better error message if the lib is not available at all

Sep 4 2024, 13:42
PiRK added inline comments to D16689: [electrum] ecc: use libsecp256k1 for sign/verify/mul/add.
Sep 4 2024, 10:06
PiRK abandoned D16706: [electrum] hard fail if libsecp256k1 is not found/usable.
Sep 4 2024, 10:05
PiRK updated the diff for D16707: [electrum] remove ecdsa as a direct dependency.

rebase after squashing D16706 with previous diffs

Sep 4 2024, 10:04
PiRK updated the diff for D16705: [electrum] use libsecp256k1 for pubkey recovery (from sig and msg).

rebase

Sep 4 2024, 10:03
PiRK updated the diff for D16690: [electrum] use libsecp256k1 for signature conversions.

dedup

Sep 4 2024, 10:01
PiRK updated the diff for D16689: [electrum] ecc: use libsecp256k1 for sign/verify/mul/add.

move secp256k1_schnorr_* declarations to secp256k1 where it belongs, raise a meaningful error if the lib is missing the schnorr module, remove some extra try: except: wrapping in secp256k1.py so that the inner errors are raised with more precise error messages

Sep 4 2024, 09:50
PiRK added inline comments to D16689: [electrum] ecc: use libsecp256k1 for sign/verify/mul/add.
Sep 4 2024, 09:02
PiRK closed D16687: [CI] build libsecp256k1 for electrum tests.
Sep 4 2024, 08:52
PiRK committed rABC7f062bb764b6: [CI] build libsecp256k1 for electrum tests (authored by PiRK).
[CI] build libsecp256k1 for electrum tests
Sep 4 2024, 08:52

Sep 3 2024

PiRK added inline comments to D16689: [electrum] ecc: use libsecp256k1 for sign/verify/mul/add.
Sep 3 2024, 10:50
teamcity awarded D16707: [electrum] remove ecdsa as a direct dependency a Haypence token.
Sep 3 2024, 10:48
PiRK added a comment to D16707: [electrum] remove ecdsa as a direct dependency.

@bot electrum-functional-tests

Sep 3 2024, 10:48
PiRK published D16707: [electrum] remove ecdsa as a direct dependency for review.
Sep 3 2024, 10:48
PiRK published D16706: [electrum] hard fail if libsecp256k1 is not found/usable for review.
Sep 3 2024, 10:47
PiRK published D16705: [electrum] use libsecp256k1 for pubkey recovery (from sig and msg) for review.
Sep 3 2024, 10:45
PiRK published D16687: [CI] build libsecp256k1 for electrum tests for review.
Sep 3 2024, 10:45
PiRK updated the diff for D16690: [electrum] use libsecp256k1 for signature conversions.

resbase

Sep 3 2024, 10:32
PiRK updated the summary of D16689: [electrum] ecc: use libsecp256k1 for sign/verify/mul/add.
Sep 3 2024, 10:31
PiRK updated the diff for D16689: [electrum] ecc: use libsecp256k1 for sign/verify/mul/add.

rebase

Sep 3 2024, 10:30
teamcity awarded D16687: [CI] build libsecp256k1 for electrum tests a Like token.
Sep 3 2024, 08:40
teamcity awarded D16687: [CI] build libsecp256k1 for electrum tests a Love token.
Sep 3 2024, 08:38
PiRK accepted D16704: Bump version to 0.29.12.
Sep 3 2024, 08:04
PiRK closed D16685: [electrum] grind ecdsa low R signature when using libsecp256k1.
Sep 3 2024, 06:19
PiRK closed D16686: [electrum] deduplicate the ECPrivkey.sign code.
Sep 3 2024, 06:19
PiRK closed D16684: [electrum] also use libsecp256k1 for point addition.
Sep 3 2024, 06:19
PiRK committed rABC63d3ef0463e2: [electrum] deduplicate the ECPrivkey.sign code (authored by PiRK).
[electrum] deduplicate the ECPrivkey.sign code
Sep 3 2024, 06:19
PiRK committed rABC6154c4b510d8: [electrum] also use libsecp256k1 for point addition (authored by PiRK).
[electrum] also use libsecp256k1 for point addition
Sep 3 2024, 06:19
PiRK committed rABCb0d72c50a89b: [electrum] grind ecdsa low R signature when using libsecp256k1 (authored by PiRK).
[electrum] grind ecdsa low R signature when using libsecp256k1
Sep 3 2024, 06:19
PiRK closed D16682: [electrum] use GENERATOR and CURVE_ORDER from ecc module.
Sep 3 2024, 06:19
PiRK closed D16681: [electrum] properly handle point at infinity and point not on curve.
Sep 3 2024, 06:19
PiRK committed rABCcec785ad7fc4: [electrum] use GENERATOR and CURVE_ORDER from ecc module (authored by PiRK).
[electrum] use GENERATOR and CURVE_ORDER from ecc module
Sep 3 2024, 06:19
PiRK committed rABCc60c8fbc7d46: [electrum] properly handle point at infinity and point not on curve (authored by PiRK).
[electrum] properly handle point at infinity and point not on curve
Sep 3 2024, 06:19
PiRK closed D16676: [electrum] refactor private key class to better abstract ecdsa library usage.
Sep 3 2024, 06:19
PiRK committed rABC26c62cc78b2c: [electrum] refactor private key class to better abstract ecdsa library usage (authored by PiRK).
[electrum] refactor private key class to better abstract ecdsa library usage
Sep 3 2024, 06:19

Sep 2 2024

PiRK closed D16702: [electrum] regenerate protobuf files.
Sep 2 2024, 18:18
PiRK committed rABC28620bdc2b3c: [electrum] regenerate protobuf files (authored by PiRK).
[electrum] regenerate protobuf files
Sep 2 2024, 18:18
PiRK requested review of D16702: [electrum] regenerate protobuf files.
Sep 2 2024, 14:33
PiRK accepted D16700: [cmake] Add an option to build the secp256k1 library as shared.
Sep 2 2024, 08:41

Aug 30 2024

PiRK accepted D16694: refactor: Enable proof reward rank to be used elsewhere.
Aug 30 2024, 13:23
PiRK accepted D16692: [Cashtab] Update dependencies.
Aug 30 2024, 07:47
PiRK updated the diff for D16686: [electrum] deduplicate the ECPrivkey.sign code.

rebase

Aug 30 2024, 07:41
PiRK updated the diff for D16685: [electrum] grind ecdsa low R signature when using libsecp256k1.

rebase

Aug 30 2024, 07:40
PiRK updated the diff for D16684: [electrum] also use libsecp256k1 for point addition.

rebase

Aug 30 2024, 07:38
PiRK updated the diff for D16682: [electrum] use GENERATOR and CURVE_ORDER from ecc module.

rebase

Aug 30 2024, 07:37
PiRK updated the diff for D16681: [electrum] properly handle point at infinity and point not on curve.

rebase

Aug 30 2024, 07:36
PiRK updated the diff for D16676: [electrum] refactor private key class to better abstract ecdsa library usage.

replace a few 32's with PRIVATE_KEY_BYTECOUNT, clarify legacy use for arbitrary size secret

Aug 30 2024, 07:35
PiRK added inline comments to D16676: [electrum] refactor private key class to better abstract ecdsa library usage.
Aug 30 2024, 07:24
PiRK added a comment to D16681: [electrum] properly handle point at infinity and point not on curve.

still not able to arc patch this one, which could mean we see issues when it is landed. may want to wait until this is next off the rank.

did points at infinity or not on curve not being properly handled impact app performance? why was this not handled before this diff?

Aug 30 2024, 07:02

Aug 29 2024

PiRK added a comment to D16676: [electrum] refactor private key class to better abstract ecdsa library usage.

I can't get the test plan to pass but I'm also not sure it's really an issue.

Aug 29 2024, 15:00
PiRK updated the diff for D16682: [electrum] use GENERATOR and CURVE_ORDER from ecc module.

rebase

Aug 29 2024, 09:40
PiRK updated the summary of D16684: [electrum] also use libsecp256k1 for point addition.
Aug 29 2024, 09:39
PiRK updated the diff for D16681: [electrum] properly handle point at infinity and point not on curve.

rebase

Aug 29 2024, 09:37
PiRK updated the diff for D16676: [electrum] refactor private key class to better abstract ecdsa library usage.

rebase

Aug 29 2024, 09:36
teamcity awarded D16687: [CI] build libsecp256k1 for electrum tests a Like token.
Aug 29 2024, 09:23
teamcity awarded D16687: [CI] build libsecp256k1 for electrum tests a Mountain of Wealth token.
Aug 29 2024, 08:44
PiRK added a comment to D16681: [electrum] properly handle point at infinity and point not on curve.

I'm not sure exactly what is going on. I will try to rebase all these diffs onto D16687 when I get it sorted out. Hopefully it will fix the situation. I could just rebase everything onto master after I land any diff in the stack, but that would be tedious and noisy in the phabricator logs for a stack of 10+ commits.

Aug 29 2024, 08:38
teamcity awarded D16687: [CI] build libsecp256k1 for electrum tests a Doubloon token.
Aug 29 2024, 08:27
teamcity awarded D16687: [CI] build libsecp256k1 for electrum tests a Piece of Eight token.
Aug 29 2024, 08:17
PiRK accepted D16691: [avalanche] Make buildRandomProof use a random payout script.
Aug 29 2024, 06:33