Page MenuHomePhabricator
Feed Advanced Search

Sep 30 2025

teamcity awarded D18741: test: rename CBlockHeader .hash -> .hash_hex for consistency a Haypence token.
Sep 30 2025, 15:03
teamcity awarded D18740: test: rename CBlockHeader `.rehash()`/`.sha256` -> `.hash_int` for consistency a Haypence token.
Sep 30 2025, 15:01
teamcity awarded D18738: test: remove header hash caching in CBlockHeader class a Haypence token.
Sep 30 2025, 14:58
PiRK closed D18737: test: fix missing tx.hash -> tx.txid_hex and tx.sha256 -> tx.txid_int renamings.
Sep 30 2025, 14:34
PiRK committed rABCeaee44f769d1: test: fix missing tx.hash -> tx.txid_hex and tx.sha256 -> tx.txid_int renamings (authored by PiRK).
test: fix missing tx.hash -> tx.txid_hex and tx.sha256 -> tx.txid_int renamings
Sep 30 2025, 14:34
teamcity awarded D18737: test: fix missing tx.hash -> tx.txid_hex and tx.sha256 -> tx.txid_int renamings a Haypence token.
Sep 30 2025, 14:03
PiRK added a comment to D18737: test: fix missing tx.hash -> tx.txid_hex and tx.sha256 -> tx.txid_int renamings.

@bot chronik-client-integration-tests build-chronik-plugins

Sep 30 2025, 14:03
PiRK requested review of D18737: test: fix missing tx.hash -> tx.txid_hex and tx.sha256 -> tx.txid_int renamings.
Sep 30 2025, 14:02
PiRK requested review of D18736: test: avoid direct block header modification.
Sep 30 2025, 13:18
PiRK updated the diff for D18735: test: refactor: dedup `CBlockHeader` serialization.

refactor on dependency

Sep 30 2025, 13:16
PiRK requested review of D18735: test: refactor: dedup `CBlockHeader` serialization.
Sep 30 2025, 13:15
PiRK added inline comments to D18733: [test] factor some common block generation code in functional tests.
Sep 30 2025, 12:52
PiRK requested review of D18733: [test] factor some common block generation code in functional tests.
Sep 30 2025, 12:47
PiRK closed D18716: test: avoid unneeded txid hex -> integer conversions.
Sep 30 2025, 09:48
PiRK closed D18714: test: rename CTransaction .rehash()/.hash -> .txid_hex for consistency.
Sep 30 2025, 09:48
PiRK committed rABC520813b84f7a: test: rename CTransaction .sha256 -> .txid_int for consistency (authored by PiRK).
test: rename CTransaction .sha256 -> .txid_int for consistency
Sep 30 2025, 09:48
PiRK closed D18715: test: rename CTransaction .sha256 -> .txid_int for consistency.
Sep 30 2025, 09:48
PiRK committed rABC8572f61a78da: test: avoid unneeded txid hex -> integer conversions (authored by PiRK).
test: avoid unneeded txid hex -> integer conversions
Sep 30 2025, 09:48
PiRK committed rABCf5229b5e132f: test: rename CTransaction .rehash()/.hash -> .txid_hex for consistency (authored by PiRK).
test: rename CTransaction .rehash()/.hash -> .txid_hex for consistency
Sep 30 2025, 09:48
PiRK closed D18713: test: remove bare CTransaction `.rehash()` calls.
Sep 30 2025, 09:48
PiRK committed rABC13275833a495: test: remove bare CTransaction `.rehash()` calls (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>).
test: remove bare CTransaction `.rehash()` calls
Sep 30 2025, 09:48
PiRK closed D18712: test: remove txid caching in CTransaction class.
Sep 30 2025, 09:48
PiRK committed rABC496a019e7180: test: remove txid caching in CTransaction class (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>).
test: remove txid caching in CTransaction class
Sep 30 2025, 09:48
PiRK closed D18711: test: remove unused code from p2p_compactblocks.
Sep 30 2025, 09:48
PiRK committed rABCfe4ce9642e82: test: remove unused code from p2p_compactblocks (authored by PiRK).
test: remove unused code from p2p_compactblocks
Sep 30 2025, 09:48
PiRK accepted D18732: [proof-manager] Apply clippy fixes on the proof-manager-cli and its dependencies.
Sep 30 2025, 09:46
teamcity awarded D18716: test: avoid unneeded txid hex -> integer conversions a Piece of Eight token.
Sep 30 2025, 08:39
PiRK updated the diff for D18716: test: avoid unneeded txid hex -> integer conversions.

@bot build-master

Sep 30 2025, 08:39
PiRK updated the diff for D18715: test: rename CTransaction .sha256 -> .txid_int for consistency.

rebase

Sep 30 2025, 08:39
PiRK accepted D18718: Fix the Qt tests on MacOS.
Sep 30 2025, 05:22
teamcity awarded D18716: test: avoid unneeded txid hex -> integer conversions a Haypence token.
Sep 30 2025, 05:21
PiRK added a comment to D18716: test: avoid unneeded txid hex -> integer conversions.

@bot build-master

Sep 30 2025, 05:21

Sep 29 2025

PiRK updated the diff for D18714: test: rename CTransaction .rehash()/.hash -> .txid_hex for consistency.

fix feature_block, which was previously hanging so i missed these missing instances

Sep 29 2025, 19:53
PiRK updated the diff for D18716: test: avoid unneeded txid hex -> integer conversions.

rebase

Sep 29 2025, 19:48
PiRK requested review of D18712: test: remove txid caching in CTransaction class.

i fixed the issue in D18713, there is no significant problem with the performance because of caching, it was a bug

Sep 29 2025, 19:48
PiRK updated the diff for D18715: test: rename CTransaction .sha256 -> .txid_int for consistency.

rebase

Sep 29 2025, 19:47
PiRK updated the diff for D18714: test: rename CTransaction .rehash()/.hash -> .txid_hex for consistency.

rebase

Sep 29 2025, 19:46
PiRK updated the diff for D18713: test: remove bare CTransaction `.rehash()` calls.

unbreak feature_block.py

Sep 29 2025, 19:45
PiRK planned changes to D18713: test: remove bare CTransaction `.rehash()` calls.
Sep 29 2025, 19:41
PiRK planned changes to D18712: test: remove txid caching in CTransaction class.

i think i need to check the effect of this on the perf of the feature_block test. Specifically the numerous calls to make_conform_to_ctor may slow down the test now that the txid is no longer cached and the sorting process may need to recompute the txids multiple times.

Sep 29 2025, 19:28
PiRK updated the diff for D18715: test: rename CTransaction .sha256 -> .txid_int for consistency.

missed one in abc_p2p_compactblocks

Sep 29 2025, 18:56
PiRK requested review of D18716: test: avoid unneeded txid hex -> integer conversions.
Sep 29 2025, 15:42
PiRK requested review of D18715: test: rename CTransaction .sha256 -> .txid_int for consistency.
Sep 29 2025, 15:40
PiRK requested review of D18714: test: rename CTransaction .rehash()/.hash -> .txid_hex for consistency.
Sep 29 2025, 15:38
PiRK requested review of D18713: test: remove bare CTransaction `.rehash()` calls.
Sep 29 2025, 15:36
PiRK requested review of D18712: test: remove txid caching in CTransaction class.
Sep 29 2025, 15:33
PiRK accepted D18710: Enable the config file reading test case in the Qt test.
Sep 29 2025, 15:18
PiRK accepted D18709: Remove deprecated Makefile.
Sep 29 2025, 15:17
PiRK updated the summary of D18711: test: remove unused code from p2p_compactblocks.
Sep 29 2025, 13:33
PiRK updated the diff for D18711: test: remove unused code from p2p_compactblocks.

more

Sep 29 2025, 13:33
PiRK updated the diff for D18711: test: remove unused code from p2p_compactblocks.

also remove a comment that no longer makes sense

Sep 29 2025, 13:29
PiRK requested review of D18711: test: remove unused code from p2p_compactblocks.
Sep 29 2025, 13:20
PiRK accepted D18699: [rust] Bump Rust version to 1.90.
Sep 29 2025, 12:24
PiRK added a comment to D18699: [rust] Bump Rust version to 1.90.

looks reasonable to me

Sep 29 2025, 12:24

Sep 26 2025

PiRK closed D18698: [assumeutxo] add snapshot data for mainnet block 916'000 and testnet 1'680'000.
Sep 26 2025, 17:50
PiRK committed rABCb71266566058: [assumeutxo] add snapshot data for mainnet block 916'000 and testnet 1'680'000 (authored by PiRK).
[assumeutxo] add snapshot data for mainnet block 916'000 and testnet 1'680'000
Sep 26 2025, 17:50
PiRK accepted D18700: [avalanche] Fix a couple tests flakiness due to stalled txs.
Sep 26 2025, 15:34
PiRK requested review of D18698: [assumeutxo] add snapshot data for mainnet block 916'000 and testnet 1'680'000.
Sep 26 2025, 10:14
PiRK accepted D18675: [ecash-lib, cashtab] Expand parsing functions of ecash-lib.
Sep 26 2025, 06:28
PiRK added a comment to D18675: [ecash-lib, cashtab] Expand parsing functions of ecash-lib.

OK, I checked that the getEmppAppAction, getEmppAppActions & getXecxAppAction related changes are move-only (with some blank line changes and some const renaming, eg opReturn.appPrefixesHex.xecx -> EMPP_APP_PREFIXES.XECX).
The API of the new stuff (ParsedOpReturn, parseOpReturn) makes senses to me.

Sep 26 2025, 06:28
teamcity awarded D18549: add a build target for generating an assumeutxo snapshot a Love token.
Sep 26 2025, 06:15

Sep 25 2025

PiRK closed D18693: refactor: Remove gArgs access from validation.cpp.
Sep 25 2025, 18:06
PiRK committed rABC7bea13e016fe: refactor: Remove gArgs access from validation.cpp (authored by TheCharlatan <seb.kung@gmail.com>).
refactor: Remove gArgs access from validation.cpp
Sep 25 2025, 18:06
PiRK closed D18692: refactor: add replayprotectionactivationtime option in chainstatemanager.
Sep 25 2025, 18:06
PiRK committed rABCcb9ed7a26a6a: refactor: add replayprotectionactivationtime option in chainstatemanager (authored by PiRK).
refactor: add replayprotectionactivationtime option in chainstatemanager
Sep 25 2025, 18:06
teamcity awarded D18549: add a build target for generating an assumeutxo snapshot a Like token.
Sep 25 2025, 14:19
PiRK accepted D18694: [avalanche] Fix abc_rpc_getavalancheinfo.py flakiness.
Sep 25 2025, 13:10
PiRK requested review of D18693: refactor: Remove gArgs access from validation.cpp.
Sep 25 2025, 08:45
PiRK requested review of D18692: refactor: add replayprotectionactivationtime option in chainstatemanager.
Sep 25 2025, 08:44
PiRK closed D18686: refactor: Add path argument to FindSnapshotChainstateDir.
Sep 25 2025, 06:51
PiRK committed rABCf0f17d95391a: refactor: Add path argument to FindSnapshotChainstateDir (authored by PiRK).
refactor: Add path argument to FindSnapshotChainstateDir
Sep 25 2025, 06:51
PiRK committed rABC6dc0bd7b3dd7: refactor: Add stop_at_height option in ChainstateManager (authored by TheCharlatan <seb.kung@gmail.com>).
refactor: Add stop_at_height option in ChainstateManager
Sep 25 2025, 06:51
PiRK closed D18685: refactor: Add stop_at_height option in ChainstateManager.
Sep 25 2025, 06:51
PiRK closed D18684: refactor: add parkdeepreorg and automaticunparking options in ChainstateManager.
Sep 25 2025, 06:51
PiRK committed rABC70f94b283fbf: refactor: add parkdeepreorg and automaticunparking options in ChainstateManager (authored by PiRK).
refactor: add parkdeepreorg and automaticunparking options in ChainstateManager
Sep 25 2025, 06:50
PiRK accepted D18691: [ecash-lib] Actually fix the CI.
Sep 25 2025, 06:02

Sep 24 2025

PiRK updated the diff for D18685: refactor: Add stop_at_height option in ChainstateManager.

fix newline, and while we are touching this remove weird semicolons after function bodies

Sep 24 2025, 16:06
PiRK committed rABC918384f60564: [electrum] fix a few derivation path quirks in testnet mode (authored by PiRK).
[electrum] fix a few derivation path quirks in testnet mode
Sep 24 2025, 16:00
PiRK closed D18676: [electrum] fix a few derivation path quirks in testnet mode.
Sep 24 2025, 16:00
PiRK accepted D18677: [avalanche] Encapsulate the activation functions.
Sep 24 2025, 16:00
PiRK requested review of D18686: refactor: Add path argument to FindSnapshotChainstateDir.
Sep 24 2025, 15:56
PiRK requested review of D18685: refactor: Add stop_at_height option in ChainstateManager.
Sep 24 2025, 15:55
PiRK added inline comments to D18684: refactor: add parkdeepreorg and automaticunparking options in ChainstateManager.
Sep 24 2025, 15:54
PiRK requested review of D18684: refactor: add parkdeepreorg and automaticunparking options in ChainstateManager.
Sep 24 2025, 15:53
PiRK added inline comments to D18676: [electrum] fix a few derivation path quirks in testnet mode.
Sep 24 2025, 09:47
PiRK requested review of D18676: [electrum] fix a few derivation path quirks in testnet mode.
Sep 24 2025, 09:44

Sep 23 2025

PiRK closed D18663: ci: add unused-using-decls to clang-tidy.
Sep 23 2025, 15:54
PiRK committed rABC5b7f0c422114: ci: add unused-using-decls to clang-tidy (authored by PiRK).
ci: add unused-using-decls to clang-tidy
Sep 23 2025, 15:54
PiRK closed D18662: refactor: use C++11 default initializers.
Sep 23 2025, 15:15
PiRK committed rABC2456cc06d33d: refactor: use C++11 default initializers (authored by fanquake <fanquake@gmail.com>).
refactor: use C++11 default initializers
Sep 23 2025, 15:15
PiRK updated the diff for D18662: refactor: use C++11 default initializers.

fix processor tests (MSG_TX)

Sep 23 2025, 11:35
PiRK planned changes to D18662: refactor: use C++11 default initializers.
Sep 23 2025, 11:31
PiRK updated the diff for D18662: refactor: use C++11 default initializers.

iterate++

Sep 23 2025, 11:04
PiRK updated the diff for D18663: ci: add unused-using-decls to clang-tidy.

clang-tidy

Sep 23 2025, 10:36
PiRK updated the diff for D18662: refactor: use C++11 default initializers.

clang-tidy

Sep 23 2025, 10:29
PiRK closed D18661: lint: support cross-platform macros in format specifiers.
Sep 23 2025, 09:26
PiRK committed rABC3bf98f7f014f: lint: support cross-platform macros in format specifiers (authored by PiRK).
lint: support cross-platform macros in format specifiers
Sep 23 2025, 09:26
PiRK updated the diff for D18661: lint: support cross-platform macros in format specifiers.

ll

Sep 23 2025, 08:16
PiRK closed D18660: clang-tidy: cover fuzzers and chronik cpp code.
Sep 23 2025, 08:11
PiRK committed rABCa94c961835fc: clang-tidy: cover fuzzers and chronik cpp code (authored by PiRK).
clang-tidy: cover fuzzers and chronik cpp code
Sep 23 2025, 08:11