Page MenuHomePhabricator
Feed Advanced Search

Advanced Search
Use Results
Hide Query

Wed, Nov 19

PiRK accepted D18955: [64-bit ints] 32-bit integers? I never knew you.
Wed, Nov 19, 19:35
PiRK updated the test plan for D18971: test: cover read-only blockstore.
Wed, Nov 19, 17:13
PiRK updated the diff for D18971: test: cover read-only blockstore.

don't log 3 warnings for a single message

Wed, Nov 19, 17:12
PiRK added inline comments to D18971: test: cover read-only blockstore.
Wed, Nov 19, 17:10
PiRK requested review of D18971: test: cover read-only blockstore.
Wed, Nov 19, 17:08
PiRK updated the diff for D18969: kernel: Add fatalError method to notifications.

rebase after removing the txdb -> ui_interface dependency (D18970) and document the remaining kernel -> ui_interface transitive dependencies

Wed, Nov 19, 17:04
PiRK updated the diff for D18966: kernel: Pass interrupt reference to chainman.

rebase on D18970

Wed, Nov 19, 17:03
PiRK requested review of D18970: txdb: remove dependency on ui_interface.
Wed, Nov 19, 16:53
PiRK planned changes to D18969: kernel: Add fatalError method to notifications.

figure out why we still need ui_interface in the kernel lib

Wed, Nov 19, 15:47
PiRK requested review of D18969: kernel: Add fatalError method to notifications.
Wed, Nov 19, 14:49
PiRK requested review of D18968: kernel: Add flushError method to notifications.
Wed, Nov 19, 14:44
PiRK requested review of D18967: scripted-diff: Rename FatalError to FatalErrorf.
Wed, Nov 19, 14:43
PiRK requested review of D18966: kernel: Pass interrupt reference to chainman.
Wed, Nov 19, 14:42
PiRK requested review of D18965: util: Add SignalInterrupt class and use in shutdown.cpp.
Wed, Nov 19, 14:41
PiRK updated the diff for D18964: util: move threadinterrupt into util.

rebase

Wed, Nov 19, 11:31
PiRK added a comment to D18964: util: move threadinterrupt into util.

the failures seem unrelated, rerunning

Wed, Nov 19, 11:01
PiRK requested review of D18964: util: move threadinterrupt into util.
Wed, Nov 19, 10:31
PiRK accepted D18963: [website] Build the man pages for iguana and the proof-manager-cli.
Wed, Nov 19, 10:16
PiRK accepted D18962: Bump version to 0.32.4.
Wed, Nov 19, 10:14
PiRK accepted D18961: [cmake] Add man pages for the new executables.
Wed, Nov 19, 10:14
PiRK accepted D18958: [cmake] Add a target for the proof-manager-cli tool.
Wed, Nov 19, 08:06
PiRK closed D18957: bench: add readblock benchmark.
Wed, Nov 19, 08:01
PiRK closed D18952: net: Serve blocks directly from disk when possible.
Wed, Nov 19, 08:01
PiRK committed rABCa51b28b23a2d: net: Serve blocks directly from disk when possible (authored by PiRK).
net: Serve blocks directly from disk when possible
Wed, Nov 19, 08:01
PiRK committed rABC960a5e160248: bench: add readblock benchmark (authored by Andrew Toth <andrewstoth@gmail.com>).
bench: add readblock benchmark
Wed, Nov 19, 08:01

Tue, Nov 18

PiRK accepted D18959: [guix] Add the proof-manager-cli to the release.
Tue, Nov 18, 20:02
PiRK added inline comments to D18958: [cmake] Add a target for the proof-manager-cli tool.
Tue, Nov 18, 20:00
PiRK added inline comments to D18958: [cmake] Add a target for the proof-manager-cli tool.
Tue, Nov 18, 19:58
PiRK accepted D18956: [proof-manager-cli] Rename the proof-manager executable to proof-manager-cli.
Tue, Nov 18, 19:51
PiRK updated the diff for D18957: bench: add readblock benchmark.

also add missing includes from core#30716

Tue, Nov 18, 16:18
PiRK updated the diff for D18957: bench: add readblock benchmark.

fully apply https://github.com/bitcoin/bitcoin/pull/31490/commits/34f9a0157aad7c10ac364b7e4602c5f74c1f9e20

Tue, Nov 18, 16:09
PiRK requested review of D18957: bench: add readblock benchmark.
Tue, Nov 18, 15:51
PiRK updated the diff for D18952: net: Serve blocks directly from disk when possible.

deduplicate handling of block read error

Tue, Nov 18, 14:10
PiRK planned changes to D18952: net: Serve blocks directly from disk when possible.
Tue, Nov 18, 13:58
PiRK planned changes to D18934: validation: only check input scripts once.

The benefit / risk ratio is not clear on that one. The benefits are limited to deduplicating the script checks, and the risks involve making some CPU DoS attacks easier to perform.
This needs more consideration.

Tue, Nov 18, 13:47
PiRK planned changes to D18933: net_processing: drop MaybePunishNodeForTx.
Tue, Nov 18, 13:45
teamcity awarded D18952: net: Serve blocks directly from disk when possible a Haypence token.
Tue, Nov 18, 13:14
PiRK added a comment to D18952: net: Serve blocks directly from disk when possible.

benchmark, comparing ReadBlockFromDisk and ReadRawBlockFromDisk (from https://github.com/bitcoin/bitcoin/pull/26684/commits):

Tue, Nov 18, 11:29
PiRK closed D18948: Use DataStream where possible.
Tue, Nov 18, 11:22
PiRK closed D18947: streams: Add DataStream without ser-type and ser-version.
Tue, Nov 18, 11:22
PiRK committed rABCe63a388c3f04: Use DataStream where possible (authored by PiRK).
Use DataStream where possible
Tue, Nov 18, 11:22
PiRK committed rABC374ef2a303e9: streams: Add DataStream without ser-type and ser-version (authored by MarcoFalke <*~=`'#}+{/-|&$^_@721217.xyz>).
streams: Add DataStream without ser-type and ser-version
Tue, Nov 18, 11:22
PiRK published D18952: net: Serve blocks directly from disk when possible for review.
Tue, Nov 18, 11:15
teamcity awarded D18947: streams: Add DataStream without ser-type and ser-version a Haypence token.
Tue, Nov 18, 10:38

Mon, Nov 17

PiRK accepted D18949: [cmake] Move the common rust configuration to its own file.
Mon, Nov 17, 19:11
PiRK added inline comments to D18948: Use DataStream where possible.
Mon, Nov 17, 15:14
PiRK requested review of D18948: Use DataStream where possible.
Mon, Nov 17, 15:08
PiRK requested review of D18947: streams: Add DataStream without ser-type and ser-version.
Mon, Nov 17, 15:06
teamcity awarded D18934: validation: only check input scripts once a Piece of Eight token.
Mon, Nov 17, 10:43
PiRK added a comment to D18934: validation: only check input scripts once.

@bot ecash-agora-integration-tests chronik-client-integration-tests

Mon, Nov 17, 10:43
PiRK closed D18946: test: use a regexp in ecash-agora test.
Mon, Nov 17, 09:53
PiRK committed rABC3abc25461f59: test: use a regexp in ecash-agora test (authored by PiRK).
test: use a regexp in ecash-agora test
Mon, Nov 17, 09:53
PiRK published D18934: validation: only check input scripts once for review.
Mon, Nov 17, 09:51
PiRK published D18933: net_processing: drop MaybePunishNodeForTx for review.
Mon, Nov 17, 09:50
PiRK retitled D18946: test: use a regexp in ecash-agora test from test: use a regext in ecash-agora test to test: use a regexp in ecash-agora test.
Mon, Nov 17, 09:50
teamcity awarded D18946: test: use a regexp in ecash-agora test a Haypence token.
Mon, Nov 17, 09:15
PiRK added a comment to D18946: test: use a regexp in ecash-agora test.

@bot ecash-agora-integration-tests

Mon, Nov 17, 09:15
PiRK added a comment to D18946: test: use a regexp in ecash-agora test.

see https://reviews.bitcoinabc.org/D18933#431712 for a failure example

Mon, Nov 17, 09:15
PiRK requested review of D18946: test: use a regexp in ecash-agora test.
Mon, Nov 17, 09:14
PiRK accepted D18945: depends: Update Boost download link.
Mon, Nov 17, 08:50
PiRK committed rABC33bba45f0f66: remove unused RPCSerializationFlags() function (authored by PiRK).
remove unused RPCSerializationFlags() function
Mon, Nov 17, 07:28
PiRK closed D18944: remove unused RPCSerializationFlags() function.
Mon, Nov 17, 07:28

Sat, Nov 15

PiRK requested review of D18944: remove unused RPCSerializationFlags() function.
Sat, Nov 15, 19:34
PiRK closed D18941: Add checkpoints after the November 2025 network upgrade.
Sat, Nov 15, 18:49
PiRK committed rABC1df9c1ca9bb7: Add checkpoints after the November 2025 network upgrade (authored by PiRK).
Add checkpoints after the November 2025 network upgrade
Sat, Nov 15, 18:49
PiRK published D18941: Add checkpoints after the November 2025 network upgrade for review.
Sat, Nov 15, 14:37
teamcity awarded D18941: Add checkpoints after the November 2025 network upgrade a Haypence token.
Sat, Nov 15, 14:31

Fri, Nov 14

PiRK accepted D18935: [cmake] Remove Applications symlink in the OSX zip.
Fri, Nov 14, 15:46
teamcity awarded D18934: validation: only check input scripts once a Haypence token.
Fri, Nov 14, 13:19
teamcity awarded D18933: net_processing: drop MaybePunishNodeForTx a Haypence token.
Fri, Nov 14, 13:18
PiRK closed D18930: [test] A non-standard transaction which is also consensus-invalid should return the consensus error.
Fri, Nov 14, 12:16
PiRK closed D18928: [test] add a test for a transaction failing specifically for scriptsig-not-pushonly.
Fri, Nov 14, 12:16
PiRK closed D18929: test: ensure reason is checked for invalid blocks rejection.
Fri, Nov 14, 12:16
PiRK closed D18927: test: refactor: deduplicate ECDSA signing for tx inputs.
Fri, Nov 14, 12:16
PiRK committed rABC18a0ba609a96: test: refactor: deduplicate ECDSA signing for tx inputs (authored by PiRK).
test: refactor: deduplicate ECDSA signing for tx inputs
Fri, Nov 14, 12:16
PiRK committed rABC95386e73f188: test: ensure reason is checked for invalid blocks rejection (authored by Greg Sanders <gsanders87@gmail.com>).
test: ensure reason is checked for invalid blocks rejection
Fri, Nov 14, 12:16
PiRK committed rABC511bba71f2e5: [test] A non-standard transaction which is also consensus-invalid should return… (authored by Antoine Poinsot <darosior@protonmail.com>).
[test] A non-standard transaction which is also consensus-invalid should return…
Fri, Nov 14, 12:16
PiRK committed rABC4124839fc33b: [test] add a test for a transaction failing specifically for scriptsig-not… (authored by PiRK).
[test] add a test for a transaction failing specifically for scriptsig-not…
Fri, Nov 14, 12:16
PiRK updated the test plan for D18930: [test] A non-standard transaction which is also consensus-invalid should return the consensus error.
Fri, Nov 14, 11:40
PiRK updated the test plan for D18929: test: ensure reason is checked for invalid blocks rejection.
Fri, Nov 14, 11:40
PiRK requested review of D18930: [test] A non-standard transaction which is also consensus-invalid should return the consensus error.
Fri, Nov 14, 11:12
PiRK updated the test plan for D18930: [test] A non-standard transaction which is also consensus-invalid should return the consensus error.
Fri, Nov 14, 11:12
PiRK requested review of D18929: test: ensure reason is checked for invalid blocks rejection.
Fri, Nov 14, 11:11
PiRK updated the test plan for D18929: test: ensure reason is checked for invalid blocks rejection.
Fri, Nov 14, 11:10

Thu, Nov 13

PiRK requested review of D18930: [test] A non-standard transaction which is also consensus-invalid should return the consensus error.
Thu, Nov 13, 17:19
PiRK requested review of D18929: test: ensure reason is checked for invalid blocks rejection.
Thu, Nov 13, 17:14
PiRK updated the summary of D18927: test: refactor: deduplicate ECDSA signing for tx inputs.
Thu, Nov 13, 17:13
PiRK requested review of D18928: [test] add a test for a transaction failing specifically for scriptsig-not-pushonly.
Thu, Nov 13, 17:06
PiRK retitled D18927: test: refactor: deduplicate ECDSA signing for tx inputs from test: refactor: deduplicate legacy ECDSA signing for tx inputs to test: refactor: deduplicate ECDSA signing for tx inputs.
Thu, Nov 13, 16:48
PiRK updated the summary of D18927: test: refactor: deduplicate ECDSA signing for tx inputs.
Thu, Nov 13, 16:18
PiRK requested review of D18927: test: refactor: deduplicate ECDSA signing for tx inputs.
Thu, Nov 13, 16:16

Tue, Nov 11

PiRK closed D18917: [lint] enable FLY002 checks for the Electrum codebase.
Tue, Nov 11, 07:25
PiRK committed rABC32f7e38bb1ab: [lint] enable FLY002 checks for the Electrum codebase (authored by PiRK).
[lint] enable FLY002 checks for the Electrum codebase
Tue, Nov 11, 07:25

Mon, Nov 10

PiRK requested review of D18917: [lint] enable FLY002 checks for the Electrum codebase.
Mon, Nov 10, 15:52
PiRK closed D18913: [lint] replace flynt linter with ruff.
Mon, Nov 10, 15:27
PiRK closed D18907: [lint] Find function calls in default arguments.
Mon, Nov 10, 15:27
PiRK closed D18905: [lint] replace flake8 with ruff.
Mon, Nov 10, 15:27
PiRK closed D18906: [lint] remove isort linter, enable isort in ruff.
Mon, Nov 10, 15:27
PiRK committed rABC3e7747330203: [lint] replace flynt linter with ruff (authored by PiRK).
[lint] replace flynt linter with ruff
Mon, Nov 10, 15:27
PiRK committed rABC21d397cf14e4: [lint] Find function calls in default arguments (authored by PiRK).
[lint] Find function calls in default arguments
Mon, Nov 10, 15:27
First
Prev
Next