Page MenuHomePhabricator
Feed All Stories

All Stories
Use Results
Edit Query

Apr 26 2019

Fabien updated the diff for D2881: [LINTER] Improve lint-format-strings.sh performance.

Add newline at end of line

Apr 26 2019, 15:45
teamcity added a comment to D2871: Remove direct bitcoin calls from qt/optionsdialog.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 26 2019, 15:35
Fabien accepted D2871: Remove direct bitcoin calls from qt/optionsdialog.cpp.
Apr 26 2019, 15:35
jasonbcox updated the diff for D2871: Remove direct bitcoin calls from qt/optionsdialog.cpp.

Fix include ordering for project headers

Apr 26 2019, 15:34
Mengerian committed rABCb634084b3e11: Add function 'IsGravitonEnabled' (authored by Mengerian).
Add function 'IsGravitonEnabled'
Apr 26 2019, 15:30
Mengerian closed D2878: Add function 'IsGravitonEnabled'.
Apr 26 2019, 15:30
teamcity added a comment to D2881: [LINTER] Improve lint-format-strings.sh performance.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 26 2019, 14:17
teamcity added a comment to D2881: [LINTER] Improve lint-format-strings.sh performance.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 26 2019, 14:04
Herald added a reviewer for D2881: [LINTER] Improve lint-format-strings.sh performance: deadalnix.
Apr 26 2019, 14:03
teamcity added a comment to D2880: [LINTER] Revive the locale dependent functions linter in arcanist.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 26 2019, 13:30
teamcity added a comment to D2880: [LINTER] Revive the locale dependent functions linter in arcanist.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 26 2019, 13:15
Herald added a reviewer for D2880: [LINTER] Revive the locale dependent functions linter in arcanist: deadalnix.
Apr 26 2019, 13:14
Fabien accepted D2878: Add function 'IsGravitonEnabled'.
Apr 26 2019, 12:09
Fabien accepted D2874: Remove most direct bitcoin calls from qt/walletmodel.cpp.
Apr 26 2019, 11:43
teamcity added a comment to D2879: blockfilter: Remove sharp edge (uninitialized m_filter_type) when using the compiler-generated constructor for BlockFilter.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 26 2019, 05:31
teamcity added a comment to D2872: blockfilter: Refactor and add tests for BlockFilter construction.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 26 2019, 05:20
teamcity added a comment to D2879: blockfilter: Remove sharp edge (uninitialized m_filter_type) when using the compiler-generated constructor for BlockFilter.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 26 2019, 05:18
markblundeberg added a revision to T589: BIP157 & BIP158 backports: D2879: blockfilter: Remove sharp edge (uninitialized m_filter_type) when using the compiler-generated constructor for BlockFilter.
Apr 26 2019, 05:16
markblundeberg added a task to D2879: blockfilter: Remove sharp edge (uninitialized m_filter_type) when using the compiler-generated constructor for BlockFilter: T589: BIP157 & BIP158 backports.
Apr 26 2019, 05:16
Herald added a reviewer for D2879: blockfilter: Remove sharp edge (uninitialized m_filter_type) when using the compiler-generated constructor for BlockFilter: deadalnix.
Apr 26 2019, 05:16
teamcity added a comment to D2867: blockfilter: add block filters.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 26 2019, 05:10
teamcity added a comment to D2872: blockfilter: Refactor and add tests for BlockFilter construction.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 26 2019, 05:05
markblundeberg added inline comments to D2872: blockfilter: Refactor and add tests for BlockFilter construction.
Apr 26 2019, 05:05
markblundeberg updated the diff for D2872: blockfilter: Refactor and add tests for BlockFilter construction.

address Fabien comments

Apr 26 2019, 05:04
teamcity added a comment to D2867: blockfilter: add block filters.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 26 2019, 04:57
markblundeberg added inline comments to D2867: blockfilter: add block filters.
Apr 26 2019, 04:56
markblundeberg updated the diff for D2867: blockfilter: add block filters.

address Fabien comments

Apr 26 2019, 04:56
nullptr added a comment to T189: Ensure documentation for new developers is easy to understand.

The chat with ABC developers would be nice. The Contributing document was helpful with this platform and a few basics, although a few new developer doc pages could be useful.

Apr 26 2019, 03:23 · Bootcamp

Apr 25 2019

teamcity added a comment to D2874: Remove most direct bitcoin calls from qt/walletmodel.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 25 2019, 21:11
teamcity added a comment to D2874: Remove most direct bitcoin calls from qt/walletmodel.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 25 2019, 20:58
jasonbcox updated the diff for D2874: Remove most direct bitcoin calls from qt/walletmodel.cpp.

Fixed includes

Apr 25 2019, 20:57
markblundeberg added a comment to D2873: serialize: Serialization support for big-endian 32-bit ints..
In D2873#68039, @jasonbcox wrote:

Although this backport looks ok, I do think we should investigate test coverage in the future

Apr 25 2019, 19:47
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABCe8c680bd5840: serialize: Serialization support for big-endian 32-bit ints. (authored by jimpo).
serialize: Serialization support for big-endian 32-bit ints.
Apr 25 2019, 19:45
jimpo closed D2873: serialize: Serialization support for big-endian 32-bit ints..
Apr 25 2019, 19:45
teamcity added a comment to D2878: Add function 'IsGravitonEnabled'.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 25 2019, 18:37
teamcity added a comment to D2878: Add function 'IsGravitonEnabled'.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 25 2019, 18:23
Herald added a reviewer for D2878: Add function 'IsGravitonEnabled': Restricted Project.
Apr 25 2019, 18:22
Fabien requested changes to D2871: Remove direct bitcoin calls from qt/optionsdialog.cpp.
Apr 25 2019, 17:52
Fabien committed rABC1f126a0b8f42: [DOC] Add headers inclusion guidelines to the developer notes (authored by Fabien).
[DOC] Add headers inclusion guidelines to the developer notes
Apr 25 2019, 17:49
Fabien closed D2877: [DOC] Add headers inclusion guidelines to the developer notes.
Apr 25 2019, 17:49
Fabien requested changes to D2874: Remove most direct bitcoin calls from qt/walletmodel.cpp.
Apr 25 2019, 17:49
teamcity added a comment to D2877: [DOC] Add headers inclusion guidelines to the developer notes.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 25 2019, 17:47
jasonbcox accepted D2877: [DOC] Add headers inclusion guidelines to the developer notes.
Apr 25 2019, 17:37
teamcity added a comment to D2877: [DOC] Add headers inclusion guidelines to the developer notes.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 25 2019, 17:34
Fabien updated the diff for D2877: [DOC] Add headers inclusion guidelines to the developer notes.

Update as per feedbacks

Apr 25 2019, 17:33
jasonbcox requested changes to D2877: [DOC] Add headers inclusion guidelines to the developer notes.
Apr 25 2019, 16:43
teamcity added a comment to D2877: [DOC] Add headers inclusion guidelines to the developer notes.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 25 2019, 16:42
teamcity added a comment to D2877: [DOC] Add headers inclusion guidelines to the developer notes.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 25 2019, 16:28
Herald added a reviewer for D2877: [DOC] Add headers inclusion guidelines to the developer notes: deadalnix.
Apr 25 2019, 16:26
teamcity added a comment to D2874: Remove most direct bitcoin calls from qt/walletmodel.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 25 2019, 16:19
teamcity added a comment to D2871: Remove direct bitcoin calls from qt/optionsdialog.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 25 2019, 16:07
teamcity added a comment to D2874: Remove most direct bitcoin calls from qt/walletmodel.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 25 2019, 16:05
jasonbcox updated the diff for D2874: Remove most direct bitcoin calls from qt/walletmodel.cpp.

Rebase

Apr 25 2019, 16:04
jasonbcox added inline comments to D2874: Remove most direct bitcoin calls from qt/walletmodel.cpp.
Apr 25 2019, 16:03
jasonbcox added inline comments to D2874: Remove most direct bitcoin calls from qt/walletmodel.cpp.
Apr 25 2019, 16:02
teamcity added a comment to D2871: Remove direct bitcoin calls from qt/optionsdialog.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 25 2019, 15:52
jasonbcox updated the diff for D2871: Remove direct bitcoin calls from qt/optionsdialog.cpp.

Rebase

Apr 25 2019, 15:51
Fabien committed rABCd97910652534: Use angle bracket in include for wallet test (authored by Fabien).
Use angle bracket in include for wallet test
Apr 25 2019, 15:43
Fabien closed D2870: Use angle bracket in include for wallet test.
Apr 25 2019, 15:43
jasonbcox committed rABCaeb3ff3467ce: [qt] Simplifies boolean expression model && model->haveWatchOnly() (authored by 251 <13120787+251Labs@users.noreply.github.com>).
[qt] Simplifies boolean expression model && model->haveWatchOnly()
Apr 25 2019, 15:38
jasonbcox closed D2876: [qt] Simplifies boolean expression model && model->haveWatchOnly().
Apr 25 2019, 15:38
jasonbcox committed rABC370d6146a348: [qt] Avoid potential null pointer dereference in TransactionView::exportClicked… (authored by practicalswift <practicalswift@users.noreply.github.com>).
[qt] Avoid potential null pointer dereference in TransactionView::exportClicked…
Apr 25 2019, 15:37
jasonbcox closed D2875: [qt] Avoid potential null pointer dereference in TransactionView::exportClicked().
Apr 25 2019, 15:37
jasonbcox accepted D2870: Use angle bracket in include for wallet test.

Realized my comment isn't really standardizable across all source files, so ignore me.

Apr 25 2019, 15:35
Harbormaster failed remote builds in B5597: Diff 8266 for D2643: [CMAKE] Make RelWithDebInfo the default CMake configuration!
Apr 25 2019, 09:46
teamcity added a comment to D2643: [CMAKE] Make RelWithDebInfo the default CMake configuration.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Apr 25 2019, 09:46
teamcity added a comment to D2643: [CMAKE] Make RelWithDebInfo the default CMake configuration.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 25 2019, 09:32
Fabien updated the diff for D2643: [CMAKE] Make RelWithDebInfo the default CMake configuration.

Move to the root CMakeLists.txt

Apr 25 2019, 09:31
Fabien requested changes to D2872: blockfilter: Refactor and add tests for BlockFilter construction.
Apr 25 2019, 09:09
Fabien requested changes to D2867: blockfilter: add block filters.
Apr 25 2019, 08:57
Fabien requested changes to D2874: Remove most direct bitcoin calls from qt/walletmodel.cpp.
Apr 25 2019, 08:06
Fabien accepted D2876: [qt] Simplifies boolean expression model && model->haveWatchOnly().
Apr 25 2019, 06:30
Fabien accepted D2875: [qt] Avoid potential null pointer dereference in TransactionView::exportClicked().
Apr 25 2019, 06:29
Fabien committed rABCefd894165c01: Use angle bracket in include for seeder (authored by Fabien).
Use angle bracket in include for seeder
Apr 25 2019, 06:25
Fabien closed D2868: Use angle bracket in include for seeder.
Apr 25 2019, 06:25
Fabien committed rABCf05e34fccfe8: Use angle bracket in include for wallet (authored by Fabien).
Use angle bracket in include for wallet
Apr 25 2019, 06:25
Fabien closed D2869: Use angle bracket in include for wallet.
Apr 25 2019, 06:24
schancel added inline comments to D2863: [mining] Add fields for tracking package data..
Apr 25 2019, 05:54
schancel committed rABCa9acc46b47f0: [nit] Remove redundant parameter from `CTxMemPool::PrioritiseTransaction` (authored by schancel).
[nit] Remove redundant parameter from `CTxMemPool::PrioritiseTransaction`
Apr 25 2019, 05:53
schancel closed D2853: [nit] Remove redundant parameter from `CTxMemPool::PrioritiseTransaction`.
Apr 25 2019, 05:53
Mengerian commandeered D2341: Enforce NULLDUMMY.

Going to try to revive this for Nov 2019 Upgrade

Apr 25 2019, 04:30
jasonbcox accepted D2873: serialize: Serialization support for big-endian 32-bit ints..

Although this backport looks ok, I do think we should investigate test coverage in the future

Apr 25 2019, 01:35
markblundeberg requested review of D2873: serialize: Serialization support for big-endian 32-bit ints..
In D2873#68026, @jasonbcox wrote:

I don't see this being used in https://github.com/bitcoin/bitcoin/pull/14121/files Why is it needed?

Apr 25 2019, 00:19

Apr 24 2019

schancel added inline comments to D2862: [mining] Rename several CBlockTemplateEntry members for clarity.
Apr 24 2019, 23:47
schancel requested review of D2862: [mining] Rename several CBlockTemplateEntry members for clarity.
Apr 24 2019, 23:42
schancel added inline comments to D2862: [mining] Rename several CBlockTemplateEntry members for clarity.
Apr 24 2019, 23:42
jasonbcox requested changes to D2873: serialize: Serialization support for big-endian 32-bit ints..

I don't see this being used in https://github.com/bitcoin/bitcoin/pull/14121/files Why is it needed?

Apr 24 2019, 23:15
jasonbcox added inline comments to D2863: [mining] Add fields for tracking package data..
Apr 24 2019, 23:07
jasonbcox requested changes to D2863: [mining] Add fields for tracking package data..
Apr 24 2019, 23:05
jasonbcox accepted D2853: [nit] Remove redundant parameter from `CTxMemPool::PrioritiseTransaction`.
Apr 24 2019, 23:00
jasonbcox updated the summary of D2853: [nit] Remove redundant parameter from `CTxMemPool::PrioritiseTransaction`.
Apr 24 2019, 23:00
jasonbcox requested changes to D2862: [mining] Rename several CBlockTemplateEntry members for clarity.
Apr 24 2019, 22:57
teamcity added a comment to D2874: Remove most direct bitcoin calls from qt/walletmodel.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Apr 24 2019, 22:56
jasonbcox accepted D2868: Use angle bracket in include for seeder.
Apr 24 2019, 22:49
jasonbcox accepted D2869: Use angle bracket in include for wallet.
Apr 24 2019, 22:48
jasonbcox requested changes to D2870: Use angle bracket in include for wallet test.
Apr 24 2019, 22:46
jasonbcox added inline comments to D2874: Remove most direct bitcoin calls from qt/walletmodel.cpp.
Apr 24 2019, 22:43
teamcity added a comment to D2874: Remove most direct bitcoin calls from qt/walletmodel.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Apr 24 2019, 22:43
jasonbcox updated the diff for D2874: Remove most direct bitcoin calls from qt/walletmodel.cpp.

Fixed minor changes that shouldn't have deviated from the backport

Apr 24 2019, 22:42
jasonbcox added inline comments to D2874: Remove most direct bitcoin calls from qt/walletmodel.cpp.
Apr 24 2019, 22:38
First
Prev
Next