(After this, can port in https://github.com/bitcoin/bitcoin/pull/13512/files and https://github.com/bitcoin/bitcoin/pull/13517/files which are pretty great... )
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Jul 1 2019
Jul 1 2019
markblundeberg added a comment to D3495: Merge #12861: [tests] Stop feature_block.py from blowing up memory..
rebase for landed parent
D1936: Move handling for `-maxtxfee` to the config object now requires changes to proceed.
I think a variety of things have touched this code lately -- can this be rebased?
markblundeberg added a comment to D3492: Merge #13452: rpc: have verifytxoutproof check the number of txns in proof structure.
fix // nit
markblundeberg added a comment to D3495: Merge #12861: [tests] Stop feature_block.py from blowing up memory..
fix missing import
markblundeberg updated the summary of D3494: Merge #11771: [tests] Change invalidtxrequest to use BitcoinTestFramework.
Update per comments
markblundeberg added inline comments to D3494: Merge #11771: [tests] Change invalidtxrequest to use BitcoinTestFramework.
markblundeberg added inline comments to D3494: Merge #11771: [tests] Change invalidtxrequest to use BitcoinTestFramework.
markblundeberg added a comment to D3493: Merge #14305: Tests: enforce critical class instance attributes in functional tests, fix segwit test specificity.
Extended tests passed.
markblundeberg added inline comments to D3494: Merge #11771: [tests] Change invalidtxrequest to use BitcoinTestFramework.
markblundeberg updated the test plan for D3493: Merge #14305: Tests: enforce critical class instance attributes in functional tests, fix segwit test specificity.
update per comments (extended tests now in progress)
markblundeberg added a comment to D3491: Merge #14556: qt: fix confirmed transaction labeled "open".
update per comments
markblundeberg added inline comments to D3491: Merge #14556: qt: fix confirmed transaction labeled "open".
Jun 30 2019
Jun 30 2019
D3487: test: Fix dangling wallet pointer in vpwallets is now accepted and ready to land.
markblundeberg added a comment to D3483: Merge #11024: tests: Remove OldSetKeyFromPassphrase/OldEncrypt/OldDecrypt.
de-charring and braces
markblundeberg added a comment to D2552: Check that key length is correct when deserializing CExtKey.
Backport of https://github.com/bitcoin/bitcoin/pull/11081, with tests
markblundeberg added inline comments to D2268: Add calls to CWallet::BlockUntilSyncedToCurrentChain() in RPCs.
markblundeberg added a comment to D3472: add SCRIPT_ENABLE_SCHNORR_MULTISIG flag for new multisig mode.
We have a new bridge in Paris. It is 900 years old.
Jun 29 2019
Jun 29 2019
markblundeberg added inline comments to D3474: Implement new checkmultisig trigger logic and execution logic..
markblundeberg retitled D3472: add SCRIPT_ENABLE_SCHNORR_MULTISIG flag for new multisig mode from add SCRIPT_ENABLE_NEW_MULTISIG flag for new multisig mode to [WIP] add SCRIPT_ENABLE_NEW_MULTISIG flag for new multisig mode.
markblundeberg added a comment to D3472: add SCRIPT_ENABLE_SCHNORR_MULTISIG flag for new multisig mode.
(I will likely be adding some more tests and I'm open for suggestions as well)
Jun 28 2019
Jun 28 2019
D3451: Simplify testing RNG code is now accepted and ready to land.
D3450: Make unit tests use the insecure_rand_ctx exclusively is now accepted and ready to land.
D3449: Introduce a Shuffle for FastRandomContext and use it in wallet and coinselection is now accepted and ready to land.
D3448: Use a FastRandomContext in LimitOrphanTxSize is now accepted and ready to land.
D3447: Use a local FastRandomContext in a few more places in net is now accepted and ready to land.
D3446: Bugfix: randbytes should seed when needed (non reachable issue) is now accepted and ready to land.
D3445: Make addrman use its local RNG exclusively is now accepted and ready to land.
D3454: Do not permit copying FastRandomContexts is now accepted and ready to land.
D3375: Merge #10765: Tests: address placement should be deterministic by default is now accepted and ready to land.
Ah! Sorry for holding this up, I forgot about it and didn't realize it was waiting on me.
Jun 27 2019
Jun 27 2019
Confirm (currently 3 confirmations and 2810 confirmations for named mainnet and testnet blocks, respectively).
Jun 26 2019
Jun 26 2019
my bad!
refactored out schnorr detector into D3417
markblundeberg updated the summary of D3416: clean up script_tests -- move segwit recovery into static json.
markblundeberg added inline comments to D3332: remove SCRIPT_ENABLE_SCHNORR flag and clean up tests.
rebase simply due to age
Jun 25 2019
Jun 25 2019
markblundeberg added inline comments to D3332: remove SCRIPT_ENABLE_SCHNORR flag and clean up tests.
(note: I don't have ZMQ installed locally so I am basically relying on CI for this testing :/)
tweak
simple rebase
Jun 24 2019
Jun 24 2019
D3400: Fix mining_prioritisetransaction is now accepted and ready to land.
Hmm weird, why is ours called tx2_id?
Jun 23 2019
Jun 23 2019
markblundeberg updated the summary of D3371: fix BIP37 processing for non-topologically ordered blocks.
address comments & rebase onto D3399
markblundeberg added inline comments to D3371: fix BIP37 processing for non-topologically ordered blocks.
Note: in principle in this Diff, I could take out the two remaining *uses* of this flag as well, from MANDATORY_SCRIPT_VERIFY_FLAGS and from GetNextBlockScriptFlags (aka GetBlockScriptFlags). At the moment they are removed in the follow-up diff D3332.
markblundeberg added inline comments to D3371: fix BIP37 processing for non-topologically ordered blocks.
Jun 22 2019
Jun 22 2019
markblundeberg added inline comments to D3371: fix BIP37 processing for non-topologically ordered blocks.
markblundeberg added a comment to D3366: [consensus] Pin P2SH activation to block 173805 on mainnet.
just rebase
markblundeberg added a comment to D3365: Merge #8498: Near-Bugfix: Optimization: Minimize the number of times it is checked that no money....
Self-reviewing again.
markblundeberg added a comment to D3387: Speedup coinselector_tests by using a dummy WalletDBWrapper when apropriate.
From what I can see, Core used a dummy wallet from the very start. Why is ours different? It looks like the backport D3252 got modified from the original somehow.