Page MenuHomePhabricator
Feed Advanced Search

Jul 29 2020

jasonbcox requested review of D7079: Fixup comment regarding finalized block.
Jul 29 2020, 16:56
jasonbcox requested review of D7078: Fix RPC example for finalizeblock.
Jul 29 2020, 16:54
jasonbcox added a comment to D7071: Do not generate RPC doc index files multiple times.

Note that you still need to build an index per group (so within the loop), despite this is not what is done here.

Jul 29 2020, 16:34
jasonbcox accepted D7076: [CI] Prevent copying undesired test/tmp content to the artifacts.
Jul 29 2020, 16:32
jasonbcox requested changes to D7075: [DOC] Improve instructions for setting up shellcheck.

This doesn't strike me as something that belongs in CONTRIBUTING and brings up lots of questions:

  • Why do we expect new devs to have multiple shellcheck versions installed?
  • Why do we expect shellcheck to not be in PATH correctly?
  • What makes shellcheck install special such that we need to tell devs to check the version, but we do not do this for other tools?
Jul 29 2020, 16:28
jasonbcox accepted D7072: [GITIAN] Build with cmake 3.16 from the backport repository.

Expanding our ownership to gitian-builder makes me uncomfortable, but this change is small and the benefits far outweigh the cost of maintaining this change.

Jul 29 2020, 16:25
jasonbcox requested changes to D7073: [CMAKE] Bump minimum cmake to 3.16.

Version bump is missing from contrib/debian/control. Please add this to the test plan also.

Jul 29 2020, 16:21

Jul 28 2020

jasonbcox added a parent task for T1004: Backport Core PR18417: Unknown Object (Maniphest Task).
Jul 28 2020, 23:41 · Restricted Project
jasonbcox triaged T1004: Backport Core PR18417 as Normal priority.
Jul 28 2020, 23:38 · Restricted Project
jasonbcox closed T580: Backport Core PR 13930 as Resolved.
Jul 28 2020, 23:35 · Restricted Project
jasonbcox closed T702: Backport 15210 as Resolved.
Jul 28 2020, 23:35
jasonbcox closed T692: Fix apptests as Resolved.
Jul 28 2020, 23:35
jasonbcox closed T693: Backport 15195, a subtask of T692: Fix apptests, as Resolved.
Jul 28 2020, 23:34
jasonbcox closed T693: Backport 15195 as Resolved.
Jul 28 2020, 23:34
jasonbcox closed T694: Backport 15153, a subtask of T692: Fix apptests, as Resolved.
Jul 28 2020, 23:34
jasonbcox closed T694: Backport 15153 as Resolved.
Jul 28 2020, 23:34
jasonbcox closed T695: Backport 15226, a subtask of T694: Backport 15153, as Resolved.
Jul 28 2020, 23:34
jasonbcox closed T695: Backport 15226 as Resolved.
Jul 28 2020, 23:34
jasonbcox closed T696: Backport 15280, a subtask of T694: Backport 15153, as Resolved.
Jul 28 2020, 23:33
jasonbcox closed T696: Backport 15280 as Resolved.
Jul 28 2020, 23:33
jasonbcox closed T688: Backport Core PR13235, a subtask of T537: Backport Core PR14670, as Resolved.
Jul 28 2020, 23:32 · Restricted Project
jasonbcox closed T688: Backport Core PR13235 as Resolved.
Jul 28 2020, 23:32 · Restricted Project
jasonbcox closed T689: Backport of Core PR13131, a subtask of T688: Backport Core PR13235, as Resolved.
Jul 28 2020, 23:32 · Restricted Project
jasonbcox closed T689: Backport of Core PR13131 as Resolved.
Jul 28 2020, 23:32 · Restricted Project
jasonbcox closed T537: Backport Core PR14670 as Resolved.
Jul 28 2020, 23:32 · Restricted Project
jasonbcox closed T644: Backport Core PR 13163 as Resolved.
Jul 28 2020, 23:31
jasonbcox requested review of D7071: Do not generate RPC doc index files multiple times.
Jul 28 2020, 23:25
jasonbcox accepted D7069: Disable Jemalloc for the debian package builds.
Jul 28 2020, 21:20
jasonbcox accepted D7064: [CI] Enable Junit reporting via the build system and use it in scripts.
Jul 28 2020, 21:12
jasonbcox retitled D7065: Remove language sub-route from RPC doc permalinks from Remove langage sub-route from RPC doc permalinks to Remove language sub-route from RPC doc permalinks.
Jul 28 2020, 20:35
jasonbcox committed rABCWEB0cf7c443f98e: Link to new /doc/dev route (authored by jasonbcox).
Link to new /doc/dev route
Jul 28 2020, 20:35
jasonbcox closed D7066: Link to new /doc/dev route.
Jul 28 2020, 20:35
jasonbcox requested review of D7068: Add a link to RPC docs.
Jul 28 2020, 17:56
jasonbcox updated the summary of D7067: Add 0.21.12 RPC docs.
Jul 28 2020, 17:50
jasonbcox updated the summary of D7067: Add 0.21.12 RPC docs.
Jul 28 2020, 17:49
jasonbcox requested review of D7067: Add 0.21.12 RPC docs.
Jul 28 2020, 17:47
jasonbcox requested review of D7066: Link to new /doc/dev route.
Jul 28 2020, 17:32
jasonbcox requested review of D7065: Remove language sub-route from RPC doc permalinks.
Jul 28 2020, 17:30
jasonbcox committed rABCWEBb059f4bf972f: Add autoindexing for /doc route (authored by jasonbcox).
Add autoindexing for /doc route
Jul 28 2020, 15:56
jasonbcox closed D7057: Add autoindexing for /doc route.
Jul 28 2020, 15:56
jasonbcox added a comment to D7057: Add autoindexing for /doc route.

I don't quite get it, since D7052 updated the generated extension there is no html anymore in the RPC docs ?

Jul 28 2020, 15:35
jasonbcox requested review of D7057: Add autoindexing for /doc route.
Jul 28 2020, 01:00

Jul 27 2020

jasonbcox committed rABCb77a2c3698b3: Set correct markdown extension for generated RPC docs (authored by jasonbcox).
Set correct markdown extension for generated RPC docs
Jul 27 2020, 22:17
jasonbcox closed D7052: Set correct markdown extension for generated RPC docs.
Jul 27 2020, 22:17
jasonbcox committed rABC79d346dc6faa: Bump version to 0.21.13 (authored by jasonbcox).
Bump version to 0.21.13
Jul 27 2020, 22:11
jasonbcox closed D7047: Bump version to 0.21.13.
Jul 27 2020, 22:10
jasonbcox requested review of D7052: Set correct markdown extension for generated RPC docs.
Jul 27 2020, 19:32
jasonbcox requested review of D7047: Bump version to 0.21.13.
Jul 27 2020, 19:17
jasonbcox abandoned D6963: Add CI config for Avalanche tests.
Jul 27 2020, 16:17
jasonbcox abandoned D6964: Add CI config for seeder tests.
Jul 27 2020, 16:17
jasonbcox committed rABC798bd152c075: Add golang to the CI base image (authored by jasonbcox).
Add golang to the CI base image
Jul 27 2020, 15:35
jasonbcox closed D7001: Add golang to the CI base image.
Jul 27 2020, 15:35

Jul 22 2020

jasonbcox committed rABCb4fa9a213c24: Fix OSX SDK caching in Gitian builds (authored by jasonbcox).
Fix OSX SDK caching in Gitian builds
Jul 22 2020, 05:56
jasonbcox closed D6997: Fix OSX SDK caching in Gitian builds.
Jul 22 2020, 05:56
jasonbcox updated the diff for D7001: Add golang to the CI base image.

Use packaged version, even though it's much older

Jul 22 2020, 05:53
jasonbcox planned changes to D7001: Add golang to the CI base image.
Jul 22 2020, 05:50
jasonbcox requested review of D7001: Add golang to the CI base image.
Jul 22 2020, 05:42

Jul 21 2020

jasonbcox abandoned D6985: Fix locations of gitian build dependencies.

In favor of D6997 now that the base image building has been fixed.

Jul 21 2020, 21:31
jasonbcox requested review of D6997: Fix OSX SDK caching in Gitian builds.
Jul 21 2020, 21:30
jasonbcox abandoned D6987: [CI] Revert broken changes in gitian.sh.
Jul 21 2020, 21:00
jasonbcox committed rABC41e3cc675f40: Add build config for documentation, including RPC docs (authored by jasonbcox).
Add build config for documentation, including RPC docs
Jul 21 2020, 17:04
jasonbcox closed D6979: Add build config for documentation, including RPC docs.
Jul 21 2020, 17:04
jasonbcox updated the diff for D6979: Add build config for documentation, including RPC docs.

Simplify waiting for bitcoind

Jul 21 2020, 16:26
jasonbcox updated the diff for D6979: Add build config for documentation, including RPC docs.
  • Add bitcoin-cli for better parallelism
  • Make waiting for bitcoind more robust
Jul 21 2020, 02:44
jasonbcox committed rABC3af9381d5433: Renaming bswap_tests test case so that the name does not collide with the test… (authored by jasonbcox).
Renaming bswap_tests test case so that the name does not collide with the test…
Jul 21 2020, 02:33
jasonbcox closed D6982: Renaming bswap_tests test case so that the name does not collide with the test suite name.
Jul 21 2020, 02:33
jasonbcox requested review of D6987: [CI] Revert broken changes in gitian.sh.
Jul 21 2020, 02:24
jasonbcox planned changes to D6985: Fix locations of gitian build dependencies.
Jul 21 2020, 01:22
jasonbcox updated the diff for D6985: Fix locations of gitian build dependencies.

Fix some bugs. Still need to figure out where var/lxc.config will come from.

Jul 21 2020, 01:22
jasonbcox updated the summary of D6985: Fix locations of gitian build dependencies.
Jul 21 2020, 00:35
jasonbcox planned changes to D6985: Fix locations of gitian build dependencies.
Jul 21 2020, 00:34
jasonbcox requested review of D6985: Fix locations of gitian build dependencies.
Jul 21 2020, 00:34

Jul 20 2020

jasonbcox accepted D6983: [CI] Store functional tests duration with ms resolution in Junit.
Jul 20 2020, 22:23
jasonbcox requested review of D6982: Renaming bswap_tests test case so that the name does not collide with the test suite name.
Jul 20 2020, 21:07
jasonbcox planned changes to D6982: Renaming bswap_tests test case so that the name does not collide with the test suite name.
Jul 20 2020, 20:59
jasonbcox requested review of D6982: Renaming bswap_tests test case so that the name does not collide with the test suite name.
Jul 20 2020, 20:59
jasonbcox accepted D6977: [GITIAN] Fix instructions for extracting the OSX SDK.
Jul 20 2020, 20:00
jasonbcox accepted D6978: [GITIAN] Remove vagrant support documentation for the gitian builds.
Jul 20 2020, 19:58
jasonbcox accepted D6976: [GITIAN] Update scripts and docs to use the local gitian version.
Jul 20 2020, 19:58
jasonbcox requested review of D6979: Add build config for documentation, including RPC docs.
Jul 20 2020, 16:51
jasonbcox committed rABC98cd27974781: Generate RPC docs using regtest (authored by jasonbcox).
Generate RPC docs using regtest
Jul 20 2020, 15:59
jasonbcox closed D6971: Generate RPC docs using regtest.
Jul 20 2020, 15:59

Jul 18 2020

jasonbcox requested review of D6971: Generate RPC docs using regtest.
Jul 18 2020, 01:21

Jul 17 2020

jasonbcox accepted D6508: Move CustomArgumentsFixture to an apropriate place.
Jul 17 2020, 23:20
jasonbcox committed rABCb56f68112d84: Fix providing an explicit branch/ref to land-via-bot (authored by jasonbcox).
Fix providing an explicit branch/ref to land-via-bot
Jul 17 2020, 23:09
jasonbcox closed D6969: Fix providing an explicit branch/ref to land-via-bot.
Jul 17 2020, 23:09
jasonbcox requested review of D6969: Fix providing an explicit branch/ref to land-via-bot.
Jul 17 2020, 21:30
jasonbcox planned changes to D6969: Fix providing an explicit branch/ref to land-via-bot.
Jul 17 2020, 21:29
jasonbcox requested review of D6969: Fix providing an explicit branch/ref to land-via-bot.
Jul 17 2020, 21:29
jasonbcox requested review of D6964: Add CI config for seeder tests.
Jul 17 2020, 16:40
jasonbcox requested review of D6963: Add CI config for Avalanche tests.
Jul 17 2020, 16:33

Jul 16 2020

jasonbcox accepted D6957: [backport#15040] Add workaround for QProgressDialog bug on macOS.
Jul 16 2020, 22:20
jasonbcox committed rABC7a820a75ecfb: Merge #16302: test: Add missing syncwithvalidationinterfacequeue to… (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #16302: test: Add missing syncwithvalidationinterfacequeue to…
Jul 16 2020, 22:09
jasonbcox closed D6954: Merge #16302: test: Add missing syncwithvalidationinterfacequeue to wallet_balance test.
Jul 16 2020, 22:09
jasonbcox committed rABCed56d7f60735: Merge #15866: test: Add missing syncwithvalidationinterfacequeue to… (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #15866: test: Add missing syncwithvalidationinterfacequeue to…
Jul 16 2020, 22:05
jasonbcox closed D6953: Merge #15866: test: Add missing syncwithvalidationinterfacequeue to wallet_import_rescan.
Jul 16 2020, 22:05
jasonbcox committed rABCfec61921b712: Fix some functional test executable flags (authored by jasonbcox).
Fix some functional test executable flags
Jul 16 2020, 21:52
jasonbcox closed D6955: Fix some functional test executable flags.
Jul 16 2020, 21:52
jasonbcox added a comment to D6953: Merge #15866: test: Add missing syncwithvalidationinterfacequeue to wallet_import_rescan.

The PR15866 fixes the _issue_ 15865, please update the summary accordingly

Jul 16 2020, 21:40
jasonbcox updated the summary of D6953: Merge #15866: test: Add missing syncwithvalidationinterfacequeue to wallet_import_rescan.
Jul 16 2020, 21:40