Page MenuHomePhabricator
Feed Advanced Search

May 5 2021

majcosta committed rABC1377a4f39fc1: [backport#20016] uint256: 1 is a constant (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#20016] uint256: 1 is a constant
May 5 2021, 17:01
majcosta requested review of D9477: [backport#20016] uint256: 1 is a constant.
May 5 2021, 14:49
majcosta added inline comments to D9476: [avalanche] use the OrphanProofPool.
May 5 2021, 13:21

May 4 2021

majcosta accepted D9473: [website] remove exchanges that don't have withdrawals and deposits enabled.
May 4 2021, 19:12
majcosta closed D9472: [cashtab] enable gzip compression when serving cashtab.
May 4 2021, 16:29
majcosta committed rABCa1b2bac3c93a: [cashtab] enable gzip compression when serving cashtab (authored by majcosta).
[cashtab] enable gzip compression when serving cashtab
May 4 2021, 16:28
majcosta requested review of D9472: [cashtab] enable gzip compression when serving cashtab.
May 4 2021, 16:13

May 3 2021

majcosta closed D9470: [trivial] fix return value not using alias for SchnorrSig.
May 3 2021, 17:39
majcosta committed rABC005237ad2301: [trivial] fix return value not using alias for SchnorrSig (authored by majcosta).
[trivial] fix return value not using alias for SchnorrSig
May 3 2021, 17:39
majcosta requested review of D9470: [trivial] fix return value not using alias for SchnorrSig.
May 3 2021, 17:15
majcosta accepted D9460: [Cashtab] Reduce bundle size.
May 3 2021, 15:07

May 1 2021

majcosta closed D9466: [cashtab] replace deprecated eslint-loader, bump eslint version.
May 1 2021, 08:44
majcosta committed rABC1095182d0453: [cashtab] replace deprecated eslint-loader, bump eslint version (authored by majcosta).
[cashtab] replace deprecated eslint-loader, bump eslint version
May 1 2021, 08:44

Apr 30 2021

majcosta accepted D9467: [Cashtab] Use live wallet.state tokens obj if present.
Apr 30 2021, 22:58
majcosta requested review of D9466: [cashtab] replace deprecated eslint-loader, bump eslint version.
Apr 30 2021, 22:28
majcosta requested review of D9463: [cashtab] add arcanist linter support for eslint.
Apr 30 2021, 22:28
majcosta planned changes to D9462: [Cashtab] update @zxing/library.

broke QR code scanning

Apr 30 2021, 20:25
majcosta planned changes to D9463: [cashtab] add arcanist linter support for eslint.
Apr 30 2021, 19:48
majcosta accepted D9465: Add some release notes for the 0.23.3 release.
Apr 30 2021, 19:26
majcosta accepted D9464: Bump version to 0.23.3.
Apr 30 2021, 18:48
majcosta updated the summary of D9463: [cashtab] add arcanist linter support for eslint.
Apr 30 2021, 18:46
majcosta updated the test plan for D9463: [cashtab] add arcanist linter support for eslint.
Apr 30 2021, 18:06
majcosta updated the diff for D9463: [cashtab] add arcanist linter support for eslint.

revert the linter complaints and green the diff

Apr 30 2021, 18:05
majcosta requested review of D9463: [cashtab] add arcanist linter support for eslint.
Apr 30 2021, 18:02
majcosta requested review of D9462: [Cashtab] update @zxing/library.
Apr 30 2021, 16:43

Apr 29 2021

majcosta accepted D9459: [Cashtab] bug fix in utxo diff check.
Apr 29 2021, 14:55

Apr 27 2021

majcosta closed D9444: [refactor] extract function for past activation tests.
Apr 27 2021, 15:24
majcosta committed rABCd7f5657808e3: [refactor] extract function for past activation tests (authored by majcosta).
[refactor] extract function for past activation tests
Apr 27 2021, 15:24
majcosta accepted D9448: refactor: Use Mutex type for g_cs_recent_confirmed_transactions.
Apr 27 2021, 15:21
majcosta updated the diff for D9444: [refactor] extract function for past activation tests.

corrected missing line between functions, made testPastActivation static

Apr 27 2021, 10:58

Apr 25 2021

majcosta updated the summary of D9444: [refactor] extract function for past activation tests.
Apr 25 2021, 02:36
majcosta updated the summary of D9444: [refactor] extract function for past activation tests.
Apr 25 2021, 02:36

Apr 24 2021

majcosta requested review of D9444: [refactor] extract function for past activation tests.
Apr 24 2021, 11:19
majcosta retitled D9444: [refactor] extract function for past activation tests from [refactor] test past activations by height at the same place to [refactor] extract function for past activation tests.
Apr 24 2021, 11:18

Apr 23 2021

majcosta requested review of D9444: [refactor] extract function for past activation tests.
Apr 23 2021, 16:42
majcosta closed D9442: remove BCHN from download page.
Apr 23 2021, 15:20
majcosta committed rABCWEB79833d4e4374: remove BCHN from download page (authored by majcosta).
remove BCHN from download page
Apr 23 2021, 15:19
majcosta requested review of D9442: remove BCHN from download page.
Apr 23 2021, 15:02
majcosta planned changes to D9442: remove BCHN from download page.
Apr 23 2021, 15:01
majcosta requested review of D9442: remove BCHN from download page.
Apr 23 2021, 14:58
majcosta accepted D9345: [avalanche] set a minimum amount for a proof.
Apr 23 2021, 10:17

Apr 20 2021

majcosta accepted D9439: [Cashtab] Re-enable send for 9-decimal tokens.
Apr 20 2021, 19:28
majcosta accepted D9438: Make sure unconfirmed parents are requestable.
Apr 20 2021, 17:43
majcosta accepted D9437: Drop setInventoryTxToSend based filtering.
Apr 20 2021, 17:39
majcosta added a comment to D9437: Drop setInventoryTxToSend based filtering.

wrong summary link, this is the right one: https://github.com/bitcoin/bitcoin/pull/19109/commits/c4626bcd211af08c85b6567ef07eeae333edba47

Apr 20 2021, 17:39
majcosta accepted D9436: Only respond to requests for recently announced transactions.
Apr 20 2021, 17:38
majcosta accepted D9435: Introduce constant for mempool-based relay separate from mapRelay caching.

built and tested locally ok

Apr 20 2021, 17:05
majcosta accepted D9434: Swap relay pool and mempool lookup.
Apr 20 2021, 16:52
majcosta accepted D9432: test: refactor functional tests to use restart_node.
Apr 20 2021, 16:51
majcosta accepted D9431: test: move sync_blocks and sync_mempool functions to test_framework.py.
Apr 20 2021, 16:44

Apr 16 2021

majcosta accepted D9427: Add some release notes for 0.23.2.
Apr 16 2021, 20:03
majcosta accepted D9426: Bump version to 0.23.2.
Apr 16 2021, 18:01

Apr 14 2021

majcosta accepted D9415: [SECP256K1] Fix CI builds and badge links.
Apr 14 2021, 07:52
majcosta accepted D9408: [SECP256K1] Remove num/gmp support.

got it

Apr 14 2021, 07:51
majcosta accepted D9412: [SECP256K1] Make scalar_inverse{,_var} benchmark scale with SECP256K1_BENCH_ITERS.
Apr 14 2021, 00:09
majcosta accepted D9411: [SECP256K1] Optimization: track f,g limb count and pass to new variable-time update_fg_var.
Apr 14 2021, 00:08
majcosta accepted D9410: [SECP256K1] Optimization: use formulas instead of lookup tables for cancelling g bits.
Apr 14 2021, 00:01

Apr 13 2021

majcosta accepted D9409: [SECP256K1] Optimization: special-case zero modulus limbs in modinv64.
Apr 13 2021, 23:58
majcosta added inline comments to D9408: [SECP256K1] Remove num/gmp support.
Apr 13 2021, 23:53
majcosta requested changes to D9408: [SECP256K1] Remove num/gmp support.

is https://github.com/bitcoin-core/secp256k1/pull/831/commits/20448b8d09a492afcfcae7721033c13a44a776fd a skip? it's linked in the summary but this is a diff for: https://github.com/bitcoin-core/secp256k1/pull/831/commits/1f233b3fa05eb29a744487e0682d925055fb0d4c

Apr 13 2021, 23:33
majcosta accepted D9407: [SECP256K1] Remove unused scalar_sqr.
Apr 13 2021, 23:29
majcosta accepted D9406: [SECP256K1] Improve field/scalar inverse tests.
Apr 13 2021, 23:25
majcosta accepted D9405: [SECP256K1] Make field/scalar code use the new modinv modules for inverses.
Apr 13 2021, 23:09
majcosta accepted D9404: [SECP256K1] Move secp256k1_scalar_{inverse{_var},is_even} and secp256k1_fe_inverse{_var} to per-impl files.
Apr 13 2021, 22:37
majcosta accepted D9403: [SECP256K1] Improve bounds checks in modinv modules.
Apr 13 2021, 21:23
majcosta accepted D9402: [SECP256K1] Add safegcd based modular inverse modules.
Apr 13 2021, 21:11
majcosta accepted D9401: [SECP256K1] Add secp256k1_ctz{32,64}_var functions.
Apr 13 2021, 19:10

Apr 8 2021

majcosta accepted D9389: [SECP256K1] ctime_test: move context randomization test to the end.
Apr 8 2021, 16:10
majcosta accepted D9388: [SECP256K1] Use bit ops instead of int mult for constant-time logic in gej_add_ge.
Apr 8 2021, 16:05
majcosta closed D9371: [avalanche] delay executing avalanche event loop until IBD is done.
Apr 8 2021, 16:03
majcosta committed rABCa5c12c9a2c57: [avalanche] delay executing avalanche event loop until IBD is done (authored by majcosta).
[avalanche] delay executing avalanche event loop until IBD is done
Apr 8 2021, 16:03

Apr 7 2021

majcosta updated the diff for D9371: [avalanche] delay executing avalanche event loop until IBD is done.

went with simpler

Apr 7 2021, 15:35

Apr 6 2021

majcosta requested review of D9371: [avalanche] delay executing avalanche event loop until IBD is done.
Apr 6 2021, 18:49

Apr 2 2021

majcosta accepted D9366: Add some release notes for 0.23.1.
Apr 2 2021, 13:58
majcosta accepted D9367: Add a checkpoint at block height 680140.

double checked hash, ok

Apr 2 2021, 13:58

Mar 26 2021

majcosta accepted D9354: [website] Add OKEX to list of exchanges.
Mar 26 2021, 17:25
majcosta requested changes to D9345: [avalanche] set a minimum amount for a proof.
Mar 26 2021, 14:17

Mar 19 2021

majcosta accepted D9334: Add -netinfo peer connections dashboard.
Mar 19 2021, 19:12
majcosta accepted D9335: Cleanup the seeder list.
Mar 19 2021, 14:55

Mar 17 2021

majcosta accepted D9326: net: Extract download permission from noban.
Mar 17 2021, 14:20
majcosta accepted D9325: doc: Extract net permissions doc.
Mar 17 2021, 13:41
majcosta accepted D9324: Prepare docs for the next minor version bump.
Mar 17 2021, 13:32

Mar 11 2021

majcosta accepted D9316: Signal the avalanche service if avalanche is enabled.
Mar 11 2021, 13:18

Mar 10 2021

majcosta accepted D9290: [avalanche] implement getavalanchepeerinfo.

lgtm, just a few suggestions for conciseness

Mar 10 2021, 14:43
majcosta accepted D9312: [Cashtab] Form elements to themed styled components.
Mar 10 2021, 09:25

Mar 9 2021

majcosta requested changes to D9290: [avalanche] implement getavalanchepeerinfo.
Mar 9 2021, 22:48
majcosta accepted D9311: refactor: Replace RecursiveMutex with Mutex in warnings.cpp.
Mar 9 2021, 19:23
majcosta added a comment to D9311: refactor: Replace RecursiveMutex with Mutex in warnings.cpp.

@bot build-tsan

Mar 9 2021, 17:25
majcosta accepted D9310: refactor: Replace RecursiveMutex with Mutex in timedata.cpp.
Mar 9 2021, 15:38
majcosta accepted D9309: refactor: Replace RecursiveMutex with Mutex in netbase.cpp.
Mar 9 2021, 15:35

Mar 4 2021

majcosta accepted D9297: add "unofficial" to the image link for the BCHA telegram group.
Mar 4 2021, 19:30

Mar 3 2021

majcosta accepted D9285: [Cashtab] Migrate some css to styled components.
Mar 3 2021, 16:06
majcosta accepted D9295: [QT] Undim the validation button as the user updates the validated field.
Mar 3 2021, 15:52
majcosta requested changes to D9294: [QT] Improve validated fields responsiveness.
Mar 3 2021, 13:21
majcosta requested changes to D9290: [avalanche] implement getavalanchepeerinfo.
Mar 3 2021, 11:11

Mar 1 2021

majcosta accepted D9277: doc: noban precludes maxuploadtarget disconnects.
Mar 1 2021, 15:49
majcosta accepted D9284: Increase timeout for abc_p2p_fullblocktest.
Mar 1 2021, 11:47

Feb 28 2021

majcosta accepted D9283: [Cashtab] Add commas to formatted displays of large numbers.
Feb 28 2021, 14:20
majcosta accepted D9282: [Cashtab] Improve nav buttons.

Macro likestamp:

Feb 28 2021, 14:13
majcosta accepted D9281: [Cashtab] Move toSmallestDenomination function to utils.
Feb 28 2021, 14:07