Page MenuHomePhabricator
Feed Advanced Search

Advanced Search
Use Results
Hide Query

Mar 1 2019

jasonbcox added inline comments to D2616: Added Execute(JSONRPCRequest) overload in RPCCommandBase for wallet and help commands.
Mar 1 2019, 00:56
Herald added a reviewer for D2632: Fix undefined behavior in rpc/server.cpp: Restricted Project.
Mar 1 2019, 00:55
jasonbcox committed rABC7839640916c5: Avoid NULL pointer dereference when _walletModel is NULL (which is valid) (authored by practicalswift <practicalswift@users.noreply.github.com>).
Avoid NULL pointer dereference when _walletModel is NULL (which is valid)
Mar 1 2019, 00:43
jasonbcox closed D2625: Avoid NULL pointer dereference when _walletModel is NULL (which is valid).
Mar 1 2019, 00:42
jasonbcox committed rABC9bae8c8bf6f1: Use two boolean literals instead of re-using variable (authored by practicalswift <practicalswift@users.noreply.github.com>).
Use two boolean literals instead of re-using variable
Mar 1 2019, 00:40
jasonbcox closed D2624: Use two boolean literals instead of re-using variable.
Mar 1 2019, 00:40
jasonbcox committed rABCc99e09a9a9db: Remove duplicate uriParts.size() > 0 check (authored by practicalswift <practicalswift@users.noreply.github.com>).
Remove duplicate uriParts.size() > 0 check
Mar 1 2019, 00:39
jasonbcox closed D2623: Remove duplicate uriParts.size() > 0 check.
Mar 1 2019, 00:39
jasonbcox committed rABC9dd6ff0deb2d: Remove redundant NULL checks after new (authored by practicalswift <practicalswift@users.noreply.github.com>).
Remove redundant NULL checks after new
Mar 1 2019, 00:39
jasonbcox closed D2622: Remove redundant NULL checks after new.
Mar 1 2019, 00:38
jasonbcox committed rABC32f04379b4e5: Remove redundant check (!ecc is always true) (authored by practicalswift <practicalswift@users.noreply.github.com>).
Remove redundant check (!ecc is always true)
Mar 1 2019, 00:36
jasonbcox closed D2621: Remove redundant check (!ecc is always true).
Mar 1 2019, 00:36

Feb 28 2019

jasonbcox accepted D2586: [avalanche] Reject votes that fromnodes which already are in the quorum..
Feb 28 2019, 22:29
jasonbcox accepted D2557: Add a linter to detect python % format and convert them to use .format().
Feb 28 2019, 22:19
jasonbcox accepted D2606: Refactor ProcessGetData in anticipation of avoiding cs_main for ABC.
Feb 28 2019, 17:54

Feb 27 2019

jasonbcox accepted D2620: Use cached [compact] blocks to respond to getdata messages.
Feb 27 2019, 22:18
jasonbcox updated the summary of D2620: Use cached [compact] blocks to respond to getdata messages.
Feb 27 2019, 22:11
jasonbcox updated the test plan for D2625: Avoid NULL pointer dereference when _walletModel is NULL (which is valid).
Feb 27 2019, 21:59
jasonbcox updated the test plan for D2625: Avoid NULL pointer dereference when _walletModel is NULL (which is valid).
Feb 27 2019, 21:59
Herald added a reviewer for D2625: Avoid NULL pointer dereference when _walletModel is NULL (which is valid): Restricted Project.
Feb 27 2019, 21:55
Herald added a reviewer for D2624: Use two boolean literals instead of re-using variable: Restricted Project.
Feb 27 2019, 21:51
Herald added a reviewer for D2623: Remove duplicate uriParts.size() > 0 check: Restricted Project.
Feb 27 2019, 21:44
Herald added a reviewer for D2622: Remove redundant NULL checks after new: Restricted Project.
Feb 27 2019, 21:39
Herald added a reviewer for D2621: Remove redundant check (!ecc is always true): Restricted Project.
Feb 27 2019, 21:33
jasonbcox renamed T524: Improve IBD script to support arbitrary params from Write a continuous IBD script to Improve IBD script to support arbitrary params.
Feb 27 2019, 20:35 · Bootcamp, Restricted Project
jasonbcox requested changes to D2155: [qa] Switch to using multiprocessing instead of threading.

Moving this off of the review queue until the dependencies are finished.

Feb 27 2019, 20:35
jasonbcox requested changes to D2168: [qa] [move only] Move threading helpers to be top level functions..

Likely needs rebasing.

Feb 27 2019, 20:34
jasonbcox requested changes to D2586: [avalanche] Reject votes that fromnodes which already are in the quorum..
Feb 27 2019, 17:52
jasonbcox accepted D2619: [wallet] Get rid of CWalletTx default constructor.
Feb 27 2019, 16:32
jasonbcox accepted D2618: [wallet] Construct CWalletTx objects in CommitTransaction.
Feb 27 2019, 16:22
jasonbcox updated the summary of D2602: Cleanup unused confirm target in GetMinimumFee().
Feb 27 2019, 06:02
jasonbcox accepted D2604: Enable automatic detection of undefined names in Python tests scripts.
Feb 27 2019, 04:14
jasonbcox updated the summary of D2604: Enable automatic detection of undefined names in Python tests scripts.
Feb 27 2019, 04:14
jasonbcox updated the summary of D2604: Enable automatic detection of undefined names in Python tests scripts.
Feb 27 2019, 04:13
jasonbcox updated the summary of D2604: Enable automatic detection of undefined names in Python tests scripts.
Feb 27 2019, 04:12

Feb 26 2019

jasonbcox accepted D2607: Avoid cs_main in net_processing ActivateBestChain calls.
Feb 26 2019, 23:49
jasonbcox added inline comments to D2606: Refactor ProcessGetData in anticipation of avoiding cs_main for ABC.
Feb 26 2019, 23:46
Herald added a reviewer for D2616: Added Execute(JSONRPCRequest) overload in RPCCommandBase for wallet and help commands: Restricted Project.
Feb 26 2019, 23:40
jasonbcox requested changes to D2612: Updated ibd.sh script to take bitcoind options and then pass them directly to the bitcoind call..

Testplan should indicate that the params passed in were verified in logs or otherwise

Feb 26 2019, 20:26
jasonbcox added inline comments to D2606: Refactor ProcessGetData in anticipation of avoiding cs_main for ABC.
Feb 26 2019, 20:21
jasonbcox requested changes to D2606: Refactor ProcessGetData in anticipation of avoiding cs_main for ABC.
Feb 26 2019, 20:18
jasonbcox accepted D2603: Refactor the imports in the test framework.
Feb 26 2019, 20:14
jasonbcox updated the summary of D2603: Refactor the imports in the test framework.
Feb 26 2019, 20:12
jasonbcox updated the diff for D2602: Cleanup unused confirm target in GetMinimumFee().

Rebase to depend on D2614

Feb 26 2019, 20:11
jasonbcox updated the task description for T524: Improve IBD script to support arbitrary params.
Feb 26 2019, 19:54 · Bootcamp, Restricted Project
jasonbcox updated the task description for T524: Improve IBD script to support arbitrary params.
Feb 26 2019, 19:54 · Bootcamp, Restricted Project
jasonbcox updated the summary of D2615: Deprecate nblocks from estimatefee RPC.
Feb 26 2019, 19:52
jasonbcox updated the summary of D2614: Remove unused param from txmempool::estimateFee.
Feb 26 2019, 19:51
jasonbcox updated the summary of D2613: Added functional test for estimatefee RPC.
Feb 26 2019, 19:50
jasonbcox abandoned D2543: Remove unused param from txmempool::estimateFee and estimatefee RPC.

Split into the following diffs:
D2613 - Add initial rpc_estimatefee test
D2614 - Refactor nblocks internally
D2615 - RPC API changes

Feb 26 2019, 19:50
Herald added a reviewer for D2615: Deprecate nblocks from estimatefee RPC: Restricted Project.
Feb 26 2019, 19:48
Herald added a reviewer for D2614: Remove unused param from txmempool::estimateFee: Restricted Project.
Feb 26 2019, 19:32
jasonbcox added inline comments to D2608: Require no cs_main lock for ProcessNewBlock/ActivateBestChain.
Feb 26 2019, 19:28
Herald added a reviewer for D2613: Added functional test for estimatefee RPC: Restricted Project.
Feb 26 2019, 19:20
jasonbcox requested changes to D2612: Updated ibd.sh script to take bitcoind options and then pass them directly to the bitcoind call..
Feb 26 2019, 19:17

Feb 25 2019

jasonbcox created D2602: Cleanup unused confirm target in GetMinimumFee().
Feb 25 2019, 22:10
jasonbcox updated the diff for D2543: Remove unused param from txmempool::estimateFee and estimatefee RPC.

Rebase

Feb 25 2019, 22:08
jasonbcox committed rABCf10ed0743aa1: Revert "Cleanup unused confirm target in GetMinimumFee()" (authored by jasonbcox).
Revert "Cleanup unused confirm target in GetMinimumFee()"
Feb 25 2019, 22:08
jasonbcox added a reverting change for rABCcb2f3c887ce9: Cleanup unused confirm target in GetMinimumFee(): rABCf10ed0743aa1: Revert "Cleanup unused confirm target in GetMinimumFee()".
Feb 25 2019, 22:08
jasonbcox closed D2601: Revert "Cleanup unused confirm target in GetMinimumFee()".
Feb 25 2019, 22:08
jasonbcox accepted D2599: Fix the mininode/messages imports in example.py.
Feb 25 2019, 22:04
jasonbcox added a comment to T524: Improve IBD script to support arbitrary params.

This script already exists, for the most part: contrib/teamcity/ibd.sh Update it so that we can pass in -assumevalid=0 -checkpoints=0

Feb 25 2019, 20:25 · Bootcamp, Restricted Project
Herald added a reviewer for D2601: Revert "Cleanup unused confirm target in GetMinimumFee()": Restricted Project.
Feb 25 2019, 20:22
jasonbcox added a reverting change for rABCcb2f3c887ce9: Cleanup unused confirm target in GetMinimumFee(): D2601: Revert "Cleanup unused confirm target in GetMinimumFee()".
Feb 25 2019, 20:22
jasonbcox accepted D2592: Refactor the imports in feature_* tests.
Feb 25 2019, 20:06
jasonbcox accepted D2593: Refactor the imports in interface_* tests.
Feb 25 2019, 20:04
jasonbcox accepted D2594: Refactor the imports in mempool_* tests.
Feb 25 2019, 20:01
jasonbcox accepted D2595: Refactor the imports in mining_* tests.
Feb 25 2019, 20:01
jasonbcox updated the summary of D2591: Refactor the imports in abc-* tests.
Feb 25 2019, 20:01
jasonbcox updated the summary of D2592: Refactor the imports in feature_* tests.
Feb 25 2019, 20:01
jasonbcox updated the summary of D2593: Refactor the imports in interface_* tests.
Feb 25 2019, 20:00
jasonbcox updated the summary of D2594: Refactor the imports in mempool_* tests.
Feb 25 2019, 20:00
jasonbcox updated the summary of D2595: Refactor the imports in mining_* tests.
Feb 25 2019, 20:00
jasonbcox accepted D2596: Refactor the imports in p2p_* tests.
Feb 25 2019, 19:59
jasonbcox updated the summary of D2598: Refactor the imports in wallet_* tests.
Feb 25 2019, 19:43
jasonbcox accepted D2597: Refactor the imports in rpc_* tests.
Feb 25 2019, 19:43
jasonbcox updated the summary of D2597: Refactor the imports in rpc_* tests.
Feb 25 2019, 19:42
jasonbcox updated the summary of D2597: Refactor the imports in rpc_* tests.
Feb 25 2019, 19:42
jasonbcox accepted D2598: Refactor the imports in wallet_* tests.
Feb 25 2019, 19:04
jasonbcox committed rABCcb2f3c887ce9: Cleanup unused confirm target in GetMinimumFee() (authored by jasonbcox).
Cleanup unused confirm target in GetMinimumFee()
Feb 25 2019, 19:02
jasonbcox closed D2588: Cleanup unused confirm target in GetMinimumFee().
Feb 25 2019, 19:01
jasonbcox added inline comments to D2543: Remove unused param from txmempool::estimateFee and estimatefee RPC.
Feb 25 2019, 18:58
jasonbcox updated the diff for D2543: Remove unused param from txmempool::estimateFee and estimatefee RPC.

Fixed named arguments + added a test for it

Feb 25 2019, 18:57

Feb 22 2019

jasonbcox updated the diff for D2543: Remove unused param from txmempool::estimateFee and estimatefee RPC.

Removed assert_equal_float as it's no longer necessary

Feb 22 2019, 20:34
jasonbcox added inline comments to D2586: [avalanche] Reject votes that fromnodes which already are in the quorum..
Feb 22 2019, 19:00
jasonbcox updated the diff for D2543: Remove unused param from txmempool::estimateFee and estimatefee RPC.

Rebase + don't overengineer casting

Feb 22 2019, 18:52
jasonbcox added a comment to T536: Make nTxConfirmTarget use config instead of being global.

As part of this ticket, investigate to see if -txconfirmtarget is useful at all anymore. It's likely that we can get rid of it entirely.

Feb 22 2019, 18:43 · Bootcamp, Restricted Project
jasonbcox added inline comments to D2588: Cleanup unused confirm target in GetMinimumFee().
Feb 22 2019, 18:43
jasonbcox closed T538: Backport Core PR13554 as Resolved.
Feb 22 2019, 18:36 · Restricted Project
jasonbcox closed T538: Backport Core PR13554, a subtask of T537: Backport Core PR14670, as Resolved.
Feb 22 2019, 18:36 · Restricted Project
jasonbcox committed rABCc9e3c4c329f0: Remove unused argument to ThreadHTTP(...) (authored by practicalswift <practicalswift@users.noreply.github.com>).
Remove unused argument to ThreadHTTP(...)
Feb 22 2019, 18:36
jasonbcox closed D2587: Remove unused argument to ThreadHTTP(...).
Feb 22 2019, 18:35
jasonbcox added inline comments to D2543: Remove unused param from txmempool::estimateFee and estimatefee RPC.
Feb 22 2019, 01:06
Herald added a reviewer for D2588: Cleanup unused confirm target in GetMinimumFee(): Restricted Project.
Feb 22 2019, 01:06
jasonbcox requested changes to D2586: [avalanche] Reject votes that fromnodes which already are in the quorum..
Feb 22 2019, 00:46

Feb 21 2019

jasonbcox accepted D2585: [avalanche] Cycle through a set of 8 nodes in multi_block_register test.
Feb 21 2019, 23:54
jasonbcox accepted D2584: [avalanche] Cycle through a set of 8 nodes in block_register test.
Feb 21 2019, 23:44
jasonbcox added a subtask for T541: Backport Core PR10267 to support includeconf: T417: Backport PR10244 from core.
Feb 21 2019, 22:40 · Restricted Project
jasonbcox added a parent task for T417: Backport PR10244 from core: T541: Backport Core PR10267 to support includeconf.
Feb 21 2019, 22:40 · Backport
jasonbcox updated the summary of D2587: Remove unused argument to ThreadHTTP(...).
Feb 21 2019, 22:18
First
Prev
Next