In D2673#62455, @Fabien wrote:I think there is a backport missing in rpcwallet.cpp for the fundrawtransaction RPC: https://github.com/bitcoin/bitcoin/pull/9672/commits/891c5eeec2dbf295d14e8f888de02637367dd930
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Mar 8 2019
Mar 8 2019
Herald added a reviewer for D2675: Partial backport of Core PR9681 to add CWallet::SignTransaction: Restricted Project.
jasonbcox committed rABC9a061e3de48f: Cleanup remaining instances of txconfirmtarget (authored by jasonbcox).
Cleanup remaining instances of txconfirmtarget
Remove unused struct in fees.h
Update manpages for 0.19.1 release
Herald added a reviewer for D2673: Merge #10706: Improve wallet fee logic and fix GUI bugs: Restricted Project.
jasonbcox committed rABC80fd7906ecac: Update chainparams for 0.19.1 release (authored by jasonbcox).
Update chainparams for 0.19.1 release
Herald added a reviewer for D2672: Cleanup remaining instances of txconfirmtarget: Restricted Project.
Mar 7 2019
Mar 7 2019
While refactoring, I realized that this won't be used anymore. There's no use it adding it to the config.
Update with new testnet params
jasonbcox committed rABC850fcdf83afa: Add minor note to release notes for 0.19.1 release (authored by jasonbcox).
Add minor note to release notes for 0.19.1 release
Added testnet params
Herald added a reviewer for D2668: Add minor note to release notes for 0.19.1 release: Restricted Project.
jasonbcox committed rABC6d9922049a87: Deprecate nblocks from estimatefee RPC (authored by jasonbcox).
Deprecate nblocks from estimatefee RPC
Moving this off my queue until it's updated.
Rebase + updated release notes comment
jasonbcox committed rABC217825de0b04: Cleanup unused confirm target in GetMinimumFee() (authored by jasonbcox).
Cleanup unused confirm target in GetMinimumFee()
The constructor that was moved is already private and made public despite you saying the public constructor was removed.
jasonbcox committed rABC2733da33c3c6: Tweak translation docs for regenerating translation strings in out-of-tree… (authored by jasonbcox).
Tweak translation docs for regenerating translation strings in out-of-tree…
jasonbcox committed rABCcf9a8488eb62: Remove unused param from txmempool::estimateFee (authored by jasonbcox).
Remove unused param from txmempool::estimateFee
jasonbcox committed rABC44a86a083681: Regenerate out-of-date translation strings (authored by jasonbcox).
Regenerate out-of-date translation strings
Mar 6 2019
Mar 6 2019
Rebase on D2662 to cleanly update translation strings
Going to split out refreshing the translation strings for unrelated changes since it's rather large.
Going to split out refreshing the translation strings for unrelated changes since it's rather large.
Herald added a reviewer for D2661: Tweak translation docs for regenerating translation strings in out-of-tree builds: Restricted Project.
Updated translation strings
Mar 5 2019
Mar 5 2019
jasonbcox committed rABC48eef2eed953: Added Execute(JSONRPCRequest) overload in RPCCommandBase for wallet and help… (authored by jasonbcox).
Added Execute(JSONRPCRequest) overload in RPCCommandBase for wallet and help…
jasonbcox updated the diff for D2645: Reject headers building on invalid chains by tracking invalidity.
bool cleanup + fixed clearing g_failed_blocks
jasonbcox added inline comments to D2645: Reject headers building on invalid chains by tracking invalidity.
jasonbcox updated the diff for D2616: Added Execute(JSONRPCRequest) overload in RPCCommandBase for wallet and help commands.
Feedback
Progress towards T456
Progress towards T456
jasonbcox updated the test plan for D2645: Reject headers building on invalid chains by tracking invalidity.
Mar 4 2019
Mar 4 2019
jasonbcox updated the summary of D2645: Reject headers building on invalid chains by tracking invalidity.
Herald added a reviewer for D2645: Reject headers building on invalid chains by tracking invalidity: Restricted Project.
jasonbcox updated the diff for D2616: Added Execute(JSONRPCRequest) overload in RPCCommandBase for wallet and help commands.
Added command.cpp and renamed RPCCommandWithRequestContext -> RPCCommand
Rebase
jasonbcox committed rABC43d3860f4c0b: Removed unused confirmation target dropdown from the UI (authored by jasonbcox).
Removed unused confirmation target dropdown from the UI
jasonbcox added inline comments to D2639: [CMAKE] Override the flags for the RelWithDebInfo build configuration.
Looks like you missed the second commit in the PR: https://github.com/bitcoin/bitcoin/pull/11593/commits/97932cd2689659addfbb58dc6148928b73af3bd0
jasonbcox added a comment to D2616: Added Execute(JSONRPCRequest) overload in RPCCommandBase for wallet and help commands.
Currently there is a grand total of zero commands that are handled by that framework. I'm not even sure this is required or not, but I'm fairly confident that it's better to have something that handle many the RPC calls rather than have something that could handle them all but handle none in practice. Beside priorities, it is also very possible that other limitation in the current design will be uncovered when actually using it, and any complication of the design will get in the way rather than help.
jasonbcox updated the diff for D2616: Added Execute(JSONRPCRequest) overload in RPCCommandBase for wallet and help commands.
Fixed according to feedback
Cleanup nSmartFeeSliderPosition settings
Rebase
jasonbcox committed rABC8a165551eff6: Added functional test for estimatefee RPC (authored by jasonbcox).
Added functional test for estimatefee RPC
Rebase + added separating line between imports
Done: D2641
Still need to rebase this diff.
Herald added a reviewer for D2641: Removed unused confirmation target dropdown from the UI: Restricted Project.
Mar 2 2019
Mar 2 2019
jasonbcox committed rABCed234bd3bb18: Fix undefined behavior in rpc/server.cpp (authored by jasonbcox).
Fix undefined behavior in rpc/server.cpp
jasonbcox committed rABCf9c866be05a6: Fix a bug in ibd.sh where multiple args provided to the script would not be… (authored by jasonbcox).
Fix a bug in ibd.sh where multiple args provided to the script would not be…
Herald added a reviewer for D2637: Fix a bug in ibd.sh where multiple args provided to the script would not be parsed correctly: Restricted Project.
Mar 1 2019
Mar 1 2019
jasonbcox accepted D2612: Updated ibd.sh script to take bitcoind options and then pass them directly to the bitcoind call..
I will update the TeamCity config to the following once this is landed:
- Existing IBD will have -disablewallet added to ensure the config behavior remains the same
- A new IBD setting will be added with -disablewallet -assumevalid=0 -checkpoints=0
Fix unnecessary copy
Added new test timing