- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
May 27 2019
May 24 2019
For posterity: Harbormaster seems to be missing something and not detecting the tests being run, despite them passing. I'm going to land this and keep an eye on master just to be sure.
Add an item in the release notes.
Rebase
May 23 2019
May 22 2019
Rebase
May 21 2019
May 15 2019
Nit: comment these as needed on Windows
Rebase + added missing includes due to refactors over the last couple weeks
May 14 2019
iirc there are backports that do similar things, but this is a good start regardless
May 13 2019
May 10 2019
Added my suggestions which include capitalization, periods, and some rewordings.
In D3009#70858, @markblundeberg wrote:still exists in this form in Core.
I notice the comment in merkleblock.h in ABC is noticeably different from Core, did we put that in or missing backport?
May 9 2019
Rebase
Related: T336
For posterity: both of those PRs have already been backported.
Thanks for the links. I'll look into them.
In D2980#70690, @Fabien wrote:This sounds strange: the PR adds a comment to state explicitly that GuessVerificationProgress requires cs_main, and a later PR discard the lock in interfaces/nodes.cpp.
Is it possible that the call from the Node interface could not trigger the behavior described in the GuessVerificationProgress comment, so it is safe to not hold the lock ?