Page MenuHomePhabricator
Feed Advanced Search

Sep 6 2019

jasonbcox accepted D4015: Bugfix: NSIS: Exclude Makefile* from docs.
Sep 6 2019, 15:50
jasonbcox updated the summary of D4012: Merge #13517: qa: Remove need to handle the network thread in tests.
Sep 6 2019, 15:47
jasonbcox updated the summary of D4012: Merge #13517: qa: Remove need to handle the network thread in tests.
Sep 6 2019, 15:46
jasonbcox closed T669: Removing comparison test framework, a subtask of T679: Backport Core PR 13512, as Resolved.
Sep 6 2019, 15:42
jasonbcox closed T669: Removing comparison test framework as Resolved.
Sep 6 2019, 15:42
jasonbcox committed rABC7fe97790bd89: Merge #11818: I accidentally [deliberately] killed it [the… (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #11818: I accidentally [deliberately] killed it [the…
Sep 6 2019, 15:42
jasonbcox closed D4002: Merge #11818: I accidentally [deliberately] killed it [the ComparisonTestFramework].
Sep 6 2019, 15:42
jasonbcox requested changes to D4014: [CI] Make IBD a standard build configuration.
Sep 6 2019, 15:39
jasonbcox committed rABCad3f7f55012f: Merge #13512: [qa] mininode: Expose connection state through is_connected (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #13512: [qa] mininode: Expose connection state through is_connected
Sep 6 2019, 15:24
jasonbcox closed D4011: Merge #13512: [qa] mininode: Expose connection state through is_connected.
Sep 6 2019, 15:24
jasonbcox committed rABC27ebde13667a: Fix incorrectly backported return statements in mininode.py (authored by jasonbcox).
Fix incorrectly backported return statements in mininode.py
Sep 6 2019, 15:15
jasonbcox closed D4010: Fix incorrectly backported return statements in mininode.py.
Sep 6 2019, 15:15
jasonbcox updated the diff for D4012: Merge #13517: qa: Remove need to handle the network thread in tests.

Merged in D4013 to fix flaky feature_assumevalid

Sep 6 2019, 15:14
jasonbcox abandoned D4013: Merge #13715: tests: fixes mininode's P2PConnection sending messages on closing transport.

Abandoning to include this change in D4012.

Sep 6 2019, 15:11
jasonbcox accepted D4004: Bump leveldb subtree.
Sep 6 2019, 00:43
jasonbcox accepted D4006: Merge leveldb subtree.
Sep 6 2019, 00:40
jasonbcox accepted D3999: Remove extra newline that leads to linter warning.
Sep 6 2019, 00:37
jasonbcox accepted D4008: [rebase] threads: fix unitialized members in sched_param.
Sep 6 2019, 00:36
jasonbcox requested changes to D4009: zmq: log outbound message high water mark when reusing socket.

Can you fix the summary? looks like some of it got cut off.

Sep 6 2019, 00:35
jasonbcox committed rABC3542fbfd24a0: Added a script to generate chainparams intermediate files (authored by jasonbcox).
Added a script to generate chainparams intermediate files
Sep 6 2019, 00:31
jasonbcox closed D3732: Added a script to generate chainparams intermediate files.
Sep 6 2019, 00:31
jasonbcox updated the diff for D4002: Merge #11818: I accidentally [deliberately] killed it [the ComparisonTestFramework].

Cleaned up remaining doc notes

Sep 6 2019, 00:27
jasonbcox planned changes to D3856: Merge #13439: rpc: Avoid "duplicate" return value for invalid submitblock.

After some discussion with Fabien, we decided it wasn't urgent to get this change in without tests to accompany it (or at least be landed shortly after). https://github.com/bitcoin/bitcoin/pull/13983/ This PR and it's dependencies get us there, but will take some more time. Putting this diff on the back burner until then.

Sep 6 2019, 00:24
jasonbcox created D4013: Merge #13715: tests: fixes mininode's P2PConnection sending messages on closing transport.
Sep 6 2019, 00:12

Sep 5 2019

jasonbcox created D4012: Merge #13517: qa: Remove need to handle the network thread in tests.
Sep 5 2019, 23:57
jasonbcox created D4011: Merge #13512: [qa] mininode: Expose connection state through is_connected.
Sep 5 2019, 22:03
jasonbcox created D4010: Fix incorrectly backported return statements in mininode.py.
Sep 5 2019, 21:34
jasonbcox planned changes to D4003: Generalized ibd.sh to provide a logging tool for running similar types of tests.
Sep 5 2019, 18:58
jasonbcox created D4003: Generalized ibd.sh to provide a logging tool for running similar types of tests.
Sep 5 2019, 18:58
jasonbcox added inline comments to D4002: Merge #11818: I accidentally [deliberately] killed it [the ComparisonTestFramework].
Sep 5 2019, 15:42
jasonbcox created D4002: Merge #11818: I accidentally [deliberately] killed it [the ComparisonTestFramework].
Sep 5 2019, 15:41
jasonbcox committed rABC23dd085f1312: Migrated abc-p2p-compactblocks.py off of ComparisonTestFramework (authored by jasonbcox).
Migrated abc-p2p-compactblocks.py off of ComparisonTestFramework
Sep 5 2019, 15:25
jasonbcox closed D3996: Migrated abc-p2p-compactblocks.py off of ComparisonTestFramework.
Sep 5 2019, 15:24
jasonbcox committed rABC2557eb97aa72: Migrated abc-p2p-fullblocktest.py off of ComparisonTestFramework (authored by jasonbcox).
Migrated abc-p2p-fullblocktest.py off of ComparisonTestFramework
Sep 5 2019, 15:24
jasonbcox closed D3995: Migrated abc-p2p-fullblocktest.py off of ComparisonTestFramework.
Sep 5 2019, 15:24
jasonbcox committed rABC30ad164a8285: Migrated abc-mempool-coherence-on-activations.py off of ComparisonTestFramework (authored by jasonbcox).
Migrated abc-mempool-coherence-on-activations.py off of ComparisonTestFramework
Sep 5 2019, 15:23
jasonbcox closed D3991: Migrated abc-mempool-coherence-on-activations.py off of ComparisonTestFramework.
Sep 5 2019, 15:23
jasonbcox committed rABCa6e32827ea6a: Migrated abc-transaction-ordering.py off of ComparisonTestFramework (authored by jasonbcox).
Migrated abc-transaction-ordering.py off of ComparisonTestFramework
Sep 5 2019, 15:22
jasonbcox closed D3990: Migrated abc-transaction-ordering.py off of ComparisonTestFramework.
Sep 5 2019, 15:22

Sep 4 2019

jasonbcox accepted D3986: During IBD, when doing pruning, prune 10% extra to avoid pruning again soon after.
Sep 4 2019, 20:24
jasonbcox requested changes to D3993: [CI] Refactor the build configuration by moving out tests from the build.
Sep 4 2019, 20:19
jasonbcox requested changes to D3308: Merge #9894: remove 'label' filter for rpc command help.

I will green this once D3950 is getting close to completion. Right now, there are some missing backports so it's difficult to estimate a timeline.

Sep 4 2019, 18:31
jasonbcox requested changes to D3950: Merge #12953: Deprecate accounts.
Sep 4 2019, 18:29
jasonbcox added a revision to T669: Removing comparison test framework: D3996: Migrated abc-p2p-compactblocks.py off of ComparisonTestFramework.
Sep 4 2019, 18:21
jasonbcox created D3996: Migrated abc-p2p-compactblocks.py off of ComparisonTestFramework.
Sep 4 2019, 18:21
jasonbcox accepted D3949: Merge #12892: [wallet] [rpc] introduce 'label' API for wallet.
Sep 4 2019, 18:10
jasonbcox added a revision to T669: Removing comparison test framework: D3995: Migrated abc-p2p-fullblocktest.py off of ComparisonTestFramework.
Sep 4 2019, 16:06
jasonbcox created D3995: Migrated abc-p2p-fullblocktest.py off of ComparisonTestFramework.
Sep 4 2019, 16:06
jasonbcox requested changes to D3992: [CI] Improve error catching and build log verbosity.

set -eux is a good idea. I'm not yet convinced on set -o pipefail, though I think it's probably best to have it on by default rather than not.

Sep 4 2019, 16:01
jasonbcox added a revision to T669: Removing comparison test framework: D3991: Migrated abc-mempool-coherence-on-activations.py off of ComparisonTestFramework.
Sep 4 2019, 14:51
jasonbcox created D3991: Migrated abc-mempool-coherence-on-activations.py off of ComparisonTestFramework.
Sep 4 2019, 14:51
jasonbcox added a revision to T669: Removing comparison test framework: D3990: Migrated abc-transaction-ordering.py off of ComparisonTestFramework.
Sep 4 2019, 14:39
jasonbcox created D3990: Migrated abc-transaction-ordering.py off of ComparisonTestFramework.
Sep 4 2019, 14:39

Aug 21 2019

jasonbcox committed rABC2b80f23c116d: Cleanup TODOs leftover from PR14119 backporting (authored by jasonbcox).
Cleanup TODOs leftover from PR14119 backporting
Aug 21 2019, 15:35
jasonbcox closed D3924: Cleanup TODOs leftover from PR14119 backporting.
Aug 21 2019, 15:35
jasonbcox updated the test plan for D3924: Cleanup TODOs leftover from PR14119 backporting.
Aug 21 2019, 15:34
jasonbcox committed rABC317690e7d094: Cleanup reject_code in abc-schnorr.py (authored by jasonbcox).
Cleanup reject_code in abc-schnorr.py
Aug 21 2019, 15:34
jasonbcox closed D3923: Cleanup reject_code in abc-schnorr.py.
Aug 21 2019, 15:34
jasonbcox committed rABC482bedb0d69f: Cleanup reject_code in abc-segwit-recovery (authored by jasonbcox).
Cleanup reject_code in abc-segwit-recovery
Aug 21 2019, 15:33
jasonbcox closed D3922: Cleanup reject_code in abc-segwit-recovery.
Aug 21 2019, 15:33

Aug 20 2019

jasonbcox requested review of D3924: Cleanup TODOs leftover from PR14119 backporting.
Aug 20 2019, 22:18
jasonbcox updated the summary of D3924: Cleanup TODOs leftover from PR14119 backporting.
Aug 20 2019, 22:11
jasonbcox planned changes to D3924: Cleanup TODOs leftover from PR14119 backporting.
Aug 20 2019, 22:10
jasonbcox created D3924: Cleanup TODOs leftover from PR14119 backporting.
Aug 20 2019, 22:09
jasonbcox updated the diff for D3922: Cleanup reject_code in abc-segwit-recovery.

Added missing bytes -> str

Aug 20 2019, 22:03
jasonbcox created D3923: Cleanup reject_code in abc-schnorr.py.
Aug 20 2019, 21:57
jasonbcox created D3922: Cleanup reject_code in abc-segwit-recovery.
Aug 20 2019, 21:03
jasonbcox accepted D3906: Create dependencies.md, and link it from README & build docs.
Aug 20 2019, 19:58
jasonbcox accepted D3910: [docs] initial QT documentation, move Qt Creator instructions.
Aug 20 2019, 19:09
jasonbcox accepted D3919: release: require macOS 10.10+.
Aug 20 2019, 19:07
jasonbcox accepted D3911: doc: add qrencode to brew install instructions.
Aug 20 2019, 19:04
jasonbcox accepted D3921: trivial: Fixed typos and cleaned up language.
Aug 20 2019, 19:04
jasonbcox accepted D3912: Rename “OS X” to the newer “macOS” convention.
Aug 20 2019, 19:01
jasonbcox accepted D3696: Merge #10036: Fix init README format to render correctly on github.
Aug 20 2019, 19:01
jasonbcox committed rABC2a60a2cef70e: Cleanup reject_code in abc-schnorrmultisig-activation (authored by jasonbcox).
Cleanup reject_code in abc-schnorrmultisig-activation
Aug 20 2019, 16:51
jasonbcox closed D3895: Cleanup reject_code in abc-schnorrmultisig-activation.
Aug 20 2019, 16:51
jasonbcox committed rABC7ce71d5615f1: Cleanup reject_code in abc-minimaldata-activation (authored by jasonbcox).
Cleanup reject_code in abc-minimaldata-activation
Aug 20 2019, 16:50
jasonbcox closed D3896: Cleanup reject_code in abc-minimaldata-activation.
Aug 20 2019, 16:50
jasonbcox accepted D3913: [CMAKE] Add missing -DMAC_OSX definition.
Aug 20 2019, 16:37
jasonbcox accepted D3918: Update timing.json.
Aug 20 2019, 16:24
jasonbcox accepted D3916: [CMAKE] Add the -commit suffix to version number through obj/build.h.
Aug 20 2019, 16:23
jasonbcox accepted D3917: Bump version to 0.20.1.
Aug 20 2019, 16:22
jasonbcox abandoned D3920: Bump version to 0.20.1.

Duplicate of D3917

Aug 20 2019, 16:21
jasonbcox created D3920: Bump version to 0.20.1.
Aug 20 2019, 16:20
jasonbcox requested review of D3915: Merge #13022: [qa] Attach node index to test_node AssertionError and print messages.
Aug 20 2019, 01:32
jasonbcox planned changes to D3915: Merge #13022: [qa] Attach node index to test_node AssertionError and print messages.
Aug 20 2019, 01:04
jasonbcox updated the summary of D3915: Merge #13022: [qa] Attach node index to test_node AssertionError and print messages.
Aug 20 2019, 01:03
jasonbcox created D3915: Merge #13022: [qa] Attach node index to test_node AssertionError and print messages.
Aug 20 2019, 01:03
jasonbcox updated the summary of D3914: Merge #12853: qa: Match full plain text by default.
Aug 20 2019, 01:02

Aug 19 2019

jasonbcox requested review of D3914: Merge #12853: qa: Match full plain text by default.
Aug 19 2019, 22:38
jasonbcox planned changes to D3914: Merge #12853: qa: Match full plain text by default.
Aug 19 2019, 22:24
jasonbcox created D3914: Merge #12853: qa: Match full plain text by default.
Aug 19 2019, 22:24
jasonbcox accepted D3888: Merge #12714: Introduce interface for signing providers.
Aug 19 2019, 18:51
jasonbcox accepted D3900: Merge #12762: Make CKeyStore an interface.
Aug 19 2019, 18:28
jasonbcox accepted D3912: Rename “OS X” to the newer “macOS” convention.
Aug 19 2019, 18:02
jasonbcox accepted D3909: docs: Update osx brew install instruction.
Aug 19 2019, 17:53
jasonbcox accepted D3908: remove brew c++ flag.
Aug 19 2019, 17:52
jasonbcox accepted D3905: Add python3 to list of dependencies on some platforms.
Aug 19 2019, 17:49
jasonbcox accepted D3904: [doc] Minor corrections to osx dependencies.
Aug 19 2019, 17:49
jasonbcox accepted D3907: Remove the tested versions from the OSX build guide.
Aug 19 2019, 17:43