applying changes to UnwindBlock
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Jan 3 2020
Jan 3 2020
fpelliccioni planned changes to D4804: Optimization: don't add txn back to mempool after 10 invalidates.
fpelliccioni planned changes to D4803: Prevent callback overruns in InvalidateBlock and RewindBlockIndex.
Jan 2 2020
Jan 2 2020
rebasing
rebasing
rebased
Dec 26 2019
Dec 26 2019
fpelliccioni retitled D4804: Optimization: don't add txn back to mempool after 10 invalidates from Granular invalidateblock and RewindBlockIndex to Optimization: don't add txn back to mempool after 10 invalidates.
fpelliccioni retitled D4803: Prevent callback overruns in InvalidateBlock and RewindBlockIndex from Granular invalidateblock and RewindBlockIndex to Prevent callback overruns in InvalidateBlock and RewindBlockIndex.
fpelliccioni edited reviewers for D4802: Release cs_main during InvalidateBlock iterations, added: markblundeberg; removed: Fabien.
fpelliccioni retitled D4802: Release cs_main during InvalidateBlock iterations from Granular invalidateblock and RewindBlockIndex to Release cs_main during InvalidateBlock iterations.
Dec 24 2019
Dec 24 2019
In D4758#115570, @markblundeberg wrote:In D4758#115130, @fpelliccioni wrote:In D4758#115041, @markblundeberg wrote:Something seems a bit off here -- note that ABC has renamed the 'inner' InvalidateBlock to UnwindBlock in D1952 (not sure why). I think you might be putting the lock in the wrong place, and it should rather go on UnwindBlock.
I didn't want to change the semantics of UnwindBlock because this function is used by ParkBlock.
In any case, I will create another Diff to change ParkBlock.Hmm, however, in the original PR there will get many many more changes made to UnwindBlock (called InvalidateBlock in Core) -- https://github.com/bitcoin/bitcoin/pull/15402/files#diff-24efdb00bfbe56b140fb006b562cc70bL2787 . The essence of the PR is that UnwindBlock will only take short-term locks during its execution. If we start off like this then it seems none of the following commits will make sense.
Dec 19 2019
Dec 19 2019
In D4758#115041, @markblundeberg wrote:Something seems a bit off here -- note that ABC has renamed the 'inner' InvalidateBlock to UnwindBlock in D1952 (not sure why). I think you might be putting the lock in the wrong place, and it should rather go on UnwindBlock.
In D4757#115032, @markblundeberg wrote:Heh, unfortunate title for this diff now that RewindBlockIndex is gone :-D
Dec 18 2019
Dec 18 2019
fpelliccioni edited reviewers for D4758: Call InvalidateBlock without cs_main held, added: markblundeberg; removed: Fabien.
fpelliccioni retitled D4758: Call InvalidateBlock without cs_main held from Granular invalidateblock and RewindBlockIndex to Call InvalidateBlock without cs_main held.
remove empty line
fpelliccioni retitled D4757: Call RewindBlockIndex without cs_main held from Granular invalidateblock and RewindBlockIndex to Call RewindBlockIndex without cs_main held.
It seems that removal of the RewindBlockIndex declaration is missing (src/validation.h).
Due to D4728
Due to D4728
fpelliccioni abandoned D4669: Move erasure of non-active blocks to a separate loop in RewindBlockIndex.
Due to D4728
fpelliccioni added a comment to D4669: Move erasure of non-active blocks to a separate loop in RewindBlockIndex.
In D4669#114633, @deadalnix wrote:As @markblundeberg pointed, this looks like a bunch of dead code. Can you look at D4728 and see what that means for this backport?
Not really requesting changes, requesting change to get this back on your queue.
Dec 17 2019
Dec 17 2019
fpelliccioni committed rABC197e349654be: We assume uint8_t is an alias of unsigned char. (authored by fpelliccioni).
We assume uint8_t is an alias of unsigned char.
Fixes AES benchmarks
included climits header
included cstdint header
added 8-bit byte assumtion
Dec 16 2019
Dec 16 2019
added linting exclusion
fixed comments
In D4731#114006, @jasonbcox wrote:The change doesn't appear to match the description. Did you get bit by the linter?
included type_traits header
Dec 12 2019
Dec 12 2019
fpelliccioni updated the diff for D4669: Move erasure of non-active blocks to a separate loop in RewindBlockIndex.
remove code section
fpelliccioni committed rABC4b92e0e79051: Abstract EraseBlockData out of RewindBlockIndex (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Abstract EraseBlockData out of RewindBlockIndex
moved comment
Dec 11 2019
Dec 11 2019
fpelliccioni added inline comments to D4683: Merge the disconnection and erasing loops in RewindBlockIndex.
Dec 10 2019
Dec 10 2019
fpelliccioni retitled D4684: Release cs_main during RewindBlockIndex operation from Granular invalidateblock and RewindBlockIndex to Release cs_main during RewindBlockIndex operation.
fpelliccioni updated the summary of D4683: Merge the disconnection and erasing loops in RewindBlockIndex.
fpelliccioni retitled D4683: Merge the disconnection and erasing loops in RewindBlockIndex from Granular invalidateblock and RewindBlockIndex to Merge the disconnection and erasing loops in RewindBlockIndex.
Dec 9 2019
Dec 9 2019
fpelliccioni updated the summary of D4669: Move erasure of non-active blocks to a separate loop in RewindBlockIndex.
fpelliccioni retitled D4669: Move erasure of non-active blocks to a separate loop in RewindBlockIndex from Granular invalidateblock and RewindBlockIndex to Move erasure of non-active blocks to a separate loop in RewindBlockIndex.
fpelliccioni retitled D4653: Abstract EraseBlockData out of RewindBlockIndex from Granular invalidateblock and RewindBlockIndex (Partial) to Abstract EraseBlockData out of RewindBlockIndex.
Solved Bitcoin-QT test
fpelliccioni retitled D4653: Abstract EraseBlockData out of RewindBlockIndex from Granular invalidateblock and RewindBlockIndex to Granular invalidateblock and RewindBlockIndex (Partial).
Dec 5 2019
Dec 5 2019
In D4550#110003, @deadalnix wrote:I think we may want to keep this around for QUIC.
Need to adjust Summary
Dec 2 2019
Dec 2 2019
fpelliccioni committed rABCba82bd9f9256: refactor: Add and use HaveTxsDownloaded() where appropriate (authored by MarcoFalke <falke.marco@gmail.com>).
refactor: Add and use HaveTxsDownloaded() where appropriate
fpelliccioni updated the diff for D4552: refactor: Add and use HaveTxsDownloaded() where appropriate.
rebase from master
Nov 26 2019
Nov 26 2019
I have to update the test plan.
fpelliccioni updated the test plan for D4552: refactor: Add and use HaveTxsDownloaded() where appropriate.
Nov 19 2019
Nov 19 2019
Oct 29 2019
Oct 29 2019
fpelliccioni committed rABCf316cd272e95: rpc: Expose g_is_mempool_loaded via getmempoolinfo (authored by MarcoFalke <falke.marco@gmail.com>).
rpc: Expose g_is_mempool_loaded via getmempoolinfo
rebase from master
Oct 25 2019
Oct 25 2019
Applies backport changes.