Good stuff.

remove accidentaly duplicated line

remove "// serialization support" comments and mark getters as const

rebase after changing D9247 to suppress compiler warning

remove maybe_unused which does not work for GCC with attributes, define two getters instead

replace a SER_READ with SER_WRITE (seeder/db.h l234)

Rebase after fixing -Wunused-private-field warning in D9247

annotate two private attributes in avalanche/protocol.h with [[maybe_unused]] to suppress a compiler warning

getters are required to silence a compiler warning

-Wunused-private-field

and also write the store request when serializing

in case BIP70 is disabled, still store the deserialized payment request in the object's sPaymentRequest attribute

rebase (probably unrelated coinselector_tests failure in build-clang-tidy)

remove maybe_unused annotation

annotate unused function

rebase

I wasn't able to reproduce the latest build-clang-tidy failure on my machine.

address review

Note: i did not review src/bench/nanobench.h

use boost_check instead of assert

rebase