Page MenuHomePhabricator
Feed All Stories

All Stories
Use Results
Edit Query

Jun 10 2019

teamcity added a comment to D3276: Avoid unintentional unsigned integer wraparounds in tests.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 10 2019, 12:47
teamcity added a comment to D3275: [tests] Use FastRandomContext instead of boost::random::*.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 10 2019, 12:40
teamcity added a comment to D3276: Avoid unintentional unsigned integer wraparounds in tests.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 10 2019, 12:36
Fabien added a comment to D3276: Avoid unintentional unsigned integer wraparounds in tests.

Reverted squashing the fix as it belongs to D3275

Jun 10 2019, 12:36
Fabien updated the summary of D3276: Avoid unintentional unsigned integer wraparounds in tests.
Jun 10 2019, 12:34
teamcity added a comment to D3275: [tests] Use FastRandomContext instead of boost::random::*.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 10 2019, 12:34
Fabien added a comment to D3275: [tests] Use FastRandomContext instead of boost::random::*.

Squash the fix

Jun 10 2019, 12:34
teamcity added a comment to D3276: Avoid unintentional unsigned integer wraparounds in tests.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 10 2019, 12:33
Fabien updated the summary of D3275: [tests] Use FastRandomContext instead of boost::random::*.
Jun 10 2019, 12:33
Fabien planned changes to D3275: [tests] Use FastRandomContext instead of boost::random::*.
Jun 10 2019, 12:28
Fabien planned changes to D3276: Avoid unintentional unsigned integer wraparounds in tests.
Jun 10 2019, 12:28
Fabien updated the summary of D3276: Avoid unintentional unsigned integer wraparounds in tests.
Jun 10 2019, 12:28
teamcity added a comment to D3276: Avoid unintentional unsigned integer wraparounds in tests.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 10 2019, 12:27
Fabien added a comment to D3276: Avoid unintentional unsigned integer wraparounds in tests.

Squash the fix

Jun 10 2019, 12:27
teamcity added a comment to D3276: Avoid unintentional unsigned integer wraparounds in tests.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 10 2019, 12:22
Fabien planned changes to D3276: Avoid unintentional unsigned integer wraparounds in tests.
Jun 10 2019, 12:20
teamcity added a comment to D3276: Avoid unintentional unsigned integer wraparounds in tests.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 10 2019, 12:16
Fabien created D3276: Avoid unintentional unsigned integer wraparounds in tests.
Jun 10 2019, 12:16
teamcity added a comment to D3275: [tests] Use FastRandomContext instead of boost::random::*.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 10 2019, 12:14
teamcity added a comment to D3275: [tests] Use FastRandomContext instead of boost::random::*.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 10 2019, 12:08
Fabien created D3275: [tests] Use FastRandomContext instead of boost::random::*.
Jun 10 2019, 12:08
teamcity added a comment to D3274: [tests] Better stderr testing.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 10 2019, 11:55
teamcity added a comment to D3274: [tests] Better stderr testing.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 10 2019, 11:49
Fabien added a revision to T540: Backport Core PR12755: D3274: [tests] Better stderr testing.
Jun 10 2019, 11:49 ยท Restricted Project
Fabien created D3274: [tests] Better stderr testing.
Jun 10 2019, 11:49
teamcity added a comment to D3273: qa: Normalize executable location.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 10 2019, 11:41
teamcity added a comment to D3273: qa: Normalize executable location.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 10 2019, 11:35
Fabien added a comment to D3273: qa: Normalize executable location.

Fix comparison framework

Jun 10 2019, 11:35
Fabien updated the summary of D3273: qa: Normalize executable location.
Jun 10 2019, 11:34
Fabien planned changes to D3273: qa: Normalize executable location.
Jun 10 2019, 11:07
Harbormaster failed remote builds in B6240: Diff 9280 for D3273: qa: Normalize executable location!
Jun 10 2019, 11:04
teamcity added a comment to D3273: qa: Normalize executable location.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Jun 10 2019, 11:04
teamcity added a comment to D3273: qa: Normalize executable location.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 10 2019, 11:00
Fabien created D3273: qa: Normalize executable location.
Jun 10 2019, 11:00
markblundeberg added inline comments to D3271: add SCRIPTSIGMINPUSHONLY flag and logic.
Jun 10 2019, 03:35
Mengerian added inline comments to D3271: add SCRIPTSIGMINPUSHONLY flag and logic.
Jun 10 2019, 03:12
teamcity added a comment to D3253: Remove Schnorr activation.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 10 2019, 00:13
teamcity added a comment to D3253: Remove Schnorr activation.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 10 2019, 00:03
teamcity added a comment to D3253: Remove Schnorr activation.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 10 2019, 00:02
markblundeberg added a comment to D3253: Remove Schnorr activation.

remove newline from timing.json

Jun 10 2019, 00:02

Jun 9 2019

teamcity added a comment to D3253: Remove Schnorr activation.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 9 2019, 23:55
markblundeberg added a comment to D3253: Remove Schnorr activation.

rebase for D3262 & tweak accordingly

Jun 9 2019, 23:55
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABCef575f052a30: Add script tests with valid 64-byte ECDSA signatures. (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>).
Add script tests with valid 64-byte ECDSA signatures.
Jun 9 2019, 23:29
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> closed D3262: Add script tests with valid 64-byte ECDSA signatures..
Jun 9 2019, 23:29
teamcity added a comment to D3262: Add script tests with valid 64-byte ECDSA signatures..

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 9 2019, 22:40
teamcity added a comment to D3262: Add script tests with valid 64-byte ECDSA signatures..

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 9 2019, 22:34
markblundeberg added a comment to D3262: Add script tests with valid 64-byte ECDSA signatures..

update comment per suggestion

Jun 9 2019, 22:33
D3262: Add script tests with valid 64-byte ECDSA signatures. is now accepted and ready to land.

Checked throught the Diff again, looks good to me.

Jun 9 2019, 18:52
markblundeberg added a comment to D3263: add CScriptNum operator>>=.

Probably going to abandon this. The motivation was to avoid using int for a bitfield as it has implementation-defined length, but I think I will just use use asserts / tests to get rid of weird platforms.

Jun 9 2019, 17:13
Fabien committed rABC897e59d0af84: utils: run commands using utf-8 string on Windows (authored by Chun Kuan Lee <ken2812221@gmail.com>).
utils: run commands using utf-8 string on Windows
Jun 9 2019, 15:37
Fabien closed D3272: utils: run commands using utf-8 string on Windows.
Jun 9 2019, 15:37
teamcity added a comment to D3265: add new encoding checker for Schnorr sigs.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 9 2019, 14:54
teamcity added a comment to D3265: add new encoding checker for Schnorr sigs.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 9 2019, 14:45
markblundeberg added a comment to D3265: add new encoding checker for Schnorr sigs.

update per comments

Jun 9 2019, 14:45
D3272: utils: run commands using utf-8 string on Windows is now accepted and ready to land.
Jun 9 2019, 14:42
markblundeberg updated the summary of D3271: add SCRIPTSIGMINPUSHONLY flag and logic.
Jun 9 2019, 12:37
teamcity added a comment to D3272: utils: run commands using utf-8 string on Windows.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 9 2019, 06:50
teamcity added a comment to D3272: utils: run commands using utf-8 string on Windows.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 9 2019, 06:44
Fabien created D3272: utils: run commands using utf-8 string on Windows.
Jun 9 2019, 06:43
teamcity added a comment to D3271: add SCRIPTSIGMINPUSHONLY flag and logic.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 9 2019, 05:59
markblundeberg requested review of D3262: Add script tests with valid 64-byte ECDSA signatures..
Jun 9 2019, 05:59
markblundeberg added a revision to T667: add rule for **minimal** push only in scriptSig: D3271: add SCRIPTSIGMINPUSHONLY flag and logic.
Jun 9 2019, 05:51
markblundeberg added a task to D3271: add SCRIPTSIGMINPUSHONLY flag and logic: T667: add rule for **minimal** push only in scriptSig.
Jun 9 2019, 05:51
teamcity added a comment to D3271: add SCRIPTSIGMINPUSHONLY flag and logic.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 9 2019, 05:49
markblundeberg created D3271: add SCRIPTSIGMINPUSHONLY flag and logic.
Jun 9 2019, 05:49
teamcity added a comment to D3270: add CScript::IsMinimalPushOnly.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 9 2019, 05:37
teamcity added a comment to D3270: add CScript::IsMinimalPushOnly.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 9 2019, 05:27
markblundeberg added a comment to D3270: add CScript::IsMinimalPushOnly.

rebuild

Jun 9 2019, 05:27
teamcity added a comment to D3262: Add script tests with valid 64-byte ECDSA signatures..

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 9 2019, 03:18
markblundeberg added a comment to D3270: add CScript::IsMinimalPushOnly.
In D3270#77156, @teamcity wrote:

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Jun 9 2019, 03:18
teamcity added a comment to D3262: Add script tests with valid 64-byte ECDSA signatures..

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 9 2019, 03:11
markblundeberg added a comment to D3262: Add script tests with valid 64-byte ECDSA signatures..

tweak names; add multisig test too

Jun 9 2019, 03:11
teamcity added a comment to D3269: move CheckMinimalPush to script.h.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 9 2019, 02:38
teamcity added a comment to D3268: Increase test coverage on CScript.IsPushOnly().

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 9 2019, 02:35
teamcity added a comment to D3270: add CScript::IsMinimalPushOnly.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Jun 9 2019, 02:30
Harbormaster failed remote builds in B6231: Diff 9269 for D3270: add CScript::IsMinimalPushOnly!
Jun 9 2019, 02:30
markblundeberg added a task to D3270: add CScript::IsMinimalPushOnly: T667: add rule for **minimal** push only in scriptSig.
Jun 9 2019, 02:30
markblundeberg added a revision to T667: add rule for **minimal** push only in scriptSig: D3270: add CScript::IsMinimalPushOnly.
Jun 9 2019, 02:30
markblundeberg added a revision to T667: add rule for **minimal** push only in scriptSig: D3269: move CheckMinimalPush to script.h.
Jun 9 2019, 02:30
markblundeberg added a task to D3269: move CheckMinimalPush to script.h: T667: add rule for **minimal** push only in scriptSig.
Jun 9 2019, 02:30
markblundeberg added a revision to T667: add rule for **minimal** push only in scriptSig: D3268: Increase test coverage on CScript.IsPushOnly().
Jun 9 2019, 02:30
markblundeberg added a task to D3268: Increase test coverage on CScript.IsPushOnly(): T667: add rule for **minimal** push only in scriptSig.
Jun 9 2019, 02:30
teamcity added a comment to D3270: add CScript::IsMinimalPushOnly.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 9 2019, 02:29
markblundeberg created D3270: add CScript::IsMinimalPushOnly.
Jun 9 2019, 02:28
teamcity added a comment to D3269: move CheckMinimalPush to script.h.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 9 2019, 02:27
markblundeberg created D3269: move CheckMinimalPush to script.h.
Jun 9 2019, 02:27
teamcity added a comment to D3268: Increase test coverage on CScript.IsPushOnly().

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 9 2019, 02:27
markblundeberg created D3268: Increase test coverage on CScript.IsPushOnly().
Jun 9 2019, 02:27
teamcity added a comment to D3267: check negative CScriptNum.getint() and introduce new error code.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 9 2019, 00:26
markblundeberg added inline comments to D3267: check negative CScriptNum.getint() and introduce new error code.
Jun 9 2019, 00:23
teamcity added a comment to D3267: check negative CScriptNum.getint() and introduce new error code.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 9 2019, 00:19
markblundeberg updated the summary of D3267: check negative CScriptNum.getint() and introduce new error code.

oops, missed the json tests somehow

Jun 9 2019, 00:19
markblundeberg added a comment to D3266: test NUM2BIN with negative size.

Oopsie nope, this *was* tested already! ( in script_tests.json)

Jun 9 2019, 00:12
markblundeberg planned changes to D3266: test NUM2BIN with negative size.
Jun 9 2019, 00:04
markblundeberg planned changes to D3267: check negative CScriptNum.getint() and introduce new error code.
Jun 9 2019, 00:02

Jun 8 2019

markblundeberg added a comment to D3267: check negative CScriptNum.getint() and introduce new error code.

*sigh* this works on my local machine, I swear! =D

Jun 8 2019, 23:59
Harbormaster failed remote builds in B6227: Diff 9265 for D3267: check negative CScriptNum.getint() and introduce new error code!
Jun 8 2019, 23:57
teamcity added a comment to D3267: check negative CScriptNum.getint() and introduce new error code.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Jun 8 2019, 23:57
teamcity added a comment to D3267: check negative CScriptNum.getint() and introduce new error code.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 8 2019, 23:50
markblundeberg added a comment to D3267: check negative CScriptNum.getint() and introduce new error code.

rebase just to get another build (mystery teamcity fail)

Jun 8 2019, 23:50
First
Prev
Next