Page MenuHomePhabricator
Feed All Stories

All Stories
Use Results
Edit Query

Jun 8 2019

Harbormaster failed remote builds in B6226: Diff 9264 for D3267: check negative CScriptNum.getint() and introduce new error code!
Jun 8 2019, 23:46
teamcity added a comment to D3267: check negative CScriptNum.getint() and introduce new error code.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Jun 8 2019, 23:46
teamcity added a comment to D3266: test NUM2BIN with negative size.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 8 2019, 23:43
markblundeberg updated the summary of D3266: test NUM2BIN with negative size.
Jun 8 2019, 23:39
teamcity added a comment to D3267: check negative CScriptNum.getint() and introduce new error code.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 8 2019, 23:39
markblundeberg created D3267: check negative CScriptNum.getint() and introduce new error code.
Jun 8 2019, 23:39
teamcity added a comment to D3266: test NUM2BIN with negative size.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 8 2019, 23:37
markblundeberg created D3266: test NUM2BIN with negative size.
Jun 8 2019, 23:37
markblundeberg planned changes to D3265: add new encoding checker for Schnorr sigs.
Jun 8 2019, 23:21
Mengerian added inline comments to D3265: add new encoding checker for Schnorr sigs.
Jun 8 2019, 22:14
teamcity added a comment to D3265: add new encoding checker for Schnorr sigs.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 8 2019, 21:57
markblundeberg created T667: add rule for **minimal** push only in scriptSig.
Jun 8 2019, 21:54
teamcity added a comment to D3264: sigencoding_tests: improve test coverage.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 8 2019, 21:52
markblundeberg added a task to D3265: add new encoding checker for Schnorr sigs: T528: Add Schnorr support to OP_CHECKMULTISIG (new mechanics).
Jun 8 2019, 21:50
markblundeberg added a revision to T528: Add Schnorr support to OP_CHECKMULTISIG (new mechanics): D3265: add new encoding checker for Schnorr sigs.
Jun 8 2019, 21:50
markblundeberg planned changes to D3263: add CScriptNum operator>>=.
Jun 8 2019, 21:50
teamcity added a comment to D3265: add new encoding checker for Schnorr sigs.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 8 2019, 21:46
markblundeberg created D3265: add new encoding checker for Schnorr sigs.
Jun 8 2019, 21:46
teamcity added a comment to D3264: sigencoding_tests: improve test coverage.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 8 2019, 21:43
markblundeberg created D3264: sigencoding_tests: improve test coverage.
Jun 8 2019, 21:43
Mengerian added inline comments to D3263: add CScriptNum operator>>=.
Jun 8 2019, 20:44
D3262: Add script tests with valid 64-byte ECDSA signatures. is now accepted and ready to land.

This looks good to me. I played around with this a bit, it all seems to work.

Jun 8 2019, 19:20
teamcity added a comment to D3263: add CScriptNum operator>>=.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 8 2019, 19:06
markblundeberg added a comment to D3232: Avoid spurious boost output in scheduler_tests.

I guess one frustrating thing with assert is that it doesn't throw an exception (just kills program without any information), if it happens that these fail for some reason.

Jun 8 2019, 19:02
markblundeberg added a revision to T528: Add Schnorr support to OP_CHECKMULTISIG (new mechanics): D3263: add CScriptNum operator>>=.
Jun 8 2019, 18:56
markblundeberg added a task to D3263: add CScriptNum operator>>=: T528: Add Schnorr support to OP_CHECKMULTISIG (new mechanics).
Jun 8 2019, 18:56
teamcity added a comment to D3263: add CScriptNum operator>>=.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 8 2019, 18:56
markblundeberg created D3263: add CScriptNum operator>>=.
Jun 8 2019, 18:55
Nico Guiton <nico@bitframe.org> committed rABC5b2a94af2a90: Merge #10560: Remove unused constants (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #10560: Remove unused constants
Jun 8 2019, 17:56
Nico Guiton <nico@bitframe.org> closed D3260: Merge #10560: Remove unused constants.
Jun 8 2019, 17:56
Nico Guiton <nico@bitframe.org> committed rABCf1c98bdf367e: Merge #10524: [tests] Remove printf(...) (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #10524: [tests] Remove printf(...)
Jun 8 2019, 17:48
Nico Guiton <nico@bitframe.org> closed D3259: Merge #10524: [tests] Remove printf(...).
Jun 8 2019, 17:48
Mengerian committed rABC3c56495801af: Update timing.json Segwit Recovery functional test name (authored by Mengerian).
Update timing.json Segwit Recovery functional test name
Jun 8 2019, 17:37
Mengerian closed D3258: Update timing.json Segwit Recovery functional test name.
Jun 8 2019, 17:37
Fabien added inline comments to D3258: Update timing.json Segwit Recovery functional test name.
Jun 8 2019, 15:35
teamcity added a comment to D3258: Update timing.json Segwit Recovery functional test name.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 8 2019, 15:33
teamcity added a comment to D3258: Update timing.json Segwit Recovery functional test name.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 8 2019, 15:27
Mengerian added a comment to D3258: Update timing.json Segwit Recovery functional test name.

Remove added newline

Jun 8 2019, 15:27
markblundeberg updated the summary of D3262: Add script tests with valid 64-byte ECDSA signatures..
Jun 8 2019, 15:26
markblundeberg added a comment to D3253: Remove Schnorr activation.

note: will probably rebase this onto D3262, supposing people are in for that one.

Jun 8 2019, 15:22
markblundeberg added inline comments to D3253: Remove Schnorr activation.
Jun 8 2019, 15:17
markblundeberg added inline comments to D3258: Update timing.json Segwit Recovery functional test name.
Jun 8 2019, 15:17
Mengerian added inline comments to D3258: Update timing.json Segwit Recovery functional test name.
Jun 8 2019, 15:10
markblundeberg added a comment to D3253: Remove Schnorr activation.

IBD successful on both nets.

Jun 8 2019, 15:05
markblundeberg updated the test plan for D3253: Remove Schnorr activation.
Jun 8 2019, 15:05
teamcity added a comment to D3262: Add script tests with valid 64-byte ECDSA signatures..

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 8 2019, 14:29
teamcity added a comment to D3262: Add script tests with valid 64-byte ECDSA signatures..

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 8 2019, 14:27
markblundeberg updated the test plan for D3262: Add script tests with valid 64-byte ECDSA signatures..
Jun 8 2019, 14:19
teamcity added a comment to D3262: Add script tests with valid 64-byte ECDSA signatures..

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 8 2019, 14:16
markblundeberg added a comment to D3262: Add script tests with valid 64-byte ECDSA signatures..

recomment json-gen line

Jun 8 2019, 14:16
teamcity added a comment to D3262: Add script tests with valid 64-byte ECDSA signatures..

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 8 2019, 14:15
markblundeberg created D3262: Add script tests with valid 64-byte ECDSA signatures..
Jun 8 2019, 14:15
D3258: Update timing.json Segwit Recovery functional test name is now accepted and ready to land.
Jun 8 2019, 13:49
Fabien committed rABCd4c2516b74c8: [qa] util: Remove unused sync_chain (authored by MarcoFalke <falke.marco@gmail.com>).
[qa] util: Remove unused sync_chain
Jun 8 2019, 13:47
Fabien closed D3257: [qa] util: Remove unused sync_chain.
Jun 8 2019, 13:47
Mengerian added a comment to D3253: Remove Schnorr activation.

Did another pass over the Diff today, it looks good to me.

Jun 8 2019, 04:17
markblundeberg added inline comments to D3253: Remove Schnorr activation.
Jun 8 2019, 03:05
Mengerian added inline comments to D3253: Remove Schnorr activation.
Jun 8 2019, 03:03
markblundeberg requested review of D3253: Remove Schnorr activation.
Jun 8 2019, 01:42
markblundeberg added a comment to D3253: Remove Schnorr activation.
In D3253#76958, @deadalnix wrote:

There are still a lot of leftovers, like the flags that are passed down to functions that do not need them, the caching layer depending on flags, or the exception tot he banning code for schnorr txns. Not all need to be done in this patch, but this need some battle plan or we'll have a lot of pieces laying around.

Jun 8 2019, 01:41
D3259: Merge #10524: [tests] Remove printf(...) is now accepted and ready to land.
Jun 8 2019, 00:24
D3260: Merge #10560: Remove unused constants is now accepted and ready to land.
Jun 8 2019, 00:23
D3253: Remove Schnorr activation now requires changes to proceed.

There are still a lot of leftovers, like the flags that are passed down to functions that do not need them, the caching layer depending on flags, or the exception tot he banning code for schnorr txns. Not all need to be done in this patch, but this need some battle plan or we'll have a lot of pieces laying around.

Jun 8 2019, 00:23
Nico Guiton <nico@bitframe.org> committed rABC56d39e7dca49: Merge #10568: Remove unnecessary forward class declarations in header files (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Merge #10568: Remove unnecessary forward class declarations in header files
Jun 8 2019, 00:05
Nico Guiton <nico@bitframe.org> closed D3261: Merge #10568: Remove unnecessary forward class declarations in header files.
Jun 8 2019, 00:04

Jun 7 2019

D3261: Merge #10568: Remove unnecessary forward class declarations in header files is now accepted and ready to land.
Jun 7 2019, 21:46
teamcity added a comment to D3261: Merge #10568: Remove unnecessary forward class declarations in header files.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 7 2019, 21:21
teamcity added a comment to D3261: Merge #10568: Remove unnecessary forward class declarations in header files.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 7 2019, 21:11
nakihito created D3261: Merge #10568: Remove unnecessary forward class declarations in header files.
Jun 7 2019, 21:11
markblundeberg added inline comments to D3254: Revert "add flags to VerifySignature and sigcache".
Jun 7 2019, 20:15
teamcity added a comment to D3260: Merge #10560: Remove unused constants.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 7 2019, 20:02
teamcity added a comment to D3260: Merge #10560: Remove unused constants.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 7 2019, 19:52
nakihito created D3260: Merge #10560: Remove unused constants.
Jun 7 2019, 19:52
teamcity added a comment to D3259: Merge #10524: [tests] Remove printf(...).

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 7 2019, 19:44
teamcity added a comment to D3259: Merge #10524: [tests] Remove printf(...).

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 7 2019, 19:33
nakihito created D3259: Merge #10524: [tests] Remove printf(...).
Jun 7 2019, 19:33
teamcity added a comment to D3258: Update timing.json Segwit Recovery functional test name.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 7 2019, 19:15
teamcity added a comment to D3258: Update timing.json Segwit Recovery functional test name.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 7 2019, 19:04
Mengerian created D3258: Update timing.json Segwit Recovery functional test name.
Jun 7 2019, 19:04
Nico Guiton <nico@bitframe.org> committed rABC52f1bcc8c711: Merge #9909: tests: Add FindEarliestAtLeast test for edge cases (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #9909: tests: Add FindEarliestAtLeast test for edge cases
Jun 7 2019, 18:18
Nico Guiton <nico@bitframe.org> closed D3244: Merge #9909: tests: Add FindEarliestAtLeast test for edge cases.
Jun 7 2019, 18:18
D3257: [qa] util: Remove unused sync_chain is now accepted and ready to land.
Jun 7 2019, 17:47
jasonbcox added inline comments to D3254: Revert "add flags to VerifySignature and sigcache".
Jun 7 2019, 17:45
Nico Guiton <nico@bitframe.org> committed rABCd8adeb047da6: Merge #10522: [wallet] Remove unused variables (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #10522: [wallet] Remove unused variables
Jun 7 2019, 17:44
Nico Guiton <nico@bitframe.org> closed D3247: Merge #10522: [wallet] Remove unused variables.
Jun 7 2019, 17:44
jasonbcox committed rABCb651d377ebbb: Merge #11198: [Qt] Fix display of package name on 'open config file' tooltip (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #11198: [Qt] Fix display of package name on 'open config file' tooltip
Jun 7 2019, 17:29
jasonbcox closed D3220: Merge #11198: [Qt] Fix display of package name on 'open config file' tooltip.
Jun 7 2019, 17:29
jasonbcox committed rABC76041fb6f529: Merge #9890: Add a button to open the config file in a text editor (authored by Jonas Schnelli <dev@jonasschnelli.ch>).
Merge #9890: Add a button to open the config file in a text editor
Jun 7 2019, 17:23
jasonbcox closed D3219: Merge #9890: Add a button to open the config file in a text editor.
Jun 7 2019, 17:23
jasonbcox committed rABC24e8d0a5b2c3: Cleanup remaining boost includes (authored by jasonbcox).
Cleanup remaining boost includes
Jun 7 2019, 17:21
jasonbcox closed D3242: Cleanup remaining boost includes.
Jun 7 2019, 17:21
jasonbcox committed rABC9581a13b2008: Merge #13877: utils: Make fs::path::string() always return utf-8 string on… (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #13877: utils: Make fs::path::string() always return utf-8 string on…
Jun 7 2019, 17:21
jasonbcox closed D3241: Merge #13877: utils: Make fs::path::string() always return utf-8 string on Windows.
Jun 7 2019, 17:20
Fabien updated the summary of D3217: [LINTER] Add a spell checker to arcanist.
Jun 7 2019, 17:16
D3217: [LINTER] Add a spell checker to arcanist is now accepted and ready to land.
Jun 7 2019, 17:14
teamcity added a comment to D3257: [qa] util: Remove unused sync_chain.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 7 2019, 15:37
teamcity added a comment to D3256: Fix make distcheck.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 7 2019, 15:30
teamcity added a comment to D3253: Remove Schnorr activation.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 7 2019, 15:28
teamcity added a comment to D3257: [qa] util: Remove unused sync_chain.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 7 2019, 15:26
Fabien created D3257: [qa] util: Remove unused sync_chain.
Jun 7 2019, 15:26
First
Prev
Next