Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Jun 10 2019
Jun 10 2019
D3278: Merge #10536: Remove unreachable or otherwise redundant code is now accepted and ready to land.
D3268: Increase test coverage on CScript.IsPushOnly() now requires changes to proceed.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Changes to bitcoin-tx.cpp removed here:
https://reviews.bitcoinabc.org/D540
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
teamcity added a comment to D3282: Merge #10177: Changed "Send" button default status from true to false.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
jasonbcox requested review of D3282: Merge #10177: Changed "Send" button default status from true to false.
jasonbcox updated the test plan for D3282: Merge #10177: Changed "Send" button default status from true to false.
Fabien committed rABC3263031e7f50: [tests] Better stderr testing (authored by John Newbery <john@johnnewbery.com>).
[tests] Better stderr testing
Jun 10 2019, 21:25 · Restricted Project
Fabien closed T540: Backport Core PR12755, a subtask of T650: Backport Core PR 13197 "util: warn about ignored recursive -includeconf calls", as Resolved.
Fabien closed T540: Backport Core PR12755 as Resolved by committing rABC3263031e7f50: [tests] Better stderr testing.
Jun 10 2019, 21:24 · Restricted Project
teamcity added a comment to D3282: Merge #10177: Changed "Send" button default status from true to false.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Fabien committed rABCc0cfdb0c647a: qa: Normalize executable location (authored by MarcoFalke <falke.marco@gmail.com>).
qa: Normalize executable location
Fabien committed rABC87ff2706705c: Avoid unintentional unsigned integer wraparounds in tests (authored by practicalswift <practicalswift@users.noreply.github.com>).
Avoid unintentional unsigned integer wraparounds in tests
Fabien committed rABC838fd7ecc61d: [tests] Use FastRandomContext instead of boost::random::* (authored by practicalswift <practicalswift@users.noreply.github.com>).
[tests] Use FastRandomContext instead of boost::random::*
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Fabien committed rABC3a0a0966a1d1: Don't assert(...) with side effects (authored by practicalswift <practicalswift@users.noreply.github.com>).
Don't assert(...) with side effects
D3273: qa: Normalize executable location is now accepted and ready to land.
jasonbcox updated the test plan for D3281: Merge #10090: Update bitcoin.conf with example for pruning.
jasonbcox updated the test plan for D3281: Merge #10090: Update bitcoin.conf with example for pruning.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
markblundeberg added a comment to D3279: Merge #9350: [Trivial] Adding label for amount inside of tx_valid/tx_invalid.json.
Hmm looks like transaction_tests.cpp (e.g., BOOST_AUTO_TEST_CASE(tx_invalid) comment) needs to be updated as well.
jasonbcox updated the test plan for D3281: Merge #10090: Update bitcoin.conf with example for pruning.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
teamcity added a comment to D3279: Merge #9350: [Trivial] Adding label for amount inside of tx_valid/tx_invalid.json.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
teamcity added a comment to D3279: Merge #9350: [Trivial] Adding label for amount inside of tx_valid/tx_invalid.json.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Rebase and update error message.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Fix exception message.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
markblundeberg updated the task description for T667: add rule for **minimal** push only in scriptSig.
markblundeberg updated the task description for T667: add rule for **minimal** push only in scriptSig.
markblundeberg updated the task description for T667: add rule for **minimal** push only in scriptSig.
markblundeberg updated the task description for T667: add rule for **minimal** push only in scriptSig.
markblundeberg updated the task description for T667: add rule for **minimal** push only in scriptSig.
markblundeberg updated the task description for T667: add rule for **minimal** push only in scriptSig.
In D3270#77358, @jasonbcox wrote:Needs a summary. What's the goal here?
markblundeberg updated the task description for T667: add rule for **minimal** push only in scriptSig.
D3270: add CScript::IsMinimalPushOnly now requires changes to proceed.
Needs a summary. What's the goal here?
D3273: qa: Normalize executable location now requires changes to proceed.
D3274: [tests] Better stderr testing is now accepted and ready to land.
D3269: move CheckMinimalPush to script.h now requires changes to proceed.
While mildly useful, I don't think we should be making changes like this until backports are up-to-date.
D3276: Avoid unintentional unsigned integer wraparounds in tests is now accepted and ready to land.
D3275: [tests] Use FastRandomContext instead of boost::random::* is now accepted and ready to land.
D3277: Don't assert(...) with side effects is now accepted and ready to land.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.
Address feedback + minor improvements.
No SSH setup yet.
[LINTER] Add a spell checker to arcanist
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.
Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.