Page MenuHomePhabricator
Feed All Stories

Nov 17 2019

deadalnix accepted D4437: [CMAKE] Only build the bitcoin-qt application bundle on OSX.
Nov 17 2019, 22:44
teamcity added a comment to D4424: Add outputtype module.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 17 2019, 22:29
teamcity added a comment to D4424: Add outputtype module.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 17 2019, 22:29
teamcity added a comment to D4424: Add outputtype module.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 17 2019, 22:19
teamcity added a comment to D4424: Add outputtype module.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 17 2019, 22:19
deadalnix updated the diff for D4424: Add outputtype module.

Add spaces

Nov 17 2019, 22:19
deadalnix requested changes to D4025: Added empty block fallback to CreateNewBlock.

I don't think the design here is sound. You don't have an error boundary set anywhere, but a parameter that you pass down to ask what's downstream to not error out. This is not solid. The whole point of the maneuver is to not trust what downstream of the error boundary.

Nov 17 2019, 22:01
teamcity added a comment to D4457: Fix merging of global unknown data in PSBTs.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 17 2019, 17:58
teamcity added a comment to D4457: Fix merging of global unknown data in PSBTs.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 17 2019, 17:58
teamcity added a comment to D4457: Fix merging of global unknown data in PSBTs.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 17 2019, 17:47
teamcity added a comment to D4457: Fix merging of global unknown data in PSBTs.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 17 2019, 17:47
deadalnix created D4457: Fix merging of global unknown data in PSBTs.
Nov 17 2019, 17:46
teamcity added a comment to D4456: Check that PSBT keys are the correct length.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 17 2019, 17:44
teamcity added a comment to D4456: Check that PSBT keys are the correct length.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 17 2019, 17:44
teamcity added a comment to D4456: Check that PSBT keys are the correct length.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 17 2019, 17:33
teamcity added a comment to D4456: Check that PSBT keys are the correct length.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 17 2019, 17:33
deadalnix created D4456: Check that PSBT keys are the correct length.
Nov 17 2019, 17:33
markblundeberg added inline comments to D4455: add a couple more Schnorr checkmultisig tests.
Nov 17 2019, 02:25
teamcity added a comment to D4455: add a couple more Schnorr checkmultisig tests.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 17 2019, 02:21
teamcity added a comment to D4455: add a couple more Schnorr checkmultisig tests.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 17 2019, 02:21
teamcity added a comment to D4455: add a couple more Schnorr checkmultisig tests.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 17 2019, 02:12
teamcity added a comment to D4455: add a couple more Schnorr checkmultisig tests.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 17 2019, 02:12
markblundeberg created D4455: add a couple more Schnorr checkmultisig tests.
Nov 17 2019, 02:11
teamcity added a comment to D4454: Fix PSBT error test vectors.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 17 2019, 00:32
teamcity added a comment to D4454: Fix PSBT error test vectors.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 17 2019, 00:32
teamcity added a comment to D4454: Fix PSBT error test vectors.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 17 2019, 00:23
teamcity added a comment to D4454: Fix PSBT error test vectors.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 17 2019, 00:23
deadalnix created D4454: Fix PSBT error test vectors.
Nov 17 2019, 00:23

Nov 16 2019

Fabien added inline comments to D4424: Add outputtype module.
Nov 16 2019, 22:10
deadalnix added inline comments to D4424: Add outputtype module.
Nov 16 2019, 14:46
teamcity added a comment to D4424: Add outputtype module.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 16 2019, 13:48
teamcity added a comment to D4424: Add outputtype module.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 16 2019, 13:48
teamcity added a comment to D4424: Add outputtype module.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 16 2019, 13:38
teamcity added a comment to D4424: Add outputtype module.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 16 2019, 13:38
deadalnix updated the diff for D4424: Add outputtype module.

Address comments

Nov 16 2019, 13:37

Nov 15 2019

Nico Guiton <nico@bitframe.org> committed rABCf2206f5e5660: Merge #14025: p2p: Remove dead code for nVersion=10300 (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #14025: p2p: Remove dead code for nVersion=10300
Nov 15 2019, 22:50
Nico Guiton <nico@bitframe.org> closed D4449: Merge #14025: p2p: Remove dead code for nVersion=10300.
Nov 15 2019, 22:49
deadalnix accepted D4449: Merge #14025: p2p: Remove dead code for nVersion=10300.
Nov 15 2019, 22:11
teamcity added a comment to D4452: Add checkpoints for graviton upgrade.

Build Bitcoin-ABC / Resource Intensive Builds / Resource Intensive Diff Testing passed.

Nov 15 2019, 21:16
teamcity added a comment to D4452: Add checkpoints for graviton upgrade.

Build Bitcoin-ABC / Resource Intensive Builds / Resource Intensive Diff Testing passed.

Nov 15 2019, 21:16
nakihito added inline comments to D4439: Allow Seeder to handle receiving HEADER messages.
Nov 15 2019, 20:41
nakihito added inline comments to D4442: Seeder bans nodes not following the correct chain.
Nov 15 2019, 20:32
teamcity added a comment to D4439: Allow Seeder to handle receiving HEADER messages.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 15 2019, 20:29
teamcity added a comment to D4439: Allow Seeder to handle receiving HEADER messages.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 15 2019, 20:29
teamcity added a comment to D4442: Seeder bans nodes not following the correct chain.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 15 2019, 20:26
teamcity added a comment to D4442: Seeder bans nodes not following the correct chain.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 15 2019, 20:26
teamcity added a comment to D4439: Allow Seeder to handle receiving HEADER messages.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 15 2019, 20:19
teamcity added a comment to D4439: Allow Seeder to handle receiving HEADER messages.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 15 2019, 20:19
nakihito updated the diff for D4439: Allow Seeder to handle receiving HEADER messages.

Rebase.

Nov 15 2019, 20:19
teamcity added a comment to D4442: Seeder bans nodes not following the correct chain.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 15 2019, 20:16
teamcity added a comment to D4442: Seeder bans nodes not following the correct chain.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 15 2019, 20:16
nakihito updated the diff for D4442: Seeder bans nodes not following the correct chain.

Updated release notes, rebased, and renamed some functions.

Nov 15 2019, 20:16
nakihito updated the test plan for D4442: Seeder bans nodes not following the correct chain.
Nov 15 2019, 20:11
teamcity added a comment to D4436: Add unit tests for CSeederNode::ProcessMessage().

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 15 2019, 19:32
teamcity added a comment to D4436: Add unit tests for CSeederNode::ProcessMessage().

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 15 2019, 19:32
teamcity added a comment to D4436: Add unit tests for CSeederNode::ProcessMessage().

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 15 2019, 19:23
teamcity added a comment to D4436: Add unit tests for CSeederNode::ProcessMessage().

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 15 2019, 19:23
nakihito updated the diff for D4436: Add unit tests for CSeederNode::ProcessMessage().

Removed test after rebase on D4449's changes and fixed comment typo.

Nov 15 2019, 19:23
teamcity added a comment to D4452: Add checkpoints for graviton upgrade.

Build Bitcoin-ABC / Resource Intensive Builds / Resource Intensive Diff Testing passed.

Nov 15 2019, 19:20
teamcity added a comment to D4452: Add checkpoints for graviton upgrade.

Build Bitcoin-ABC / Resource Intensive Builds / Resource Intensive Diff Testing passed.

Nov 15 2019, 19:20
teamcity added a comment to D4418: Add simple unit tests for parse_name().

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 15 2019, 18:59
teamcity added a comment to D4418: Add simple unit tests for parse_name().

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 15 2019, 18:59
jasonbcox accepted D4418: Add simple unit tests for parse_name().
Nov 15 2019, 18:51
teamcity added a comment to D4418: Add simple unit tests for parse_name().

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 15 2019, 18:50
teamcity added a comment to D4418: Add simple unit tests for parse_name().

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 15 2019, 18:50
teamcity added a comment to D4418: Add simple unit tests for parse_name().

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 15 2019, 18:47
teamcity added a comment to D4418: Add simple unit tests for parse_name().

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 15 2019, 18:46
teamcity added a comment to D4418: Add simple unit tests for parse_name().

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 15 2019, 18:38
teamcity added a comment to D4418: Add simple unit tests for parse_name().

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 15 2019, 18:38
teamcity added a comment to D4418: Add simple unit tests for parse_name().

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Nov 15 2019, 18:36
Harbormaster failed remote builds in B8130: Diff 14154 for D4418: Add simple unit tests for parse_name()!
Nov 15 2019, 18:36
teamcity added a comment to D4418: Add simple unit tests for parse_name().

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Nov 15 2019, 18:36
teamcity added a comment to D4418: Add simple unit tests for parse_name().

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 15 2019, 18:31
teamcity added a comment to D4418: Add simple unit tests for parse_name().

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 15 2019, 18:31
nakihito updated the diff for D4418: Add simple unit tests for parse_name().

Fixed nit.

Nov 15 2019, 18:31
jasonbcox requested changes to D4418: Add simple unit tests for parse_name().
Nov 15 2019, 18:27
teamcity added a comment to D4418: Add simple unit tests for parse_name().

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 15 2019, 17:34
teamcity added a comment to D4418: Add simple unit tests for parse_name().

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 15 2019, 17:34
nakihito planned changes to D4436: Add unit tests for CSeederNode::ProcessMessage().
Nov 15 2019, 17:30
teamcity added a comment to D4418: Add simple unit tests for parse_name().

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 15 2019, 17:25
teamcity added a comment to D4418: Add simple unit tests for parse_name().

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 15 2019, 17:25
nakihito updated the diff for D4418: Add simple unit tests for parse_name().

Fixed typos.

Nov 15 2019, 17:25
jasonbcox requested changes to D4418: Add simple unit tests for parse_name().
Nov 15 2019, 17:17
jasonbcox accepted D4449: Merge #14025: p2p: Remove dead code for nVersion=10300.
Nov 15 2019, 17:14
jasonbcox requested changes to D4453: [CI] Remove functional tests with graviton activation.

I think it would be better to replace this with the next upgrade, even if it does nothing for now. Otherwise, we have to re-implement this later.

Nov 15 2019, 17:12
teamcity added a comment to D4453: [CI] Remove functional tests with graviton activation.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 15 2019, 17:10
teamcity added a comment to D4453: [CI] Remove functional tests with graviton activation.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 15 2019, 17:10
teamcity added a comment to D4453: [CI] Remove functional tests with graviton activation.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 15 2019, 17:04
teamcity added a comment to D4453: [CI] Remove functional tests with graviton activation.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 15 2019, 17:04
Fabien created D4453: [CI] Remove functional tests with graviton activation.
Nov 15 2019, 17:04
teamcity added a comment to D4449: Merge #14025: p2p: Remove dead code for nVersion=10300.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 15 2019, 15:23
teamcity added a comment to D4449: Merge #14025: p2p: Remove dead code for nVersion=10300.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 15 2019, 15:23
teamcity added a comment to D4449: Merge #14025: p2p: Remove dead code for nVersion=10300.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 15 2019, 15:14
teamcity added a comment to D4449: Merge #14025: p2p: Remove dead code for nVersion=10300.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Nov 15 2019, 15:14
nakihito updated the diff for D4449: Merge #14025: p2p: Remove dead code for nVersion=10300.

Removed some more obsolete code from the seeder.

Nov 15 2019, 15:13
teamcity added a comment to D4452: Add checkpoints for graviton upgrade.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 15 2019, 15:08
teamcity added a comment to D4452: Add checkpoints for graviton upgrade.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Nov 15 2019, 15:08
markblundeberg added inline comments to D4452: Add checkpoints for graviton upgrade.
Nov 15 2019, 15:02
Fabien accepted D4452: Add checkpoints for graviton upgrade.
Nov 15 2019, 15:02
teamcity added a comment to D4452: Add checkpoints for graviton upgrade.

Build Bitcoin-ABC / Resource Intensive Builds / Resource Intensive Diff Testing started.

Nov 15 2019, 15:00