Page MenuHomePhabricator
Feed All Stories

Jan 22 2021

PiRK requested review of D9022: test: fix intermittent mempool_unbroadcast txn-mempool-conflict.
Jan 22 2021, 02:32
PiRK planned changes to D9024: [rpc] add unbroadcast info to mempool entries and getmempoolinfo.
Jan 22 2021, 02:31
teamcity added a comment to D9026: [test] wait for inital broadcast before comparing mempool entries.
Jan 22 2021, 02:31
PiRK planned changes to D9025: [mempool] sanity check that all unbroadcast txns are in mempool.
Jan 22 2021, 02:31
PiRK planned changes to D9026: [test] wait for inital broadcast before comparing mempool entries.
Jan 22 2021, 02:31
PiRK planned changes to D9023: wallet] remove nLastResend logic.
Jan 22 2021, 02:30
PiRK planned changes to D9022: test: fix intermittent mempool_unbroadcast txn-mempool-conflict.
Jan 22 2021, 02:30
teamcity added a comment to D9025: [mempool] sanity check that all unbroadcast txns are in mempool.
Jan 22 2021, 02:29
teamcity added a comment to D9025: [mempool] sanity check that all unbroadcast txns are in mempool.
Jan 22 2021, 02:25
teamcity added a comment to D9024: [rpc] add unbroadcast info to mempool entries and getmempoolinfo.
Jan 22 2021, 02:17
teamcity updated the summary of D9026: [test] wait for inital broadcast before comparing mempool entries.
Jan 22 2021, 02:12
PiRK requested review of D9026: [test] wait for inital broadcast before comparing mempool entries.
Jan 22 2021, 02:12
teamcity updated the summary of D9025: [mempool] sanity check that all unbroadcast txns are in mempool.
Jan 22 2021, 02:08
PiRK requested review of D9025: [mempool] sanity check that all unbroadcast txns are in mempool.
Jan 22 2021, 02:08
teamcity updated the summary of D9024: [rpc] add unbroadcast info to mempool entries and getmempoolinfo.
Jan 22 2021, 02:06
PiRK requested review of D9024: [rpc] add unbroadcast info to mempool entries and getmempoolinfo.
Jan 22 2021, 02:06
teamcity updated the summary of D9023: wallet] remove nLastResend logic.
Jan 22 2021, 02:03
PiRK requested review of D9023: wallet] remove nLastResend logic.
Jan 22 2021, 02:03
PiRK requested review of D9022: test: fix intermittent mempool_unbroadcast txn-mempool-conflict.
Jan 22 2021, 01:33
teamcity added a comment to D9020: [CashAddr] deprecate legacy prefixes maintaining backwards compatibility.
Jan 22 2021, 00:40
majcosta updated the diff for D9020: [CashAddr] deprecate legacy prefixes maintaining backwards compatibility.

fix missing braces error for gcc-8

Jan 22 2021, 00:34
majcosta planned changes to D9020: [CashAddr] deprecate legacy prefixes maintaining backwards compatibility.
Jan 22 2021, 00:10

Jan 21 2021

bytesofman requested review of D9021: [Cashtab] Add unit tests for send BCHA amount validation.
Jan 21 2021, 22:01
teamcity added a comment to D9020: [CashAddr] deprecate legacy prefixes maintaining backwards compatibility.
Jan 21 2021, 21:55
teamcity added a comment to D9020: [CashAddr] deprecate legacy prefixes maintaining backwards compatibility.
Jan 21 2021, 21:55
teamcity added a comment to D9020: [CashAddr] deprecate legacy prefixes maintaining backwards compatibility.
Jan 21 2021, 21:53
majcosta requested review of D9020: [CashAddr] deprecate legacy prefixes maintaining backwards compatibility.
Jan 21 2021, 21:52
majcosta updated the diff for D8692: [CashAddr] replace bitcoincash: prefix with ecash: in the node.

removed the last backward compatibility tests I missed the first time around.

Jan 21 2021, 21:36
majcosta planned changes to D8692: [CashAddr] replace bitcoincash: prefix with ecash: in the node.

missed some stuff in tests

Jan 21 2021, 21:22
majcosta updated the summary of D8692: [CashAddr] replace bitcoincash: prefix with ecash: in the node.
Jan 21 2021, 21:21
majcosta updated the diff for D8692: [CashAddr] replace bitcoincash: prefix with ecash: in the node.

cut all backwards compatibility changes from the patch, this is a pure prefix change now.

Jan 21 2021, 21:20
bytesofman planned changes to D9019: [Cashtab] Convert BCHA send form validation to use BigNumber.js.

Cashtab does not have unit tests for these validation functions, will create some to support this change.

Jan 21 2021, 21:13
bytesofman requested review of D9019: [Cashtab] Convert BCHA send form validation to use BigNumber.js.
Jan 21 2021, 21:01
teamcity triaged T1464: Build Bitcoin-ABC / Master / Sanitizers / Undefined Behavior Sanitizer (UBSAN) is broken. as Unbreak Now! priority.
Jan 21 2021, 20:55
deadalnix accepted D9017: script: prevent UB when computing abs value for num opcode serialize.
Jan 21 2021, 20:52
deadalnix accepted D8942: [net_processing] Pass chainparams to PeerLogicValidation constructor.
Jan 21 2021, 20:51
Joey King <joseph.roy.king@gmail.com> closed D9018: [Cashtab] Reject transactions lower than backend dust limit.
Jan 21 2021, 20:38
Joey King <joseph.roy.king@gmail.com> committed rABC0a34961f68bd: [Cashtab] Reject transactions lower than backend dust limit (authored by Joey King <joseph.roy.king@gmail.com>).
[Cashtab] Reject transactions lower than backend dust limit
Jan 21 2021, 20:38
Fabien accepted D9018: [Cashtab] Reject transactions lower than backend dust limit.
Jan 21 2021, 20:37
bytesofman added a comment to D9018: [Cashtab] Reject transactions lower than backend dust limit.

The figure 0.00000546 is the dust limit of the bch-api backend. If the app attempts to broadcast a transaction sending less then 0.00000546 BCHA, an error will be returned from the API. These hard coded 546-sat figures will be replaced by currency.ticker once the app sending limit is brought in line with the backend limit in a future diff.

Jan 21 2021, 20:24
bytesofman requested review of D9018: [Cashtab] Reject transactions lower than backend dust limit.
Jan 21 2021, 20:11
Fabien requested changes to D9016: [Cashtab] Set dust param to minimum accepted by backend.

This diff is actually doing several things at a time. Splitting it into pieces and stack them will make the review easier and will help getting this landed faster.

Jan 21 2021, 19:52
teamcity closed T1463: Build Bitcoin-ABC / Master / Make Generator is broken. as Resolved.
Jan 21 2021, 19:36
PiRK closed D9012: [mempool] Persist unbroadcast set to mempool.dat.
Jan 21 2021, 19:20
PiRK committed rABCad4cfa37da85: [mempool] Persist unbroadcast set to mempool.dat (authored by Amiti Uttarwar <amiti@uttarwar.org>).
[mempool] Persist unbroadcast set to mempool.dat
Jan 21 2021, 19:20
teamcity triaged T1463: Build Bitcoin-ABC / Master / Make Generator is broken. as Unbreak Now! priority.
Jan 21 2021, 18:24
Fabien updated the diff for D8942: [net_processing] Pass chainparams to PeerLogicValidation constructor.

Rebase

Jan 21 2021, 18:16
deadalnix requested changes to D8942: [net_processing] Pass chainparams to PeerLogicValidation constructor.

Back to your queue due to test failures.

Jan 21 2021, 18:12
bytesofman updated the diff for D9016: [Cashtab] Set dust param to minimum accepted by backend.

Remove debug logging

Jan 21 2021, 18:08
PiRK closed D9011: [test] Integration tests for unbroadcast functionality.
Jan 21 2021, 18:05
PiRK committed rABC0462bb493d52: [test] Integration tests for unbroadcast functionality (authored by Amiti Uttarwar <amiti@uttarwar.org>).
[test] Integration tests for unbroadcast functionality
Jan 21 2021, 18:05
bytesofman updated the diff for D9016: [Cashtab] Set dust param to minimum accepted by backend.

Add unit test for dust limit, add catch for dust to sendBCH function as dust error comes from server, implement BigNumber for dust constant

Jan 21 2021, 18:05
PiRK accepted D9014: test: Add fuzzing harnesses for various classes/functions in primitives/.
Jan 21 2021, 18:02
PiRK accepted D9013: fuzz: Remove enumeration of expected deserialization exceptions in ProcessMessage(...) fuzzer.
Jan 21 2021, 18:00
PiRK closed D9010: [refactor/test] Extract P2PTxInvStore into test framework.
Jan 21 2021, 17:46
PiRK committed rABC1167285f9107: [refactor/test] Extract P2PTxInvStore into test framework (authored by Amiti Uttarwar <amiti@uttarwar.org>).
[refactor/test] Extract P2PTxInvStore into test framework
Jan 21 2021, 17:46
Fabien requested changes to D9016: [Cashtab] Set dust param to minimum accepted by backend.

The test plan would benefit from being a unit test

Jan 21 2021, 17:38
PiRK closed D9009: [wallet] Update the rebroadcast frequency to be ~1/day..
Jan 21 2021, 17:31
PiRK committed rABC232939a30114: [wallet] Update the rebroadcast frequency to be ~1/day. (authored by Amiti Uttarwar <amiti@uttarwar.org>).
[wallet] Update the rebroadcast frequency to be ~1/day.
Jan 21 2021, 17:31
PiRK closed D9008: [p2p] Reattempt initial send of unbroadcast transactions.
Jan 21 2021, 17:08
PiRK committed rABC0ea659532280: [p2p] Reattempt initial send of unbroadcast transactions (authored by Amiti Uttarwar <amiti@uttarwar.org>).
[p2p] Reattempt initial send of unbroadcast transactions
Jan 21 2021, 17:08
Mengerian closed D8995: [website] Add ViaWallet explorer to site.
Jan 21 2021, 17:06
Mengerian committed rABCWEB746176b17fd7: [website] Add ViaWallet explorer to site (authored by Mengerian).
[website] Add ViaWallet explorer to site
Jan 21 2021, 17:06
Mengerian closed D8996: [website] Remove Bitcoin Cash from project description.
Jan 21 2021, 17:05
Mengerian committed rABCWEB9076103c0cf4: [website] Remove Bitcoin Cash from project description (authored by Mengerian).
[website] Remove Bitcoin Cash from project description
Jan 21 2021, 17:05
PiRK closed D9007: [util] Add method that returns random time in milliseconds.
Jan 21 2021, 16:59
PiRK committed rABC9a88bcf4618e: [util] Add method that returns random time in milliseconds (authored by Amiti Uttarwar <amiti@uttarwar.org>).
[util] Add method that returns random time in milliseconds
Jan 21 2021, 16:58
teamcity updated the summary of D9017: script: prevent UB when computing abs value for num opcode serialize.
Jan 21 2021, 16:02
Fabien requested review of D9017: script: prevent UB when computing abs value for num opcode serialize.
Jan 21 2021, 16:01
bytesofman requested review of D9016: [Cashtab] Set dust param to minimum accepted by backend.
Jan 21 2021, 15:45
teamcity updated the summary of D9015: test: Add fuzzing harnesses for various classes/functions in util/.
Jan 21 2021, 15:33
Fabien requested review of D9015: test: Add fuzzing harnesses for various classes/functions in util/.
Jan 21 2021, 15:33
teamcity closed T1462: Build Bitcoin-ABC / Master / Sanitizers / Thread Sanitizer (TSAN) is broken. as Resolved.
Jan 21 2021, 15:03
teamcity updated the summary of D9014: test: Add fuzzing harnesses for various classes/functions in primitives/.
Jan 21 2021, 14:55
Fabien requested review of D9014: test: Add fuzzing harnesses for various classes/functions in primitives/.
Jan 21 2021, 14:55
PiRK closed D9006: [mempool] Track "unbroadcast" transactions.
Jan 21 2021, 14:43
PiRK committed rABC674a222fdbab: [mempool] Track "unbroadcast" transactions (authored by Amiti Uttarwar <amiti@uttarwar.org>).
[mempool] Track "unbroadcast" transactions
Jan 21 2021, 14:43
teamcity triaged T1462: Build Bitcoin-ABC / Master / Sanitizers / Thread Sanitizer (TSAN) is broken. as Unbreak Now! priority.
Jan 21 2021, 14:35
teamcity updated the summary of D9013: fuzz: Remove enumeration of expected deserialization exceptions in ProcessMessage(...) fuzzer.
Jan 21 2021, 14:21
Fabien requested review of D9013: fuzz: Remove enumeration of expected deserialization exceptions in ProcessMessage(...) fuzzer.
Jan 21 2021, 14:21
Fabien closed D9005: tests: Add fuzzing harness for Golomb-Rice coding (GolombRiceEncode/GolombRiceDecode).
Jan 21 2021, 14:10
Fabien committed rABCe7c737ed6f1f: tests: Add fuzzing harness for Golomb-Rice coding… (authored by practicalswift <practicalswift@users.noreply.github.com>).
tests: Add fuzzing harness for Golomb-Rice coding…
Jan 21 2021, 14:09
Fabien closed D9004: fuzz: fix unused variable compiler warning.
Jan 21 2021, 14:09
Fabien committed rABCb8d4c2553d0e: fuzz: fix unused variable compiler warning (authored by Jon Atack <jon@atack.com>).
fuzz: fix unused variable compiler warning
Jan 21 2021, 14:09
Fabien closed D9003: Add fuzzer version of randomized prevector test.
Jan 21 2021, 14:08
Fabien committed rABC3c8f5fb298a5: Add fuzzer version of randomized prevector test (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Add fuzzer version of randomized prevector test
Jan 21 2021, 14:08
Fabien closed D9002: tests: Avoid fuzzer-specific nullptr dereference in libevent when handling PROXY requests.
Jan 21 2021, 14:07
Fabien committed rABCdafd2b7224b5: tests: Avoid fuzzer-specific nullptr dereference in libevent when handling… (authored by practicalswift <practicalswift@users.noreply.github.com>).
tests: Avoid fuzzer-specific nullptr dereference in libevent when handling…
Jan 21 2021, 14:07
Fabien closed D9001: fuzz: http_request workaround for libevent < 2.1.1.
Jan 21 2021, 14:07
Fabien committed rABC1684b6761b2b: fuzz: http_request workaround for libevent < 2.1.1 (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>).
fuzz: http_request workaround for libevent < 2.1.1
Jan 21 2021, 14:07
Fabien closed D9000: tests: Add fuzzing harness for HTTPRequest, libevent's evhttp and related functions.
Jan 21 2021, 14:06
Fabien committed rABC8ce1ab436912: tests: Add fuzzing harness for HTTPRequest, libevent's evhttp and related… (authored by practicalswift <practicalswift@users.noreply.github.com>).
tests: Add fuzzing harness for HTTPRequest, libevent's evhttp and related…
Jan 21 2021, 14:06
majcosta accepted D9009: [wallet] Update the rebroadcast frequency to be ~1/day..
Jan 21 2021, 13:53
majcosta accepted D9012: [mempool] Persist unbroadcast set to mempool.dat.

discussed off Phab, the wait_until import should be removed in PR19752

Jan 21 2021, 13:53
PiRK updated the diff for D9012: [mempool] Persist unbroadcast set to mempool.dat.

put a comment on its own line

Jan 21 2021, 13:50
majcosta accepted D9006: [mempool] Track "unbroadcast" transactions.
Jan 21 2021, 13:49
majcosta requested changes to D9012: [mempool] Persist unbroadcast set to mempool.dat.
Jan 21 2021, 13:39
PiRK updated the summary of D9011: [test] Integration tests for unbroadcast functionality.
Jan 21 2021, 13:35
majcosta accepted D9011: [test] Integration tests for unbroadcast functionality.
Jan 21 2021, 13:35
PiRK updated the summary of D9011: [test] Integration tests for unbroadcast functionality.
Jan 21 2021, 13:35