Page MenuHomePhabricator
Feed All Stories

Jun 3 2021

Fabien updated the diff for D9582: [avalanche] Answer proof invs with getdata proof requests.

Revert the empty line change in init.cpp

Jun 3 2021, 15:50
deadalnix requested changes to D9582: [avalanche] Answer proof invs with getdata proof requests.
Jun 3 2021, 15:42
PiRK closed D9622: rpc: remove deprecated getaddressinfo fields.
Jun 3 2021, 15:40
PiRK committed rABC5f4b8a11f74d: rpc: remove deprecated getaddressinfo fields (authored by Jon Atack <jon@atack.com>).
rpc: remove deprecated getaddressinfo fields
Jun 3 2021, 15:39
PiRK accepted D9623: Remove wallet related constant from the mining util test lib.
Jun 3 2021, 15:39
PiRK updated the diff for D9613: [avalanche] make delegateavalancheproof take a limited id rather than a whole proof.

address review:

Jun 3 2021, 15:10
Fabien closed D9598: Extract inv saturation check and data request time computation.
Jun 3 2021, 14:45
Fabien committed rABCe19bc0f9629c: Extract inv saturation check and data request time computation (authored by Fabien).
Extract inv saturation check and data request time computation
Jun 3 2021, 14:45
Fabien added inline comments to D9476: [avalanche] use the OrphanProofPool.
Jun 3 2021, 14:38
Mengerian accepted D9622: rpc: remove deprecated getaddressinfo fields.
Jun 3 2021, 14:09
deadalnix accepted D9598: Extract inv saturation check and data request time computation.
Jun 3 2021, 13:51
PiRK updated the summary of D9622: rpc: remove deprecated getaddressinfo fields.
Jun 3 2021, 13:47
deadalnix requested review of D9476: [avalanche] use the OrphanProofPool.
Jun 3 2021, 13:46
PiRK updated the diff for D9622: rpc: remove deprecated getaddressinfo fields.

rebase after version bump in D9609. This fixes the release-notes.md mess.

Jun 3 2021, 13:43
PiRK added inline comments to D9626: [avalanche] implement proof expiration verification.
Jun 3 2021, 13:26
PiRK accepted D9625: [avalanche] Add a facility to check if a peer is preferred for DL.
Jun 3 2021, 13:21
PiRK accepted D9627: [avalanche] Download the proof from our peers that send avahello.
Jun 3 2021, 13:16
Fabien requested changes to D9626: [avalanche] implement proof expiration verification.
Jun 3 2021, 13:07
Fabien requested review of D9627: [avalanche] Download the proof from our peers that send avahello.
Jun 3 2021, 12:28
teamcity added a comment to D9626: [avalanche] implement proof expiration verification.
Jun 3 2021, 11:39
teamcity added a comment to D9626: [avalanche] implement proof expiration verification.
Jun 3 2021, 11:38
teamcity added a comment to D9626: [avalanche] implement proof expiration verification.
Jun 3 2021, 11:37
teamcity added a comment to D9626: [avalanche] implement proof expiration verification.
Jun 3 2021, 11:37
teamcity added a comment to D9626: [avalanche] implement proof expiration verification.
Jun 3 2021, 11:36
PiRK requested review of D9626: [avalanche] implement proof expiration verification.
Jun 3 2021, 11:33
PiRK planned changes to D9626: [avalanche] implement proof expiration verification.
Jun 3 2021, 11:33
Fabien requested review of D9625: [avalanche] Add a facility to check if a peer is preferred for DL.
Jun 3 2021, 10:19
Fabien updated the diff for D9582: [avalanche] Answer proof invs with getdata proof requests.

Also download the proofs during IBD. They will likely end up in the orphan pool but that should not be an issue.

Jun 3 2021, 10:13
Fabien closed D9609: Bump version to 0.23.6.
Jun 3 2021, 09:58
Fabien committed rABC7209a1f1c395: Bump version to 0.23.6 (authored by Fabien).
Bump version to 0.23.6
Jun 3 2021, 09:58
PiRK accepted D9609: Bump version to 0.23.6.
Jun 3 2021, 09:42
Fabien requested review of D9609: Bump version to 0.23.6.
Jun 3 2021, 09:41
Fabien requested review of D9623: Remove wallet related constant from the mining util test lib.
Jun 3 2021, 08:59
Fabien requested changes to D9613: [avalanche] make delegateavalancheproof take a limited id rather than a whole proof.
Jun 3 2021, 08:21
rudyreichert updated rudyreichert.
Jun 3 2021, 07:10
abc-bot committed rABCa049a25f4639: [Automated] Update timing.json (authored by abc-bot).
[Automated] Update timing.json
Jun 3 2021, 03:20
abc-bot committed rABC09be7de7c440: [Automated] Update chainparams (authored by abc-bot).
[Automated] Update chainparams
Jun 3 2021, 02:16
abc-bot committed rABCa6faa5441bc8: [Automated] Update seeds (authored by abc-bot).
[Automated] Update seeds
Jun 3 2021, 02:11

Jun 2 2021

Fabien updated the summary of D9582: [avalanche] Answer proof invs with getdata proof requests.
Jun 2 2021, 19:41
Fabien updated the diff for D9582: [avalanche] Answer proof invs with getdata proof requests.

Remove the no longer used flag and rebase on top of D9608 to fix the permission inconsistency

Jun 2 2021, 19:40
Fabien updated the diff for D9598: Extract inv saturation check and data request time computation.

Add the limit bypass permission flags to the structure so we can use different permission for tx and proofs without adding much to the code

Jun 2 2021, 19:09
Mengerian requested changes to D9622: rpc: remove deprecated getaddressinfo fields.

There's something strange going on with the release notes.

Jun 2 2021, 17:53
PiRK updated the diff for D9622: rpc: remove deprecated getaddressinfo fields.

remove the empty release-notes-19200.md

Jun 2 2021, 17:51
majcosta accepted D9622: rpc: remove deprecated getaddressinfo fields.

green, just as long as you rebase on top of D9609 after it lands :)

Jun 2 2021, 17:48
majcosta accepted D9476: [avalanche] use the OrphanProofPool.
Jun 2 2021, 16:33
teamcity closed T1638: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Windows 64-bit is broken. as Resolved.
Jun 2 2021, 16:08
Fabien closed D9595: [avalanche] Add an API to store and retrieve a proof.
Jun 2 2021, 16:06
Fabien committed rABC605bfbfce5a9: [avalanche] Add an API to store and retrieve a proof (authored by Fabien).
[avalanche] Add an API to store and retrieve a proof
Jun 2 2021, 16:06
teamcity triaged T1639: Build Bitcoin-ABC / Master / Benchmarking is broken. as Unbreak Now! priority.
Jun 2 2021, 15:50
Fabien closed D9617: [avalanche] Make the processor methods use a shared pointer to proof.
Jun 2 2021, 15:45
Fabien committed rABC470c7b10647b: [avalanche] Make the processor methods use a shared pointer to proof (authored by Fabien).
[avalanche] Make the processor methods use a shared pointer to proof
Jun 2 2021, 15:45
Fabien closed D9616: [avalanche] Make the peermanager methods use a shared pointer to proof.
Jun 2 2021, 15:44
Fabien committed rABC0c1b7cdfed8f: [avalanche] Make the peermanager methods use a shared pointer to proof (authored by Fabien).
[avalanche] Make the peermanager methods use a shared pointer to proof
Jun 2 2021, 15:44
teamcity added a comment to D9478: [avalanche] make avalanche peer discovery in a simple case.
Jun 2 2021, 15:33
teamcity added a comment to D9478: [avalanche] make avalanche peer discovery in a simple case.
Jun 2 2021, 15:33
teamcity added a comment to D9478: [avalanche] make avalanche peer discovery in a simple case.
Jun 2 2021, 15:32
teamcity added a comment to D9478: [avalanche] make avalanche peer discovery in a simple case.
Jun 2 2021, 15:32
teamcity added a comment to D9478: [avalanche] make avalanche peer discovery in a simple case.
Jun 2 2021, 15:31
PiRK planned changes to D9478: [avalanche] make avalanche peer discovery in a simple case.
Jun 2 2021, 15:29
PiRK updated the diff for D9478: [avalanche] make avalanche peer discovery in a simple case.

rebase onto current master. This fixes the avahello signature (D9565).

Jun 2 2021, 15:29
Fabien requested changes to D9476: [avalanche] use the OrphanProofPool.
Jun 2 2021, 15:14
PiRK requested review of D9622: rpc: remove deprecated getaddressinfo fields.
Jun 2 2021, 14:21
deadalnix accepted D9617: [avalanche] Make the processor methods use a shared pointer to proof.
Jun 2 2021, 14:18
deadalnix updated the diff for D9476: [avalanche] use the OrphanProofPool.

clear the container explicitely

Jun 2 2021, 13:17
Fabien updated the diff for D9617: [avalanche] Make the processor methods use a shared pointer to proof.

Init with make_shared

Jun 2 2021, 13:02
deadalnix accepted D9599: [avalanche] Manage the notfound messages from a proof request.
Jun 2 2021, 12:53
deadalnix accepted D9595: [avalanche] Add an API to store and retrieve a proof.
Jun 2 2021, 12:08
deadalnix requested changes to D9617: [avalanche] Make the processor methods use a shared pointer to proof.
Jun 2 2021, 12:05
deadalnix accepted D9616: [avalanche] Make the peermanager methods use a shared pointer to proof.
Jun 2 2021, 12:03
Fabien updated the diff for D9608: [avalanche] Add an avaproof network permission for bypassing the inv tracking limit.

Improve doc and pick a more descriptive name

Jun 2 2021, 11:39
Fabien updated the diff for D9595: [avalanche] Add an API to store and retrieve a proof.

Use const ref to shared ptr

Jun 2 2021, 09:13
PiRK abandoned D9423: [avalanche] Remember rejected proofs.
Jun 2 2021, 09:06
PiRK closed D9615: RPC: Rephrase generatetoaddress help, and use PACKAGE_NAME.
Jun 2 2021, 09:06
PiRK committed rABCcbb9aa019131: RPC: Rephrase generatetoaddress help, and use PACKAGE_NAME (authored by Luke Dashjr <luke-jr+git@utopios.org>).
RPC: Rephrase generatetoaddress help, and use PACKAGE_NAME
Jun 2 2021, 09:05
Fabien updated the diff for D9617: [avalanche] Make the processor methods use a shared pointer to proof.

Address feedback

Jun 2 2021, 08:56
Fabien updated the diff for D9616: [avalanche] Make the peermanager methods use a shared pointer to proof.

Revert behavior change, use const ref to shared pointers, use auto where applicable

Jun 2 2021, 08:47
PiRK resigned from D9476: [avalanche] use the OrphanProofPool.

I'm resigning as a reviewer for this one because there are obviously too many things I don't understand, here. My understanding was that moving a variable makes it invalid, I don't understand how you can move the entire container and keep using it.
i also don't get how adding a new circular dependency is less bad than any of my other attemps at solving this.

Jun 2 2021, 08:32
PiRK abandoned D9614: [avalanche] make the delegateavalancheproof RPC take a limited ID.

Changes merged with D9613

Jun 2 2021, 08:24
PiRK updated the diff for D9613: [avalanche] make delegateavalancheproof take a limited id rather than a whole proof.

Replace DelegationBuilder::importDelegation with a constructor. This forces me to modify delegateavalancheproof immediately, so merge this revision with D9614.

Jun 2 2021, 08:20
Fabien closed D9607: [avalanche] Make the peer hold a shared pointer to the proof.
Jun 2 2021, 06:24
Fabien committed rABCdbc7bb707be2: [avalanche] Make the peer hold a shared pointer to the proof (authored by Fabien).
[avalanche] Make the peer hold a shared pointer to the proof
Jun 2 2021, 06:24
Fabien accepted D9615: RPC: Rephrase generatetoaddress help, and use PACKAGE_NAME.
Jun 2 2021, 06:14
PiRK closed D9621: Remove WalletDatabase::Create, CreateMock, and CreateDummy.
Jun 2 2021, 06:12
PiRK committed rABC9947dbf2350a: Remove WalletDatabase::Create, CreateMock, and CreateDummy (authored by Andrew Chow <achow101-github@achow101.com>).
Remove WalletDatabase::Create, CreateMock, and CreateDummy
Jun 2 2021, 06:12
PiRK closed D9620: scripted-diff: Replace WalletDatabase::Create* with CreateWalletDatabase.
Jun 2 2021, 06:12
PiRK committed rABCa6336823cdd4: scripted-diff: Replace WalletDatabase::Create* with CreateWalletDatabase (authored by PiRK).
scripted-diff: Replace WalletDatabase::Create* with CreateWalletDatabase
Jun 2 2021, 06:11
PiRK closed D9619: Add Create*WalletDatabase functions.
Jun 2 2021, 06:11
PiRK committed rABC4e3282e343e6: Add Create*WalletDatabase functions (authored by Andrew Chow <achow101-github@achow101.com>).
Add Create*WalletDatabase functions
Jun 2 2021, 06:11
PiRK closed D9618: walletdb: refactor Read, Write, Erase, and Exists into non-template func.
Jun 2 2021, 06:11
PiRK committed rABC7a2391c93f6d: walletdb: refactor Read, Write, Erase, and Exists into non-template func (authored by Andrew Chow <achow101-github@achow101.com>).
walletdb: refactor Read, Write, Erase, and Exists into non-template func
Jun 2 2021, 06:10
majcosta added a comment to D9476: [avalanche] use the OrphanProofPool.

forgot to comment. I think you need to clear the proofs container since std::move leaves it in a 'valid, but unspecified state'. I assume that means it could contain garbage or something.

Jun 2 2021, 01:13
majcosta requested changes to D9476: [avalanche] use the OrphanProofPool.
Jun 2 2021, 01:11

Jun 1 2021

majcosta committed rABCd2dc6677dd61: [CashAddr] adds eCash prefixes to the node behind a -ecash CLI argument (authored by majcosta).
[CashAddr] adds eCash prefixes to the node behind a -ecash CLI argument
Jun 1 2021, 21:14
PiRK added inline comments to D9613: [avalanche] make delegateavalancheproof take a limited id rather than a whole proof.
Jun 1 2021, 20:15
deadalnix requested changes to D9614: [avalanche] make the delegateavalancheproof RPC take a limited ID.
Jun 1 2021, 20:15
deadalnix accepted D9620: scripted-diff: Replace WalletDatabase::Create* with CreateWalletDatabase.
Jun 1 2021, 20:13
deadalnix accepted D9619: Add Create*WalletDatabase functions.
Jun 1 2021, 20:12
deadalnix accepted D9621: Remove WalletDatabase::Create, CreateMock, and CreateDummy.
Jun 1 2021, 20:11
deadalnix accepted D9615: RPC: Rephrase generatetoaddress help, and use PACKAGE_NAME.
Jun 1 2021, 20:11
deadalnix requested changes to D9613: [avalanche] make delegateavalancheproof take a limited id rather than a whole proof.
Jun 1 2021, 17:52