Revert the empty line change in init.cpp
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Jun 3 2021
address review:
rebase after version bump in D9609. This fixes the release-notes.md mess.
Also download the proofs during IBD. They will likely end up in the orphan pool but that should not be an issue.
Jun 2 2021
Remove the no longer used flag and rebase on top of D9608 to fix the permission inconsistency
Add the limit bypass permission flags to the structure so we can use different permission for tx and proofs without adding much to the code
There's something strange going on with the release notes.
remove the empty release-notes-19200.md
green, just as long as you rebase on top of D9609 after it lands :)
rebase onto current master. This fixes the avahello signature (D9565).
clear the container explicitely
Init with make_shared
Improve doc and pick a more descriptive name
Use const ref to shared ptr
Address feedback
Revert behavior change, use const ref to shared pointers, use auto where applicable
I'm resigning as a reviewer for this one because there are obviously too many things I don't understand, here. My understanding was that moving a variable makes it invalid, I don't understand how you can move the entire container and keep using it.
i also don't get how adding a new circular dependency is less bad than any of my other attemps at solving this.
Changes merged with D9613
Replace DelegationBuilder::importDelegation with a constructor. This forces me to modify delegateavalancheproof immediately, so merge this revision with D9614.
forgot to comment. I think you need to clear the proofs container since std::move leaves it in a 'valid, but unspecified state'. I assume that means it could contain garbage or something.