Feed All Stories

All Stories
Use Results
Edit Query
Hide Query

Sat, Nov 16

PiRK updated the diff for D17150: Make DecodeBase{32,64} take string_view arguments.

rebase

Sat, Nov 16, 11:01

PiRK updated the diff for D17149: modernize DecodeBase{32,64}, reject incorrect base64 in HTTP auth.

rebase

Sat, Nov 16, 11:00

teamcity added a comment to D17150: Make DecodeBase{32,64} take string_view arguments.

Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.

Sat, Nov 16, 10:58

teamcity added a comment to D17149: modernize DecodeBase{32,64}, reject incorrect base64 in HTTP auth.

Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.

Sat, Nov 16, 10:47

PiRK updated the diff for D17148: Make strencodings functions use string_view.

fix clang-tidy

Sat, Nov 16, 10:46

PiRK added inline comments to D17151: Use std::string_view throughout util strencodings/string.

Sat, Nov 16, 10:44

teamcity updated the summary of D17152: scripted-diff: Rename ValidAsCString to ContainsNoNUL.

Sat, Nov 16, 10:42

PiRK requested review of D17152: scripted-diff: Rename ValidAsCString to ContainsNoNUL.

Sat, Nov 16, 10:42

teamcity updated the summary of D17151: Use std::string_view throughout util strencodings/string.

Sat, Nov 16, 10:39

PiRK requested review of D17151: Use std::string_view throughout util strencodings/string.

Sat, Nov 16, 10:39

teamcity added a comment to D17148: Make strencodings functions use string_view.

Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.

Sat, Nov 16, 10:38

teamcity updated the summary of D17150: Make DecodeBase{32,64} take string_view arguments.

Sat, Nov 16, 10:37

PiRK requested review of D17150: Make DecodeBase{32,64} take string_view arguments.

Sat, Nov 16, 10:37

PiRK added a comment to D17149: modernize DecodeBase{32,64}, reject incorrect base64 in HTTP auth.

Note that I squashed these 3 commits because they kept touching the same lines. The intermediate states in-between commits was not very interesting to have in the git history.

Sat, Nov 16, 10:36

teamcity updated the summary of D17149: modernize DecodeBase{32,64}, reject incorrect base64 in HTTP auth.

Sat, Nov 16, 10:34

PiRK requested review of D17149: modernize DecodeBase{32,64}, reject incorrect base64 in HTTP auth.

Sat, Nov 16, 10:34

teamcity updated the summary of D17148: Make strencodings functions use string_view.

Sat, Nov 16, 10:32

PiRK requested review of D17148: Make strencodings functions use string_view.

Sat, Nov 16, 10:32

PiRK updated the diff for D17147: util: Introduce ToIntegral<T>(const std::string&) for locale independent parsing using std::from_chars(…) (C++17).

it didn't complain but fix it anyway

Sat, Nov 16, 10:31

PiRK planned changes to D17147: util: Introduce ToIntegral<T>(const std::string&) for locale independent parsing using std::from_chars(…) (C++17).

Sat, Nov 16, 09:34

teamcity updated the summary of D17147: util: Introduce ToIntegral<T>(const std::string&) for locale independent parsing using std::from_chars(…) (C++17).

Sat, Nov 16, 09:21

PiRK requested review of D17147: util: Introduce ToIntegral<T>(const std::string&) for locale independent parsing using std::from_chars(…) (C++17).

Sat, Nov 16, 09:20

bytesofman published D17146: [Cashtab] Show NFT offer on token page for review.

Sat, Nov 16, 04:45

Fri, Nov 15

Fabien closed D17145: [website] Update the upgrade page after the November 15 2024 activation.

Fri, Nov 15, 20:21

Fabien committed rABCWEB1ab101d83133: [website] Update the upgrade page after the November 15 2024 activation (authored by Fabien).

[website] Update the upgrade page after the November 15 2024 activation

Fri, Nov 15, 20:21

Mengerian accepted D17145: [website] Update the upgrade page after the November 15 2024 activation.

Fri, Nov 15, 20:20

Fabien requested review of D17145: [website] Update the upgrade page after the November 15 2024 activation.

Fri, Nov 15, 20:18

bytesofman published D17140: [Cashtab] More ts implementation as prep for wallet upgrade for review.

Fri, Nov 15, 18:57

roqqit updated the summary of D17121: [avalanche] Add stake contender polling.

Fri, Nov 15, 18:14

Fabien requested changes to D17144: [avalanche] Return pending stake contender status when there is no local staking rewards computed.

Fri, Nov 15, 18:14

roqqit updated the diff for D17121: [avalanche] Add stake contender polling.

rebase on D17144 to fix early convergence issue

Fri, Nov 15, 18:13

roqqit requested review of D17144: [avalanche] Return pending stake contender status when there is no local staking rewards computed.

Fri, Nov 15, 18:11

Fabien closed D17142: Add checkpoints after the November 2024 upgrade.

Fri, Nov 15, 17:46

Fabien committed rABC6aa479fa6861: Add checkpoints after the November 2024 upgrade (authored by Fabien).

Add checkpoints after the November 2024 upgrade

Fri, Nov 15, 17:46

Mengerian accepted D17142: Add checkpoints after the November 2024 upgrade.

Checked the mainnet checkpoint, looks good

Fri, Nov 15, 15:05

PiRK accepted D17142: Add checkpoints after the November 2024 upgrade.

block heights and hashes match what I saw

Fri, Nov 15, 14:51

teamcity awarded D17142: Add checkpoints after the November 2024 upgrade a Haypence token.

Fri, Nov 15, 14:39

Fabien added a comment to D17142: Add checkpoints after the November 2024 upgrade.

@bot build-ibd

Fri, Nov 15, 14:38

bytesofman closed D17135: [ecash-herald] Show volume by token.

Fri, Nov 15, 14:22

bytesofman committed rABC544ca1c50c17: [ecash-herald] Show volume by token (authored by bytesofman).

[ecash-herald] Show volume by token

Fri, Nov 15, 14:22

Fabien requested review of D17142: Add checkpoints after the November 2024 upgrade.

Fri, Nov 15, 14:21

Mengerian closed D17141: [e.cash] Mark upgrade as complete - 2024-11-15.

Fri, Nov 15, 13:56

Mengerian committed rABC1786b38f784e: [e.cash] Mark upgrade as complete - 2024-11-15 (authored by Mengerian).

[e.cash] Mark upgrade as complete - 2024-11-15

Fri, Nov 15, 13:56

Fabien accepted D17141: [e.cash] Mark upgrade as complete - 2024-11-15.

Fri, Nov 15, 13:56

Mengerian requested review of D17141: [e.cash] Mark upgrade as complete - 2024-11-15.

Fri, Nov 15, 13:54

PiRK accepted D17135: [ecash-herald] Show volume by token.

Fri, Nov 15, 09:43

Thu, Nov 14

roqqit accepted D17130: refactor: wrap accept() and extend usage of Sock.

Thu, Nov 14, 21:48

Fabien accepted D17131: net: use Sock in CNode.

Thu, Nov 14, 14:07

Fabien accepted D17137: fuzz: Add fuzzing harness for Socks5(...).

Thu, Nov 14, 14:05

bytesofman published D17135: [ecash-herald] Show volume by token for review.

Thu, Nov 14, 13:58

PiRK added inline comments to D17137: fuzz: Add fuzzing harness for Socks5(...).

Thu, Nov 14, 13:55

Fabien added inline comments to D17137: fuzz: Add fuzzing harness for Socks5(...).

Thu, Nov 14, 13:43

bytesofman closed D17136: [ecash-herald] Standardize the way we convert satoshi values to formatted amounts.

Thu, Nov 14, 13:41

bytesofman committed rABCf9a0ab6cb7af: [ecash-herald] Standardize the way we convert satoshi values to formatted… (authored by bytesofman).

[ecash-herald] Standardize the way we convert satoshi values to formatted…

Thu, Nov 14, 13:40

bytesofman closed D17128: [Cashtab] More improvements to agora partial sale tx parsing.

Thu, Nov 14, 13:40

bytesofman committed rABCd705d989c04c: [Cashtab] More improvements to agora partial sale tx parsing (authored by bytesofman).

[Cashtab] More improvements to agora partial sale tx parsing

Thu, Nov 14, 13:40

PiRK added a comment to D17131: net: use Sock in CNode.

In D17131#388860, @Fabien wrote:

In D17131#388836, @PiRK wrote:

rebase onto D17137 which fixes the fuzzer

Please add the dependency in phab then

Thu, Nov 14, 13:36

PiRK requested review of D17137: fuzz: Add fuzzing harness for Socks5(...).

Thu, Nov 14, 13:34

PiRK added a comment to D17137: fuzz: Add fuzzing harness for Socks5(...).

I missed the main one: core#19203
I added it to the summary

Thu, Nov 14, 13:32

PiRK updated the summary of D17137: fuzz: Add fuzzing harness for Socks5(...).

Thu, Nov 14, 13:31

Fabien added a comment to D17131: net: use Sock in CNode.

In D17131#388836, @PiRK wrote:

rebase onto D17137 which fixes the fuzzer

Thu, Nov 14, 13:18

Fabien requested changes to D17137: fuzz: Add fuzzing harness for Socks5(...).

I think the backports are not correct for this diff, none of the netbase changes are from the listed commits afaict

Thu, Nov 14, 13:17

emack accepted D17136: [ecash-herald] Standardize the way we convert satoshi values to formatted amounts.

Thu, Nov 14, 12:40

PiRK updated the diff for D17134: net: use Sock::WaitMany() instead of CConnman::SocketEvents().

rebase

Thu, Nov 14, 11:42

PiRK updated the diff for D17133: net: introduce Sock::WaitMany().

rebase

Thu, Nov 14, 11:38

PiRK updated the diff for D17132: net: also wait for exceptional events in Sock::Wait().

rebase

Thu, Nov 14, 11:38

PiRK updated the diff for D17131: net: use Sock in CNode.

rebase onto D17137 which fixes the fuzzer

Thu, Nov 14, 11:36

PiRK updated the diff for D17130: refactor: wrap accept() and extend usage of Sock.

rebase onto D17137, include relevant fuzzer changes

Thu, Nov 14, 11:33

teamcity updated the summary of D17137: fuzz: Add fuzzing harness for Socks5(...).

Thu, Nov 14, 11:31

PiRK requested review of D17137: fuzz: Add fuzzing harness for Socks5(...).

Thu, Nov 14, 11:31

emack accepted D17128: [Cashtab] More improvements to agora partial sale tx parsing.

Thu, Nov 14, 10:32

Fabien accepted D17134: net: use Sock::WaitMany() instead of CConnman::SocketEvents().

Thu, Nov 14, 09:04

Fabien accepted D17133: net: introduce Sock::WaitMany().

Thu, Nov 14, 08:48

Fabien accepted D17132: net: also wait for exceptional events in Sock::Wait().

Thu, Nov 14, 08:29

Fabien requested changes to D17121: [avalanche] Add stake contender polling.

Thu, Nov 14, 08:23

Wed, Nov 13

bytesofman published D17136: [ecash-herald] Standardize the way we convert satoshi values to formatted amounts for review.

Wed, Nov 13, 23:16

bytesofman added a comment to D17128: [Cashtab] More improvements to agora partial sale tx parsing.

In D17128#388782, @emack wrote:

summary and test plan are still TBD?

Wed, Nov 13, 23:16

bytesofman updated the summary of D17128: [Cashtab] More improvements to agora partial sale tx parsing.

Wed, Nov 13, 23:16

emack added a comment to D17128: [Cashtab] More improvements to agora partial sale tx parsing.

summary and test plan are still TBD?

Wed, Nov 13, 21:47

PiRK added inline comments to D17132: net: also wait for exceptional events in Sock::Wait().

Wed, Nov 13, 21:32

PiRK planned changes to D17131: net: use Sock in CNode.

needs a fuzzer fix and test plan

Wed, Nov 13, 21:30

PiRK updated the summary of D17130: refactor: wrap accept() and extend usage of Sock.

Wed, Nov 13, 21:28

roqqit accepted D17130: refactor: wrap accept() and extend usage of Sock.

Wed, Nov 13, 21:21

roqqit updated the diff for D17121: [avalanche] Add stake contender polling.

set mock time and give some comments why we do this
clarify a bunch of comments in the goofy loop

Wed, Nov 13, 20:59

johnkuney closed D17124: [cashtab] Menu style tweaks.

Wed, Nov 13, 20:17

johnkuney committed rABC9e7a26de9f03: [cashtab] Menu style tweaks (authored by johnkuney).

[cashtab] Menu style tweaks

Wed, Nov 13, 20:17

johnkuney updated the diff for D17124: [cashtab] Menu style tweaks.

add version

Wed, Nov 13, 19:55

bytesofman accepted D17124: [cashtab] Menu style tweaks.

Wed, Nov 13, 18:33

teamcity added a comment to D17131: net: use Sock in CNode.

Build Bitcoin ABC Diffs / Diff Testing (build-fuzzer) failed.

Wed, Nov 13, 18:04

teamcity updated the summary of D17134: net: use Sock::WaitMany() instead of CConnman::SocketEvents().

Wed, Nov 13, 17:53

PiRK requested review of D17134: net: use Sock::WaitMany() instead of CConnman::SocketEvents().

Wed, Nov 13, 17:52

teamcity updated the summary of D17133: net: introduce Sock::WaitMany().

Wed, Nov 13, 17:50

PiRK requested review of D17133: net: introduce Sock::WaitMany().

Wed, Nov 13, 17:50

teamcity updated the summary of D17132: net: also wait for exceptional events in Sock::Wait().

Wed, Nov 13, 17:49

PiRK requested review of D17132: net: also wait for exceptional events in Sock::Wait().

Wed, Nov 13, 17:49

teamcity updated the summary of D17131: net: use Sock in CNode.

Wed, Nov 13, 17:40

PiRK requested review of D17131: net: use Sock in CNode.

Wed, Nov 13, 17:40

teamcity updated the summary of D17130: refactor: wrap accept() and extend usage of Sock.

Wed, Nov 13, 17:37

PiRK requested review of D17130: refactor: wrap accept() and extend usage of Sock.

Wed, Nov 13, 17:37

PiRK committed rABCd8719d90bb5c: net: split CConnman::SocketHandler() (authored by Vasil Dimov <vd@FreeBSD.org>).

net: split CConnman::SocketHandler()

Wed, Nov 13, 17:33