Added back an invalid case. It is incomplete since the local winner does not actually trigger an ACCEPT vote, but this should make it more obvious where that test is heading.

Mon, Nov 18, 18:33

roqqit requested review of D17160: [avalanche] Cleanup unnecessary setArgs in compute_staking_rewards test.

Mon, Nov 18, 18:28

johnkuney published D17143: [cashtab] Hide balance button style edits for review.

Mon, Nov 18, 18:16

roqqit accepted D17159: util: optimize HexStr.

Mon, Nov 18, 17:42

roqqit accepted D17158: Handle invalid hex encoding in ParseHex.

Mon, Nov 18, 17:22

roqqit accepted D17157: util: Add ParseHex<std::byte>() helper.

Mon, Nov 18, 17:16

roqqit accepted D17156: refactor: Take Span in SetSeed.

Mon, Nov 18, 17:06

teamcity updated the summary of D17159: util: optimize HexStr.

Mon, Nov 18, 15:47

PiRK requested review of D17159: util: optimize HexStr.

Mon, Nov 18, 15:47

PiRK updated the diff for D17139: rpc, test: add sendmsgtopeer rpc and a test for net-level deadlock situation.

remove fixme comment (now fixed)

Mon, Nov 18, 11:26

PiRK published D17139: rpc, test: add sendmsgtopeer rpc and a test for net-level deadlock situation for review.

Mon, Nov 18, 11:23

PiRK published D17138: Rework receive buffer pushback for review.

Mon, Nov 18, 11:16

PiRK updated the summary of D17158: Handle invalid hex encoding in ParseHex.

Mon, Nov 18, 11:10

teamcity updated the summary of D17158: Handle invalid hex encoding in ParseHex.

Mon, Nov 18, 11:10

PiRK requested review of D17158: Handle invalid hex encoding in ParseHex.

Mon, Nov 18, 11:10

PiRK updated the summary of D17157: util: Add ParseHex<std::byte>() helper.

Mon, Nov 18, 10:28

teamcity updated the summary of D17157: util: Add ParseHex<std::byte>() helper.

Mon, Nov 18, 10:25

PiRK requested review of D17157: util: Add ParseHex<std::byte>() helper.

Mon, Nov 18, 10:25

teamcity updated the summary of D17156: refactor: Take Span in SetSeed.

Mon, Nov 18, 10:24

PiRK requested review of D17156: refactor: Take Span in SetSeed.

Mon, Nov 18, 10:24

PiRK closed D17152: scripted-diff: Rename ValidAsCString to ContainsNoNUL.

Mon, Nov 18, 10:23

PiRK closed D17151: Use std::string_view throughout util strencodings/string.

Mon, Nov 18, 10:23

PiRK committed rABC56db8a817f1c: Use std::string_view throughout util strencodings/string (authored by Pieter Wuille <pieter@wuille.net>).

Use std::string_view throughout util strencodings/string

Mon, Nov 18, 10:23

PiRK committed rABC2ce28a323c56: scripted-diff: Rename ValidAsCString to ContainsNoNUL (authored by PiRK).

scripted-diff: Rename ValidAsCString to ContainsNoNUL

Mon, Nov 18, 10:23

PiRK closed D17150: Make DecodeBase{32,64} take string_view arguments.

Mon, Nov 18, 10:23

PiRK closed D17149: modernize DecodeBase{32,64}, reject incorrect base64 in HTTP auth.

Mon, Nov 18, 10:23

PiRK committed rABC6d85d6304400: Make DecodeBase{32,64} take string_view arguments (authored by Pieter Wuille <pieter@wuille.net>).

Make DecodeBase{32,64} take string_view arguments

Mon, Nov 18, 10:23

PiRK committed rABC5dc47a349314: modernize DecodeBase{32,64}, reject incorrect base64 in HTTP auth (authored by Pieter Wuille <pieter@wuille.net>).

modernize DecodeBase{32,64}, reject incorrect base64 in HTTP auth

Mon, Nov 18, 10:23

PiRK closed D17148: Make strencodings functions use string_view.

Mon, Nov 18, 10:23

PiRK committed rABCdad4fd9df468: Make strencodings functions use string_view (authored by Pieter Wuille <pieter@wuille.net>).

Make strencodings functions use string_view

Mon, Nov 18, 10:23

PiRK closed D17147: util: Introduce ToIntegral<T>(const std::string&) for locale independent parsing using std::from_chars(…) (C++17).

Mon, Nov 18, 10:22

PiRK committed rABC10326d3320e1: util: Introduce ToIntegral<T>(const std::string&) for locale independent… (authored by practicalswift <practicalswift@users.noreply.github.com>).

util: Introduce ToIntegral<T>(const std::string&) for locale independent…

Mon, Nov 18, 10:22

Fabien accepted D17152: scripted-diff: Rename ValidAsCString to ContainsNoNUL.

Mon, Nov 18, 10:09

Fabien accepted D17149: modernize DecodeBase{32,64}, reject incorrect base64 in HTTP auth.

Mon, Nov 18, 10:08

Fabien accepted D17151: Use std::string_view throughout util strencodings/string.

Mon, Nov 18, 10:08

PiRK updated the diff for D17149: modernize DecodeBase{32,64}, reject incorrect base64 in HTTP auth.

fix var shadowing and move comment to the related line of code

Mon, Nov 18, 10:03

Fabien accepted D17150: Make DecodeBase{32,64} take string_view arguments.

Mon, Nov 18, 10:00

Fabien requested changes to D17149: modernize DecodeBase{32,64}, reject incorrect base64 in HTTP auth.

Mon, Nov 18, 09:53

Fabien accepted D17148: Make strencodings functions use string_view.

Mon, Nov 18, 09:34

PiRK updated the diff for D17149: modernize DecodeBase{32,64}, reject incorrect base64 in HTTP auth.

rebase

Mon, Nov 18, 09:31

PiRK updated the diff for D17147: util: Introduce ToIntegral<T>(const std::string&) for locale independent parsing using std::from_chars(…) (C++17).

comment nits

Mon, Nov 18, 09:29

Fabien accepted D17147: util: Introduce ToIntegral<T>(const std::string&) for locale independent parsing using std::from_chars(…) (C++17).

Mon, Nov 18, 09:16

Fabien requested changes to D17155: [CHRONIK] add is_final to tx struct in util.rs.

When you add a new feature like this you need to also add a test for the new feature so you demonstrate that it works as expected.
You can look at the functional tests in test/functional/chronik_*.py for test examples, and most likely you can extend one of the existing test instead of creating a new one.

Mon, Nov 18, 08:42

Fabien accepted D17121: [avalanche] Add stake contender polling.

Mon, Nov 18, 08:31

PiRK closed D17133: net: introduce Sock::WaitMany().

Mon, Nov 18, 06:42

PiRK closed D17132: net: also wait for exceptional events in Sock::Wait().

Mon, Nov 18, 06:42

PiRK closed D17134: net: use Sock::WaitMany() instead of CConnman::SocketEvents().

Mon, Nov 18, 06:42

PiRK committed rABCadc9c8e45a53: net: use Sock::WaitMany() instead of CConnman::SocketEvents() (authored by Vasil Dimov <vd@FreeBSD.org>).

net: use Sock::WaitMany() instead of CConnman::SocketEvents()

Mon, Nov 18, 06:42

PiRK committed rABCf0f41147f028: net: also wait for exceptional events in Sock::Wait() (authored by Vasil Dimov <vd@FreeBSD.org>).

net: also wait for exceptional events in Sock::Wait()

Mon, Nov 18, 06:42

PiRK committed rABC9f4a3fa6a70c: net: introduce Sock::WaitMany() (authored by Vasil Dimov <vd@FreeBSD.org>).

net: introduce Sock::WaitMany()

Mon, Nov 18, 06:42

PiRK closed D17131: net: use Sock in CNode.

Mon, Nov 18, 06:42

PiRK committed rABC48e3344f9f94: net: use Sock in CNode (authored by Vasil Dimov <vd@FreeBSD.org>).

net: use Sock in CNode

Mon, Nov 18, 06:42

PiRK closed D17130: refactor: wrap accept() and extend usage of Sock.

Mon, Nov 18, 06:42

PiRK committed rABC7e5ca9440c2f: refactor: wrap accept() and extend usage of Sock (authored by Vasil Dimov <vd@FreeBSD.org>).

refactor: wrap accept() and extend usage of Sock

Mon, Nov 18, 06:42

PiRK closed D17137: fuzz: Add fuzzing harness for Socks5(...).

Mon, Nov 18, 06:42

PiRK committed rABC5bea016076f0: fuzz: Add fuzzing harness for Socks5(...) (authored by practicalswift <practicalswift@users.noreply.github.com>).

fuzz: Add fuzzing harness for Socks5(...)

Mon, Nov 18, 06:42

Sun, Nov 17

abc-bot committed rABC5e55086a3dea: [Automated] Update seeds (authored by abc-bot).

[Automated] Update seeds

Sun, Nov 17, 22:21

abc-bot committed rABC8022a937a44e: [Automated] Update chainparams (authored by abc-bot).

[Automated] Update chainparams

Sun, Nov 17, 22:10

abc-bot committed rABC2ed2dd9475a8: [Automated] Update timing.json (authored by abc-bot).

[Automated] Update timing.json

Sun, Nov 17, 21:41

hazzarust updated the diff for D17155: [CHRONIK] add is_final to tx struct in util.rs.

renamed variable from x to block

Sun, Nov 17, 21:26

hazzarust requested review of D17155: [CHRONIK] add is_final to tx struct in util.rs.

Sun, Nov 17, 20:35

bytesofman closed D17153: [Cashtab] Convert OrderBook component to ts as prep for adding websocket support.

Sun, Nov 17, 03:08

bytesofman committed rABC92e37d388268: [Cashtab] Convert OrderBook component to ts as prep for adding websocket support (authored by bytesofman).

[Cashtab] Convert OrderBook component to ts as prep for adding websocket support

Sun, Nov 17, 03:08

emack accepted D17153: [Cashtab] Convert OrderBook component to ts as prep for adding websocket support.

Sun, Nov 17, 02:54

Sat, Nov 16

bytesofman published D17153: [Cashtab] Convert OrderBook component to ts as prep for adding websocket support for review.

Sat, Nov 16, 15:29

teamcity closed T3679: Build Bitcoin-ABC / Master / Native tests / Test Native OSX is broken. as Resolved.

Sat, Nov 16, 14:52

PiRK added a comment to D17149: modernize DecodeBase{32,64}, reject incorrect base64 in HTTP auth.

In D17149#389136, @teamcity wrote:

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Tail of the build log:

tests/test_iguana.py::test_invalid_inputindex ##teamcity[testStarted timestamp='2024-11-16T11:34:10.910' captureStandardOutput='false' flowId='tests.test_iguana.test_invalid_inputindex' metainfo='test_invalid_inputindex' name='tests.test_iguana.test_invalid_inputindex']
PASSED                     [ 25%]##teamcity[testFinished timestamp='2024-11-16T11:34:10.925' duration='14' flowId='tests.test_iguana.test_invalid_inputindex' name='tests.test_iguana.test_invalid_inputindex']

tests/test_iguana.py::test_sig_push_only ##teamcity[testStarted timestamp='2024-11-16T11:34:10.926' captureStandardOutput='false' flowId='tests.test_iguana.test_sig_push_only' metainfo='test_sig_push_only' name='tests.test_iguana.test_sig_push_only']
PASSED                          [ 30%]##teamcity[testFinished timestamp='2024-11-16T11:34:11.018' duration='92' flowId='tests.test_iguana.test_sig_push_only' name='tests.test_iguana.test_sig_push_only']

tests/test_iguana.py::test_script_sig_success ##teamcity[testStarted timestamp='2024-11-16T11:34:11.019' captureStandardOutput='false' flowId='tests.test_iguana.test_script_sig_success' metainfo='test_script_sig_success' name='tests.test_iguana.test_script_sig_success']
PASSED                     [ 35%]##teamcity[testFinished timestamp='2024-11-16T11:34:11.103' duration='83' flowId='tests.test_iguana.test_script_sig_success' name='tests.test_iguana.test_script_sig_success']

tests/test_iguana.py::test_script_sig_invalid_opcode_encoding ##teamcity[testStarted timestamp='2024-11-16T11:34:11.103' captureStandardOutput='false' flowId='tests.test_iguana.test_script_sig_invalid_opcode_encoding' metainfo='test_script_sig_invalid_opcode_encoding' name='tests.test_iguana.test_script_sig_invalid_opcode_encoding']
PASSED     [ 40%]##teamcity[testFinished timestamp='2024-11-16T11:34:11.158' duration='54' flowId='tests.test_iguana.test_script_sig_invalid_opcode_encoding' name='tests.test_iguana.test_script_sig_invalid_opcode_encoding']

tests/test_iguana.py::test_script_pub_key_success ##teamcity[testStarted timestamp='2024-11-16T11:34:11.159' captureStandardOutput='false' flowId='tests.test_iguana.test_script_pub_key_success' metainfo='test_script_pub_key_success' name='tests.test_iguana.test_script_pub_key_success']
PASSED                 [ 45%]##teamcity[testFinished timestamp='2024-11-16T11:34:11.227' duration='67' flowId='tests.test_iguana.test_script_pub_key_success' name='tests.test_iguana.test_script_pub_key_success']

tests/test_iguana.py::test_script_pub_key_failure ##teamcity[testStarted timestamp='2024-11-16T11:34:11.228' captureStandardOutput='false' flowId='tests.test_iguana.test_script_pub_key_failure' metainfo='test_script_pub_key_failure' name='tests.test_iguana.test_script_pub_key_failure']
PASSED                 [ 50%]##teamcity[testFinished timestamp='2024-11-16T11:34:11.250' duration='21' flowId='tests.test_iguana.test_script_pub_key_failure' name='tests.test_iguana.test_script_pub_key_failure']

tests/test_iguana.py::test_script_pub_key_empty_stack ##teamcity[testStarted timestamp='2024-11-16T11:34:11.251' captureStandardOutput='false' flowId='tests.test_iguana.test_script_pub_key_empty_stack' metainfo='test_script_pub_key_empty_stack' name='tests.test_iguana.test_script_pub_key_empty_stack']
PASSED             [ 55%]##teamcity[testFinished timestamp='2024-11-16T11:34:11.287' duration='36' flowId='tests.test_iguana.test_script_pub_key_empty_stack' name='tests.test_iguana.test_script_pub_key_empty_stack']

tests/test_iguana.py::test_script_pub_key_false_stack ##teamcity[testStarted timestamp='2024-11-16T11:34:11.288' captureStandardOutput='false' flowId='tests.test_iguana.test_script_pub_key_false_stack' metainfo='test_script_pub_key_false_stack' name='tests.test_iguana.test_script_pub_key_false_stack']
PASSED             [ 60%]##teamcity[testFinished timestamp='2024-11-16T11:34:11.310' duration='21' flowId='tests.test_iguana.test_script_pub_key_false_stack' name='tests.test_iguana.test_script_pub_key_false_stack']

tests/test_iguana.py::test_script_pub_key_cleanstack ##teamcity[testStarted timestamp='2024-11-16T11:34:11.311' captureStandardOutput='false' flowId='tests.test_iguana.test_script_pub_key_cleanstack' metainfo='test_script_pub_key_cleanstack' name='tests.test_iguana.test_script_pub_key_cleanstack']
PASSED              [ 65%]##teamcity[testFinished timestamp='2024-11-16T11:34:11.325' duration='12' flowId='tests.test_iguana.test_script_pub_key_cleanstack' name='tests.test_iguana.test_script_pub_key_cleanstack']

tests/test_iguana.py::test_redeem_script_success ##teamcity[testStarted timestamp='2024-11-16T11:34:11.325' captureStandardOutput='false' flowId='tests.test_iguana.test_redeem_script_success' metainfo='test_redeem_script_success' name='tests.test_iguana.test_redeem_script_success']
PASSED                  [ 70%]##teamcity[testFinished timestamp='2024-11-16T11:34:11.355' duration='29' flowId='tests.test_iguana.test_redeem_script_success' name='tests.test_iguana.test_redeem_script_success']

tests/test_iguana.py::test_redeem_script_error ##teamcity[testStarted timestamp='2024-11-16T11:34:11.356' captureStandardOutput='false' flowId='tests.test_iguana.test_redeem_script_error' metainfo='test_redeem_script_error' name='tests.test_iguana.test_redeem_script_error']
PASSED                    [ 75%]##teamcity[testFinished timestamp='2024-11-16T11:34:11.371' duration='14' flowId='tests.test_iguana.test_redeem_script_error' name='tests.test_iguana.test_redeem_script_error']

tests/test_iguana.py::test_redeem_script_exception ##teamcity[testStarted timestamp='2024-11-16T11:34:11.371' captureStandardOutput='false' flowId='tests.test_iguana.test_redeem_script_exception' metainfo='test_redeem_script_exception' name='tests.test_iguana.test_redeem_script_exception']
PASSED                [ 80%]##teamcity[testFinished timestamp='2024-11-16T11:34:11.386' duration='13' flowId='tests.test_iguana.test_redeem_script_exception' name='tests.test_iguana.test_redeem_script_exception']

tests/test_iguana.py::test_redeem_script_empty_stack ##teamcity[testStarted timestamp='2024-11-16T11:34:11.386' captureStandardOutput='false' flowId='tests.test_iguana.test_redeem_script_empty_stack' metainfo='test_redeem_script_empty_stack' name='tests.test_iguana.test_redeem_script_empty_stack']
PASSED              [ 85%]##teamcity[testFinished timestamp='2024-11-16T11:34:11.401' duration='14' flowId='tests.test_iguana.test_redeem_script_empty_stack' name='tests.test_iguana.test_redeem_script_empty_stack']

tests/test_iguana.py::test_redeem_script_false ##teamcity[testStarted timestamp='2024-11-16T11:34:11.402' captureStandardOutput='false' flowId='tests.test_iguana.test_redeem_script_false' metainfo='test_redeem_script_false' name='tests.test_iguana.test_redeem_script_false']
PASSED                    [ 90%]##teamcity[testFinished timestamp='2024-11-16T11:34:11.418' duration='15' flowId='tests.test_iguana.test_redeem_script_false' name='tests.test_iguana.test_redeem_script_false']

tests/test_iguana.py::test_redeem_script_cleanstack ##teamcity[testStarted timestamp='2024-11-16T11:34:11.418' captureStandardOutput='false' flowId='tests.test_iguana.test_redeem_script_cleanstack' metainfo='test_redeem_script_cleanstack' name='tests.test_iguana.test_redeem_script_cleanstack']
PASSED               [ 95%]##teamcity[testFinished timestamp='2024-11-16T11:34:11.433' duration='13' flowId='tests.test_iguana.test_redeem_script_cleanstack' name='tests.test_iguana.test_redeem_script_cleanstack']

tests/test_iguana.py::test_redeem_script_input_sigchecks ##teamcity[testStarted timestamp='2024-11-16T11:34:11.434' captureStandardOutput='false' flowId='tests.test_iguana.test_redeem_script_input_sigchecks' metainfo='test_redeem_script_input_sigchecks' name='tests.test_iguana.test_redeem_script_input_sigchecks']
PASSED          [100%]##teamcity[testFinished timestamp='2024-11-16T11:34:11.489' duration='54' flowId='tests.test_iguana.test_redeem_script_input_sigchecks' name='tests.test_iguana.test_redeem_script_input_sigchecks']


============================== 20 passed in 0.76s ==============================
[212/489] Running pow test suite
PASSED: pow test suite
[227/489] Running seeder test suite
PASSED: seeder test suite
[231/489] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
[486/489] Running bitcoin test suite
PASSED: bitcoin test suite
ninja: build stopped: cannot make progress due to previous errors.
Build build-without-wallet failed with exit code 1

Sat, Nov 16, 14:49

teamcity triaged T3679: Build Bitcoin-ABC / Master / Native tests / Test Native OSX is broken. as Unbreak Now! priority.

Sat, Nov 16, 14:38

bytesofman closed D17146: [Cashtab] Show NFT offer on token page.

Sat, Nov 16, 14:32

bytesofman committed rABCcff88b5382e6: [Cashtab] Show NFT offer on token page (authored by bytesofman).

[Cashtab] Show NFT offer on token page

Sat, Nov 16, 14:32

bytesofman closed D17140: [Cashtab] More ts implementation as prep for wallet upgrade.

Sat, Nov 16, 14:22

bytesofman committed rABCc4b245224f2c: [Cashtab] More ts implementation as prep for wallet upgrade (authored by bytesofman).

[Cashtab] More ts implementation as prep for wallet upgrade