Feed All Stories
Sun, Mar 23
Sun, Mar 23
teamcity awarded D17849: [Chronik] Bump Rust version to 1.85.1 a Doubloon token.
teamcity awarded D17849: [Chronik] Bump Rust version to 1.85.1 a Piece of Eight token.
teamcity awarded D17849: [Chronik] Bump Rust version to 1.85.1 a Haypence token.
Sat, Mar 22
Sat, Mar 22
PiRK committed rABC017aa9c0d98b: [electrum] improve layout for Trezor firmware tools (authored by PiRK).
[electrum] improve layout for Trezor firmware tools
tobias_ruck requested changes to D17822: [ecash-wallet] Add fluent API for building and broadcasting txs.
PiRK added a comment to D17846: [electrum] improve layout for Trezor firmware tools.
PiRK requested review of D17846: [electrum] improve layout for Trezor firmware tools.
Fri, Mar 21
Fri, Mar 21
PiRK committed rABC381c284405a2: [electrum] fix opening Trezor settings menu while the device is locked (authored by PiRK).
[electrum] fix opening Trezor settings menu while the device is locked
PiRK requested review of D17845: [electrum] fix opening Trezor settings menu while the device is locked.
alitayin added inline comments to D17815: [Cashtab] Introduce CSS variables to make styling easier.
roqqit committed rABC4271d8338029: [avalanche] Fix flaky proof rank comparison in processor_tests (authored by roqqit).
[avalanche] Fix flaky proof rank comparison in processor_tests
johnkuney added inline comments to D17815: [Cashtab] Introduce CSS variables to make styling easier.
Fabien committed rABC269465eb445f: [electrum] Catch a potential LibUSB error during session close when jumping to… (authored by Fabien).
[electrum] Catch a potential LibUSB error during session close when jumping to…
Fabien committed rABC399c09a28574: [electrum] Increase the timeout for entering the bootloader mode (authored by Fabien).
[electrum] Increase the timeout for entering the bootloader mode
translation nit
Fabien committed rABCea7437f90053: [electrum] Alllow for downgrading the Trezor firmware (authored by Fabien).
[electrum] Alllow for downgrading the Trezor firmware
Fabien requested review of D17843: [electrum] Increase the timeout for entering the bootloader mode.
Fabien requested review of D17842: [electrum] Alllow for downgrading the Trezor firmware.
alitayin added inline comments to D17815: [Cashtab] Introduce CSS variables to make styling easier.
alitayin added inline comments to D17815: [Cashtab] Introduce CSS variables to make styling easier.
bytesofman published D17822: [ecash-wallet] Add fluent API for building and broadcasting txs for review.
bytesofman committed rABC5b53dd1d5d01: [ecash-herald] Improve miner parsing (authored by bytesofman).
[ecash-herald] Improve miner parsing
Thu, Mar 20
Thu, Mar 20
bytesofman published D17841: [ecash-herald] Improve miner parsing for review.
Fabien added inline comments to D17831: [avalanche] Limit the finalized txs radix tree size so it always fits in the next block.
roqqit committed rABC892275701a2b: [avalanche] Refactor helpers to build avaproofs messages (authored by roqqit).
[avalanche] Refactor helpers to build avaproofs messages
roqqit committed rABC2b95ae7e2f43: [avalanche] Cleanup unused prefilled proof index set (authored by roqqit).
[avalanche] Cleanup unused prefilled proof index set
roqqit requested review of D17840: [avalanche] Fix flaky proof rank comparison in processor_tests.
[fuzzer] Include missing header
johnkuney requested changes to D17815: [Cashtab] Introduce CSS variables to make styling easier.
Good idea, but think theres some over complicating going on with the line heights
Fabien requested review of D17839: [fuzzer] Include missing header.
teamcity triaged T3773: Build Bitcoin-ABC / Master / Sanitizers / Fuzzer is broken. as Unbreak Now! priority.
Fabien committed rABC12025bba2389: [avalanche] Don't include validation.h via proof.h (authored by Fabien).
[avalanche] Don't include validation.h via proof.h
[avalanche] Add some missing headers
Fabien updated the diff for D17831: [avalanche] Limit the finalized txs radix tree size so it always fits in the next block.
Reword the log
PiRK committed rABCefe279d43307: test_framework: improve the syntax of serialize() methods (authored by PiRK).
test_framework: improve the syntax of serialize() methods
Fabien added inline comments to D17831: [avalanche] Limit the finalized txs radix tree size so it always fits in the next block.
lgtm (if the bitcoin-chainstate / kernel build does not fail)
Fabien planned changes to D17836: [avalanche] Improve lock annotations for AvalancheFinalizeBlock.
Fabien requested review of D17838: [avalanche] Don't include validation.h via proof.h.
Fabien requested review of D17837: [avalanche] Add some missing headers.
teamcity added a comment to D17836: [avalanche] Improve lock annotations for AvalancheFinalizeBlock.
Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.
Fabien requested review of D17836: [avalanche] Improve lock annotations for AvalancheFinalizeBlock.
PiRK added inline comments to D17831: [avalanche] Limit the finalized txs radix tree size so it always fits in the next block.
PiRK added inline comments to D17831: [avalanche] Limit the finalized txs radix tree size so it always fits in the next block.
PiRK added inline comments to D17831: [avalanche] Limit the finalized txs radix tree size so it always fits in the next block.
PiRK added inline comments to D17835: test_framework: improve the syntax of serialize() methods.
PiRK added a comment to D17835: test_framework: improve the syntax of serialize() methods.
This whole diff is a test on how Grok v3 can helpful to do semi-automated changes on a large amount of code.
It worked quite well, I just had to revert a few changes msg_avaproofs.serialize and msg_avaproofsreq.serialize, which imo were not trivial enough to justify removing the intermadiate var and all the comments to make it a one-liner.
PiRK updated the diff for D17835: test_framework: improve the syntax of serialize() methods.
back-off unrelated changes
PiRK planned changes to D17835: test_framework: improve the syntax of serialize() methods.
PiRK requested review of D17835: test_framework: improve the syntax of serialize() methods.
Fabien updated the diff for D17832: [avalanche] Poll for the transactions that didn't make it into the last block.
Fix another lock issue (cs_main => cs_peermanager)
alitayin updated the diff for D17815: [Cashtab] Introduce CSS variables to make styling easier.
Switch to my branch and commit again.
bytesofman requested changes to D17815: [Cashtab] Introduce CSS variables to make styling easier.
this diff was created on the master branch, which makes it difficult to rebase onto the latest master
Wed, Mar 19
Wed, Mar 19
teamcity added a comment to D17832: [avalanche] Poll for the transactions that didn't make it into the last block.
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.
Fabien committed rABCd0d90118ccea: [avalanche] Add to the recently finalized items filter at callsite (authored by Fabien).
[avalanche] Add to the recently finalized items filter at callsite
Fabien updated the diff for D17832: [avalanche] Poll for the transactions that didn't make it into the last block.
Fix mempool lock
roqqit requested changes to D17832: [avalanche] Poll for the transactions that didn't make it into the last block.
back to you
This looks a bit odd to move it to the callsite but since it is moving in the right direction with regards to the processor FIXME, it is probably a small step in the right direction.
roqqit requested review of D17834: [avalanche] Refactor helpers to build avaproofs messages.
roqqit requested review of D17833: [avalanche] Cleanup unused prefilled proof index set.
teamcity added a comment to D17832: [avalanche] Poll for the transactions that didn't make it into the last block.
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.
Fabien committed rABC9b7827b53bdd: Bump the log crawling timeout after node restart in rpc_setban.py (authored by Fabien).
Bump the log crawling timeout after node restart in rpc_setban.py
Fabien requested review of D17830: Bump the log crawling timeout after node restart in rpc_setban.py.