Page MenuHomePhabricator
Feed All Stories

May 28 2020

majcosta updated the summary of D6272: [backport#16452] refactor : use RelayTransaction in BroadcastTransaction utility.
May 28 2020, 02:09
majcosta abandoned D6271: [backport#15492] [rpc] remove deprecated generate method.

can't be removed until v0.22

May 28 2020, 02:08
abc-bot committed rABCb4ba40fd8a8e: [Automated] Update chainparams (authored by abc-bot).
[Automated] Update chainparams
May 28 2020, 02:05
nakihito added inline comments to D6271: [backport#15492] [rpc] remove deprecated generate method.
May 28 2020, 01:35
teamcity added a comment to D6273: [backport#15713] Add BroadcastTransaction utility usage in Chain interface.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

May 28 2020, 01:18
teamcity added a comment to D6273: [backport#15713] Add BroadcastTransaction utility usage in Chain interface.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

May 28 2020, 01:09
majcosta updated the summary of D6271: [backport#15492] [rpc] remove deprecated generate method.
May 28 2020, 01:07
teamcity added a comment to D6273: [backport#15713] Add BroadcastTransaction utility usage in Chain interface.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

May 28 2020, 01:07
teamcity added a comment to D6273: [backport#15713] Add BroadcastTransaction utility usage in Chain interface.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

May 28 2020, 01:06
teamcity added a comment to D6273: [backport#15713] Add BroadcastTransaction utility usage in Chain interface.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

May 28 2020, 01:06
teamcity added a comment to D6273: [backport#15713] Add BroadcastTransaction utility usage in Chain interface.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

May 28 2020, 01:06
teamcity added a comment to D6273: [backport#15713] Add BroadcastTransaction utility usage in Chain interface.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

May 28 2020, 01:05
teamcity updated the summary of D6273: [backport#15713] Add BroadcastTransaction utility usage in Chain interface.
May 28 2020, 01:05
majcosta requested review of D6273: [backport#15713] Add BroadcastTransaction utility usage in Chain interface.
May 28 2020, 01:05
nakihito added a comment to D6272: [backport#16452] refactor : use RelayTransaction in BroadcastTransaction utility.

Not sure what D6262 has to do with this patch?

May 28 2020, 00:41
nakihito requested changes to D6271: [backport#15492] [rpc] remove deprecated generate method.

The summary makes it seem like these are two unrelated commits when they're actually from the same PR. Since they are from the same PR, you don't need to link the individual commits.

May 28 2020, 00:32
teamcity added a comment to D6272: [backport#16452] refactor : use RelayTransaction in BroadcastTransaction utility.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

May 28 2020, 00:20
teamcity added a comment to D6272: [backport#16452] refactor : use RelayTransaction in BroadcastTransaction utility.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

May 28 2020, 00:10
teamcity added a comment to D6272: [backport#16452] refactor : use RelayTransaction in BroadcastTransaction utility.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

May 28 2020, 00:09
teamcity added a comment to D6272: [backport#16452] refactor : use RelayTransaction in BroadcastTransaction utility.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

May 28 2020, 00:07
teamcity added a comment to D6272: [backport#16452] refactor : use RelayTransaction in BroadcastTransaction utility.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

May 28 2020, 00:07
teamcity added a comment to D6272: [backport#16452] refactor : use RelayTransaction in BroadcastTransaction utility.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

May 28 2020, 00:07
teamcity updated the summary of D6272: [backport#16452] refactor : use RelayTransaction in BroadcastTransaction utility.
May 28 2020, 00:07
teamcity added a comment to D6272: [backport#16452] refactor : use RelayTransaction in BroadcastTransaction utility.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

May 28 2020, 00:07
majcosta requested review of D6272: [backport#16452] refactor : use RelayTransaction in BroadcastTransaction utility.
May 28 2020, 00:07

May 27 2020

majcosta added inline comments to D6271: [backport#15492] [rpc] remove deprecated generate method.
May 27 2020, 23:38
teamcity added a comment to D6271: [backport#15492] [rpc] remove deprecated generate method.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

May 27 2020, 23:25
teamcity added a comment to D6271: [backport#15492] [rpc] remove deprecated generate method.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

May 27 2020, 23:17
teamcity added a comment to D6271: [backport#15492] [rpc] remove deprecated generate method.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

May 27 2020, 23:14
majcosta updated the summary of D6271: [backport#15492] [rpc] remove deprecated generate method.
May 27 2020, 23:13
teamcity added a comment to D6271: [backport#15492] [rpc] remove deprecated generate method.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

May 27 2020, 23:11
teamcity added a comment to D6271: [backport#15492] [rpc] remove deprecated generate method.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

May 27 2020, 23:11
teamcity added a comment to D6271: [backport#15492] [rpc] remove deprecated generate method.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

May 27 2020, 23:11
teamcity added a comment to D6271: [backport#15492] [rpc] remove deprecated generate method.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

May 27 2020, 23:11
teamcity updated the summary of D6271: [backport#15492] [rpc] remove deprecated generate method.
May 27 2020, 23:11
majcosta requested review of D6271: [backport#15492] [rpc] remove deprecated generate method.
May 27 2020, 23:11
teamcity added a comment to D6270: [backport#15435] Merge #15435: rpc: Add missing #include.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

May 27 2020, 21:59
teamcity added a comment to D6270: [backport#15435] Merge #15435: rpc: Add missing #include.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

May 27 2020, 21:53
teamcity added a comment to D6270: [backport#15435] Merge #15435: rpc: Add missing #include.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

May 27 2020, 21:52
teamcity added a comment to D6270: [backport#15435] Merge #15435: rpc: Add missing #include.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

May 27 2020, 21:50
teamcity added a comment to D6270: [backport#15435] Merge #15435: rpc: Add missing #include.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

May 27 2020, 21:50
teamcity added a comment to D6270: [backport#15435] Merge #15435: rpc: Add missing #include.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

May 27 2020, 21:50
teamcity added a comment to D6270: [backport#15435] Merge #15435: rpc: Add missing #include.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

May 27 2020, 21:49
teamcity updated the summary of D6270: [backport#15435] Merge #15435: rpc: Add missing #include.
May 27 2020, 21:49
majcosta requested review of D6270: [backport#15435] Merge #15435: rpc: Add missing #include.
May 27 2020, 21:49
majcosta committed rABC08a7b78cc44c: [backport#16034] Move LockAnnotation from threadsafety.h (imported code) to… (authored by practicalswift <practicalswift@users.noreply.github.com>).
[backport#16034] Move LockAnnotation from threadsafety.h (imported code) to…
May 27 2020, 19:35
majcosta closed D6261: [backport#16034] Move LockAnnotation from threadsafety.h (imported code) to sync.h (our code).
May 27 2020, 19:34
majcosta committed rABC0ae0f30d6b9f: [backport#15855] [refactor] interfaces: Add missing LockAnnotation for cs_main (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#15855] [refactor] interfaces: Add missing LockAnnotation for cs_main
May 27 2020, 19:33
majcosta closed D6259: [backport#15855] [refactor] interfaces: Add missing LockAnnotation for cs_main.
May 27 2020, 19:33
majcosta requested review of D6262: [backport#16034] scripted-diff: Rename LockAnnotation to LockAssertion.

expanded test plan

May 27 2020, 19:31
majcosta updated the test plan for D6262: [backport#16034] scripted-diff: Rename LockAnnotation to LockAssertion.
May 27 2020, 19:31
majcosta updated the test plan for D6262: [backport#16034] scripted-diff: Rename LockAnnotation to LockAssertion.
May 27 2020, 19:30
deadalnix accepted D6259: [backport#15855] [refactor] interfaces: Add missing LockAnnotation for cs_main.
May 27 2020, 19:20
teamcity added a comment to D6268: [wallet] abort when attempting to fund a transaction above maxtxfee.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

May 27 2020, 19:11
teamcity added a comment to D6268: [wallet] abort when attempting to fund a transaction above maxtxfee.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

May 27 2020, 19:01
majcosta requested review of D6259: [backport#15855] [refactor] interfaces: Add missing LockAnnotation for cs_main.

expanded test plan

May 27 2020, 19:00
teamcity added a comment to D6268: [wallet] abort when attempting to fund a transaction above maxtxfee.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

May 27 2020, 18:59
majcosta updated the test plan for D6259: [backport#15855] [refactor] interfaces: Add missing LockAnnotation for cs_main.
May 27 2020, 18:59
majcosta updated the test plan for D6259: [backport#15855] [refactor] interfaces: Add missing LockAnnotation for cs_main.
May 27 2020, 18:59
teamcity added a comment to D6268: [wallet] abort when attempting to fund a transaction above maxtxfee.

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

May 27 2020, 18:58
teamcity added a comment to D6268: [wallet] abort when attempting to fund a transaction above maxtxfee.

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

May 27 2020, 18:57
teamcity added a comment to D6268: [wallet] abort when attempting to fund a transaction above maxtxfee.

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

May 27 2020, 18:56
teamcity closed T907: Build Bitcoin-ABC / Master / Bitcoin-ABC Master Autotools is broken. as Resolved.
May 27 2020, 18:54
deadalnix updated the diff for D6268: [wallet] abort when attempting to fund a transaction above maxtxfee.

Remove fee estimate comment

May 27 2020, 18:51
teamcity added a comment to D6269: Revert "[backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency".

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

May 27 2020, 18:49
majcosta added a reverting change for D6256: [backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency: rABC3c12bc770217: Revert "[backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a….
May 27 2020, 18:44
majcosta committed rABC3c12bc770217: Revert "[backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a… (authored by majcosta).
Revert "[backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a…
May 27 2020, 18:44
majcosta added a reverting change for rABCa7a55fb3ac4f: [backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency: rABC3c12bc770217: Revert "[backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a….
May 27 2020, 18:44
majcosta closed D6269: Revert "[backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency".
May 27 2020, 18:44
deadalnix accepted D6269: Revert "[backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency".
May 27 2020, 18:43
teamcity added a comment to D6269: Revert "[backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency".

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

May 27 2020, 18:42
majcosta updated the summary of D6269: Revert "[backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency".
May 27 2020, 18:42
teamcity added a comment to D6269: Revert "[backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency".

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

May 27 2020, 18:40
teamcity added a comment to D6269: Revert "[backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency".

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

May 27 2020, 18:37
teamcity added a comment to D6269: Revert "[backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency".

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

May 27 2020, 18:37
teamcity added a comment to D6269: Revert "[backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency".

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

May 27 2020, 18:37
majcosta updated the diff for D6269: Revert "[backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency".

add explicit libevent dependency to util library

May 27 2020, 18:36
teamcity added a comment to D6269: Revert "[backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency".

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

May 27 2020, 18:05
teamcity added a comment to D6269: Revert "[backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency".

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

May 27 2020, 17:58
teamcity added a comment to D6269: Revert "[backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency".

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

May 27 2020, 17:55
teamcity added a comment to D6269: Revert "[backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency".

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

May 27 2020, 17:54
teamcity added a comment to D6269: Revert "[backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency".

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

May 27 2020, 17:54
teamcity added a comment to D6269: Revert "[backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency".

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

May 27 2020, 17:54
majcosta updated the diff for D6269: Revert "[backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency".

cleaned up event leftovers

May 27 2020, 17:54
teamcity added a comment to D6269: Revert "[backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency".

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

May 27 2020, 17:36
deadalnix requested changes to D6269: Revert "[backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency".
May 27 2020, 17:31
teamcity added a comment to D6269: Revert "[backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency".
May 27 2020, 17:28
teamcity added a comment to D6269: Revert "[backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency".

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

May 27 2020, 17:28
majcosta updated the summary of D6269: Revert "[backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency".
May 27 2020, 17:26
teamcity added a comment to D6269: Revert "[backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency".

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) started.

May 27 2020, 17:26
teamcity added a comment to D6269: Revert "[backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency".

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

May 27 2020, 17:26
teamcity added a comment to D6269: Revert "[backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency".

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

May 27 2020, 17:25
majcosta updated the diff for D6269: Revert "[backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency".

removed redundant link commands and removed obsolete event dep

May 27 2020, 17:25
majcosta updated the summary of D6269: Revert "[backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency".
May 27 2020, 17:15
teamcity added a comment to D6269: Revert "[backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency".

Build Bitcoin ABC Diffs / Diff Testing (build-diff) passed.

May 27 2020, 17:14
deadalnix requested changes to D6269: Revert "[backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency".
May 27 2020, 17:13
teamcity added a comment to D6269: Revert "[backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency".

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) passed.

May 27 2020, 17:05
teamcity added a comment to D6269: Revert "[backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency".

Build Bitcoin ABC Diffs / Diff Testing (build-werror) passed.

May 27 2020, 17:02
teamcity added a comment to D6269: Revert "[backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency".

Build Bitcoin ABC Diffs / Diff Testing (build-werror) started.

May 27 2020, 17:01
teamcity added a comment to D6269: Revert "[backport#15639] bitcoin-wallet tool: Drop libbitcoin_server.a dependency".

Build Bitcoin ABC Diffs / Diff Testing (build-diff) started.

May 27 2020, 17:01