Page MenuHomePhabricator
Feed All Stories

Jun 7 2020

teamcity added a comment to D6437: node: Add reference to mempool in NodeContext.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 7 2020, 16:42
deadalnix requested review of D6437: node: Add reference to mempool in NodeContext.
Jun 7 2020, 16:42
deadalnix requested review of D6436: Explicitely pass the mempool down in some test.
Jun 7 2020, 16:30
deadalnix accepted D6430: [backport#16551] test: Pass down correct chain name in tests.
Jun 7 2020, 13:28
deadalnix accepted D6431: [backport#16551] test: Test that low difficulty chain fork is rejected.
Jun 7 2020, 13:28
deadalnix accepted D6432: [backport#18247] test: Remove redundant sync_with_ping after add_p2p_connection.
Jun 7 2020, 13:27
deadalnix requested changes to D6384: [backport#18247] test: Wait for both veracks in add_p2p_connection.

Still missing the dos header tree.

Jun 7 2020, 13:27
teamcity added a comment to D6435: Disconnect peers violating blocks-only mode.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 7 2020, 13:24
teamcity updated the summary of D6435: Disconnect peers violating blocks-only mode.
Jun 7 2020, 13:24
deadalnix requested review of D6435: Disconnect peers violating blocks-only mode.
Jun 7 2020, 13:24
teamcity added a comment to D6434: doc: improve comments relating to block-relay-only peers.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 7 2020, 13:12
teamcity updated the summary of D6434: doc: improve comments relating to block-relay-only peers.
Jun 7 2020, 13:12
deadalnix requested review of D6434: doc: improve comments relating to block-relay-only peers.
Jun 7 2020, 13:12
teamcity updated the summary of D6433: Don't relay addr messages to block-relay-only peers.
Jun 7 2020, 12:47
teamcity added a comment to D6433: Don't relay addr messages to block-relay-only peers.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 7 2020, 12:47
deadalnix requested review of D6433: Don't relay addr messages to block-relay-only peers.
Jun 7 2020, 12:46
deadalnix committed rABC33f713967dd5: Change ImportScriptPubKeys' internal to apply_label (authored by Andrew Chow <achow101-github@achow101.com>).
Change ImportScriptPubKeys' internal to apply_label
Jun 7 2020, 11:17
deadalnix closed D6410: Change ImportScriptPubKeys' internal to apply_label.
Jun 7 2020, 11:17
teamcity added a comment to D6432: [backport#18247] test: Remove redundant sync_with_ping after add_p2p_connection.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 7 2020, 02:46
teamcity updated the summary of D6432: [backport#18247] test: Remove redundant sync_with_ping after add_p2p_connection.
Jun 7 2020, 02:46
majcosta requested review of D6432: [backport#18247] test: Remove redundant sync_with_ping after add_p2p_connection.
Jun 7 2020, 02:46
majcosta updated the diff for D6384: [backport#18247] test: Wait for both veracks in add_p2p_connection.

rebase onto proper deps

Jun 7 2020, 02:34
teamcity added a comment to D6431: [backport#16551] test: Test that low difficulty chain fork is rejected.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 7 2020, 02:16
teamcity updated the summary of D6431: [backport#16551] test: Test that low difficulty chain fork is rejected.
Jun 7 2020, 02:16
majcosta requested review of D6431: [backport#16551] test: Test that low difficulty chain fork is rejected.
Jun 7 2020, 02:16
teamcity added a comment to D6430: [backport#16551] test: Pass down correct chain name in tests.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 7 2020, 02:10
teamcity updated the summary of D6430: [backport#16551] test: Pass down correct chain name in tests.
Jun 7 2020, 02:10
majcosta requested review of D6430: [backport#16551] test: Pass down correct chain name in tests.
Jun 7 2020, 02:10
majcosta committed rABC7a4fc02d8de7: [backport#16839] Avoid using g_rpc_node global in wallet code (authored by Russell Yanofsky <russ@yanofsky.org>).
[backport#16839] Avoid using g_rpc_node global in wallet code
Jun 7 2020, 01:51
majcosta closed D6419: [backport#16839] Avoid using g_rpc_node global in wallet code.
Jun 7 2020, 01:51
majcosta committed rABC49478a329299: [backport#16244] Move wallet creation out of the createwallet rpc into its own… (authored by Andrew Chow <achow101-github@achow101.com>).
[backport#16244] Move wallet creation out of the createwallet rpc into its own…
Jun 7 2020, 01:51
majcosta closed D6425: [backport#16244] Move wallet creation out of the createwallet rpc into its own function.
Jun 7 2020, 01:51
majcosta committed rABC8345f442a7e6: [backport#15006] Add option to create an encrypted wallet (authored by Andrew Chow <achow101-github@achow101.com>).
[backport#15006] Add option to create an encrypted wallet
Jun 7 2020, 01:50
majcosta closed D6423: [backport#15006] Add option to create an encrypted wallet.
Jun 7 2020, 01:50
majcosta accepted D6410: Change ImportScriptPubKeys' internal to apply_label.
Jun 7 2020, 01:40
majcosta committed rABC60df8b10021c: [backport#15713] Tidy up BroadcastTransaction() (authored by John Newbery <john@johnnewbery.com>).
[backport#15713] Tidy up BroadcastTransaction()
Jun 7 2020, 01:28
majcosta closed D6427: [backport#15713] Tidy up BroadcastTransaction().
Jun 7 2020, 01:28
majcosta updated the diff for D6425: [backport#16244] Move wallet creation out of the createwallet rpc into its own function.

rebase

Jun 7 2020, 01:25
deadalnix accepted D6423: [backport#15006] Add option to create an encrypted wallet.
Jun 7 2020, 01:22
majcosta updated the diff for D6423: [backport#15006] Add option to create an encrypted wallet.

placed a comment on its own line

Jun 7 2020, 01:20
deadalnix committed rABC3c4a3c0cf1cc: Log when an import is being skipped because we already have it (authored by Andrew Chow <achow101-github@achow101.com>).
Log when an import is being skipped because we already have it
Jun 7 2020, 01:17
deadalnix closed D6411: Log when an import is being skipped because we already have it.
Jun 7 2020, 01:16
deadalnix accepted D6427: [backport#15713] Tidy up BroadcastTransaction().
Jun 7 2020, 01:15
deadalnix accepted D6425: [backport#16244] Move wallet creation out of the createwallet rpc into its own function.
Jun 7 2020, 01:14
deadalnix requested changes to D6423: [backport#15006] Add option to create an encrypted wallet.
Jun 7 2020, 01:12
teamcity added a comment to D6429: Add 2 outbound block-relay-only connections.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 7 2020, 01:09
teamcity updated the summary of D6429: Add 2 outbound block-relay-only connections.
Jun 7 2020, 01:09
deadalnix requested review of D6429: Add 2 outbound block-relay-only connections.
Jun 7 2020, 01:09
deadalnix accepted D6419: [backport#16839] Avoid using g_rpc_node global in wallet code.
Jun 7 2020, 01:07
teamcity added a comment to D6428: Add comment explaining intended use of m_tx_relay.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 7 2020, 01:03
teamcity updated the summary of D6428: Add comment explaining intended use of m_tx_relay.
Jun 7 2020, 01:03
deadalnix requested review of D6428: Add comment explaining intended use of m_tx_relay.
Jun 7 2020, 01:03
teamcity added a comment to D6427: [backport#15713] Tidy up BroadcastTransaction().

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 7 2020, 00:58
teamcity updated the summary of D6427: [backport#15713] Tidy up BroadcastTransaction().
Jun 7 2020, 00:58
majcosta requested review of D6427: [backport#15713] Tidy up BroadcastTransaction().
Jun 7 2020, 00:58
teamcity added a comment to D6426: Check that tx_relay is initialized before access.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 7 2020, 00:57
teamcity updated the summary of D6426: Check that tx_relay is initialized before access.
Jun 7 2020, 00:57
deadalnix requested review of D6426: Check that tx_relay is initialized before access.
Jun 7 2020, 00:57
majcosta committed rABCf62324ecde56: [backport#15713 4/5] Remove unused submitToMemoryPool and relayTransactions… (authored by Antoine Riard <ariard@student.42.fr>).
[backport#15713 4/5] Remove unused submitToMemoryPool and relayTransactions…
Jun 7 2020, 00:39
majcosta closed D6422: [backport#15713 4/5] Remove unused submitToMemoryPool and relayTransactions Chain interfaces.
Jun 7 2020, 00:38
majcosta committed rABC552ce234fb05: [backport#15713 3/5] Remove duplicate checks in SubmitMemoryPoolAndRelay (authored by Antoine Riard <ariard@student.42.fr>).
[backport#15713 3/5] Remove duplicate checks in SubmitMemoryPoolAndRelay
Jun 7 2020, 00:38
majcosta closed D6421: [backport#15713 3/5] Remove duplicate checks in SubmitMemoryPoolAndRelay.
Jun 7 2020, 00:38
majcosta committed rABC5bdc385b0f6a: [backport#15713 2/5] Introduce CWalletTx::SubmitMemoryPoolAndRelay (authored by Antoine Riard <ariard@student.42.fr>).
[backport#15713 2/5] Introduce CWalletTx::SubmitMemoryPoolAndRelay
Jun 7 2020, 00:34
majcosta closed D6420: [backport#15713 2/5] Introduce CWalletTx::SubmitMemoryPoolAndRelay.
Jun 7 2020, 00:34
majcosta committed rABC5c8f7c532c3b: [backport#16839] scripted-diff: Remove g_connman, g_banman globals (authored by majcosta).
[backport#16839] scripted-diff: Remove g_connman, g_banman globals
Jun 7 2020, 00:33
majcosta closed D6418: [backport#16839] scripted-diff: Remove g_connman, g_banman globals.
Jun 7 2020, 00:33
majcosta updated the diff for D6419: [backport#16839] Avoid using g_rpc_node global in wallet code.

rebased onto missing deps, addressed comments

Jun 7 2020, 00:31
teamcity added a comment to D6425: [backport#16244] Move wallet creation out of the createwallet rpc into its own function.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 7 2020, 00:15
teamcity updated the summary of D6425: [backport#16244] Move wallet creation out of the createwallet rpc into its own function.
Jun 7 2020, 00:15
teamcity added a comment to D6424: Add tests and documentation for blocksonly.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 7 2020, 00:15
teamcity updated the summary of D6424: Add tests and documentation for blocksonly.
Jun 7 2020, 00:15
majcosta requested review of D6425: [backport#16244] Move wallet creation out of the createwallet rpc into its own function.
Jun 7 2020, 00:15
deadalnix requested review of D6424: Add tests and documentation for blocksonly.
Jun 7 2020, 00:14
majcosta accepted D6411: Log when an import is being skipped because we already have it.
Jun 7 2020, 00:11

Jun 6 2020

teamcity added a comment to D6423: [backport#15006] Add option to create an encrypted wallet.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 6 2020, 23:58
teamcity updated the summary of D6423: [backport#15006] Add option to create an encrypted wallet.
Jun 6 2020, 23:58
majcosta requested review of D6423: [backport#15006] Add option to create an encrypted wallet.
Jun 6 2020, 23:58
deadalnix committed rABCb1693872a95e: net: Remove unused unsanitized user agent string CNode::strSubVer (authored by MarcoFalke <falke.marco@gmail.com>).
net: Remove unused unsanitized user agent string CNode::strSubVer
Jun 6 2020, 23:47
deadalnix closed D6417: net: Remove unused unsanitized user agent string CNode::strSubVer.
Jun 6 2020, 23:47
majcosta accepted D6417: net: Remove unused unsanitized user agent string CNode::strSubVer.

"Fire is cool"

Jun 6 2020, 23:37
deadalnix accepted D6421: [backport#15713 3/5] Remove duplicate checks in SubmitMemoryPoolAndRelay.
Jun 6 2020, 23:18
deadalnix accepted D6422: [backport#15713 4/5] Remove unused submitToMemoryPool and relayTransactions Chain interfaces.
Jun 6 2020, 23:15
deadalnix committed rABC864a067138ef: [refactor] Change tx_relay structure to be unique_ptr (authored by Suhas Daftuar <sdaftuar@gmail.com>).
[refactor] Change tx_relay structure to be unique_ptr
Jun 6 2020, 23:15
deadalnix closed D6401: [refactor] Change tx_relay structure to be unique_ptr.
Jun 6 2020, 23:15
deadalnix committed rABCd80ffc2408df: [refactor] Move tx relay state to separate structure (authored by Suhas Daftuar <sdaftuar@gmail.com>).
[refactor] Move tx relay state to separate structure
Jun 6 2020, 23:14
deadalnix closed D6400: [refactor] Move tx relay state to separate structure.
Jun 6 2020, 23:14
majcosta updated the summary of D6422: [backport#15713 4/5] Remove unused submitToMemoryPool and relayTransactions Chain interfaces.
Jun 6 2020, 22:58
majcosta retitled D6422: [backport#15713 4/5] Remove unused submitToMemoryPool and relayTransactions Chain interfaces from [backport#15713 3/5] Remove unused submitToMemoryPool and relayTransactions Chain interfaces to [backport#15713 4/5] Remove unused submitToMemoryPool and relayTransactions Chain interfaces.
Jun 6 2020, 22:57
majcosta retitled D6421: [backport#15713 3/5] Remove duplicate checks in SubmitMemoryPoolAndRelay from [backport#15713] Remove duplicate checks in SubmitMemoryPoolAndRelay to [backport#15713 3/5] Remove duplicate checks in SubmitMemoryPoolAndRelay.
Jun 6 2020, 22:56
teamcity added a comment to D6422: [backport#15713 4/5] Remove unused submitToMemoryPool and relayTransactions Chain interfaces.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jun 6 2020, 22:56
teamcity updated the summary of D6422: [backport#15713 4/5] Remove unused submitToMemoryPool and relayTransactions Chain interfaces.
Jun 6 2020, 22:56
majcosta requested review of D6422: [backport#15713 4/5] Remove unused submitToMemoryPool and relayTransactions Chain interfaces.
Jun 6 2020, 22:56
majcosta requested review of D6421: [backport#15713 3/5] Remove duplicate checks in SubmitMemoryPoolAndRelay.

fat fingers, my bad

Jun 6 2020, 22:53
majcosta updated the summary of D6421: [backport#15713 3/5] Remove duplicate checks in SubmitMemoryPoolAndRelay.
Jun 6 2020, 22:53
nakihito accepted D6400: [refactor] Move tx relay state to separate structure.
Jun 6 2020, 22:46
deadalnix updated the diff for D6401: [refactor] Change tx_relay structure to be unique_ptr.

rebase

Jun 6 2020, 22:39
deadalnix accepted D6420: [backport#15713 2/5] Introduce CWalletTx::SubmitMemoryPoolAndRelay.
Jun 6 2020, 22:38
deadalnix updated the summary of D6420: [backport#15713 2/5] Introduce CWalletTx::SubmitMemoryPoolAndRelay.
Jun 6 2020, 22:36
deadalnix requested changes to D6421: [backport#15713 3/5] Remove duplicate checks in SubmitMemoryPoolAndRelay.

The patch doesn't seems to be the one in the description.

Jun 6 2020, 22:35
deadalnix updated the diff for D6400: [refactor] Move tx relay state to separate structure.

Relayout comments and remove changes from PR15654.

Jun 6 2020, 22:31