Page MenuHomePhabricator
Feed All Stories

Jul 7 2020

majcosta requested review of D6835: [backport#19188] test: Avoid overwriting the NodeContext member of the testing setup [-Wshadow-field].
Jul 7 2020, 01:09
majcosta updated the diff for D6539: [backport#14193] validation: Add missing mempool locks.

void UpdateMempoolForReorg void UpdateMempoolForReorg and a section of bool DisconnectTip were refactored into DisconnectedBlockTransactions::updateMempoolForReorg and DisconnectedBlockTransactions::addForBlock in D1667

Jul 7 2020, 00:34

Jul 6 2020

majcosta committed rABCfc1de4a6ae0e: [refactor] add const CChainParams& m_params to interface::ChainImpl (authored by majcosta).
[refactor] add const CChainParams& m_params to interface::ChainImpl
Jul 6 2020, 22:17
majcosta closed D6829: [refactor] add const CChainParams& m_params to interface::ChainImpl.
Jul 6 2020, 22:17
Fabien committed rABC35faecfbd153: [CI] Add a runOnDiff flag to the build configurations (authored by Fabien).
[CI] Add a runOnDiff flag to the build configurations
Jul 6 2020, 22:12
Fabien closed D6833: [CI] Add a runOnDiff flag to the build configurations.
Jul 6 2020, 22:12
deadalnix requested review of D6834: [avalanche] Use PerrManager instead of ad hoc logic in AvalancheProcessor.
Jul 6 2020, 21:51
deadalnix committed rABC7d1e29374d16: [avalanche] Factor AvalancheNode from PeerManager (authored by deadalnix).
[avalanche] Factor AvalancheNode from PeerManager
Jul 6 2020, 21:49
deadalnix closed D6831: [avalanche] Factor AvalancheNode from PeerManager.
Jul 6 2020, 21:49
deadalnix committed rABC2625cfcf5ed7: [avalanche] Move AvalancheNode to its own file (authored by deadalnix).
[avalanche] Move AvalancheNode to its own file
Jul 6 2020, 21:48
deadalnix closed D6830: [avalanche] Move AvalancheNode to its own file.
Jul 6 2020, 21:48
deadalnix added inline comments to D6831: [avalanche] Factor AvalancheNode from PeerManager.
Jul 6 2020, 21:48
deadalnix accepted D6829: [refactor] add const CChainParams& m_params to interface::ChainImpl.
Jul 6 2020, 21:47
deadalnix committed rABC4148611617c6: [avalanche] Remove getPubkey API (authored by deadalnix).
[avalanche] Remove getPubkey API
Jul 6 2020, 21:42
deadalnix closed D6828: [avalanche] Remove getPubkey API.
Jul 6 2020, 21:42
jasonbcox accepted D6833: [CI] Add a runOnDiff flag to the build configurations.
Jul 6 2020, 21:37
Fabien requested review of D6833: [CI] Add a runOnDiff flag to the build configurations.
Jul 6 2020, 21:36
jasonbcox accepted D6831: [avalanche] Factor AvalancheNode from PeerManager.
Jul 6 2020, 21:36
majcosta added inline comments to D6829: [refactor] add const CChainParams& m_params to interface::ChainImpl.
Jul 6 2020, 21:27
majcosta added inline comments to D6829: [refactor] add const CChainParams& m_params to interface::ChainImpl.
Jul 6 2020, 21:26
jasonbcox accepted D6830: [avalanche] Move AvalancheNode to its own file.
Jul 6 2020, 21:25
majcosta updated the diff for D6829: [refactor] add const CChainParams& m_params to interface::ChainImpl.

addressed comments

Jul 6 2020, 21:25
jasonbcox accepted D6828: [avalanche] Remove getPubkey API.
Jul 6 2020, 21:23
deadalnix requested review of D6831: [avalanche] Factor AvalancheNode from PeerManager.
Jul 6 2020, 20:49
deadalnix updated the summary of D6830: [avalanche] Move AvalancheNode to its own file.
Jul 6 2020, 20:48
deadalnix requested review of D6830: [avalanche] Move AvalancheNode to its own file.
Jul 6 2020, 20:47
deadalnix requested changes to D6829: [refactor] add const CChainParams& m_params to interface::ChainImpl.

Good start, but you needlessly complicated yourself for the tests.

Jul 6 2020, 20:00
majcosta updated the test plan for D6829: [refactor] add const CChainParams& m_params to interface::ChainImpl.
Jul 6 2020, 19:36
majcosta updated the test plan for D6829: [refactor] add const CChainParams& m_params to interface::ChainImpl.
Jul 6 2020, 19:36
majcosta updated the test plan for D6829: [refactor] add const CChainParams& m_params to interface::ChainImpl.
Jul 6 2020, 19:36
majcosta requested review of D6829: [refactor] add const CChainParams& m_params to interface::ChainImpl.
Jul 6 2020, 19:36
deadalnix requested review of D6828: [avalanche] Remove getPubkey API.
Jul 6 2020, 18:11
deadalnix committed rABCc357d6422cbd: [avalanche] Add a facility to update node's timeout (authored by deadalnix).
[avalanche] Add a facility to update node's timeout
Jul 6 2020, 12:41
deadalnix closed D6825: [avalanche] Add a facility to update node's timeout.
Jul 6 2020, 12:41
deadalnix added inline comments to D6825: [avalanche] Add a facility to update node's timeout.
Jul 6 2020, 12:40
deadalnix committed rABCdcae6a72516c: [avalanche] Add facilities to delete nodes from the PeerManager (authored by deadalnix).
[avalanche] Add facilities to delete nodes from the PeerManager
Jul 6 2020, 12:39
deadalnix closed D6824: [avalanche] Add facilities to delete nodes from the PeerManager.
Jul 6 2020, 12:39
deadalnix committed rABC785a2f794bac: [avalanche] Add node related functions to the peermanager (authored by deadalnix).
[avalanche] Add node related functions to the peermanager
Jul 6 2020, 12:38
deadalnix closed D6822: [avalanche] Add node related functions to the peermanager.
Jul 6 2020, 12:37
deadalnix committed rABCb406ddfc609f: [avalanche] Add the notion of Peer to the PeerManager (authored by deadalnix).
[avalanche] Add the notion of Peer to the PeerManager
Jul 6 2020, 12:36
deadalnix closed D6818: [avalanche] Add the notion of Peer to the PeerManager.
Jul 6 2020, 12:36
deadalnix committed rABC77ce7e791586: [avalanche] Use an hash_unique key for the node/round index in QuerySet (authored by deadalnix).
[avalanche] Use an hash_unique key for the node/round index in QuerySet
Jul 6 2020, 12:34
deadalnix closed D6823: [avalanche] Use an hash_unique key for the node/round index in QuerySet.
Jul 6 2020, 12:34
deadalnix committed rABC52d09d010769: Move NO_NODE to net.h (authored by deadalnix).
Move NO_NODE to net.h
Jul 6 2020, 12:33
deadalnix closed D6826: Move NO_NODE to net.h.
Jul 6 2020, 12:33
Fabien accepted D6826: Move NO_NODE to net.h.
Jul 6 2020, 06:33
Fabien accepted D6825: [avalanche] Add a facility to update node's timeout.
Jul 6 2020, 06:32
Fabien accepted D6824: [avalanche] Add facilities to delete nodes from the PeerManager.
Jul 6 2020, 06:26
Fabien accepted D6823: [avalanche] Use an hash_unique key for the node/round index in QuerySet.
Jul 6 2020, 06:21
Fabien accepted D6822: [avalanche] Add node related functions to the peermanager.
Jul 6 2020, 06:20
Fabien accepted D6818: [avalanche] Add the notion of Peer to the PeerManager.
Jul 6 2020, 06:02
deadalnix requested review of D6826: Move NO_NODE to net.h.
Jul 6 2020, 00:01

Jul 5 2020

deadalnix requested review of D6825: [avalanche] Add a facility to update node's timeout.
Jul 5 2020, 21:59
deadalnix requested review of D6824: [avalanche] Add facilities to delete nodes from the PeerManager.
Jul 5 2020, 21:46
deadalnix updated the diff for D6822: [avalanche] Add node related functions to the peermanager.

Flatten things such as one multi_index is used and all nodes are in it.

Jul 5 2020, 17:56
deadalnix updated the diff for D6818: [avalanche] Add the notion of Peer to the PeerManager.

Simplify the Peer struct so that it doesn't contain nodes. Nodes wills be stored in their own datastructure later on.

Jul 5 2020, 17:25
majcosta committed rABC061f629c7e3e: [backport#15267] doc: explain AcceptToMemoryPoolWorker's coins_to_uncache (authored by James O'Beirne <james.obeirne@gmail.com>).
[backport#15267] doc: explain AcceptToMemoryPoolWorker's coins_to_uncache
Jul 5 2020, 03:47
majcosta closed D6819: [backport#15267] doc: explain AcceptToMemoryPoolWorker's coins_to_uncache.
Jul 5 2020, 03:47
deadalnix planned changes to D6822: [avalanche] Add node related functions to the peermanager.

See D6818

Jul 5 2020, 02:42
deadalnix planned changes to D6818: [avalanche] Add the notion of Peer to the PeerManager.

There is a better way to do this using multi index magic.

Jul 5 2020, 02:41
deadalnix requested review of D6823: [avalanche] Use an hash_unique key for the node/round index in QuerySet.
Jul 5 2020, 02:28
deadalnix updated the diff for D6822: [avalanche] Add node related functions to the peermanager.

rebase

Jul 5 2020, 00:44
deadalnix updated the diff for D6818: [avalanche] Add the notion of Peer to the PeerManager.

rebase

Jul 5 2020, 00:44
deadalnix accepted D6819: [backport#15267] doc: explain AcceptToMemoryPoolWorker's coins_to_uncache.
Jul 5 2020, 00:41
deadalnix committed rABC0f4e51c145e0: [avalanche] Use std::chrono for time constants (authored by deadalnix).
[avalanche] Use std::chrono for time constants
Jul 5 2020, 00:38
deadalnix closed D6821: [avalanche] Use std::chrono for time constants.
Jul 5 2020, 00:38
deadalnix committed rABC7bd7f8c0caea: [avalanche] Use constexpr for global constants (authored by deadalnix).
[avalanche] Use constexpr for global constants
Jul 5 2020, 00:34
deadalnix closed D6820: [avalanche] Use constexpr for global constants.
Jul 5 2020, 00:34
deadalnix updated the summary of D6822: [avalanche] Add node related functions to the peermanager.
Jul 5 2020, 00:31
deadalnix requested review of D6822: [avalanche] Add node related functions to the peermanager.
Jul 5 2020, 00:31
majcosta accepted D6821: [avalanche] Use std::chrono for time constants.
Jul 5 2020, 00:13
majcosta accepted D6820: [avalanche] Use constexpr for global constants.

Nit: consider getting rid of the AVALANCHE_ prefix unless where needed to convey that info; this is all static and we're in src/avalanche after all

Jul 5 2020, 00:11

Jul 4 2020

deadalnix updated the diff for D6821: [avalanche] Use std::chrono for time constants.

Name tweaks

Jul 4 2020, 23:52
deadalnix requested review of D6821: [avalanche] Use std::chrono for time constants.
Jul 4 2020, 23:45
deadalnix updated the diff for D6820: [avalanche] Use constexpr for global constants.

Also do AVALANCHE_TIME_STEP_MILLISECONDS

Jul 4 2020, 23:41
deadalnix requested review of D6820: [avalanche] Use constexpr for global constants.
Jul 4 2020, 23:32
teamcity added a comment to D6819: [backport#15267] doc: explain AcceptToMemoryPoolWorker's coins_to_uncache.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jul 4 2020, 22:53
teamcity updated the summary of D6819: [backport#15267] doc: explain AcceptToMemoryPoolWorker's coins_to_uncache.
Jul 4 2020, 22:53
majcosta requested review of D6819: [backport#15267] doc: explain AcceptToMemoryPoolWorker's coins_to_uncache.
Jul 4 2020, 22:53
Fabien committed rABC04cf5437c814: [CI] Improve teamcity error reporting by setting the failure message (authored by Fabien).
[CI] Improve teamcity error reporting by setting the failure message
Jul 4 2020, 07:34
Fabien closed D6817: [CI] Improve teamcity error reporting by setting the failure message.
Jul 4 2020, 07:34
deadalnix updated the diff for D6818: [avalanche] Add the notion of Peer to the PeerManager.

vetor => vector

Jul 4 2020, 01:01
deadalnix requested review of D6818: [avalanche] Add the notion of Peer to the PeerManager.
Jul 4 2020, 01:00

Jul 3 2020

jasonbcox accepted D6817: [CI] Improve teamcity error reporting by setting the failure message.
Jul 3 2020, 21:49
deadalnix accepted D6817: [CI] Improve teamcity error reporting by setting the failure message.
Jul 3 2020, 21:47
teamcity added a comment to D6571: [WIP] Test commit, don't review.
Jul 3 2020, 21:41
teamcity added a comment to D6571: [WIP] Test commit, don't review.
Jul 3 2020, 21:36
Fabien added a comment to D6817: [CI] Improve teamcity error reporting by setting the failure message.

Examples of rendering:
Success: https://build.bitcoinabc.org/viewLog.html?buildTypeId=BitcoinABC_BitcoinAbcStaging&buildId=91213&guest=1
And failure: https://build.bitcoinabc.org/viewLog.html?buildTypeId=BitcoinABC_BitcoinAbcStaging&buildId=91243&guest=1

Jul 3 2020, 21:34
teamcity added a comment to D6571: [WIP] Test commit, don't review.
Jul 3 2020, 21:33
Fabien planned changes to D6571: [WIP] Test commit, don't review.
Jul 3 2020, 21:25
Fabien updated the diff for D6571: [WIP] Test commit, don't review.

Rebase

Jul 3 2020, 21:24
Fabien updated the diff for D6817: [CI] Improve teamcity error reporting by setting the failure message.

Don't keep the original message in case of a failure

Jul 3 2020, 21:24
teamcity added a comment to D6571: [WIP] Test commit, don't review.
Jul 3 2020, 21:21
teamcity added a comment to D6571: [WIP] Test commit, don't review.
Jul 3 2020, 21:20
teamcity added a comment to D6571: [WIP] Test commit, don't review.
Jul 3 2020, 21:20
Fabien updated the diff for D6817: [CI] Improve teamcity error reporting by setting the failure message.

Deduplicate the status message

Jul 3 2020, 21:15
Fabien planned changes to D6571: [WIP] Test commit, don't review.
Jul 3 2020, 21:12
Fabien updated the diff for D6571: [WIP] Test commit, don't review.

Rebase

Jul 3 2020, 21:11
teamcity added a comment to D6571: [WIP] Test commit, don't review.
Jul 3 2020, 21:08
teamcity added a comment to D6571: [WIP] Test commit, don't review.
Jul 3 2020, 21:08