Page MenuHomePhabricator
Feed All Stories

Jul 13 2020

jasonbcox requested review of D6923: [validation] Remove fMissingInputs from AcceptToMemoryPool().
Jul 13 2020, 18:28
deadalnix updated the diff for D6914: [avalanche] Add buildavalanchproof RPC call.

Address comments

Jul 13 2020, 18:14
deadalnix requested review of D6922: [avalanche] Do not add invalid proof in PeerManager.
Jul 13 2020, 18:08
deadalnix added inline comments to D6914: [avalanche] Add buildavalanchproof RPC call.
Jul 13 2020, 15:48
deadalnix committed rABC5e0a00f10117: [avalanche] Generate proof that verify (authored by deadalnix).
[avalanche] Generate proof that verify
Jul 13 2020, 13:39
deadalnix closed D6913: [avalanche] Generate proof that verify.
Jul 13 2020, 13:39
deadalnix committed rABC464da9894922: [avalanche] Move makeRandomProof to the test framework (authored by deadalnix).
[avalanche] Move makeRandomProof to the test framework
Jul 13 2020, 13:33
deadalnix closed D6912: [avalanche] Move makeRandomProof to the test framework.
Jul 13 2020, 13:33
Fabien requested changes to D6914: [avalanche] Add buildavalanchproof RPC call.
Jul 13 2020, 07:44
Fabien accepted D6913: [avalanche] Generate proof that verify.
Jul 13 2020, 07:32
Fabien accepted D6912: [avalanche] Move makeRandomProof to the test framework.
Jul 13 2020, 07:31

Jul 11 2020

deadalnix requested review of D6914: [avalanche] Add buildavalanchproof RPC call.
Jul 11 2020, 22:19
deadalnix requested review of D6913: [avalanche] Generate proof that verify.
Jul 11 2020, 14:39
deadalnix requested review of D6912: [avalanche] Move makeRandomProof to the test framework.
Jul 11 2020, 14:27
teamcity closed T994: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux ARM is broken. as Resolved.
Jul 11 2020, 13:49
deadalnix committed rABCdd13e82f8537: [avalanche] Change the addavalanchenode RPC so that it return if the operation… (authored by deadalnix).
[avalanche] Change the addavalanchenode RPC so that it return if the operation…
Jul 11 2020, 13:14
deadalnix closed D6911: [avalanche] Change the addavalanchenode RPC so that it return if the operation succeeded.
Jul 11 2020, 13:13
deadalnix requested changes to D6906: [backport#17357 2/2] tests: Add fuzzing harness for Bech32 encoding/decoding.
Jul 11 2020, 13:11
majcosta accepted D6911: [avalanche] Change the addavalanchenode RPC so that it return if the operation succeeded.
Jul 11 2020, 02:52
teamcity triaged T994: Build Bitcoin-ABC / Master / Cross Builds / Cross Build Linux ARM is broken. as Unbreak Now! priority.
Jul 11 2020, 00:28
deadalnix requested review of D6911: [avalanche] Change the addavalanchenode RPC so that it return if the operation succeeded.
Jul 11 2020, 00:20

Jul 10 2020

deadalnix requested changes to D6861: [refactor] refactor FinalizeBlockAndInvalidate.
Jul 10 2020, 23:56
majcosta updated the diff for D6906: [backport#17357 2/2] tests: Add fuzzing harness for Bech32 encoding/decoding.

good catch, that was wrong

Jul 10 2020, 23:28
teamcity triaged T993: Build Bitcoin-ABC / Master / Sanitizers / Thread Sanitizer (TSAN) is broken. as Unbreak Now! priority.
Jul 10 2020, 23:26
jasonbcox committed rABC503ba2615978: Merge #14524: Trivial: fix typo (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Merge #14524: Trivial: fix typo
Jul 10 2020, 23:11
jasonbcox closed D6895: Merge #14524: Trivial: fix typo.
Jul 10 2020, 23:11
deadalnix accepted D6898: [backport#17291] tests: Add fuzzing harness for ISO-8601 related functions.
Jul 10 2020, 22:43
majcosta updated the diff for D6861: [refactor] refactor FinalizeBlockAndInvalidate.

encapsulated functions into CChainState class, handled locking of cs_main in public facing method

Jul 10 2020, 22:42
deadalnix accepted D6896: [backport#17083] tests: Add fuzzing harness for various CScript related functions.
Jul 10 2020, 22:42
deadalnix requested changes to D6906: [backport#17357 2/2] tests: Add fuzzing harness for Bech32 encoding/decoding.
Jul 10 2020, 22:40
deadalnix accepted D6904: [backport#17357 1/2] tests: Move CaseInsensitiveEqual to test/util/str.
Jul 10 2020, 22:38
deadalnix committed rABC1e3cb98e15ed: Use RPCTypeCheck in avalanche's RPC (authored by deadalnix).
Use RPCTypeCheck in avalanche's RPC
Jul 10 2020, 22:37
deadalnix closed D6892: Use RPCTypeCheck in avalanche's RPC.
Jul 10 2020, 22:37
teamcity added a comment to D6571: [WIP] Test commit, don't review.
Jul 10 2020, 22:20
Fabien added a comment to D6571: [WIP] Test commit, don't review.

@bot build-clang-10

Jul 10 2020, 22:19
teamcity added a comment to D6571: [WIP] Test commit, don't review.
Jul 10 2020, 22:08
Fabien added a comment to D6571: [WIP] Test commit, don't review.

@bot build-clang-10

Jul 10 2020, 22:07
majcosta retitled D6906: [backport#17357 2/2] tests: Add fuzzing harness for Bech32 encoding/decoding from [backport#17357] tests: Add fuzzing harness for Bech32 encoding/decoding to [backport#17357 2/2] tests: Add fuzzing harness for Bech32 encoding/decoding.
Jul 10 2020, 21:54
Fabien added a comment to D6571: [WIP] Test commit, don't review.

@bot build-clang-10

Jul 10 2020, 21:38
teamcity added a comment to D6906: [backport#17357 2/2] tests: Add fuzzing harness for Bech32 encoding/decoding.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jul 10 2020, 21:23
teamcity updated the summary of D6906: [backport#17357 2/2] tests: Add fuzzing harness for Bech32 encoding/decoding.
Jul 10 2020, 21:23
majcosta requested review of D6906: [backport#17357 2/2] tests: Add fuzzing harness for Bech32 encoding/decoding.
Jul 10 2020, 21:23
teamcity added a comment to D6904: [backport#17357 1/2] tests: Move CaseInsensitiveEqual to test/util/str.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jul 10 2020, 21:09
teamcity updated the summary of D6904: [backport#17357 1/2] tests: Move CaseInsensitiveEqual to test/util/str.
Jul 10 2020, 21:09
majcosta requested review of D6904: [backport#17357 1/2] tests: Move CaseInsensitiveEqual to test/util/str.
Jul 10 2020, 21:09
teamcity added a comment to D6898: [backport#17291] tests: Add fuzzing harness for ISO-8601 related functions.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jul 10 2020, 19:37
teamcity updated the summary of D6898: [backport#17291] tests: Add fuzzing harness for ISO-8601 related functions.
Jul 10 2020, 19:37
majcosta requested review of D6898: [backport#17291] tests: Add fuzzing harness for ISO-8601 related functions.
Jul 10 2020, 19:37
teamcity added a comment to D6895: Merge #14524: Trivial: fix typo.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jul 10 2020, 19:11
teamcity updated the summary of D6895: Merge #14524: Trivial: fix typo.
Jul 10 2020, 19:11
teamcity added a comment to D6896: [backport#17083] tests: Add fuzzing harness for various CScript related functions.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jul 10 2020, 19:10
teamcity updated the summary of D6896: [backport#17083] tests: Add fuzzing harness for various CScript related functions.
Jul 10 2020, 19:10
majcosta accepted D6895: Merge #14524: Trivial: fix typo.
Jul 10 2020, 19:08
majcosta requested review of D6896: [backport#17083] tests: Add fuzzing harness for various CScript related functions.
Jul 10 2020, 18:50
jasonbcox requested review of D6895: Merge #14524: Trivial: fix typo.
Jul 10 2020, 18:45
martina updated martina.
Jul 10 2020, 18:40
jasonbcox updated the diff for D6799: [land-bot] Pass committer name/email to land bot endpoint.

Use GIT_COMMITTER_IDENT directly for both name and email. This no longer
uses any part of the Arcanist API, but is heavily influenced from their code.

Jul 10 2020, 17:50
Fabien accepted D6892: Use RPCTypeCheck in avalanche's RPC.
Jul 10 2020, 16:14
majcosta committed rABCfed8c7465286: [backports] tests: Skip unnecessary fuzzer initialisation. Hold ECCVerifyHandle… (authored by MarcoFalke <falke.marco@gmail.com>).
[backports] tests: Skip unnecessary fuzzer initialisation. Hold ECCVerifyHandle…
Jul 10 2020, 16:10
majcosta closed D6883: [backports] tests: Skip unnecessary fuzzer initialisation. Hold ECCVerifyHandle only when needed..
Jul 10 2020, 16:10
majcosta committed rABC18edda4a16e6: [correction] fix comment style for D6878 (authored by majcosta).
[correction] fix comment style for D6878
Jul 10 2020, 16:09
majcosta closed D6887: [correction] fix comment style for D6878.
Jul 10 2020, 16:09
jasonbcox committed rABC0b39bc3f5a70: [validation] Remove useless ret parameter from Invalid() (authored by jasonbcox).
[validation] Remove useless ret parameter from Invalid()
Jul 10 2020, 15:57
jasonbcox closed D6885: [validation] Remove useless ret parameter from Invalid().
Jul 10 2020, 15:57
deadalnix requested review of D6892: Use RPCTypeCheck in avalanche's RPC.
Jul 10 2020, 15:50
deadalnix committed rABC360cb45964fc: [avalanche] Create addavalanchenode RPC call (authored by deadalnix).
[avalanche] Create addavalanchenode RPC call
Jul 10 2020, 11:57
deadalnix closed D6886: [avalanche] Create addavalanchenode RPC call.
Jul 10 2020, 11:56
Fabien requested changes to D6799: [land-bot] Pass committer name/email to land bot endpoint.
Jul 10 2020, 07:39
Fabien accepted D6885: [validation] Remove useless ret parameter from Invalid().
Jul 10 2020, 07:00
Fabien accepted D6883: [backports] tests: Skip unnecessary fuzzer initialisation. Hold ECCVerifyHandle only when needed..
Jul 10 2020, 06:53
jasonbcox abandoned D6668: [DO NOT REVIEW] PATCH TEST 2.
Jul 10 2020, 00:13
jasonbcox abandoned D6667: [DO NOT REVIEW] PATCH TEST 1.
Jul 10 2020, 00:13
jasonbcox abandoned D6016: Test patch; please do NOT review.
Jul 10 2020, 00:13

Jul 9 2020

jasonbcox accepted D6886: [avalanche] Create addavalanchenode RPC call.
Jul 9 2020, 23:53
jasonbcox accepted D6887: [correction] fix comment style for D6878.
Jul 9 2020, 23:49
majcosta committed rABC526a21b26a1b: [backport#17018] tests: Add Parse(...) (descriptor) fuzzing harness (authored by practicalswift <practicalswift@users.noreply.github.com>).
[backport#17018] tests: Add Parse(...) (descriptor) fuzzing harness
Jul 9 2020, 23:48
majcosta closed D6881: [backport#17018] tests: Add Parse(...) (descriptor) fuzzing harness.
Jul 9 2020, 23:47
majcosta committed rABC70e026e8889b: [backport#17113] tests: Add fuzzing harness for descriptor Span-parsing helpers (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#17113] tests: Add fuzzing harness for descriptor Span-parsing helpers
Jul 9 2020, 23:44
majcosta closed D6880: [backport#17113] tests: Add fuzzing harness for descriptor Span-parsing helpers.
Jul 9 2020, 23:44
majcosta requested review of D6887: [correction] fix comment style for D6878.
Jul 9 2020, 23:43
majcosta committed rABC7dab6aa3923c: [backport#16887 3/3] test: add unit tests for Span-parsing helpers (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>).
[backport#16887 3/3] test: add unit tests for Span-parsing helpers
Jul 9 2020, 23:37
majcosta closed D6879: [backport#16887 3/3] test: add unit tests for Span-parsing helpers.
Jul 9 2020, 23:37
majcosta committed rABC21181ec40c31: [backport#16887 2/3] Add documenting comments to spanparsing.h (authored by Pieter Wuille <pieter.wuille@gmail.com>).
[backport#16887 2/3] Add documenting comments to spanparsing.h
Jul 9 2020, 23:36
majcosta closed D6878: [backport#16887 2/3] Add documenting comments to spanparsing.h.
Jul 9 2020, 23:36
majcosta committed rABCf206c4defc32: [backport#16887 1/3] Abstract out some of the descriptor Span-parsing helpers (authored by Pieter Wuille <pieter.wuille@gmail.com>).
[backport#16887 1/3] Abstract out some of the descriptor Span-parsing helpers
Jul 9 2020, 23:34
majcosta closed D6877: [backport#16887 1/3] Abstract out some of the descriptor Span-parsing helpers.
Jul 9 2020, 23:34
deadalnix requested review of D6886: [avalanche] Create addavalanchenode RPC call.
Jul 9 2020, 23:34
deadalnix accepted D6878: [backport#16887 2/3] Add documenting comments to spanparsing.h.
Jul 9 2020, 23:27
majcosta updated the diff for D6878: [backport#16887 2/3] Add documenting comments to spanparsing.h.

fix comment formatting

Jul 9 2020, 23:19
teamcity added a comment to D6885: [validation] Remove useless ret parameter from Invalid().

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Jul 9 2020, 23:05
teamcity updated the summary of D6885: [validation] Remove useless ret parameter from Invalid().
Jul 9 2020, 23:05
jasonbcox requested review of D6885: [validation] Remove useless ret parameter from Invalid().
Jul 9 2020, 23:05
deadalnix accepted D6881: [backport#17018] tests: Add Parse(...) (descriptor) fuzzing harness.
Jul 9 2020, 22:39
deadalnix accepted D6880: [backport#17113] tests: Add fuzzing harness for descriptor Span-parsing helpers.
Jul 9 2020, 22:35
deadalnix accepted D6879: [backport#16887 3/3] test: add unit tests for Span-parsing helpers.
Jul 9 2020, 22:31
deadalnix requested changes to D6878: [backport#16887 2/3] Add documenting comments to spanparsing.h.
Jul 9 2020, 22:31
deadalnix accepted D6877: [backport#16887 1/3] Abstract out some of the descriptor Span-parsing helpers.
Jul 9 2020, 22:30
deadalnix committed rABC3bd72bcd07e0: [avalanche] Add capability to verify proofs (authored by deadalnix).
[avalanche] Add capability to verify proofs
Jul 9 2020, 22:26
deadalnix closed D6875: [avalanche] Add capability to verify proofs.
Jul 9 2020, 22:26
jasonbcox committed rABC754a9d81cf88: [validation] Remove unused first_invalid parameter from ProcessNewBlockHeaders() (authored by John Newbery <john@johnnewbery.com>).
[validation] Remove unused first_invalid parameter from ProcessNewBlockHeaders()
Jul 9 2020, 22:07