Page MenuHomePhabricator
Feed All Stories

Jul 20 2020

deadalnix accepted D6984: [refactor] remove global mapBlockIndex access from parkblock RPC.
Jul 20 2020, 22:54
Fabien committed rABC680e87100166: [GITIAN] Remove vagrant support documentation for the gitian builds (authored by Fabien).
[GITIAN] Remove vagrant support documentation for the gitian builds
Jul 20 2020, 22:48
Fabien closed D6978: [GITIAN] Remove vagrant support documentation for the gitian builds.
Jul 20 2020, 22:48
Fabien accepted D6982: Renaming bswap_tests test case so that the name does not collide with the test suite name.

There should be a linter for that

Jul 20 2020, 22:36
teamcity added a comment to D6571: [WIP] Test commit, don't review.
Jul 20 2020, 22:24
Fabien requested changes to D6979: Add build config for documentation, including RPC docs.
Jul 20 2020, 22:23
jasonbcox accepted D6983: [CI] Store functional tests duration with ms resolution in Junit.
Jul 20 2020, 22:23
Fabien committed rABC505960069a6e: [GITIAN] Fix instructions for extracting the OSX SDK (authored by Fabien).
[GITIAN] Fix instructions for extracting the OSX SDK
Jul 20 2020, 21:44
Fabien closed D6977: [GITIAN] Fix instructions for extracting the OSX SDK.
Jul 20 2020, 21:44
Fabien closed D6976: [GITIAN] Update scripts and docs to use the local gitian version.
Jul 20 2020, 21:43
Fabien committed rABC9bb1a69a514d: [GITIAN] Update scripts and docs to use the local gitian version (authored by Fabien).
[GITIAN] Update scripts and docs to use the local gitian version
Jul 20 2020, 21:43
Fabien committed rABC034693d46b13: [CMAKE] Don't distribute gitian as part of our sources package (authored by Fabien).
[CMAKE] Don't distribute gitian as part of our sources package
Jul 20 2020, 21:42
Fabien closed D6974: [CMAKE] Don't distribute gitian as part of our sources package.
Jul 20 2020, 21:42
majcosta requested review of D6984: [refactor] remove global mapBlockIndex access from parkblock RPC.
Jul 20 2020, 21:39
Fabien committed rABC2ea91fae53f6: [GITIAN] Don't ignore target-bin/ (authored by Fabien).
[GITIAN] Don't ignore target-bin/
Jul 20 2020, 21:38
Fabien closed D6973: [GITIAN] Don't ignore target-bin/.
Jul 20 2020, 21:38
Fabien committed rABC96d4b649abd1: [GITIAN] Pull gitian sources in our repo (authored by Fabien).
[GITIAN] Pull gitian sources in our repo
Jul 20 2020, 21:37
Fabien closed D6972: [GITIAN] Pull gitian sources in our repo.
Jul 20 2020, 21:37
Fabien requested review of D6983: [CI] Store functional tests duration with ms resolution in Junit.
Jul 20 2020, 21:27
jasonbcox requested review of D6982: Renaming bswap_tests test case so that the name does not collide with the test suite name.
Jul 20 2020, 21:07
jasonbcox planned changes to D6982: Renaming bswap_tests test case so that the name does not collide with the test suite name.
Jul 20 2020, 20:59
jasonbcox requested review of D6982: Renaming bswap_tests test case so that the name does not collide with the test suite name.
Jul 20 2020, 20:59
jasonbcox accepted D6977: [GITIAN] Fix instructions for extracting the OSX SDK.
Jul 20 2020, 20:00
jasonbcox accepted D6978: [GITIAN] Remove vagrant support documentation for the gitian builds.
Jul 20 2020, 19:58
jasonbcox accepted D6976: [GITIAN] Update scripts and docs to use the local gitian version.
Jul 20 2020, 19:58
deadalnix changed the visibility for D6981: Implement Grasberg DAA.
Jul 20 2020, 18:55
deadalnix requested review of D6981: Implement Grasberg DAA.
Jul 20 2020, 18:55
majcosta updated the diff for D6968: [backport#16194] refactoring: make pindexBestInvalid internal to validation.cpp.

this is still encapsulation theatre, since both members are still public. but at least they're on just one place now and considering PR scope, it's a start

Jul 20 2020, 17:05
jasonbcox requested review of D6979: Add build config for documentation, including RPC docs.
Jul 20 2020, 16:51
deadalnix accepted D6973: [GITIAN] Don't ignore target-bin/.
Jul 20 2020, 16:10
jasonbcox committed rABC98cd27974781: Generate RPC docs using regtest (authored by jasonbcox).
Generate RPC docs using regtest
Jul 20 2020, 15:59
jasonbcox closed D6971: Generate RPC docs using regtest.
Jul 20 2020, 15:59
majcosta committed rABC7f8bce5c2cd3: [lint] update Avalanche change to circular dep status (authored by majcosta).
[lint] update Avalanche change to circular dep status
Jul 20 2020, 15:53
majcosta closed D6966: [lint] update Avalanche change to circular dep status.
Jul 20 2020, 15:53
majcosta committed rABCcea7b22fdb0f: [refactor] access mapBlockIndex via function in Avalanche code (authored by majcosta).
[refactor] access mapBlockIndex via function in Avalanche code
Jul 20 2020, 15:52
majcosta closed D6965: [refactor] access mapBlockIndex via function in Avalanche code.
Jul 20 2020, 15:52
majcosta committed rABCbd65ad08d28c: [backport#17357 2/2] tests: Add fuzzing harness for Bech32 encoding/decoding (authored by practicalswift <practicalswift@users.noreply.github.com>).
[backport#17357 2/2] tests: Add fuzzing harness for Bech32 encoding/decoding
Jul 20 2020, 15:45
majcosta closed D6906: [backport#17357 2/2] tests: Add fuzzing harness for Bech32 encoding/decoding.
Jul 20 2020, 15:44
majcosta committed rABC842263b6a90e: [backport#17357 1/2] tests: Move CaseInsensitiveEqual to test/util/str (authored by practicalswift <practicalswift@users.noreply.github.com>).
[backport#17357 1/2] tests: Move CaseInsensitiveEqual to test/util/str
Jul 20 2020, 15:44
majcosta closed D6904: [backport#17357 1/2] tests: Move CaseInsensitiveEqual to test/util/str.
Jul 20 2020, 15:44
majcosta updated the diff for D6906: [backport#17357 2/2] tests: Add fuzzing harness for Bech32 encoding/decoding.

rebase

Jul 20 2020, 15:30
majcosta updated the diff for D6904: [backport#17357 1/2] tests: Move CaseInsensitiveEqual to test/util/str.

rebase

Jul 20 2020, 15:29
Fabien requested review of D6978: [GITIAN] Remove vagrant support documentation for the gitian builds.
Jul 20 2020, 15:14
Fabien requested review of D6973: [GITIAN] Don't ignore target-bin/.

It adds the target-bin directory which was previously ignored due to the bad pattern in the .gitignore file.

Jul 20 2020, 14:45
Fabien updated the summary of D6973: [GITIAN] Don't ignore target-bin/.
Jul 20 2020, 14:44
Fabien updated the summary of D6973: [GITIAN] Don't ignore target-bin/.
Jul 20 2020, 14:44
Fabien requested review of D6977: [GITIAN] Fix instructions for extracting the OSX SDK.
Jul 20 2020, 14:42
teamcity closed T997: Build Bitcoin-ABC / Master / Sanitizers / Thread Sanitizer (TSAN) is broken. as Resolved.
Jul 20 2020, 14:41
deadalnix accepted D6974: [CMAKE] Don't distribute gitian as part of our sources package.

This has the wrong dependencies and should probably be packaged in D6974 .

Jul 20 2020, 14:30
deadalnix accepted D6976: [GITIAN] Update scripts and docs to use the local gitian version.

Not sure about doing everything in tree, but so be it. Consider moving things somewhere else down the road.

Jul 20 2020, 14:29
deadalnix requested changes to D6973: [GITIAN] Don't ignore target-bin/.

There is way more code in there than the description addresses. What is this, what does it do?

Jul 20 2020, 14:26
deadalnix accepted D6972: [GITIAN] Pull gitian sources in our repo.
Jul 20 2020, 14:25
deadalnix committed rABC2008ff087d7e: Pass chain params down to GetNextWorkRequired (authored by deadalnix).
Pass chain params down to GetNextWorkRequired
Jul 20 2020, 14:23
deadalnix closed D6975: Pass chain params down to GetNextWorkRequired.
Jul 20 2020, 14:23
Fabien accepted D6975: Pass chain params down to GetNextWorkRequired.
Jul 20 2020, 14:12
Fabien requested review of D6976: [GITIAN] Update scripts and docs to use the local gitian version.
Jul 20 2020, 13:47
deadalnix requested review of D6975: Pass chain params down to GetNextWorkRequired.
Jul 20 2020, 13:39
Fabien requested review of D6974: [CMAKE] Don't distribute gitian as part of our sources package.
Jul 20 2020, 13:33
Fabien requested review of D6973: [GITIAN] Don't ignore target-bin/.
Jul 20 2020, 13:25
Fabien updated the summary of D6972: [GITIAN] Pull gitian sources in our repo.
Jul 20 2020, 13:18
Fabien updated the diff for D6972: [GITIAN] Pull gitian sources in our repo.

Move to contrib/

Jul 20 2020, 13:18
deadalnix requested changes to D6972: [GITIAN] Pull gitian sources in our repo.

Don't put it at the root.

Jul 20 2020, 12:53
Fabien updated the summary of D6972: [GITIAN] Pull gitian sources in our repo.
Jul 20 2020, 12:42
Fabien requested review of D6972: [GITIAN] Pull gitian sources in our repo.
Jul 20 2020, 12:41

Jul 19 2020

deadalnix requested changes to D6963: Add CI config for Avalanche tests.

Same as for seeder, this is not a build type.

Jul 19 2020, 20:17
deadalnix requested changes to D6964: Add CI config for seeder tests.

The seeder is not a build type.

Jul 19 2020, 20:15
deadalnix requested changes to D6970: [backport#16194] refactoring: remove mapBlockIndex global.
Jul 19 2020, 20:14

Jul 18 2020

deadalnix accepted D6971: Generate RPC docs using regtest.
Jul 18 2020, 13:16
deadalnix updated the task description for T997: Build Bitcoin-ABC / Master / Sanitizers / Thread Sanitizer (TSAN) is broken..
Jul 18 2020, 13:14
teamcity triaged T997: Build Bitcoin-ABC / Master / Sanitizers / Thread Sanitizer (TSAN) is broken. as Unbreak Now! priority.
Jul 18 2020, 12:59
deadalnix committed rABCad72159d9dae: Move CustomArgumentsFixture to an apropriate place (authored by deadalnix).
Move CustomArgumentsFixture to an apropriate place
Jul 18 2020, 12:44
deadalnix closed D6508: Move CustomArgumentsFixture to an apropriate place.
Jul 18 2020, 12:43
jasonbcox requested review of D6971: Generate RPC docs using regtest.
Jul 18 2020, 01:21

Jul 17 2020

jasonbcox accepted D6508: Move CustomArgumentsFixture to an apropriate place.
Jul 17 2020, 23:20
deadalnix accepted D6967: [backport#16194] refactoring: add block_index_candidates arg to LoadBlockIndex.
Jul 17 2020, 23:13
jasonbcox committed rABCb56f68112d84: Fix providing an explicit branch/ref to land-via-bot (authored by jasonbcox).
Fix providing an explicit branch/ref to land-via-bot
Jul 17 2020, 23:09
jasonbcox closed D6969: Fix providing an explicit branch/ref to land-via-bot.
Jul 17 2020, 23:09
majcosta updated the summary of D6970: [backport#16194] refactoring: remove mapBlockIndex global.
Jul 17 2020, 22:47
majcosta updated the summary of D6970: [backport#16194] refactoring: remove mapBlockIndex global.
Jul 17 2020, 22:47
majcosta updated the summary of D6968: [backport#16194] refactoring: make pindexBestInvalid internal to validation.cpp.
Jul 17 2020, 22:46
majcosta requested review of D6967: [backport#16194] refactoring: add block_index_candidates arg to LoadBlockIndex.

fixed link to PR and added one to the Core commit

Jul 17 2020, 22:45
majcosta updated the summary of D6967: [backport#16194] refactoring: add block_index_candidates arg to LoadBlockIndex.
Jul 17 2020, 22:44
majcosta requested review of D6970: [backport#16194] refactoring: remove mapBlockIndex global.
Jul 17 2020, 22:34
deadalnix requested changes to D6968: [backport#16194] refactoring: make pindexBestInvalid internal to validation.cpp.

Why add more global state? Isn't it some state related to the chain?

Jul 17 2020, 22:14
deadalnix requested changes to D6967: [backport#16194] refactoring: add block_index_candidates arg to LoadBlockIndex.

Please fix description to tell us what it is about.

Jul 17 2020, 22:12
deadalnix accepted D6966: [lint] update Avalanche change to circular dep status.
Jul 17 2020, 22:11
deadalnix accepted D6965: [refactor] access mapBlockIndex via function in Avalanche code.
Jul 17 2020, 22:10
deadalnix accepted D6906: [backport#17357 2/2] tests: Add fuzzing harness for Bech32 encoding/decoding.
Jul 17 2020, 22:10
majcosta accepted D6969: Fix providing an explicit branch/ref to land-via-bot.
Jul 17 2020, 21:32
jasonbcox requested review of D6969: Fix providing an explicit branch/ref to land-via-bot.
Jul 17 2020, 21:30
jasonbcox planned changes to D6969: Fix providing an explicit branch/ref to land-via-bot.
Jul 17 2020, 21:29
jasonbcox requested review of D6969: Fix providing an explicit branch/ref to land-via-bot.
Jul 17 2020, 21:29
majcosta requested review of D6968: [backport#16194] refactoring: make pindexBestInvalid internal to validation.cpp.
Jul 17 2020, 21:18
majcosta committed rABC27e9ca8f6e49: [backport#17051] tests: Add deserialization fuzzing harnesses (authored by Wladimir J. van der Laan <laanwj@protonmail.com>).
[backport#17051] tests: Add deserialization fuzzing harnesses
Jul 17 2020, 20:44
majcosta closed D6947: [backport#17051] tests: Add deserialization fuzzing harnesses.
Jul 17 2020, 20:44
majcosta requested review of D6967: [backport#16194] refactoring: add block_index_candidates arg to LoadBlockIndex.
Jul 17 2020, 20:19
majcosta updated the diff for D6959: [backport#16194] refactoring: move block metadata structures into BlockManager.

fix nits and rebase

Jul 17 2020, 20:05
majcosta updated the summary of D6966: [lint] update Avalanche change to circular dep status.
Jul 17 2020, 20:03
majcosta updated the diff for D6966: [lint] update Avalanche change to circular dep status.

rebase

Jul 17 2020, 20:02
majcosta updated the diff for D6947: [backport#17051] tests: Add deserialization fuzzing harnesses.

rebase and fix nits

Jul 17 2020, 20:02