there are a few dependencies that need to be done before I can put this up for review
Feed All Stories
Jul 23 2020
Jul 23 2020
majcosta requested review of D7009: [backport#15530] doc: Move wallet lock annotations to header.
deadalnix changed the visibility for D7008: Remove BIP9 miner fund..
deadalnix requested review of D7008: Remove BIP9 miner fund..
majcosta updated the summary of D7006: [backport#17260 2/3] MOVEONLY: Move key handling code out of wallet to keyman file.
majcosta planned changes to D7006: [backport#17260 2/3] MOVEONLY: Move key handling code out of wallet to keyman file.
majcosta updated the summary of D7006: [backport#17260 2/3] MOVEONLY: Move key handling code out of wallet to keyman file.
majcosta updated the diff for D7007: [backport#16786] test: add unit test for wallet watch-only methods involving PubKeys.
fixed
majcosta planned changes to D7007: [backport#16786] test: add unit test for wallet watch-only methods involving PubKeys.
wrong comments
Jul 22 2020
Jul 22 2020
deadalnix requested changes to D7004: [CMAKE] Move the functional tests junit reports to the test/junit dir.
deadalnix requested changes to D7006: [backport#17260 2/3] MOVEONLY: Move key handling code out of wallet to keyman file.
Please point to the actual commit.
deadalnix updated the diff for D6981: Implement Grasberg DAA.
Implement testnet difficulty drop
deadalnix requested changes to D7002: [CMAKE] Generate junit output for boost unit tests.
Mengerian added inline comments to D6981: Implement Grasberg DAA.
Mengerian added inline comments to D6981: Implement Grasberg DAA.
majcosta committed rABC5b0939ce69ed: [backport#16361] Remove redundant pre-TopUpKeypool check (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#16361] Remove redundant pre-TopUpKeypool check
majcosta committed rABC8e6f8aca7ee1: [backport#16753] wallet: extract PubKey from P2PK script with Solver (authored by fanquake <fanquake@gmail.com>).
[backport#16753] wallet: extract PubKey from P2PK script with Solver
deadalnix requested review of D7005: Trigger DAA underflow in DAA unit tests.
Fabien requested review of D7004: [CMAKE] Move the functional tests junit reports to the test/junit dir.
Fabien updated the diff for D7002: [CMAKE] Generate junit output for boost unit tests.
Actually pass the list of tests rather than a directory.
Return a constant error code.
deadalnix requested review of D7003: Remove the rule that prevent retargeting on regtest from the EDA.
deadalnix requested changes to D6970: [backport#16194] refactoring: remove mapBlockIndex global.
deadalnix added a comment to D6970: [backport#16194] refactoring: remove mapBlockIndex global.
Can't blockmanager be moved in its own header or something? Including validation.h everywhere like this is definitively not desirable, and solving circular dependencies by putting everything in a single blob is *NOT* a solution.
deadalnix requested changes to D7002: [CMAKE] Generate junit output for boost unit tests.
The idea is there, but the way it is deployed is unsound.
Fabien requested review of D7002: [CMAKE] Generate junit output for boost unit tests.
Fabien requested changes to D6994: [backport#15655] Resolve the checkpoints <-> validation circular dependency.
Please run the circular dependency script as part of the test plan.
Fix OSX SDK caching in Gitian builds
jasonbcox updated the diff for D7001: Add golang to the CI base image.
Use packaged version, even though it's much older
jasonbcox planned changes to D7001: Add golang to the CI base image.
jasonbcox requested review of D7001: Add golang to the CI base image.
Jul 21 2020
Jul 21 2020
majcosta updated the summary of D6998: [backport#17260 1/3] Move wallet enums to walletutil.h.
majcosta requested review of D7000: [backport#16361] Remove redundant pre-TopUpKeypool check.
majcosta requested review of D6999: [backport#16753] wallet: extract PubKey from P2PK script with Solver.
majcosta requested review of D6998: [backport#17260 1/3] Move wallet enums to walletutil.h.
In favor of D6997 now that the base image building has been fixed.
jasonbcox requested review of D6997: Fix OSX SDK caching in Gitian builds.
majcosta requested review of D6995: [backport#17999 1/2] Add ChainClient setMockTime, getWallets methods.
majcosta updated the diff for D6994: [backport#15655] Resolve the checkpoints <-> validation circular dependency.
update lint-circular-dependencies.sh
majcosta updated the diff for D6970: [backport#16194] refactoring: remove mapBlockIndex global.
updated lint-circular-dependencies.sh
[GITIAN] Use docker for the build on CI
Fabien committed rABC32024ec84d3a: [LINTER] Fix syntax error in the cppcheck linter (authored by Fabien).
[LINTER] Fix syntax error in the cppcheck linter
majcosta added inline comments to D6970: [backport#16194] refactoring: remove mapBlockIndex global.
majcosta requested review of D6970: [backport#16194] refactoring: remove mapBlockIndex global.
Fabien requested review of D6992: [LINTER] Fix syntax error in the cppcheck linter.
jasonbcox committed rABC41e3cc675f40: Add build config for documentation, including RPC docs (authored by jasonbcox).
Add build config for documentation, including RPC docs
jasonbcox updated the diff for D6979: Add build config for documentation, including RPC docs.
Simplify waiting for bitcoind
majcosta updated the diff for D6968: [backport#16194] refactoring: make pindexBestInvalid internal to validation.cpp.
reverted to match the PR more closely
majcosta committed rABCec474f67b2bd: [refactor] remove global mapBlockIndex access from unparkblock RPC (authored by majcosta).
[refactor] remove global mapBlockIndex access from unparkblock RPC
majcosta updated the diff for D6988: [refactor] factor CBlockIndex out of chain.h.
moved comment that should've been there in the first place and moved source files to the Server library
majcosta added inline comments to D6988: [refactor] factor CBlockIndex out of chain.h.
Fabien committed rABC68c51f6c5a0f: [GITIAN] Add documentation for building using Docker (authored by Fabien).
[GITIAN] Add documentation for building using Docker
deadalnix requested changes to D6968: [backport#16194] refactoring: make pindexBestInvalid internal to validation.cpp.
You are correct, you can remove it from chainstate and match core.
Fabien requested review of D6990: [GITIAN] Use docker for the build on CI.
Fabien requested changes to D6988: [refactor] factor CBlockIndex out of chain.h.
Fabien requested changes to D6987: [CI] Revert broken changes in gitian.sh.
I am working on a solution, clearing my queue for now
Fabien requested review of D6989: [GITIAN] Add documentation for building using Docker.
jasonbcox updated the diff for D6979: Add build config for documentation, including RPC docs.
- Add bitcoin-cli for better parallelism
- Make waiting for bitcoind more robust
majcosta updated the diff for D6988: [refactor] factor CBlockIndex out of chain.h.
missing newline at the end of blockindex.h
majcosta requested review of D6988: [refactor] factor CBlockIndex out of chain.h.
jasonbcox committed rABC3af9381d5433: Renaming bswap_tests test case so that the name does not collide with the test… (authored by jasonbcox).
Renaming bswap_tests test case so that the name does not collide with the test…
jasonbcox requested review of D6987: [CI] Revert broken changes in gitian.sh.
majcosta requested review of D6986: [refactor] remove global mapBlockIndex access from unparkblock RPC.
jasonbcox planned changes to D6985: Fix locations of gitian build dependencies.
jasonbcox updated the diff for D6985: Fix locations of gitian build dependencies.
Fix some bugs. Still need to figure out where var/lxc.config will come from.
majcosta planned changes to D6970: [backport#16194] refactoring: remove mapBlockIndex global.
majcosta updated the diff for D6970: [backport#16194] refactoring: remove mapBlockIndex global.
rebase on top of D6984
jasonbcox updated the summary of D6985: Fix locations of gitian build dependencies.
jasonbcox planned changes to D6985: Fix locations of gitian build dependencies.
jasonbcox requested review of D6985: Fix locations of gitian build dependencies.
Jul 20 2020
Jul 20 2020
majcosta committed rABC8a10f28311f0: [refactor] remove global mapBlockIndex access from parkblock RPC (authored by majcosta).
[refactor] remove global mapBlockIndex access from parkblock RPC
Fabien committed rABC9f5c428a8f44: [CI] Store functional tests duration with ms resolution in Junit (authored by Fabien).
[CI] Store functional tests duration with ms resolution in Junit