Page MenuHomePhabricator
Feed All Stories

Oct 19 2020

Fabien updated the diff for D7993: test: Remove duplicate NodeContext hacks.

Rebase for CI

Oct 19 2020, 22:07
teamcity added a comment to D7993: test: Remove duplicate NodeContext hacks.
Oct 19 2020, 22:04
Fabien added a comment to D7993: test: Remove duplicate NodeContext hacks.

@bot build-asan

Oct 19 2020, 22:04
teamcity updated the summary of D7993: test: Remove duplicate NodeContext hacks.
Oct 19 2020, 22:03
Fabien requested review of D7993: test: Remove duplicate NodeContext hacks.
Oct 19 2020, 22:03
Fabien closed D7982: [CI] Improve the error snippet in diffs when a test fails.
Oct 19 2020, 21:40
Fabien committed rABCeb0c5503515d: [CI] Improve the error snippet in diffs when a test fails (authored by Fabien).
[CI] Improve the error snippet in diffs when a test fails
Oct 19 2020, 21:40
Fabien closed D7980: [CI] Don't run the sanitizer against the debug build.
Oct 19 2020, 21:39
Fabien committed rABC224f5842f84a: [CI] Don't run the sanitizer against the debug build (authored by Fabien).
[CI] Don't run the sanitizer against the debug build
Oct 19 2020, 21:38
Fabien closed D7979: [CI] Add a debug build configuration.
Oct 19 2020, 21:38
Fabien committed rABCf4d08b46a572: [CI] Add a debug build configuration (authored by Fabien).
[CI] Add a debug build configuration
Oct 19 2020, 21:38
teamcity added a comment to D7991: scripted-diff: Remove g_rpc_node references.
Oct 19 2020, 21:35
teamcity updated the summary of D7992: refactor: Remove g_rpc_node global.
Oct 19 2020, 21:32
Fabien requested review of D7992: refactor: Remove g_rpc_node global.
Oct 19 2020, 21:32
teamcity updated the summary of D7991: scripted-diff: Remove g_rpc_node references.
Oct 19 2020, 21:28
Fabien requested review of D7991: scripted-diff: Remove g_rpc_node references.
Oct 19 2020, 21:28
teamcity updated the summary of D7990: refactor: Pass NodeContext to RPC and REST methods through util::Ref.
Oct 19 2020, 21:24
Fabien requested review of D7990: refactor: Pass NodeContext to RPC and REST methods through util::Ref.
Oct 19 2020, 21:24
teamcity updated the summary of D7989: Add util::Ref class as temporary alternative for c++17 std::any.
Oct 19 2020, 21:11
Fabien requested review of D7989: Add util::Ref class as temporary alternative for c++17 std::any.
Oct 19 2020, 21:11
Fabien updated the diff for D7988: rpc: Remove mempool global from miner.

Rebase

Oct 19 2020, 20:45
Fabien updated the summary of D7988: rpc: Remove mempool global from miner.
Oct 19 2020, 20:44
Fabien closed D7984: test: Add generatetodescriptor RPC.
Oct 19 2020, 20:43
Fabien committed rABC08a28259cd0e: test: Add generatetodescriptor RPC (authored by MarcoFalke <falke.marco@gmail.com>).
test: Add generatetodescriptor RPC
Oct 19 2020, 20:43
Fabien closed D7983: [rpc] Correct reconsiderblock help text, add test.
Oct 19 2020, 20:42
Fabien committed rABC3345d011bb0c: [rpc] Correct reconsiderblock help text, add test (authored by MarcoFalke <falke.marco@gmail.com>).
[rpc] Correct reconsiderblock help text, add test
Oct 19 2020, 20:42
teamcity updated the summary of D7988: rpc: Remove mempool global from miner.
Oct 19 2020, 18:32
Fabien requested review of D7988: rpc: Remove mempool global from miner.
Oct 19 2020, 18:32
Smartbuds updated Smartbuds.
Oct 19 2020, 17:38
PiRK added a comment to D7987: tests: Remove unused testing code.

I already ran the command locally. There will be quite a few unused functions, variables and classes to be removed. I imagine I will do that in a separate diff too.

Oct 19 2020, 17:21
PiRK added a comment to D7987: tests: Remove unused testing code.

Where is part 2?

Oct 19 2020, 17:17
jasonbcox accepted D7982: [CI] Improve the error snippet in diffs when a test fails.
Oct 19 2020, 16:19
deadalnix added a comment to D7985: [backport#16224 1/5]gui: Add detailed text to BitcoinGUI::message.

Please make sure you have all the PR parts up for review so we can know where this is going when reviewing individual parts. This also helps ensure there won't be a PR half merged in flight forever.

Oct 19 2020, 16:19
deadalnix requested changes to D7973: [CI] Fail fast the builds that print error to stdout.
Oct 19 2020, 16:17
deadalnix added a comment to D7987: tests: Remove unused testing code.

Where is part 2?

Oct 19 2020, 16:15
deadalnix accepted D7984: test: Add generatetodescriptor RPC.
Oct 19 2020, 16:13
PiRK updated the diff for D7981: p2p: Remove BIP61 reject messages.

address 2 review items: add a blank line accidentaly removed, use ABC version numbers in bip.md

Oct 19 2020, 15:54
PiRK added inline comments to D7981: p2p: Remove BIP61 reject messages.
Oct 19 2020, 15:51
teamcity updated the summary of D7987: tests: Remove unused testing code.
Oct 19 2020, 15:49
PiRK requested review of D7987: tests: Remove unused testing code.
Oct 19 2020, 15:49
PiRK closed D7978: doc: Remove mention of renamed mapBlocksUnlinked.
Oct 19 2020, 15:39
PiRK committed rABC113ee003dbd0: doc: Remove mention of renamed mapBlocksUnlinked (authored by MarcoFalke <falke.marco@gmail.com>).
doc: Remove mention of renamed mapBlocksUnlinked
Oct 19 2020, 15:39
teamcity updated the summary of D7986: [backport#16224 2/5] Make ThreadSafe{MessageBox|Question} bilingual.
Oct 19 2020, 15:32
PiRK requested review of D7986: [backport#16224 2/5] Make ThreadSafe{MessageBox|Question} bilingual.
Oct 19 2020, 15:32
teamcity updated the summary of D7985: [backport#16224 1/5]gui: Add detailed text to BitcoinGUI::message.
Oct 19 2020, 15:27
PiRK requested review of D7985: [backport#16224 1/5]gui: Add detailed text to BitcoinGUI::message.
Oct 19 2020, 15:26
PiRK added inline comments to D7981: p2p: Remove BIP61 reject messages.
Oct 19 2020, 15:22
teamcity updated the summary of D7984: test: Add generatetodescriptor RPC.
Oct 19 2020, 14:23
Fabien requested review of D7984: test: Add generatetodescriptor RPC.
Oct 19 2020, 14:22
deadalnix accepted D7983: [rpc] Correct reconsiderblock help text, add test.
Oct 19 2020, 14:08
deadalnix accepted D7980: [CI] Don't run the sanitizer against the debug build.
Oct 19 2020, 14:05
deadalnix accepted D7979: [CI] Add a debug build configuration.
Oct 19 2020, 14:01
teamcity updated the summary of D7983: [rpc] Correct reconsiderblock help text, add test.
Oct 19 2020, 13:56
Fabien requested review of D7983: [rpc] Correct reconsiderblock help text, add test.
Oct 19 2020, 13:55
deadalnix requested changes to D7981: p2p: Remove BIP61 reject messages.
Oct 19 2020, 13:20
Fabien requested review of D7982: [CI] Improve the error snippet in diffs when a test fails.
Oct 19 2020, 12:04
PiRK updated the diff for D7978: doc: Remove mention of renamed mapBlocksUnlinked.

rebase

Oct 19 2020, 11:58
PiRK closed D7977: [Doc] Add documentation for the new whitelist permissions.
Oct 19 2020, 11:43
PiRK committed rABCfdedc9312f38: [Doc] Add documentation for the new whitelist permissions (authored by nicolas.dorier <nicolas.dorier@gmail.com>).
[Doc] Add documentation for the new whitelist permissions
Oct 19 2020, 11:43
PiRK closed D7976: [doc] mention whitelist is inbound, and applies to blocksonly.
Oct 19 2020, 11:34
PiRK committed rABC1118027f79db: [doc] mention whitelist is inbound, and applies to blocksonly (authored by Sjors Provoost <sjors@sprovoost.nl>).
[doc] mention whitelist is inbound, and applies to blocksonly
Oct 19 2020, 11:34
PiRK closed D7975: Doc: remove text about txes always relayed from -whitelist.
Oct 19 2020, 11:33
PiRK committed rABC3c35162fc448: Doc: remove text about txes always relayed from -whitelist (authored by David A. Harding <dave@dtrt.org>).
Doc: remove text about txes always relayed from -whitelist
Oct 19 2020, 11:33
PiRK closed D7974: doc: Fix -dustrelayfee= argument docs grammar.
Oct 19 2020, 11:32
PiRK committed rABC2ec285f844b7: doc: Fix -dustrelayfee= argument docs grammar (authored by keepkeyjon <35975617+keepkeyjon@users.noreply.github.com>).
doc: Fix -dustrelayfee= argument docs grammar
Oct 19 2020, 11:32
teamcity updated the summary of D7981: p2p: Remove BIP61 reject messages.
Oct 19 2020, 11:11
PiRK requested review of D7981: p2p: Remove BIP61 reject messages.
Oct 19 2020, 11:11
teamcity added a comment to D7980: [CI] Don't run the sanitizer against the debug build.
Oct 19 2020, 10:16
Fabien accepted D7978: doc: Remove mention of renamed mapBlocksUnlinked.
Oct 19 2020, 09:50
Fabien accepted D7977: [Doc] Add documentation for the new whitelist permissions.
Oct 19 2020, 09:48
Fabien accepted D7976: [doc] mention whitelist is inbound, and applies to blocksonly.
Oct 19 2020, 09:37
Fabien accepted D7975: Doc: remove text about txes always relayed from -whitelist.
Oct 19 2020, 09:33
Fabien accepted D7974: doc: Fix -dustrelayfee= argument docs grammar.
Oct 19 2020, 09:24
Fabien requested review of D7980: [CI] Don't run the sanitizer against the debug build.
Oct 19 2020, 09:21
Fabien requested review of D7979: [CI] Add a debug build configuration.
Oct 19 2020, 09:19
teamcity added a comment to D7978: doc: Remove mention of renamed mapBlocksUnlinked.
Oct 19 2020, 09:10
Fabien updated the diff for D7973: [CI] Fail fast the builds that print error to stdout.

Add an explicit fail_fast option, extend to sanitizers

Oct 19 2020, 09:02
Fabien retitled D7973: [CI] Fail fast the builds that print error to stdout from [CI] Stop on first failure when running the clang-tidy build to [CI] Fail fast the builds that print error to stdout.
Oct 19 2020, 09:01
teamcity added a comment to D7978: doc: Remove mention of renamed mapBlocksUnlinked.
Oct 19 2020, 08:51
teamcity updated the summary of D7978: doc: Remove mention of renamed mapBlocksUnlinked.
Oct 19 2020, 08:46
PiRK requested review of D7978: doc: Remove mention of renamed mapBlocksUnlinked.
Oct 19 2020, 08:46
PiRK updated the diff for D7977: [Doc] Add documentation for the new whitelist permissions.

remove "<<<<<<< HEAD"

Oct 19 2020, 08:14
teamcity added a comment to D7977: [Doc] Add documentation for the new whitelist permissions.
Oct 19 2020, 07:58
teamcity added a comment to D7977: [Doc] Add documentation for the new whitelist permissions.
Oct 19 2020, 07:56
teamcity added a comment to D7977: [Doc] Add documentation for the new whitelist permissions.
Oct 19 2020, 07:56
teamcity added a comment to D7977: [Doc] Add documentation for the new whitelist permissions.
Oct 19 2020, 07:55
PiRK updated the summary of D7977: [Doc] Add documentation for the new whitelist permissions.
Oct 19 2020, 07:54
PiRK updated the summary of D7977: [Doc] Add documentation for the new whitelist permissions.
Oct 19 2020, 07:52
teamcity updated the summary of D7977: [Doc] Add documentation for the new whitelist permissions.
Oct 19 2020, 07:52
PiRK requested review of D7977: [Doc] Add documentation for the new whitelist permissions.
Oct 19 2020, 07:52
PiRK closed D7970: test: Seed test RNG context for each test case, print seed.
Oct 19 2020, 07:36
PiRK committed rABCee2ce03e6d98: test: Seed test RNG context for each test case, print seed (authored by MarcoFalke <falke.marco@gmail.com>).
test: Seed test RNG context for each test case, print seed
Oct 19 2020, 07:36
teamcity updated the summary of D7976: [doc] mention whitelist is inbound, and applies to blocksonly.
Oct 19 2020, 07:36
PiRK requested review of D7976: [doc] mention whitelist is inbound, and applies to blocksonly.
Oct 19 2020, 07:35
teamcity updated the summary of D7975: Doc: remove text about txes always relayed from -whitelist.
Oct 19 2020, 07:25
PiRK requested review of D7975: Doc: remove text about txes always relayed from -whitelist.
Oct 19 2020, 07:24
PiRK updated the summary of D7974: doc: Fix -dustrelayfee= argument docs grammar.
Oct 19 2020, 07:19
PiRK requested review of D7974: doc: Fix -dustrelayfee= argument docs grammar.
Oct 19 2020, 07:17
PiRK closed D7972: rcp: update validateaddress RPCExamples to CashAddr.
Oct 19 2020, 06:26
PiRK committed rABC722197810026: rcp: update validateaddress RPCExamples to CashAddr (authored by Sebastian Falbesoner <sebastian.falbesoner@gmail.com>).
rcp: update validateaddress RPCExamples to CashAddr
Oct 19 2020, 06:26