Page MenuHomePhabricator
Feed All Stories

May 13 2021

PiRK requested review of D9522: Remove unused boost/thread.
May 13 2021, 14:08
bytesofman requested review of D9521: [Cashtab] Compare latest utxo set to stored wallet state.
May 13 2021, 14:02
deadalnix added a comment to D9509: [avalanche] Send the proof master pubkey with AVAHELLO.

No need for it to be compatible.

May 13 2021, 12:56
majcosta closed D9515: [backport#19489] test: Fail wait_until early if connection is lost.
May 13 2021, 12:34
majcosta committed rABC9ae1d72c46a9: [backport#19489] test: Fail wait_until early if connection is lost (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#19489] test: Fail wait_until early if connection is lost
May 13 2021, 12:34
majcosta closed D9514: [backport#19304] test: Check that message sends successfully when header is split across two buffers.
May 13 2021, 12:34
majcosta committed rABC7300d7291145: [backport#19304] test: Check that message sends successfully when header is… (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#19304] test: Check that message sends successfully when header is…
May 13 2021, 12:33
majcosta closed D9513: [backport#19252] test: wait for disconnect in disconnect_p2ps + bloomfilter test followups.
May 13 2021, 12:33
majcosta committed rABCf1c2bb088d03: [backport#19252] test: wait for disconnect in disconnect_p2ps + bloomfilter… (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#19252] test: wait for disconnect in disconnect_p2ps + bloomfilter…
May 13 2021, 12:33
majcosta closed D9512: [backport#19260] p2p: disconnect peers that send filterclear + update existing filter msg disconnect logic.
May 13 2021, 12:32
majcosta committed rABCa496d457ee5a: [backport#19260] p2p: disconnect peers that send filterclear + update existing… (authored by fanquake <fanquake@gmail.com>).
[backport#19260] p2p: disconnect peers that send filterclear + update existing…
May 13 2021, 12:32
majcosta closed D9520: [backport#19264] [tests] Don't import asyncio to test magic bytes.
May 13 2021, 12:31
majcosta committed rABCb97f1a9415a0: [backport#19264] [tests] Don't import asyncio to test magic bytes (authored by fanquake <fanquake@gmail.com>).
[backport#19264] [tests] Don't import asyncio to test magic bytes
May 13 2021, 12:31
majcosta closed D9519: [backport#19177] test: Fix and clean p2p_invalid_messages functional tests.
May 13 2021, 12:30
majcosta committed rABCc91add32290e: [backport#19177] test: Fix and clean p2p_invalid_messages functional tests (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#19177] test: Fix and clean p2p_invalid_messages functional tests
May 13 2021, 12:30
majcosta closed D9511: [backport#19083] test: msg_mempool, fRelay, and other bloomfilter tests.
May 13 2021, 12:29
majcosta committed rABCf5b30883d748: [backport#19083] test: msg_mempool, fRelay, and other bloomfilter tests (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#19083] test: msg_mempool, fRelay, and other bloomfilter tests
May 13 2021, 12:29
PiRK accepted D9519: [backport#19177] test: Fix and clean p2p_invalid_messages functional tests.
May 13 2021, 12:06
majcosta closed D9510: [backport#16756] test: Connection eviction logic tests.
May 13 2021, 11:56
majcosta committed rABC607527e0dbd6: [backport#16756] test: Connection eviction logic tests (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#16756] test: Connection eviction logic tests
May 13 2021, 11:56
majcosta updated the diff for D9519: [backport#19177] test: Fix and clean p2p_invalid_messages functional tests.

fixed debug log output string

May 13 2021, 11:42
PiRK accepted D9520: [backport#19264] [tests] Don't import asyncio to test magic bytes.
May 13 2021, 07:39
PiRK requested changes to D9519: [backport#19177] test: Fix and clean p2p_invalid_messages functional tests.
May 13 2021, 07:37
PiRK accepted D9515: [backport#19489] test: Fail wait_until early if connection is lost.
May 13 2021, 07:32
PiRK accepted D9514: [backport#19304] test: Check that message sends successfully when header is split across two buffers.
May 13 2021, 07:28
PiRK accepted D9513: [backport#19252] test: wait for disconnect in disconnect_p2ps + bloomfilter test followups.
May 13 2021, 07:24
PiRK updated the summary of D9513: [backport#19252] test: wait for disconnect in disconnect_p2ps + bloomfilter test followups.
May 13 2021, 07:22
PiRK added a comment to D9509: [avalanche] Send the proof master pubkey with AVAHELLO.

I don't know if I should put any effort on keeping the message deserialization compatible with previous versions. If we don't want to store the signature and wait for the proof to be able to check it, there is not much we can do and adding compatibility code seems unneccessary, but i'm not sure what happens when a new node receives an old message and finds a pubkey when it expects a schnorrSig.

May 13 2021, 07:20
PiRK accepted D9512: [backport#19260] p2p: disconnect peers that send filterclear + update existing filter msg disconnect logic.
May 13 2021, 07:08
PiRK accepted D9511: [backport#19083] test: msg_mempool, fRelay, and other bloomfilter tests.
May 13 2021, 06:52
PiRK accepted D9510: [backport#16756] test: Connection eviction logic tests.
May 13 2021, 06:43
abc-bot committed rABC17e728e7bbe2: [Automated] Update timing.json (authored by abc-bot).
[Automated] Update timing.json
May 13 2021, 03:19
abc-bot committed rABC50122290bec1: [Automated] Update chainparams (authored by abc-bot).
[Automated] Update chainparams
May 13 2021, 02:15
abc-bot committed rABC0b363efa756f: [Automated] Update seeds (authored by abc-bot).
[Automated] Update seeds
May 13 2021, 02:10
majcosta updated the summary of D9511: [backport#19083] test: msg_mempool, fRelay, and other bloomfilter tests.
May 13 2021, 01:30
majcosta updated the summary of D9512: [backport#19260] p2p: disconnect peers that send filterclear + update existing filter msg disconnect logic.
May 13 2021, 01:29
majcosta updated the diff for D9515: [backport#19489] test: Fail wait_until early if connection is lost.

rebase

May 13 2021, 01:26
majcosta updated the diff for D9514: [backport#19304] test: Check that message sends successfully when header is split across two buffers.

rebase

May 13 2021, 01:25
majcosta updated the diff for D9513: [backport#19252] test: wait for disconnect in disconnect_p2ps + bloomfilter test followups.

rebase

May 13 2021, 01:24
majcosta updated the diff for D9512: [backport#19260] p2p: disconnect peers that send filterclear + update existing filter msg disconnect logic.

rebase due to out of order backports

May 13 2021, 01:21
teamcity updated the summary of D9520: [backport#19264] [tests] Don't import asyncio to test magic bytes.
May 13 2021, 01:20
majcosta requested review of D9520: [backport#19264] [tests] Don't import asyncio to test magic bytes.
May 13 2021, 01:19
teamcity updated the summary of D9519: [backport#19177] test: Fix and clean p2p_invalid_messages functional tests.
May 13 2021, 01:16
majcosta requested review of D9519: [backport#19177] test: Fix and clean p2p_invalid_messages functional tests.
May 13 2021, 01:16

May 12 2021

Joey King <joseph.roy.king@gmail.com> closed D9516: [Cashtab] Bugfix in haveUtxosChanged.
May 12 2021, 21:53
Joey King <joseph.roy.king@gmail.com> committed rABC307cdeee185a: [Cashtab] Bugfix in haveUtxosChanged (authored by Joey King <joseph.roy.king@gmail.com>).
[Cashtab] Bugfix in haveUtxosChanged
May 12 2021, 21:53
majcosta accepted D9516: [Cashtab] Bugfix in haveUtxosChanged.
May 12 2021, 21:28
Fabien planned changes to D9518: Lock cs_main in SendMessages where it's needed.
May 12 2021, 20:36
Fabien requested review of D9518: Lock cs_main in SendMessages where it's needed.
May 12 2021, 20:36
Fabien planned changes to D9517: Use state pointer in SendMessages.
May 12 2021, 20:34
Fabien requested review of D9517: Use state pointer in SendMessages.
May 12 2021, 20:33
bytesofman requested review of D9516: [Cashtab] Bugfix in haveUtxosChanged.
May 12 2021, 20:19
teamcity updated the summary of D9515: [backport#19489] test: Fail wait_until early if connection is lost.
May 12 2021, 19:49
majcosta requested review of D9515: [backport#19489] test: Fail wait_until early if connection is lost.
May 12 2021, 19:48
Fabien closed D9508: p2p: ensure inv is GenMsgTx before ToGenTxid in inv processing.
May 12 2021, 19:13
Fabien committed rABC25996e7e2388: p2p: ensure inv is GenMsgTx before ToGenTxid in inv processing (authored by John Newbery <john@johnnewbery.com>).
p2p: ensure inv is GenMsgTx before ToGenTxid in inv processing
May 12 2021, 19:13
Fabien closed D9507: p2p: make gtxid(.hash) and fAlreadyHave localvars const.
May 12 2021, 19:12
Fabien committed rABC0f0d105ce2bf: p2p: make gtxid(.hash) and fAlreadyHave localvars const (authored by Jon Atack <jon@atack.com>).
p2p: make gtxid(.hash) and fAlreadyHave localvars const
May 12 2021, 19:12
Fabien closed D9506: p2p: use CInv block message helpers in net_processing.cpp.
May 12 2021, 19:11
Fabien committed rABC0f5b42a26d3e: p2p: use CInv block message helpers in net_processing.cpp (authored by Jon Atack <jon@atack.com>).
p2p: use CInv block message helpers in net_processing.cpp
May 12 2021, 19:11
Fabien closed D9505: [net processing] Change AlreadyHaveTx() to take a GenTxid.
May 12 2021, 19:10
Fabien committed rABC2960f55f4488: [net processing] Change AlreadyHaveTx() to take a GenTxid (authored by John Newbery <john@johnnewbery.com>).
[net processing] Change AlreadyHaveTx() to take a GenTxid
May 12 2021, 19:10
Fabien closed D9504: [net processing] Change AlreadyHaveBlock() to take block_hash argument.
May 12 2021, 19:09
Fabien committed rABC216399a4b420: [net processing] Change AlreadyHaveBlock() to take block_hash argument (authored by John Newbery <john@johnnewbery.com>).
[net processing] Change AlreadyHaveBlock() to take block_hash argument
May 12 2021, 19:08
teamcity updated the summary of D9514: [backport#19304] test: Check that message sends successfully when header is split across two buffers.
May 12 2021, 19:08
majcosta requested review of D9514: [backport#19304] test: Check that message sends successfully when header is split across two buffers.
May 12 2021, 19:07
Fabien closed D9503: [net processing] Remove mempool argument from AlreadyHaveBlock().
May 12 2021, 19:06
Fabien committed rABC63d5b8764b4a: [net processing] Remove mempool argument from AlreadyHaveBlock() (authored by John Newbery <john@johnnewbery.com>).
[net processing] Remove mempool argument from AlreadyHaveBlock()
May 12 2021, 19:06
Fabien closed D9502: [net processing] Split AlreadyHave() into separate block and tx functions.
May 12 2021, 19:02
Fabien committed rABC1a1922529936: [net processing] Split AlreadyHave() into separate block and tx functions (authored by John Newbery <john@johnnewbery.com>).
[net processing] Split AlreadyHave() into separate block and tx functions
May 12 2021, 19:02
teamcity updated the summary of D9513: [backport#19252] test: wait for disconnect in disconnect_p2ps + bloomfilter test followups.
May 12 2021, 19:01
Fabien closed D9501: p2p: add CInv block message helper methods.
May 12 2021, 19:01
Fabien committed rABC8f921089e9f5: p2p: add CInv block message helper methods (authored by Jon Atack <jon@atack.com>).
p2p: add CInv block message helper methods
May 12 2021, 19:01
Fabien closed D9500: p2p, refactor: add CInv transaction message helpers; use in net processing.
May 12 2021, 19:00
Fabien committed rABC3cb957dbb34a: p2p, refactor: add CInv transaction message helpers; use in net processing (authored by Jon Atack <jon@atack.com>).
p2p, refactor: add CInv transaction message helpers; use in net processing
May 12 2021, 19:00
teamcity updated the summary of D9513: [backport#19252] test: wait for disconnect in disconnect_p2ps + bloomfilter test followups.
May 12 2021, 18:56
majcosta requested review of D9513: [backport#19252] test: wait for disconnect in disconnect_p2ps + bloomfilter test followups.
May 12 2021, 18:56
teamcity updated the summary of D9512: [backport#19260] p2p: disconnect peers that send filterclear + update existing filter msg disconnect logic.
May 12 2021, 18:44
majcosta requested review of D9512: [backport#19260] p2p: disconnect peers that send filterclear + update existing filter msg disconnect logic.
May 12 2021, 18:44
majcosta requested review of D9511: [backport#19083] test: msg_mempool, fRelay, and other bloomfilter tests.
May 12 2021, 17:57
teamcity updated the summary of D9510: [backport#16756] test: Connection eviction logic tests.
May 12 2021, 16:43
majcosta requested review of D9510: [backport#16756] test: Connection eviction logic tests.
May 12 2021, 16:43
PiRK added a comment to D9509: [avalanche] Send the proof master pubkey with AVAHELLO.

This is intended to replace D9497, because enforcing that a delegation needs at least one level seems to require more change in more places in the codebase, and building dummy delegation to self seems like a clumsy hack.

May 12 2021, 16:11
PiRK requested review of D9509: [avalanche] Send the proof master pubkey with AVAHELLO.
May 12 2021, 16:05
majcosta accepted D9508: p2p: ensure inv is GenMsgTx before ToGenTxid in inv processing.
May 12 2021, 14:49
majcosta accepted D9507: p2p: make gtxid(.hash) and fAlreadyHave localvars const.
May 12 2021, 14:48
majcosta accepted D9506: p2p: use CInv block message helpers in net_processing.cpp.
May 12 2021, 14:44
majcosta accepted D9505: [net processing] Change AlreadyHaveTx() to take a GenTxid.
May 12 2021, 14:43
majcosta accepted D9504: [net processing] Change AlreadyHaveBlock() to take block_hash argument.
May 12 2021, 14:41
majcosta accepted D9503: [net processing] Remove mempool argument from AlreadyHaveBlock().
May 12 2021, 14:40
majcosta accepted D9502: [net processing] Split AlreadyHave() into separate block and tx functions.
May 12 2021, 14:39
Fabien updated the diff for D9502: [net processing] Split AlreadyHave() into separate block and tx functions.

Fix static bool vs bool static

May 12 2021, 14:32
Fabien planned changes to D9498: [avalanche] Reply to proof invs with getdata requests.
May 12 2021, 14:18
teamcity updated the summary of D9508: p2p: ensure inv is GenMsgTx before ToGenTxid in inv processing.
May 12 2021, 14:16
Fabien requested review of D9508: p2p: ensure inv is GenMsgTx before ToGenTxid in inv processing.
May 12 2021, 14:16
majcosta accepted D9501: p2p: add CInv block message helper methods.
May 12 2021, 14:11
majcosta accepted D9500: p2p, refactor: add CInv transaction message helpers; use in net processing.
May 12 2021, 14:10
teamcity updated the summary of D9507: p2p: make gtxid(.hash) and fAlreadyHave localvars const.
May 12 2021, 14:09
Fabien requested review of D9507: p2p: make gtxid(.hash) and fAlreadyHave localvars const.
May 12 2021, 14:08
teamcity updated the summary of D9506: p2p: use CInv block message helpers in net_processing.cpp.
May 12 2021, 14:00