Page MenuHomePhabricator
Differential D1095

Adds OP_MOD functionality into interpreter.cpp
AbandonedPublic
Actions

Authored by schancel on Feb 15 2018, 00:57.

Details

Reviewers
movrcx
Group Reviewers
Restricted Project
Restricted Owners Package(Owns No Changed Paths)
Summary

Reimplements OP_MOD (modulo by zero is not ok)

Co-authored-by: Joshua Yabut <yabut.joshua@gmail.com>
Co-authored-by: Marcos Mayorga <mm@mm-studios.com>

Test Plan

Unit tests to be submitted in follow-on diff

Diff Detail

Repository
rABC Bitcoin ABC
Branch
arcpatch-D1095
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2042
Build 2231: Bitcoin ABC Buildbot (legacy)
Build 2230: arc lint + arc unit

Event Timeline

movrcx created this revision.Feb 15 2018, 00:57
Harbormaster completed remote builds in B1847: Diff 2870.Feb 15 2018, 00:57
movrcx added parent revisions: D1094: unit test for OP_DIV, D1093: Adds OP_DIV functionality into interpreter.cpp, D1092: unit test for bitwise operations (AND, OR, XOR), D1091: unit test removal OP_LEFT/RIGHT/SUBSTR, D1090: Adds Bitwise functionality into interpreter.cpp.Feb 15 2018, 01:00
movrcx added a child revision: D1096: unit test for OP_MOD.
movrcx added a child revision: D1097: Add support for CAT, and SPLIT opcodes.Feb 15 2018, 01:04
movrcx added a child revision: D1099: Adds OP_SPLIT functionality into interpreter.cpp.Feb 15 2018, 01:15
movrcx added a child revision: D1101: Adds OP_BIN2NUM functionality into interpreter.cpp.Feb 15 2018, 01:21
movrcx added a child revision: D1103: Add support for NUM2BIN, and BIN2NUM opcodes.Feb 15 2018, 01:26
movrcx updated this revision to Diff 2883.Feb 15 2018, 01:29

Removing autolinting

Harbormaster completed remote builds in B1860: Diff 2883.Feb 15 2018, 01:29
movrcx edited the summary of this revision. (Show Details)Feb 15 2018, 01:57
movrcx edited the summary of this revision. (Show Details)Feb 15 2018, 01:59
shadders added a subscriber: shadders.Feb 15 2018, 03:23
movrcx updated this revision to Diff 2898.Feb 16 2018, 08:14

Adding unit tests

Harbormaster completed remote builds in B1874: Diff 2898.Feb 16 2018, 08:14
danconnolly added a subscriber: danconnolly.Feb 21 2018, 08:51
movrcx added a child revision: D1142: Added tests for disabled opcodes before/after the fork..Feb 28 2018, 01:57
schancel removed a child revision: D1142: Added tests for disabled opcodes before/after the fork..Mar 9 2018, 10:49
schancel removed parent revisions: D1091: unit test removal OP_LEFT/RIGHT/SUBSTR, D1092: unit test for bitwise operations (AND, OR, XOR), D1094: unit test for OP_DIV.Mar 9 2018, 10:56
schancel removed a child revision: D1096: unit test for OP_MOD.
schancel removed a parent revision: D1090: Adds Bitwise functionality into interpreter.cpp.Mar 9 2018, 11:00
schancel removed a child revision: D1099: Adds OP_SPLIT functionality into interpreter.cpp.
schancel removed a child revision: D1103: Add support for NUM2BIN, and BIN2NUM opcodes.
schancel removed a child revision: D1101: Adds OP_BIN2NUM functionality into interpreter.cpp.Mar 9 2018, 11:03
danconnolly updated this revision to Diff 3146.Mar 10 2018, 22:24

reorganize D1095

Owners added a reviewer: Restricted Owners Package.Mar 10 2018, 22:24
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptMar 10 2018, 22:24
teamcity added a subscriber: teamcity.Mar 10 2018, 22:25

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Mar 10 2018, 22:47

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2042: Diff 3146.Mar 10 2018, 22:47
danconnolly updated this revision to Diff 3156.Mar 12 2018, 18:47

resubmit D1095 - op_mod

teamcity added a comment.Mar 12 2018, 18:47

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Mar 12 2018, 19:10

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2052: Diff 3156.Mar 12 2018, 19:10
movrcx updated this revision to Diff 3224.Mar 16 2018, 02:29

Cleaning up due to D1202

teamcity added a comment.Mar 16 2018, 02:32

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Mar 16 2018, 02:46

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

Harbormaster failed remote builds in B2106: Diff 3224!Mar 16 2018, 02:47
movrcx updated this revision to Diff 3254.Mar 17 2018, 02:17

Rebase off master

teamcity added a comment.Mar 17 2018, 02:31

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Mar 17 2018, 02:47

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

Harbormaster failed remote builds in B2133: Diff 3254!Mar 17 2018, 02:47
schancel commandeered this revision.Mar 18 2018, 02:49
schancel abandoned this revision.
schancel added a reviewer: movrcx.
schancel removed a child revision: D1097: Add support for CAT, and SPLIT opcodes.Mar 18 2018, 03:14
PiRK added a child revision: D10096: wallet: IsMine overloads require cs_wallet lock.Sep 13 2021, 14:36

Revision Contents
Changeset List

PathSize
src/
script/
15 lines
6 lines
1 line
2 lines
test/
50 lines

Diff 3146

View Options

src/script/interpreter.cpp

Loading...
View Options

src/script/script.h

Loading...
View Options

src/script/script_error.h

Loading...
View Options

src/script/script_error.cpp

Loading...
View Options

src/test/op_code.cpp

Loading...