Page MenuHomePhabricator
Feed All Stories

Jun 13 2019

teamcity added a comment to D3321: Updated chainparams for 0.19.8 release.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 13 2019, 17:26
jasonbcox created D3321: Updated chainparams for 0.19.8 release.
Jun 13 2019, 17:26
teamcity added a comment to D3320: Update seeds for 0.19.8 release.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 13 2019, 17:26
teamcity added a comment to D3320: Update seeds for 0.19.8 release.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 13 2019, 17:20
jasonbcox created D3320: Update seeds for 0.19.8 release.
Jun 13 2019, 17:20
teamcity added a comment to D3319: [LINTER] Enforce using angle brackets in #include directives.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 13 2019, 16:13
teamcity added a comment to D3319: [LINTER] Enforce using angle brackets in #include directives.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 13 2019, 16:07
Fabien created D3319: [LINTER] Enforce using angle brackets in #include directives.
Jun 13 2019, 16:07
teamcity added a comment to D3318: [LINTER] Prevent including a source file.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 13 2019, 15:57
teamcity added a comment to D3317: Use MakeTransactionRef in serialize_tests.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 13 2019, 15:52
teamcity added a comment to D3318: [LINTER] Prevent including a source file.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 13 2019, 15:50
Fabien created D3318: [LINTER] Prevent including a source file.
Jun 13 2019, 15:50
teamcity added a comment to D3316: Update mempool eviction benchmark.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 13 2019, 15:48
teamcity added a comment to D3317: Use MakeTransactionRef in serialize_tests.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 13 2019, 15:46
deadalnix created D3317: Use MakeTransactionRef in serialize_tests.cpp.
Jun 13 2019, 15:46
teamcity added a comment to D3315: Make m_coinbase_txns a vector of CTransactionRef.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 13 2019, 15:42
teamcity added a comment to D3316: Update mempool eviction benchmark.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 13 2019, 15:41
deadalnix created D3316: Update mempool eviction benchmark.
Jun 13 2019, 15:41
teamcity added a comment to D3315: Make m_coinbase_txns a vector of CTransactionRef.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 13 2019, 15:34
deadalnix created D3315: Make m_coinbase_txns a vector of CTransactionRef.
Jun 13 2019, 15:33
Fabien planned changes to D3298: Introducing the new Bitcoin ABC lint engine.
Jun 13 2019, 15:26
teamcity added a comment to D3314: coinbaseTxns => m_coinbase_txns.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 13 2019, 15:18
teamcity added a comment to D3314: coinbaseTxns => m_coinbase_txns.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 13 2019, 15:09
deadalnix created D3314: coinbaseTxns => m_coinbase_txns.
Jun 13 2019, 15:09
teamcity added a comment to D3310: Merge #14085: index: Fix for indexers skipping genesis block..

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 13 2019, 14:29
teamcity added a comment to D3310: Merge #14085: index: Fix for indexers skipping genesis block..

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 13 2019, 14:23
markblundeberg added a comment to D3310: Merge #14085: index: Fix for indexers skipping genesis block..

address comments

Jun 13 2019, 14:22
teamcity added a comment to D3076: Merge #14409: utils and libraries: Make 'blocksdir' always net specific.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 13 2019, 14:13
markblundeberg added inline comments to D3076: Merge #14409: utils and libraries: Make 'blocksdir' always net specific.
Jun 13 2019, 14:06
teamcity added a comment to D3076: Merge #14409: utils and libraries: Make 'blocksdir' always net specific.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 13 2019, 14:04
markblundeberg added a comment to D3076: Merge #14409: utils and libraries: Make 'blocksdir' always net specific.

take out accidental backported line

Jun 13 2019, 14:04
teamcity added a comment to D3307: mempool: Fix missing locking in CTxMemPool::check(…) and CTxMemPool::setSanityCheck(…).

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 13 2019, 13:33
teamcity added a comment to D3304: Add a test to make sure that negative effective values are filtered.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 13 2019, 13:25
teamcity added a comment to D3307: mempool: Fix missing locking in CTxMemPool::check(…) and CTxMemPool::setSanityCheck(…).

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 13 2019, 13:24
deadalnix added a comment to D3307: mempool: Fix missing locking in CTxMemPool::check(…) and CTxMemPool::setSanityCheck(…).

rebase

Jun 13 2019, 13:24
teamcity added a comment to D3301: Have SelectCoinsMinConf and SelectCoins use BnB or Knapsack and use it.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 13 2019, 13:23
teamcity added a comment to D3304: Add a test to make sure that negative effective values are filtered.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 13 2019, 13:18
deadalnix added a comment to D3304: Add a test to make sure that negative effective values are filtered.

rebase

Jun 13 2019, 13:18
teamcity added a comment to D3301: Have SelectCoinsMinConf and SelectCoins use BnB or Knapsack and use it.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 13 2019, 13:16
teamcity added a comment to D3290: Move original knapsack solver tests to coinselector_tests.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 13 2019, 13:15
deadalnix added a comment to D3301: Have SelectCoinsMinConf and SelectCoins use BnB or Knapsack and use it.

rebase

Jun 13 2019, 13:15
deadalnix committed rABC6104bd0dcb40: Move original knapsack solver tests to coinselector_tests.cpp (authored by Andrew Chow <achow101-github@achow101.com>).
Move original knapsack solver tests to coinselector_tests.cpp
Jun 13 2019, 13:11
deadalnix closed D3290: Move original knapsack solver tests to coinselector_tests.cpp.
Jun 13 2019, 13:11
teamcity added a comment to D3290: Move original knapsack solver tests to coinselector_tests.cpp.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 13 2019, 13:08
deadalnix added a comment to D3290: Move original knapsack solver tests to coinselector_tests.cpp.

Rebase

Jun 13 2019, 13:08
deadalnix committed rABC1277558575c8: Move current coin selection algorithm to coinselection.{cpp,h} (authored by Andrew Chow <achow101-github@achow101.com>).
Move current coin selection algorithm to coinselection.{cpp,h}
Jun 13 2019, 13:03
deadalnix closed D3289: Move current coin selection algorithm to coinselection.{cpp,h}.
Jun 13 2019, 13:03
deadalnix committed rABC1716c33e056b: Benchmark BnB in the worst case where it exhausts (authored by Andrew Chow <achow101-github@achow101.com>).
Benchmark BnB in the worst case where it exhausts
Jun 13 2019, 13:01
deadalnix closed D3303: Benchmark BnB in the worst case where it exhausts.
Jun 13 2019, 13:01
deadalnix committed rABC5cc81b09640d: Add tests for the Branch and Bound algorithm (authored by Andrew Chow <achow101-github@achow101.com>).
Add tests for the Branch and Bound algorithm
Jun 13 2019, 12:58
deadalnix closed D3252: Add tests for the Branch and Bound algorithm.
Jun 13 2019, 12:58
deadalnix committed rABCc9cc9f22f14d: Calculate and store the number of bytes required to spend an input (authored by Andrew Chow <achow101-github@achow101.com>).
Calculate and store the number of bytes required to spend an input
Jun 13 2019, 12:54
deadalnix closed D3243: Calculate and store the number of bytes required to spend an input.
Jun 13 2019, 12:54
deadalnix committed rABCf24b2f5577cf: Remove coinselection.h -> wallet.h circular dependency (authored by Andrew Chow <achow101-github@achow101.com>).
Remove coinselection.h -> wallet.h circular dependency
Jun 13 2019, 12:52
deadalnix closed D3250: Remove coinselection.h -> wallet.h circular dependency.
Jun 13 2019, 12:52
deadalnix committed rABC88daa3d6c4af: Implement Branch and Bound coin selection in a new file (authored by Andrew Chow <achow101-github@achow101.com>).
Implement Branch and Bound coin selection in a new file
Jun 13 2019, 12:50
deadalnix closed D3249: Implement Branch and Bound coin selection in a new file.
Jun 13 2019, 12:50
deadalnix committed rABC558e26523d13: Fix eligibilty_filter => eligibility_filter (authored by deadalnix).
Fix eligibilty_filter => eligibility_filter
Jun 13 2019, 12:47
deadalnix closed D3306: Fix eligibilty_filter => eligibility_filter.
Jun 13 2019, 12:47
deadalnix committed rABC91d67343d27e: Build wallet dependent benchmark using cmake (authored by deadalnix).
Build wallet dependent benchmark using cmake
Jun 13 2019, 12:45
deadalnix closed D3302: Build wallet dependent benchmark using cmake.
Jun 13 2019, 12:44
deadalnix committed rABC41967b025dfd: Fix braces in multisig_test (authored by deadalnix).
Fix braces in multisig_test
Jun 13 2019, 12:39
deadalnix closed D3309: Fix braces in multisig_test.
Jun 13 2019, 12:39
deadalnix committed rABC1e3e04da8e12: Fix comments in miner.h (authored by deadalnix).
Fix comments in miner.h
Jun 13 2019, 12:38
deadalnix closed D3305: Fix comments in miner.h.
Jun 13 2019, 12:38
teamcity added a comment to D3313: Make float <-> int casts explicit outside of test, qt, CFeeRate.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 13 2019, 10:53
D3309: Fix braces in multisig_test is now accepted and ready to land.
Jun 13 2019, 10:45
Fabien added inline comments to D3307: mempool: Fix missing locking in CTxMemPool::check(…) and CTxMemPool::setSanityCheck(…).
Jun 13 2019, 10:44
teamcity added a comment to D3313: Make float <-> int casts explicit outside of test, qt, CFeeRate.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 13 2019, 10:43
Fabien created D3313: Make float <-> int casts explicit outside of test, qt, CFeeRate.
Jun 13 2019, 10:43
D3306: Fix eligibilty_filter => eligibility_filter is now accepted and ready to land.

Mind to add an entry in the test/lint/dictionary/english.json: "eligibilty": "eligibility" ?

Jun 13 2019, 09:57
D3305: Fix comments in miner.h is now accepted and ready to land.
Jun 13 2019, 09:51
D3304: Add a test to make sure that negative effective values are filtered is now accepted and ready to land.
Jun 13 2019, 09:50
D3303: Benchmark BnB in the worst case where it exhausts is now accepted and ready to land.
Jun 13 2019, 09:49
D3302: Build wallet dependent benchmark using cmake is now accepted and ready to land.
Jun 13 2019, 09:45
D3252: Add tests for the Branch and Bound algorithm is now accepted and ready to land.
Jun 13 2019, 08:05
D3249: Implement Branch and Bound coin selection in a new file is now accepted and ready to land.
Jun 13 2019, 08:03
D3243: Calculate and store the number of bytes required to spend an input is now accepted and ready to land.
Jun 13 2019, 07:59
D3076: Merge #14409: utils and libraries: Make 'blocksdir' always net specific now requires changes to proceed.
Jun 13 2019, 07:57
D3310: Merge #14085: index: Fix for indexers skipping genesis block. now requires changes to proceed.
Jun 13 2019, 06:14
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABC5141d3a733fd: fix `test_runner.py --help` (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>).
fix `test_runner.py --help`
Jun 13 2019, 06:06
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> closed D3311: fix `test_runner.py --help`.
Jun 13 2019, 06:06
D3311: fix `test_runner.py --help` is now accepted and ready to land.

Thanks, the bug is due to out-of-order backport: https://github.com/bitcoin/bitcoin/pull/13944

Jun 13 2019, 06:01
teamcity added a comment to D3076: Merge #14409: utils and libraries: Make 'blocksdir' always net specific.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 13 2019, 05:55
teamcity added a comment to D3312: create net-specific data directory early in init process.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 13 2019, 05:50
teamcity added a comment to D3076: Merge #14409: utils and libraries: Make 'blocksdir' always net specific.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 13 2019, 05:46
markblundeberg updated the summary of D3076: Merge #14409: utils and libraries: Make 'blocksdir' always net specific.

finally found the bug that was making tests fail! (D3312)

Jun 13 2019, 05:46
teamcity added a comment to D3312: create net-specific data directory early in init process.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 13 2019, 05:44
markblundeberg created D3312: create net-specific data directory early in init process.
Jun 13 2019, 05:44
teamcity added a comment to D3311: fix `test_runner.py --help`.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 13 2019, 03:58
markblundeberg added inline comments to D3273: qa: Normalize executable location.
Jun 13 2019, 03:53
teamcity added a comment to D3311: fix `test_runner.py --help`.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 13 2019, 03:52
markblundeberg created D3311: fix `test_runner.py --help`.
Jun 13 2019, 03:52
teamcity added a comment to D3310: Merge #14085: index: Fix for indexers skipping genesis block..

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Jun 13 2019, 02:14
markblundeberg added a revision to T630: Backport PR 13243 "Make reusable base class for auxiliary indices": D3310: Merge #14085: index: Fix for indexers skipping genesis block..
Jun 13 2019, 02:08
markblundeberg added a task to D3310: Merge #14085: index: Fix for indexers skipping genesis block.: T630: Backport PR 13243 "Make reusable base class for auxiliary indices".
Jun 13 2019, 02:08
teamcity added a comment to D3310: Merge #14085: index: Fix for indexers skipping genesis block..

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Jun 13 2019, 02:07
markblundeberg created D3310: Merge #14085: index: Fix for indexers skipping genesis block..
Jun 13 2019, 02:07
markblundeberg added a comment to D2788: Remove unknown version warning from UpdateTip.

This should in principle work on master now, once rebased...

Jun 13 2019, 01:43
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABCce4e304800ac: Remove unused DoWarning function (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>).
Remove unused DoWarning function
Jun 13 2019, 01:42